51713 2010-12-29 10:16:48 -0800 [Chromium, bindings] MemoryInfo wrappers leak due to caching introduced in r57004. 2010-12-30 05:05:17 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov commit-queue japhet pfeldman vitalyr yurys oldest_to_newest 327612 0 mnaganov 2010-12-29 10:16:48 -0800 See https://bugs.webkit.org/show_bug.cgi?id=51712. Getters of MemoryInfo objects must not cache wrappers. 327615 1 77629 mnaganov 2010-12-29 10:19:05 -0800 Created attachment 77629 proposed fix 327878 2 vitalyr 2010-12-30 04:23:30 -0800 (In reply to comment #1) > Created an attachment (id=77629) [details] > proposed fix LGTM as a work-around until bug 51712 is fixed. 327886 3 77629 commit-queue 2010-12-30 05:05:11 -0800 Comment on attachment 77629 proposed fix Clearing flags on attachment: 77629 Committed r74795: <http://trac.webkit.org/changeset/74795> 327887 4 commit-queue 2010-12-30 05:05:17 -0800 All reviewed patches have been landed. Closing bug. 77629 2010-12-29 10:19:05 -0800 2010-12-30 05:05:11 -0800 proposed fix 51713-patch text/plain 6034 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmVmM2I0NS4uN2EwMTY3ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMi0yOSAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBsZWFrIG9mIE1lbW9yeUluZm8gd3JhcHBlcnMgaW50 cm9kdWNlZCBpbiByNTcwMDQgKHNlZSBpc3N1ZSA1MTcxMikuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNzEzCisKKyAgICAgICAgKiBXZWJDb3Jl Lmd5cGk6CisgICAgICAgICogV2ViQ29yZS5wcm86CisgICAgICAgICogYmluZGluZ3MvdjgvY3Vz dG9tL1Y4Q29uc29sZUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOENvbnNvbGU6Om1l bW9yeUFjY2Vzc29yR2V0dGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhQZXJm b3JtYW5jZUN1c3RvbS5jcHA6IENvcGllZCBmcm9tIFY4Q29uc29sZUN1c3RvbS5jcHAuCisgICAg ICAgIChXZWJDb3JlOjpWOFBlcmZvcm1hbmNlOjptZW1vcnlBY2Nlc3NvckdldHRlcik6CisgICAg ICAgICogcGFnZS9Db25zb2xlLmlkbDoKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlLmlkbDoK KwogMjAxMC0xMi0yOSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9XZWJD b3JlL1dlYkNvcmUuZ3lwaSBiL1dlYkNvcmUvV2ViQ29yZS5neXBpCmluZGV4IGY2MmQ4ODMuLjJk OGU0Y2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1dlYkNvcmUvV2Vi Q29yZS5neXBpCkBAIC04NjAsNiArODYwLDcgQEAKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9j dXN0b20vVjhOb2RlQ3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9t L1Y4Tm9kZUxpc3RDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9jdXN0b20v VjhOb3RpZmljYXRpb25DZW50ZXJDdXN0b20uY3BwJywKKyAgICAgICAgICAgICdiaW5kaW5ncy92 OC9jdXN0b20vVjhQZXJmb3JtYW5jZUN1c3RvbS5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdz L3Y4L2N1c3RvbS9WOFBvcFN0YXRlRXZlbnRDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5k aW5ncy92OC9jdXN0b20vVjhTY3JpcHRQcm9maWxlQ3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAn YmluZGluZ3MvdjgvY3VzdG9tL1Y4U2NyaXB0UHJvZmlsZU5vZGVDdXN0b20uY3BwJywKZGlmZiAt LWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IGFh Yzc2MGEuLmVjOGNkMjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIvV2Vi Q29yZS9XZWJDb3JlLnBybwpAQCAtNDcwLDYgKzQ3MCw3IEBAIHY4IHsKICAgICAgICAgYmluZGlu Z3MvdjgvY3VzdG9tL1Y4TmFtZWROb2Rlc0NvbGxlY3Rpb24uY3BwIFwKICAgICAgICAgYmluZGlu Z3MvdjgvY3VzdG9tL1Y4Tm9kZUN1c3RvbS5jcHAgXAogICAgICAgICBiaW5kaW5ncy92OC9jdXN0 b20vVjhOb2RlTGlzdEN1c3RvbS5jcHAgXAorICAgICAgICBiaW5kaW5ncy92OC9jdXN0b20vVjhQ ZXJmb3JtYW5jZUN1c3RvbS5jcHAgXAogICAgICAgICBiaW5kaW5ncy92OC9jdXN0b20vVjhTUUxS ZXN1bHRTZXRSb3dMaXN0Q3VzdG9tLmNwcCBcCiAgICAgICAgIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OFNRTFRyYW5zYWN0aW9uQ3VzdG9tLmNwcCBcCiAgICAgICAgIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OFdlYlNvY2tldEN1c3RvbS5jcHAgXApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhDb25zb2xlQ3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 Q29uc29sZUN1c3RvbS5jcHAKaW5kZXggZTIxMzU0ZS4uNDBmZjJiMSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDb25zb2xlQ3VzdG9tLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENvbnNvbGVDdXN0b20uY3BwCkBAIC0zOSw2ICszOSw3IEBA CiAjaW5jbHVkZSAiU2NyaXB0UHJvZmlsZS5oIgogI2luY2x1ZGUgIlY4QmluZGluZy5oIgogI2lu Y2x1ZGUgIlY4QmluZGluZ01hY3Jvcy5oIgorI2luY2x1ZGUgIlY4TWVtb3J5SW5mby5oIgogI2lu Y2x1ZGUgIlY4UHJveHkuaCIKICNpbmNsdWRlICJWOFNjcmlwdFByb2ZpbGUuaCIKIApAQCAtMTA4 LDQgKzEwOSwxMSBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhDb25zb2xlOjpwcm9maWxlRW5k Q2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKIH0KICNlbmRpZgogCit2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4gVjhDb25zb2xlOjptZW1vcnlBY2Nlc3NvckdldHRlcih2ODo6TG9jYWw8 djg6OlN0cmluZz4gbmFtZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbykKK3sKKyAgICBJ TkNfU1RBVFMoIkRPTS5Db25zb2xlLm1lbW9yeUFjY2Vzc29yR2V0dGVyIik7CisgICAgQ29uc29s ZSogaW1wID0gVjhDb25zb2xlOjp0b05hdGl2ZShpbmZvLkhvbGRlcigpKTsKKyAgICByZXR1cm4g dG9WOChpbXAtPm1lbW9yeSgpKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhQZXJmb3JtYW5jZUN1c3RvbS5jcHAg Yi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFBlcmZvcm1hbmNlQ3VzdG9tLmNwcApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45NWMwZDVjCi0tLSAvZGV2L251bGwKKysr IGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhQZXJmb3JtYW5jZUN1c3RvbS5jcHAKQEAg LTAsMCArMSw0OSBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNl IGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUg cGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorICog bWV0OgorICoKKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJl dGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRp b25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBjb3B5cmlnaHQg bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyCisgKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3Zp ZGVkIHdpdGggdGhlCisgKiBkaXN0cmlidXRpb24uCisgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1l IG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisgKiBjb250cmlidXRvcnMgbWF5 IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorICog dGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4K KyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVS UyBBTkQgQ09OVFJJQlVUT1JTCisgKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVE IFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgVEhFIElNUExJ RUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisgKiBBIFBB UlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENP UFlSSUdIVAorICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVD VCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNF UVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBQUk9D VVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAq IERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5EIE9OIEFOWQorICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFD VCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElT IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN QUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKworI2luY2x1ZGUgIlY4UGVyZm9ybWFu Y2UuaCIKKworI2luY2x1ZGUgIlBlcmZvcm1hbmNlLmgiCisjaW5jbHVkZSAiVjhCaW5kaW5nLmgi CisjaW5jbHVkZSAiVjhCaW5kaW5nTWFjcm9zLmgiCisjaW5jbHVkZSAiVjhNZW1vcnlJbmZvLmgi CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKwordjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4UGVyZm9y bWFuY2U6Om1lbW9yeUFjY2Vzc29yR2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBj b25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZvKQoreworICAgIElOQ19TVEFUUygiRE9NLlBlcmZv cm1hbmNlLm1lbW9yeUFjY2Vzc29yR2V0dGVyIik7CisgICAgUGVyZm9ybWFuY2UqIGltcCA9IFY4 UGVyZm9ybWFuY2U6OnRvTmF0aXZlKGluZm8uSG9sZGVyKCkpOworICAgIHJldHVybiB0b1Y4KGlt cC0+bWVtb3J5KCkpOworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BhZ2UvQ29uc29sZS5pZGwgYi9XZWJDb3JlL3BhZ2UvQ29uc29sZS5pZGwKaW5kZXgg OWYwMzkxMS4uNTAzYmI5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0NvbnNvbGUuaWRsCisr KyBiL1dlYkNvcmUvcGFnZS9Db25zb2xlLmlkbApAQCAtNTgsNyArNTgsNyBAQCBtb2R1bGUgd2lu ZG93IHsKICAgICAgICAgW0N1c3RvbUFyZ3VtZW50SGFuZGxpbmddIHZvaWQgZ3JvdXBDb2xsYXBz ZWQoKTsKICAgICAgICAgdm9pZCBncm91cEVuZCgpOwogCi0gICAgICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBNZW1vcnlJbmZvIG1lbW9yeTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtWOEN1 c3RvbUdldHRlcl0gTWVtb3J5SW5mbyBtZW1vcnk7CiAgICAgfTsKIAogfQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlLmlkbCBiL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZS5p ZGwKaW5kZXggYzcyZjRiYy4uZTVhOGRjZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1BlcmZv cm1hbmNlLmlkbAorKysgYi9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2UuaWRsCkBAIC0zNCw3ICsz NCw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgIGludGVyZmFjZSBbQ29uZGl0aW9uYWw9V0VCX1RJ TUlORywgT21pdENvbnN0cnVjdG9yXSBQZXJmb3JtYW5jZSB7CiAgICAgICAgIHJlYWRvbmx5IGF0 dHJpYnV0ZSBQZXJmb3JtYW5jZU5hdmlnYXRpb24gbmF2aWdhdGlvbjsKICAgICAgICAgcmVhZG9u bHkgYXR0cmlidXRlIFBlcmZvcm1hbmNlVGltaW5nIHRpbWluZzsKLSAgICAgICAgcmVhZG9ubHkg YXR0cmlidXRlIE1lbW9yeUluZm8gbWVtb3J5OworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUg W1Y4Q3VzdG9tR2V0dGVyXSBNZW1vcnlJbmZvIG1lbW9yeTsKICAgICB9OwogCiB9Cg==