51709 2010-12-29 09:10:02 -0800 Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken 2010-12-31 08:57:44 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 apavlov loislo abarth apavlov bweinstein commit-queue eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 327582 0 apavlov 2010-12-29 09:10:02 -0800 The function body reads return !!WebInspector.resourceView.resourceForURL(url); instead of return !!WebInspector.resourceTreeModel.resourceForURL(url); This is a regression introduced by http://trac.webkit.org/changeset/74709. 328140 1 77711 loislo 2010-12-31 02:17:24 -0800 Created attachment 77711 [patch] initial version. 328158 2 77711 commit-queue 2010-12-31 05:02:32 -0800 Comment on attachment 77711 [patch] initial version. Clearing flags on attachment: 77711 Committed r74830: <http://trac.webkit.org/changeset/74830> 328159 3 commit-queue 2010-12-31 05:02:38 -0800 All reviewed patches have been landed. Closing bug. 328178 4 webkit.review.bot 2010-12-31 08:57:44 -0800 http://trac.webkit.org/changeset/74830 might have broken Leopard Intel Debug (Tests) 77711 2010-12-31 02:17:24 -0800 2010-12-31 05:02:32 -0800 [patch] initial version. patch text/plain 1146 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWQwNTFjZC4uODhkNjIwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0zMSAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW1JFR1JFU1NJT05dIFdlYkluc3Bl Y3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUuY2FuU2hvd1NvdXJjZUxpbmUoKSBicm9rZW4u CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNzA5 CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZS5jYW5TaG93U291cmNl TGluZSk6CisKIDIwMTAtMTItMjkgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKaW5kZXggZWU2M2RhZi4uZWNiODI2ZiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtMzI5LDcg KzMyOSw3IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAg ICBjYW5TaG93U291cmNlTGluZTogZnVuY3Rpb24odXJsLCBsaW5lKQogICAgIHsKLSAgICAgICAg cmV0dXJuICEhV2ViSW5zcGVjdG9yLnJlc291cmNlVmlldy5yZXNvdXJjZUZvclVSTCh1cmwpOwor ICAgICAgICByZXR1cm4gISFXZWJJbnNwZWN0b3IucmVzb3VyY2VUcmVlTW9kZWwucmVzb3VyY2VG b3JVUkwodXJsKTsKICAgICB9LAogCiAgICAgc2hvd1NvdXJjZUxpbmU6IGZ1bmN0aW9uKHVybCwg bGluZSkK