51700 2010-12-29 01:45:28 -0800 [Qt] On Linux build of TestNetscapePlugin fails if gold linker is used 2011-01-05 13:25:18 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 annulen webkit-unassigned commit-queue eric evan jhanssen ossy oldest_to_newest 327517 0 annulen 2010-12-29 01:45:28 -0800 TestNetscapePlugin explicitly uses X11 functions but is not linked with libX11, and gold does not perform transitive linking Attached patch fixes the problem 327519 1 77607 annulen 2010-12-29 01:48:52 -0800 Created attachment 77607 Link libX11 explicitly on unix 327786 2 77607 eric 2010-12-29 18:30:56 -0800 Comment on attachment 77607 Link libX11 explicitly on unix OK. 327797 3 commit-queue 2010-12-29 19:16:03 -0800 The commit-queue encountered the following flaky tests while processing attachment 77607: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 51732 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 327800 4 77607 commit-queue 2010-12-29 19:17:11 -0800 Comment on attachment 77607 Link libX11 explicitly on unix Clearing flags on attachment: 77607 Committed r74776: <http://trac.webkit.org/changeset/74776> 327801 5 commit-queue 2010-12-29 19:17:18 -0800 All reviewed patches have been landed. Closing bug. 329752 6 jhanssen 2011-01-05 13:25:18 -0800 (In reply to comment #1) > Created an attachment (id=77607) [details] > Link libX11 explicitly on unix This broke linking of the Qt port on OS X, see bug 51948. 77607 2010-12-29 01:48:52 -0800 2010-12-29 19:17:11 -0800 Link libX11 explicitly on unix 0001-Qt-Fixed-compatibility-with-gold-linker-on-X11-platf.patch text/plain 1633 annulen RnJvbSBlMDQ2NTllY2FmZGNiNTE0M2ViODJkMTZiMmIzMmQ2Y2I0YWY2NTYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIFRva2FyZXYgPGFubnVsZW5AeWFuZGV4LnJ1 PgpEYXRlOiBXZWQsIDI5IERlYyAyMDEwIDEyOjQ3OjM3ICswMzAwClN1YmplY3Q6IFtQQVRDSF0g W1F0XSBGaXhlZCBjb21wYXRpYmlsaXR5IHdpdGggZ29sZCBsaW5rZXIgb24gWDExIHBsYXRmb3Jt cwoKVGVzdE5ldHNjYXBlUGx1Z2luIGV4cGxpY2l0bHkgdXNlcyBYMTEgZnVuY3Rpb25zIGJ1dCBp cyBub3QgbGlua2VkIHdpdGgKbGliWDExLCBhbmQgZ29sZCBkb2VzIG5vdCBwZXJmb3JtIHRyYW5z aXRpdmUgbGlua2luZy4KClRoaXMgcGF0Y2ggZml4ZXMgdGhlIHByb2JsZW0KLS0tCiBUb29scy9D aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTAgKysrKysr KysrKwogLi4uL3F0L1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4ucHJvICAg fCAgICA0ICsrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggNWU2MjJkZC4uYjllNzE3NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEyLTI5ICBLb25zdGFudGluIFRv a2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeGVkIGNvbXBhdGliaWxpdHkgd2l0aCBnb2xkIGxp bmtlciBvbiBYMTEgcGxhdGZvcm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MTcwMAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvVGVzdE5l dHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5wcm86CisgICAgICAgIExpbmtlZCBUZXN0 TmV0c2NhcGVQbHVnaW4gd2l0aCBsaWJYMTEgb24gVW5peCBwbGF0Zm9ybXMKKwogMjAxMC0xMi0y NyAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1w ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5wcm8gYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9xdC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybwpp bmRleCBkZTNjZjZhLi4zMGQyMmQ2IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9x dC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybworKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9xdC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBy bwpAQCAtNDQsMyArNDQsNyBAQCBtYWMgewogfSBlbHNlIHsKICAgICBTT1VSQ0VTICs9IC4uLy4u L3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHAKIH0KKwordW5p eCB7CisgICAgTElCUyArPSAtbFgxMQorfQotLSAKMS43LjMKCg==