51691 2010-12-28 14:49:00 -0800 [GTK] GSettings warning is concealing real warnings on the build bots 2010-12-29 15:38:33 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 327391 0 mrobinson 2010-12-28 14:49:00 -0800 Warnings about GSettings about very common the build bots. This ends up concealing real warnings, because there are so many tests with stderr output. Here is the output text: GSettings schema not found - settings will not be used or saved. GSettings schema not found - settings will not be used or saved. GSettings schema not found - settings will not be used or saved. 327392 1 77581 mrobinson 2010-12-28 14:50:50 -0800 Created attachment 77581 Patch for this issue 327474 2 77581 eric 2010-12-28 20:18:41 -0800 Comment on attachment 77581 Patch for this issue OK. It's sad that that's the only way to disable the message. Is that string saved anywhere in Gtk that you could compare against a variable instead of a manually typed c-string? 327577 3 77621 mrobinson 2010-12-29 08:40:01 -0800 Created attachment 77621 An alternate approach to this problem 327579 4 mrobinson 2010-12-29 08:44:13 -0800 (In reply to comment #3) > Created an attachment (id=77621) [details] > An alternate approach to this problem Here's another way to approach the issue. Instead of filtering the message in DumpRenderTree, this patch modifies WebKitGTK+ to not print the message when running in DumpRenderTree. 327696 5 77621 xan.lopez 2010-12-29 14:13:33 -0800 Comment on attachment 77621 An alternate approach to this problem I prefer this one by a long shot. 327704 6 77621 mrobinson 2010-12-29 14:34:49 -0800 Comment on attachment 77621 An alternate approach to this problem Clearing flags on attachment: 77621 Committed r74762: <http://trac.webkit.org/changeset/74762> 327705 7 mrobinson 2010-12-29 14:34:53 -0800 All reviewed patches have been landed. Closing bug. 327717 8 webkit.review.bot 2010-12-29 15:38:33 -0800 http://trac.webkit.org/changeset/74762 might have broken Leopard Intel Debug (Tests) 77581 2010-12-28 14:50:50 -0800 2010-12-29 14:21:56 -0800 Patch for this issue bug-51691-20101228145049.patch text/plain 1632 mrobinson ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ZTYy MmRkZWU4NmEwYTk3NThjMmZjNTFiZDVmMDViMmRjMmQ0ODY5Li44OGFkYWRmNzJkNzYwNjA5ZmQ3 MmM1MjE0MjZmMGVlZTBjYTY5YWExIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTItMjggIE1hcnRpbiBSb2Jp bnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEdTZXR0aW5ncyB3YXJuaW5nIGlzIGNvbmNlYWxp bmcgcmVhbCB3YXJuaW5ncyBvbiB0aGUgYnVpbGQgYm90cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE2OTEKKworICAgICAgICBGaWx0ZXIgb3V0IEdT ZXR0aW5ncyB3YXJuaW5ncyBmcm9tIER1bXBSZW5kZXJUcmVlIG91dHB1dC4gVGhpcyBzaG91bGQK KyAgICAgICAgY2xlYW4gdXAgdGhlIGJ1aWxkIGJvdCByZXN1bHRzIHBhZ2UgYSBncmVhdCBkZWFs LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAg ICAgICAgKGxvZ0hhbmRsZXIpOiBGaWx0ZXIgb3V0IEdTZXR0aW5ncyB3YXJuaW5ncy4KKwogMjAx MC0xMi0yNyAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUnViYmVy LXN0YW1wZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9E dW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggMzJhNDFjM2FmZDY5ZDkwM2ZlOWIxMGQ1ZjM5ZjAwN2Fi NWRhMDA5Mi4uODE2NjllYjYwMWEwZjI4MWUyMWJmMjM4MDBmODUzZjU5NzczZWM2YyAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC0xMDU2LDYgKzEw NTYsMTEgQEAgc3RhdGljIFdlYktpdFdlYlZpZXcqIHdlYlZpZXdDcmVhdGUoV2ViS2l0V2ViVmll dyogdmlldywgV2ViS2l0V2ViRnJhbWUqIGZyYW1lKQogCiBzdGF0aWMgdm9pZCBsb2dIYW5kbGVy KGNvbnN0IGdjaGFyKiBkb21haW4sIEdMb2dMZXZlbEZsYWdzIGxldmVsLCBjb25zdCBnY2hhciog bWVzc2FnZSwgZ3BvaW50ZXIgZGF0YSkKIHsKKyAgICAvLyBUaGlzIGlzIGEgY29tbW9uIHdhcm5p bmcgb24gdGhlIGJvdHMuIFdlIGZpbHRlciBpdCBoZXJlLCBiZWNhdXNlCisgICAgLy8gaXQgaXNu J3Qgc2VyaW91cyBhbmQgaXQgbWFrZXMgc3BvdHRpbmcgdmFsaWQgd2FybmluZ3MgdmVyeSBkaWZm aWN1bHQuCisgICAgaWYgKGdfc3RyX2VxdWFsKG1lc3NhZ2UsICJHU2V0dGluZ3Mgc2NoZW1hIG5v dCBmb3VuZCAtIHNldHRpbmdzIHdpbGwgbm90IGJlIHVzZWQgb3Igc2F2ZWQuIikpCisgICAgICAg IHJldHVybjsKKwogICAgIGlmIChsZXZlbCA8IEdfTE9HX0xFVkVMX0RFQlVHKQogICAgICAgICBm cHJpbnRmKHN0ZGVyciwgIiVzXG4iLCBtZXNzYWdlKTsKIH0K 77621 2010-12-29 08:40:01 -0800 2010-12-29 14:34:49 -0800 An alternate approach to this problem bug-51691-20101229084000.patch text/plain 2502 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZjhjODRlMjY2MDRkNjNhMmQ3YTQyZGVkODU5NDcxYTk0NGFiMmJhYy4uZDExYWYyNTUz Y2ExNmVjOGFlODJkYTA4MTAxMDE2OTJjMDk4MzQ1ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx MC0xMi0yOSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW0dUS10gR1NldHRpbmdzIHdhcm5pbmcgaXMgY29uY2VhbGluZyByZWFsIHdhcm5pbmdzIG9u IHRoZSBidWlsZCBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01MTY5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERvIG5vdCBwcmludCB0aGUgR1NldHRpbmdzIHdhcm5pbmcgbWVzc2FnZSB3aGVuIHJ1 bm5pbmcgaW4gRHVtcFJlbmRlclRyZWUuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2ViaW5z cGVjdG9yLmNwcDoKKyAgICAgICAgKGluc3BlY3RvckdTZXR0aW5ncyk6IERvIG5vdCBwcmludCB0 aGUgR1NldHRpbmdzIHdhcm5pbmcgaWYgd2UgYXJlIHJ1bm5pbmcKKyAgICAgICAgaW4gRHVtcFJl bmRlclRyZWUuIFRoaXMgc2hvdWxkIGNsZWFuIHVwIHRoZSB0ZXN0IHJlc3VsdHMgcGFnZSBhIGdy ZWF0IGRlYWwuCisKIDIwMTAtMTItMjggIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwCmluZGV4IGFkNDU1YmJkNmIwNzJhMDRjNGQ4Y2Q3YjFh YmEzZTNjOTYyOWE0M2MuLjdmMGIzZWQ3ZmRiYTU1YzIzNTVhOWZhNWQxOTQyOTAxODUwYWJmZTAg MTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5jcHAKKysr IGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNwcApAQCAtNTk2LDIzICs1 OTYsMjMgQEAgc3RhdGljIGJvb2wgaXNTY2hlbWFBdmFpbGFibGUoY29uc3QgY2hhciogc2NoZW1h SUQpCiBHU2V0dGluZ3MqIGluc3BlY3RvckdTZXR0aW5ncygpCiB7CiAgICAgc3RhdGljIEdTZXR0 aW5ncyogc2V0dGluZ3MgPSAwOwotCiAgICAgaWYgKHNldHRpbmdzKQogICAgICAgICByZXR1cm4g c2V0dGluZ3M7CiAKKyAgICAvLyBVbmZvcnR1bmF0ZWx5IEdTZXR0aW5ncyB3aWxsIGFib3J0IHRo ZSBwcm9jZXNzIGV4ZWN1dGlvbiBpZiB0aGUgc2NoZW1hIGlzIG5vdAorICAgIC8vIGluc3RhbGxl ZCwgd2hpY2ggaXMgdGhlIGNhc2UgZm9yIHdoZW4gcnVubmluZyB0ZXN0cywgb3IgZXZlbiB0aGUg aW50cm9zcGVjdGlvbiBkdW1wCisgICAgLy8gYXQgYnVpbGQgdGltZSwgc28gY2hlY2sgaWYgd2Ug aGF2ZSB0aGUgc2NoZW1hIGJlZm9yZSB0cnlpbmcgdG8gaW5pdGlhbGl6ZSBpdC4KICAgICBjb25z dCBnY2hhciogc2NoZW1hSUQgPSAib3JnLndlYmtpdGd0ay0iV0VCS0lUR1RLX0FQSV9WRVJTSU9O X1NUUklORyIuaW5zcGVjdG9yIjsKLQotICAgIC8vIFVuZm9ydHVuYXRlbHkgR1NldHRpbmdzIHdp bGwgYWJvcnQgdGhlIHByb2Nlc3MgZXhlY3V0aW9uIGlmIHRoZQotICAgIC8vIHNjaGVtYSBpcyBu b3QgaW5zdGFsbGVkLCB3aGljaCBpcyB0aGUgY2FzZSBmb3Igd2hlbiBydW5uaW5nCi0gICAgLy8g dGVzdHMsIG9yIGV2ZW4gdGhlIGludHJvc3BlY3Rpb24gZHVtcCBhdCBidWlsZCB0aW1lLCBzbyBj aGVjawotICAgIC8vIGlmIHdlIGhhdmUgdGhlIHNjaGVtYSBiZWZvcmUgdHJ5aW5nIHRvIGluaXRp YWxpemUgaXQuCiAgICAgaWYgKCFpc1NjaGVtYUF2YWlsYWJsZShzY2hlbWFJRCkpIHsKLSAgICAg ICAgZ193YXJuaW5nKCJHU2V0dGluZ3Mgc2NoZW1hIG5vdCBmb3VuZCAtIHNldHRpbmdzIHdpbGwg bm90IGJlIHVzZWQgb3Igc2F2ZWQuIik7CisKKyAgICAgICAgLy8gVGhpcyB3YXJuaW5nIGlzIHZl cnkgY29tbW9uIG9uIHRoZSBidWlsZCBib3RzLCB3aGljaCBoaWRlcyB2YWxpZCB3YXJuaW5ncy4K KyAgICAgICAgLy8gU2tpcCBwcmludGluZyBpdCBpZiB3ZSBhcmUgcnVubmluZyBpbnNpZGUgRHVt cFJlbmRlclRyZWUuCisgICAgICAgIGlmICghRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpkdW1w UmVuZGVyVHJlZU1vZGVFbmFibGVkKCkpCisgICAgICAgICAgICBnX3dhcm5pbmcoIkdTZXR0aW5n cyBzY2hlbWEgbm90IGZvdW5kIC0gc2V0dGluZ3Mgd2lsbCBub3QgYmUgdXNlZCBvciBzYXZlZC4i KTsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCiAgICAgc2V0dGluZ3MgPSBnX3NldHRpbmdz X25ldyhzY2hlbWFJRCk7Ci0KICAgICByZXR1cm4gc2V0dGluZ3M7CiB9CiAjZW5kaWYK