51687 2010-12-28 13:36:39 -0800 [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform() 2010-12-28 16:13:32 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 0 jhanssen webkit-unassigned abarth ariya.hidayat commit-queue eric kling webkit.review.bot oldest_to_newest 327328 0 jhanssen 2010-12-28 13:36:39 -0800 GraphicsContext::getCTM() does not need to make a copy of the QTransform returned by QPainter::combinedTransform(), it could instead use a const reference. This will avoid a copy for compilers that don't implement (or enable by default) the NRVO optimization. 327336 1 77575 jhanssen 2010-12-28 13:39:56 -0800 Created attachment 77575 Patch 327337 2 77575 eric 2010-12-28 13:43:58 -0800 Comment on attachment 77575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77575&action=review > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:292 > return AffineTransform(matrix.m11(), matrix.m12(), matrix.m21(), Why don't we just have a AffineTransform(const QTransform&) constructor which is compiled on Qt? 327339 3 eric 2010-12-28 13:45:42 -0800 I guess that's not the pattern. No other platfrom seems to have custom constructors anymore. Strange, since that's how we (at least used to) do IntPoint, IntRect, etc. 327395 4 77575 commit-queue 2010-12-28 14:56:12 -0800 Comment on attachment 77575 Patch Clearing flags on attachment: 77575 Committed r74728: <http://trac.webkit.org/changeset/74728> 327396 5 commit-queue 2010-12-28 14:56:19 -0800 All reviewed patches have been landed. Closing bug. 327418 6 webkit.review.bot 2010-12-28 16:13:32 -0800 http://trac.webkit.org/changeset/74728 might have broken Leopard Intel Debug (Tests) 77575 2010-12-28 13:39:56 -0800 2010-12-28 14:56:12 -0800 Patch bug-51687-20101228133955.patch text/plain 1525 jhanssen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjE1MjgwNjQ4OTg5M2YyYmU2MDc5OGIzY2QxMTg0MTNmNWE0OTM2My4uNTZkM2M0ODUzYzEwN2Iy ZjkxNzY2OWYxZjljMDc3MGE5ODFmZDMxZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0yOCAgSmFu IEVyaWsgSGFuc3NlbiAgPGpoYW5zc2VuQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFwaGljc0NvbnRleHQ6OmdldENU TSgpIGRvZXMgbm90IG5lZWQgdG8gbWFrZSBhIGNvcHkgb2YgUVBhaW50ZXI6OmNvbWJpbmVkVHJh bnNmb3JtKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUxNjg3CisKKyAgICAgICAgVXNlIGEgY29uc3QgcmVmZXJlbmNlIGluc3RlYWQgb2YgYSBjb3B5 IG9mIFFQYWludGVyOjpjb21iaW5lZFRyYW5zZm9ybSgpIAorICAgICAgICBpbiBHcmFwaGljc0Nv bnRleHQ6OmdldENUTSgpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmdldENU TSk6CisKIDIwMTAtMTItMjggIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKaW5kZXggNzAxYmUwMDMx YTBiYmNkZjdjNjg1NjU0ZjkyZWE3Y2Q0ZjgzYjkwMy4uMGNmNmYyMjMwNDQyYTY2ZDlkZDY4NzQ0 Y2QwNzIxZTFmNDUxZjQwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9HcmFwaGljc0NvbnRleHRRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9HcmFwaGljc0NvbnRleHRRdC5jcHAKQEAgLTI4OCw3ICsyODgsNyBAQCBQbGF0Zm9ybUdyYXBo aWNzQ29udGV4dCogR3JhcGhpY3NDb250ZXh0OjpwbGF0Zm9ybUNvbnRleHQoKSBjb25zdAogCiBB ZmZpbmVUcmFuc2Zvcm0gR3JhcGhpY3NDb250ZXh0OjpnZXRDVE0oKSBjb25zdAogewotICAgIFFU cmFuc2Zvcm0gbWF0cml4KHBsYXRmb3JtQ29udGV4dCgpLT5jb21iaW5lZFRyYW5zZm9ybSgpKTsK KyAgICBjb25zdCBRVHJhbnNmb3JtJiBtYXRyaXggPSBwbGF0Zm9ybUNvbnRleHQoKS0+Y29tYmlu ZWRUcmFuc2Zvcm0oKTsKICAgICByZXR1cm4gQWZmaW5lVHJhbnNmb3JtKG1hdHJpeC5tMTEoKSwg bWF0cml4Lm0xMigpLCBtYXRyaXgubTIxKCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICBt YXRyaXgubTIyKCksIG1hdHJpeC5keCgpLCBtYXRyaXguZHkoKSk7CiB9Cg==