51684 2010-12-28 11:49:45 -0800 Remove unused member of PendingScript 2010-12-29 12:08:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tonyg tonyg abarth commit-queue eric koivisto rniwa webkit.review.bot oldest_to_newest 327298 0 tonyg 2010-12-28 11:49:45 -0800 Remove unused member of PendingScript 327301 1 77569 tonyg 2010-12-28 11:52:19 -0800 Created attachment 77569 Patch 327304 2 77569 eric 2010-12-28 12:07:50 -0800 Comment on attachment 77569 Patch OK. 327305 3 eric 2010-12-28 12:08:48 -0800 How does this relate to our eventual desire to show better line numbers for javascript errors? I assume not at all. I guess the time we're missing line numbers is document.written JS which I don't know how you'd show line numbers for anyway. 327352 4 77569 commit-queue 2010-12-28 13:58:01 -0800 Comment on attachment 77569 Patch Clearing flags on attachment: 77569 Committed r74724: <http://trac.webkit.org/changeset/74724> 327353 5 commit-queue 2010-12-28 13:58:07 -0800 All reviewed patches have been landed. Closing bug. 327398 6 webkit.review.bot 2010-12-28 15:03:03 -0800 http://trac.webkit.org/changeset/74724 might have broken Leopard Intel Debug (Tests) 327556 7 koivisto 2010-12-29 07:22:20 -0800 We are going to need this code to make inline scripts block on stylesheet loads as required by HTML5. Why was it so important to wipe it out right now? 327578 8 tonyg 2010-12-29 08:40:54 -0800 (In reply to comment #7) > We are going to need this code to make inline scripts block on stylesheet loads as required by HTML5. Why was it so important to wipe it out right now? Feel free to add the member back if you need it. It has been dead for several months, so I cleaned it up. Out of curiosity, are you planning to implement inline script blocking on stylesheet loads? We had initially held off on that because we didn't know of any compat problems so weren't in a rush to take the perf hit. However, if there are any sites that would benefit from it, we should obviously do it. 327580 9 koivisto 2010-12-29 09:01:22 -0800 > Feel free to add the member back if you need it. It has been dead for several months, so I cleaned it up. > > Out of curiosity, are you planning to implement inline script blocking on stylesheet loads? We had initially held off on that because we didn't know of any compat problems so weren't in a rush to take the perf hit. However, if there are any sites that would benefit from it, we should obviously do it. Yeah, I was just working on a patch (which is why I noticed when the code I was using was gone). This causes small rendering issues all over, for example my bank login page has incorrect layout on first load due to this (https://solo1.nordea.fi/nsp/engine). Another advantage is that simplifies script and stylesheet loading. We should be able to wipe out most of the nasty updateLayoutIgnorePendingStylesheets() code and probably find performance improvements there too. Generally there shouldn't be a significant performance hit from this, the preloader picks up the resources that would otherwise have their load start delayed (though you can construct a case which this would slow down). Blocking execution of external scripts was a much bigger change and didn't cause performance issues in practice. 327593 10 koivisto 2010-12-29 09:38:56 -0800 Patch in bug 8852 (including reverting this patch) 327657 11 tonyg 2010-12-29 12:08:39 -0800 (In reply to comment #9) > > Feel free to add the member back if you need it. It has been dead for several months, so I cleaned it up. > > > > Out of curiosity, are you planning to implement inline script blocking on stylesheet loads? We had initially held off on that because we didn't know of any compat problems so weren't in a rush to take the perf hit. However, if there are any sites that would benefit from it, we should obviously do it. > > Yeah, I was just working on a patch (which is why I noticed when the code I was using was gone). Sorry for the trouble, I obviously wouldn't have done this had I seen your patch. > > This causes small rendering issues all over, for example my bank login page has incorrect layout on first load due to this (https://solo1.nordea.fi/nsp/engine). I'm not sure if I agree with your point below about blocking external scripts on style not paying a performance cost in practice. While preloading may allow the overall page to complete in the same amount of time, the blocking means that during the load the user may be looking at less rendered content (a hard effect to quantify). However, I definitely agree that if there are any compat bugs, it should be fixed. Thanks for pointing out the bank login example. I wonder if this is also causing https://bugs.webkit.org/show_bug.cgi?id=50529 (which we haven't reduced yet). > > Another advantage is that simplifies script and stylesheet loading. We should be able to wipe out most of the nasty updateLayoutIgnorePendingStylesheets() code and probably find performance improvements there too. > > Generally there shouldn't be a significant performance hit from this, the preloader picks up the resources that would otherwise have their load start delayed (though you can construct a case which this would slow down). Blocking execution of external scripts was a much bigger change and didn't cause performance issues in practice. 77569 2010-12-28 11:52:19 -0800 2010-12-28 13:58:01 -0800 Patch bug-51684-20101228115218.patch text/plain 4129 tonyg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzA4N2FkNjQ2YmE0MDRhOWQ0YTFhNTUxODE3YThhZGE2Yjc0MjQ1MC4uZTkyNzlkYzlhMmVhMTNm MTQ5ZjJmZTY0MmFjZTljMjdiYmMyYjY2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0xMi0yOCAgVG9u eSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgbWVtYmVyIG9mIFBlbmRp bmdTY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUxNjg0CisKKyAgICAgICAgVGhpcyB3YXMgdXNlZCB3aGVuIEhUTUxTY3JpcHRSdW5uZXI6OnJ1 blNjcmlwdCBjcmVhdGVkIGEgUGVuZGluZ1NjcmlwdAorICAgICAgICBmb3IgaW5saW5lIHNjcmlw dHMuIEJ1dCBub3cgaXQganVzdCBjYWxscyBleGVjdXRlU2NyaXB0KCkgZGlyZWN0bHkuCisgICAg ICAgIEV4dGVybmFsIHNjcmlwdHMgYWx3YXlzIGhhdmUgdGhlIG1pbmltdW0gc3RhcnRpbmcgbGlu ZSBudW1iZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugbm8gY2hhbmdlZCBmdW5j dGlvbmFsaXR5LgorCisgICAgICAgICogZG9tL1BlbmRpbmdTY3JpcHQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGVuZGluZ1NjcmlwdDo6cmVsZWFzZUVsZW1lbnRBbmRDbGVhcik6CisgICAgICAg ICogZG9tL1BlbmRpbmdTY3JpcHQuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBlbmRpbmdTY3JpcHQ6 OlBlbmRpbmdTY3JpcHQpOgorICAgICAgICAoV2ViQ29yZTo6UGVuZGluZ1NjcmlwdDo6b3BlcmF0 b3I9KToKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MU2NyaXB0UnVubmVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxTY3JpcHRSdW5uZXI6OnNvdXJjZUZyb21QZW5kaW5nU2NyaXB0KToK KwogMjAxMC0xMi0yOCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2RvbS9QZW5kaW5nU2NyaXB0LmNwcCBiL1dlYkNvcmUvZG9tL1BlbmRpbmdTY3JpcHQuY3BwCmlu ZGV4IDE4ZjYwNzExYTRjZDMwMjMyOWJjYWFkNGQ5OGI4YTIwYzdjZTEyZmQuLjEwYjgxMzdmNjkx NTAzYTJiMThmNGNjMWY0NjE4YmM4YzEyZjMwZDcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1Bl bmRpbmdTY3JpcHQuY3BwCisrKyBiL1dlYkNvcmUvZG9tL1BlbmRpbmdTY3JpcHQuY3BwCkBAIC00 MCw3ICs0MCw2IEBAIFBlbmRpbmdTY3JpcHQ6On5QZW5kaW5nU2NyaXB0KCkKIFBhc3NSZWZQdHI8 RWxlbWVudD4gUGVuZGluZ1NjcmlwdDo6cmVsZWFzZUVsZW1lbnRBbmRDbGVhcigpCiB7CiAgICAg c2V0Q2FjaGVkU2NyaXB0KDApOwotICAgIG1fc3RhcnRpbmdQb3NpdGlvbiA9IFRleHRQb3NpdGlv bjE6OmJlbG93UmFuZ2VQb3NpdGlvbigpOwogICAgIG1fd2F0Y2hpbmdGb3JMb2FkID0gZmFsc2U7 CiAgICAgcmV0dXJuIG1fZWxlbWVudC5yZWxlYXNlKCk7CiB9CmRpZmYgLS1naXQgYS9XZWJDb3Jl L2RvbS9QZW5kaW5nU2NyaXB0LmggYi9XZWJDb3JlL2RvbS9QZW5kaW5nU2NyaXB0LmgKaW5kZXgg MDgzNTA3YTliOTA5MTZiY2YyODY1MWRmNjI5ZTViMjNiYjk0MjJjOC4uZjY3OWQ1ZDhiMmM4MzBj YTAxYzA1ZjcyMjE2OWY5ODNkYjMwOTE1MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vUGVuZGlu Z1NjcmlwdC5oCisrKyBiL1dlYkNvcmUvZG9tL1BlbmRpbmdTY3JpcHQuaApAQCAtNDQsMTQgKzQ0 LDEyIEBAIGNsYXNzIEVsZW1lbnQ7CiBjbGFzcyBQZW5kaW5nU2NyaXB0IDogcHVibGljIENhY2hl ZFJlc291cmNlQ2xpZW50IHsKIHB1YmxpYzoKICAgICBQZW5kaW5nU2NyaXB0KCkKLSAgICAgICAg OiBtX3N0YXJ0aW5nUG9zaXRpb24oVGV4dFBvc2l0aW9uMTo6YmVsb3dSYW5nZVBvc2l0aW9uKCkp Ci0gICAgICAgICwgbV93YXRjaGluZ0ZvckxvYWQoZmFsc2UpCisgICAgICAgIDogbV93YXRjaGlu Z0ZvckxvYWQoZmFsc2UpCiAgICAgewogICAgIH0KIAogICAgIFBlbmRpbmdTY3JpcHQoY29uc3Qg UGVuZGluZ1NjcmlwdCYgb3RoZXIpCiAgICAgICAgIDogQ2FjaGVkUmVzb3VyY2VDbGllbnQob3Ro ZXIpCi0gICAgICAgICwgbV9zdGFydGluZ1Bvc2l0aW9uKG90aGVyLm1fc3RhcnRpbmdQb3NpdGlv bikKICAgICAgICAgLCBtX3dhdGNoaW5nRm9yTG9hZChvdGhlci5tX3dhdGNoaW5nRm9yTG9hZCkK ICAgICAgICAgLCBtX2VsZW1lbnQob3RoZXIubV9lbGVtZW50KQogICAgIHsKQEAgLTY1LDcgKzYz LDYgQEAgcHVibGljOgogICAgICAgICBpZiAodGhpcyA9PSAmb3RoZXIpCiAgICAgICAgICAgICBy ZXR1cm4gKnRoaXM7CiAKLSAgICAgICAgbV9zdGFydGluZ1Bvc2l0aW9uID0gb3RoZXIubV9zdGFy dGluZ1Bvc2l0aW9uOwogICAgICAgICBtX3dhdGNoaW5nRm9yTG9hZCA9IG90aGVyLm1fd2F0Y2hp bmdGb3JMb2FkOwogICAgICAgICBtX2VsZW1lbnQgPSBvdGhlci5tX2VsZW1lbnQ7CiAgICAgICAg IHNldENhY2hlZFNjcmlwdChvdGhlci5jYWNoZWRTY3JpcHQoKSk7CkBAIC03MywxMCArNzAsNiBA QCBwdWJsaWM6CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKLSAgICAvLyBGSVhNRTog Tm8gc2V0dGVyIG1lYW5zIHRoaXMgaXMgbmV2ZXIgc2V0IHRvIGFueXRoaW5nIG90aGVyIHRoYW4g MC4KLSAgICAvLyBUaGlzIGlzIGVpdGhlciB1bm5lY2Vzc2FyeSBvciBpbmNvcnJlY3QuCi0gICAg VGV4dFBvc2l0aW9uMSBzdGFydGluZ1Bvc2l0aW9uKCkgY29uc3QgeyByZXR1cm4gbV9zdGFydGlu Z1Bvc2l0aW9uOyB9Ci0KICAgICBib29sIHdhdGNoaW5nRm9yTG9hZCgpIGNvbnN0IHsgcmV0dXJu IG1fd2F0Y2hpbmdGb3JMb2FkOyB9CiAgICAgdm9pZCBzZXRXYXRjaGluZ0ZvckxvYWQoYm9vbCBi KSB7IG1fd2F0Y2hpbmdGb3JMb2FkID0gYjsgfQogCkBAIC05MCw3ICs4Myw2IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5RmluaXNoZWQoQ2FjaGVkUmVzb3VyY2UqKTsKIAogcHJp dmF0ZToKLSAgICBUZXh0UG9zaXRpb24xIG1fc3RhcnRpbmdQb3NpdGlvbjsgLy8gT25seSB1c2Vk IGZvciBpbmxpbmUgc2NyaXB0IHRhZ3MuCiAgICAgYm9vbCBtX3dhdGNoaW5nRm9yTG9hZDsKICAg ICBSZWZQdHI8RWxlbWVudD4gbV9lbGVtZW50OwogICAgIENhY2hlZFJlc291cmNlSGFuZGxlPENh Y2hlZFNjcmlwdD4gbV9jYWNoZWRTY3JpcHQ7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvcGFy c2VyL0hUTUxTY3JpcHRSdW5uZXIuY3BwIGIvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MU2NyaXB0 UnVubmVyLmNwcAppbmRleCA3OTc4YTBmN2E3ZGI0NjkzMzQ2YjFlZjNjYzY3YTFiOThkOTQ1MmRi Li4yNjcyZjM5YzA0NGNlZmExMGYwOWU1MDZhMGY4NzNkNTJiN2NmMjkxIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxTY3JpcHRSdW5uZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTFNjcmlwdFJ1bm5lci5jcHAKQEAgLTk5LDcgKzk5LDcgQEAgU2NyaXB0U291 cmNlQ29kZSBIVE1MU2NyaXB0UnVubmVyOjpzb3VyY2VGcm9tUGVuZGluZ1NjcmlwdChjb25zdCBQ ZW5kaW5nU2NyaXB0JgogICAgICAgICByZXR1cm4gU2NyaXB0U291cmNlQ29kZShzY3JpcHQuY2Fj aGVkU2NyaXB0KCkpOwogICAgIH0KICAgICBlcnJvck9jY3VycmVkID0gZmFsc2U7Ci0gICAgcmV0 dXJuIFNjcmlwdFNvdXJjZUNvZGUoc2NyaXB0LmVsZW1lbnQoKS0+dGV4dENvbnRlbnQoKSwgZG9j dW1lbnRVUkxGb3JTY3JpcHRFeGVjdXRpb24obV9kb2N1bWVudCksIHNjcmlwdC5zdGFydGluZ1Bv c2l0aW9uKCkpOworICAgIHJldHVybiBTY3JpcHRTb3VyY2VDb2RlKHNjcmlwdC5lbGVtZW50KCkt PnRleHRDb250ZW50KCksIGRvY3VtZW50VVJMRm9yU2NyaXB0RXhlY3V0aW9uKG1fZG9jdW1lbnQp KTsKIH0KIAogYm9vbCBIVE1MU2NyaXB0UnVubmVyOjppc1BlbmRpbmdTY3JpcHRSZWFkeShjb25z dCBQZW5kaW5nU2NyaXB0JiBzY3JpcHQpCg==