51661 2010-12-27 17:40:57 -0800 ContextShadow should use AffineTransform instead of TransformationMatrix 2011-01-05 19:06:57 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 helder webkit-unassigned abarth ariya.hidayat commit-queue eric mdelaney7 mrobinson sam simon.fraser webkit.review.bot oldest_to_newest 327164 0 helder 2010-12-27 17:40:57 -0800 ContextShadow needs the CTM to make sure shadows are not affected by transformations when drawing on a canvas. AffineTransform is sufficient in this case. 327165 1 77530 helder 2010-12-27 17:45:02 -0800 Created attachment 77530 Patch 327175 2 77530 ariya.hidayat 2010-12-27 19:46:58 -0800 Comment on attachment 77530 Patch LGTM. re=me 327180 3 77530 ariya.hidayat 2010-12-27 20:45:02 -0800 Comment on attachment 77530 Patch cq+ 327189 4 77530 commit-queue 2010-12-27 21:33:18 -0800 Comment on attachment 77530 Patch Clearing flags on attachment: 77530 Committed r74708: <http://trac.webkit.org/changeset/74708> 327190 5 commit-queue 2010-12-27 21:33:24 -0800 All reviewed patches have been landed. Closing bug. 327232 6 webkit.review.bot 2010-12-28 07:56:41 -0800 http://trac.webkit.org/changeset/74708 might have broken Leopard Intel Debug (Tests) 327261 7 sam 2010-12-28 10:37:51 -0800 It seem like the function name getTransformationMatrixFromContext really should be changed as well. 329976 8 helder 2011-01-05 19:06:57 -0800 (In reply to comment #7) > It seem like the function name getTransformationMatrixFromContext really should be changed as well. Just a follow-up: the function was removed in http://trac.webkit.org/changeset/74947 77530 2010-12-27 17:45:02 -0800 2010-12-27 21:33:18 -0800 Patch bug-51661-20101227174500.patch text/plain 6478 helder ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWEyNTBhNWRmNDA3OTE4YjA3OTFkODRkMmJjMDI5Y2FkMzcxZjc2OS4uMzhiYTU4Y2MwMjVkMjc5 NjhiMGM3MzlhODlmZmU5YmM2MzdiMTAxNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMC0xMi0yNyAgSGVs ZGVyIENvcnJlaWEgIDxoZWxkZXJAc2VuY2hhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb250ZXh0U2hhZG93IHNob3VsZCB1c2UgQWZmaW5l VHJhbnNmb3JtIGluc3RlYWQgb2YgVHJhbnNmb3JtYXRpb25NYXRyaXgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjYxCisKKyAgICAgICAgQ29udGV4 dFNoYWRvdyBuZWVkcyB0aGUgQ1RNIHRvIG1ha2Ugc3VyZSBzaGFkb3dzIGFyZSBub3QgYWZmZWN0 ZWQgYnkKKyAgICAgICAgdHJhbnNmb3JtYXRpb25zIHdoZW4gZHJhd2luZyBvbiBhIGNhbnZhcy4g QWZmaW5lVHJhbnNmb3JtIGlzIHN1ZmZpY2llbnQKKyAgICAgICAgaW4gdGhpcyBjYXNlLgorCisg ICAgICAgIEV4aXN0aW5nIHRlc3RzOiBmYXN0L2NhbnZhcy9jYW52YXMqc2hhZG93Kmh0bWwKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0NvbnRleHRTaGFkb3cuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q29udGV4dFNoYWRvdzo6bXVzdFVzZUNvbnRleHRTaGFkb3cpOgorICAgICAgICAo V2ViQ29yZTo6Q29udGV4dFNoYWRvdzo6YWRqdXN0Qmx1ckRpc3RhbmNlKToKKyAgICAgICAgKFdl YkNvcmU6OkNvbnRleHRTaGFkb3c6OmNhbGN1bGF0ZUxheWVyQm91bmRpbmdSZWN0KToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Db250ZXh0U2hhZG93Lmg6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vQ29udGV4dFNoYWRvd0NhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNvbnRleHRTaGFkb3c6OmdldFRyYW5zZm9ybWF0aW9uTWF0cml4RnJvbUNvbnRleHQpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0NvbnRleHRTaGFkb3dRdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDb250ZXh0U2hhZG93OjpnZXRUcmFuc2Zvcm1hdGlvbk1hdHJpeEZyb21D b250ZXh0KToKKwogMjAxMC0xMi0yNyAgQW50b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9Db250ZXh0U2hhZG93LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvQ29udGV4dFNoYWRvdy5jcHAKaW5kZXggYjM0ZTU0NjYxMjJhYmNkNjk0NTFjMDQ5 OTcyZjMyZDc3YmU0OTk1OC4uOTVhYWQ0NjljMzljNzhjM2Q4ZTQ1ZjkxZTQ1YWY1ODVjNDQ4OGYy OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db250ZXh0U2hhZG93LmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbnRleHRTaGFkb3cuY3BwCkBAIC05 MSw3ICs5MSw3IEBAIGJvb2wgQ29udGV4dFNoYWRvdzo6bXVzdFVzZUNvbnRleHRTaGFkb3coUGxh dGZvcm1Db250ZXh0IGNvbnRleHQpCiAgICAgaWYgKCFzaGFkb3dzSWdub3JlVHJhbnNmb3Jtcygp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgLy8gV2UgY2FuIGF2b2lkIENvbnRleHRTaGFk b3csIHNpbmNlIHRoZXJlIGFyZSBubyB0cmFuc2Zvcm1hdGlvbnMgdG8gYXBwbHkgdG8gdGhlIGNh bnZhcy4KLSAgICBjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCB0cmFuc2Zvcm0oZ2V0VHJhbnNm b3JtYXRpb25NYXRyaXhGcm9tQ29udGV4dChjb250ZXh0KSk7CisgICAgY29uc3QgQWZmaW5lVHJh bnNmb3JtIHRyYW5zZm9ybShnZXRUcmFuc2Zvcm1hdGlvbk1hdHJpeEZyb21Db250ZXh0KGNvbnRl eHQpKTsKICAgICBpZiAodHJhbnNmb3JtLmlzSWRlbnRpdHkoKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgIC8vIE90aGVyd2lzZSwgbm8gY2hhbmNlIGF2b2lkaW5nIENvbnRleHRTaGFkb3cu CkBAIC0xNzMsNyArMTczLDcgQEAgdm9pZCBDb250ZXh0U2hhZG93OjpibHVyTGF5ZXJJbWFnZSh1 bnNpZ25lZCBjaGFyKiBpbWFnZURhdGEsIGNvbnN0IEludFNpemUmIHNpemUKIHZvaWQgQ29udGV4 dFNoYWRvdzo6YWRqdXN0Qmx1ckRpc3RhbmNlKGNvbnN0IFBsYXRmb3JtQ29udGV4dCBjb250ZXh0 KQogewogICAgIC8vIEFkanVzdCBibHVyIGlmIHdlJ3JlIHNjYWxpbmcsIHNpbmNlIHRoZSByYWRp dXMgbXVzdCBub3QgYmUgYWZmZWN0ZWQgYnkgdHJhbnNmb3JtYXRpb25zLgotICAgIGNvbnN0IFRy YW5zZm9ybWF0aW9uTWF0cml4IHRyYW5zZm9ybShnZXRUcmFuc2Zvcm1hdGlvbk1hdHJpeEZyb21D b250ZXh0KGNvbnRleHQpKTsKKyAgICBjb25zdCBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtKGdl dFRyYW5zZm9ybWF0aW9uTWF0cml4RnJvbUNvbnRleHQoY29udGV4dCkpOwogCiAgICAgaWYgKHRy YW5zZm9ybS5pc0lkZW50aXR5KCkpCiAgICAgICAgIHJldHVybjsKQEAgLTIwNCw3ICsyMDQsNyBA QCBJbnRSZWN0IENvbnRleHRTaGFkb3c6OmNhbGN1bGF0ZUxheWVyQm91bmRpbmdSZWN0KGNvbnN0 IFBsYXRmb3JtQ29udGV4dCBjb250ZXh0LAogICAgIEZsb2F0UmVjdCBsYXllckZsb2F0UmVjdDsK ICAgICBmbG9hdCBpbmZsYXRpb24gPSAwOwogCi0gICAgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRy aXggdHJhbnNmb3JtKGdldFRyYW5zZm9ybWF0aW9uTWF0cml4RnJvbUNvbnRleHQoY29udGV4dCkp OworICAgIGNvbnN0IEFmZmluZVRyYW5zZm9ybSB0cmFuc2Zvcm0oZ2V0VHJhbnNmb3JtYXRpb25N YXRyaXhGcm9tQ29udGV4dChjb250ZXh0KSk7CiAgICAgaWYgKG1fc2hhZG93c0lnbm9yZVRyYW5z Zm9ybXMgJiYgIXRyYW5zZm9ybS5pc0lkZW50aXR5KCkpIHsKICAgICAgICAgRmxvYXRRdWFkIHRy YW5zZm9ybWVkUG9seWdvbiA9IHRyYW5zZm9ybS5tYXBRdWFkKEZsb2F0UXVhZChsYXllckFyZWEp KTsKICAgICAgICAgdHJhbnNmb3JtZWRQb2x5Z29uLm1vdmUobV9vZmZzZXQpOwpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db250ZXh0U2hhZG93LmggYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0NvbnRleHRTaGFkb3cuaAppbmRleCA4ZjE0MjI5MDdhYjk1YTFiNzdm MzUzZmIzMWQ3YmE3Y2FkODk3M2YxLi5hNGMzZjAwY2YxOTMwYzg5YjhhNWZkNjBkNjU1NzQ2ZGFk NzY3NDU3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbnRleHRTaGFk b3cuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbnRleHRTaGFkb3cuaApAQCAt MjksNiArMjksNyBAQAogI2lmbmRlZiBDb250ZXh0U2hhZG93X2gKICNkZWZpbmUgQ29udGV4dFNo YWRvd19oCiAKKyNpbmNsdWRlICJBZmZpbmVUcmFuc2Zvcm0uaCIKICNpbmNsdWRlICJDb2xvci5o IgogI2luY2x1ZGUgIkZsb2F0UmVjdC5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgpA QCAtMTA3LDcgKzEwOCw3IEBAIHB1YmxpYzoKICAgICBQbGF0Zm9ybUNvbnRleHQgYmVnaW5TaGFk b3dMYXllcihQbGF0Zm9ybUNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgbGF5ZXJBcmVhKTsKICAg ICB2b2lkIGVuZFNoYWRvd0xheWVyKFBsYXRmb3JtQ29udGV4dCk7CiAgICAgc3RhdGljIHZvaWQg cHVyZ2VTY3JhdGNoQnVmZmVyKCk7Ci0gICAgc3RhdGljIFRyYW5zZm9ybWF0aW9uTWF0cml4IGdl dFRyYW5zZm9ybWF0aW9uTWF0cml4RnJvbUNvbnRleHQoUGxhdGZvcm1Db250ZXh0KTsKKyAgICBz dGF0aWMgQWZmaW5lVHJhbnNmb3JtIGdldFRyYW5zZm9ybWF0aW9uTWF0cml4RnJvbUNvbnRleHQo UGxhdGZvcm1Db250ZXh0KTsKIAogICAgIHZvaWQgc2V0U2hhZG93c0lnbm9yZVRyYW5zZm9ybXMo Ym9vbCBlbmFibGUpIHsgbV9zaGFkb3dzSWdub3JlVHJhbnNmb3JtcyA9IGVuYWJsZTsgfQogICAg IGJvb2wgc2hhZG93c0lnbm9yZVRyYW5zZm9ybXMoKSBjb25zdCB7IHJldHVybiBtX3NoYWRvd3NJ Z25vcmVUcmFuc2Zvcm1zOyB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0NvbnRleHRTaGFkb3dDYWlyby5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0NvbnRleHRTaGFkb3dDYWlyby5jcHAKaW5kZXggYWU5MTI4MmFiNzU5OWI5YWRlYzA3 ZmE1OWVlMDkxZjJiMDliMjhhNy4uYzUyY2MzYTkwYmNmZTE1NjVkYjNkZmU1ODlmMzcxY2RlNWQw Y2FlNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Db250ZXh0 U2hhZG93Q2Fpcm8uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ29u dGV4dFNoYWRvd0NhaXJvLmNwcApAQCAtMjksNyArMjksNiBAQAogI2luY2x1ZGUgImNvbmZpZy5o IgogI2luY2x1ZGUgIkNvbnRleHRTaGFkb3cuaCIKIAotI2luY2x1ZGUgIkFmZmluZVRyYW5zZm9y bS5oIgogI2luY2x1ZGUgIkNhaXJvVXRpbGl0aWVzLmgiCiAjaW5jbHVkZSAiT3duUHRyQ2Fpcm8u aCIKICNpbmNsdWRlICJQYXRoLmgiCkBAIC04MiwxMiArODEsMTIgQEAgc3RhdGljIGNhaXJvX3N1 cmZhY2VfdCogZ2V0U2NyYXRjaEJ1ZmZlcihjb25zdCBJbnRTaXplJiBzaXplKQogICAgIHJldHVy biBzY3JhdGNoQnVmZmVyOwogfQogCi1UcmFuc2Zvcm1hdGlvbk1hdHJpeCBDb250ZXh0U2hhZG93 OjpnZXRUcmFuc2Zvcm1hdGlvbk1hdHJpeEZyb21Db250ZXh0KFBsYXRmb3JtQ29udGV4dCBjb250 ZXh0KQorQWZmaW5lVHJhbnNmb3JtIENvbnRleHRTaGFkb3c6OmdldFRyYW5zZm9ybWF0aW9uTWF0 cml4RnJvbUNvbnRleHQoUGxhdGZvcm1Db250ZXh0IGNvbnRleHQpCiB7CiAgICAgY2Fpcm9fbWF0 cml4X3QgdHJhbnNmb3JtOwogICAgIGNhaXJvX2dldF9tYXRyaXgoY29udGV4dCwgJnRyYW5zZm9y bSk7Ci0gICAgcmV0dXJuIFRyYW5zZm9ybWF0aW9uTWF0cml4KHRyYW5zZm9ybS54eCwgdHJhbnNm b3JtLnl4LCB0cmFuc2Zvcm0ueHksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRy YW5zZm9ybS55eSwgdHJhbnNmb3JtLngwLCB0cmFuc2Zvcm0ueTApOworICAgIHJldHVybiBBZmZp bmVUcmFuc2Zvcm0odHJhbnNmb3JtLnh4LCB0cmFuc2Zvcm0ueXgsIHRyYW5zZm9ybS54eSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHRyYW5zZm9ybS55eSwgdHJhbnNmb3JtLngwLCB0cmFu c2Zvcm0ueTApOwogfQogCiBQbGF0Zm9ybUNvbnRleHQgQ29udGV4dFNoYWRvdzo6YmVnaW5TaGFk b3dMYXllcihQbGF0Zm9ybUNvbnRleHQgY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiBsYXllckFy ZWEpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0NvbnRleHRTaGFk b3dRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0NvbnRleHRTaGFkb3dRdC5j cHAKaW5kZXggY2I1M2IyNDM4NGUyZDBmY2IyMDUzZDA1YTU4MmNlZmNiZjVkMjhjMS4uZTBlNzQy MjI1NDBmNWI2ZmJlZmZjZjRmYzZiNDUwN2JlYTMzMjQ1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9Db250ZXh0U2hhZG93UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNoYWRvd1F0LmNwcApAQCAtMTAwLDExICsxMDAsMTEg QEAgdm9pZCBTaGFkb3dCdWZmZXI6OnRpbWVyRXZlbnQoUVRpbWVyRXZlbnQqIGV2ZW50KQogICAg IFFPYmplY3Q6OnRpbWVyRXZlbnQoZXZlbnQpOwogfQogCi1UcmFuc2Zvcm1hdGlvbk1hdHJpeCBD b250ZXh0U2hhZG93OjpnZXRUcmFuc2Zvcm1hdGlvbk1hdHJpeEZyb21Db250ZXh0KFBsYXRmb3Jt Q29udGV4dCBjb250ZXh0KQorQWZmaW5lVHJhbnNmb3JtIENvbnRleHRTaGFkb3c6OmdldFRyYW5z Zm9ybWF0aW9uTWF0cml4RnJvbUNvbnRleHQoUGxhdGZvcm1Db250ZXh0IGNvbnRleHQpCiB7CiAg ICAgY29uc3QgUVRyYW5zZm9ybSYgdHJhbnNmb3JtID0gY29udGV4dC0+dHJhbnNmb3JtKCk7Ci0g ICAgcmV0dXJuIFRyYW5zZm9ybWF0aW9uTWF0cml4KHRyYW5zZm9ybS5tMTEoKSwgdHJhbnNmb3Jt Lm0xMigpLCB0cmFuc2Zvcm0ubTIxKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHRyYW5zZm9ybS5tMjIoKSwgdHJhbnNmb3JtLmR4KCksIHRyYW5zZm9ybS5keSgpKTsKKyAgICBy ZXR1cm4gQWZmaW5lVHJhbnNmb3JtKHRyYW5zZm9ybS5tMTEoKSwgdHJhbnNmb3JtLm0xMigpLCB0 cmFuc2Zvcm0ubTIxKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICB0cmFuc2Zvcm0ubTIy KCksIHRyYW5zZm9ybS5keCgpLCB0cmFuc2Zvcm0uZHkoKSk7CiB9CiAKIFFfR0xPQkFMX1NUQVRJ QyhTaGFkb3dCdWZmZXIsIHNjcmF0Y2hTaGFkb3dCdWZmZXIpCg==