51651 2010-12-27 12:48:24 -0800 build-webkit should detect missing Java SDK and explain how to install it 2010-12-27 13:13:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue darin tonyg oldest_to_newest 327095 0 eric 2010-12-27 12:48:24 -0800 build-webkit should detect missing Java SDK and explain how to install it 327097 1 eric 2010-12-27 12:49:32 -0800 It's lame that we have to do this, but at least this makes the failure condition more user friendly. 327098 2 77515 eric 2010-12-27 12:50:30 -0800 Created attachment 77515 Patch 327101 3 77515 commit-queue 2010-12-27 13:13:17 -0800 Comment on attachment 77515 Patch Clearing flags on attachment: 77515 Committed r74694: <http://trac.webkit.org/changeset/74694> 327102 4 commit-queue 2010-12-27 13:13:24 -0800 All reviewed patches have been landed. Closing bug. 77515 2010-12-27 12:50:30 -0800 2010-12-27 13:13:17 -0800 Patch bug-51651-20101227145028.patch text/plain 2012 eric ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYmY1 YWY5NmJlYWZmODIyMjM3NTI3YjQzYTYxMDVmMWFlZmY2MTA2Li43YzRkNzVkODQxOTc2ODQ2NmM2 NGUwMjhlOTcyNjVjNGNhZWMwNDEzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTItMjcgIEVyaWMgU2VpZGVs ICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGJ1aWxkLXdlYmtpdCBzaG91bGQgZGV0ZWN0IG1pc3NpbmcgSmF2YSBTREsg YW5kIGV4cGxhaW4gaG93IHRvIGluc3RhbGwgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjUxCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdl YmtpdDoKKwogMjAxMC0xMi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtp dAppbmRleCBjYmM4ZWJhYWFkOTY5MTQwNTMwN2RiYzMwNTYxYjRjZTA3Y2RlMjc0Li40NGEyOGFh NWMzNTkzNmNjYmViNDJjNzIzYTFkYTY0NzUyOTViYzhlIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNDMs NiArNDMsNyBAQCB1c2UgUE9TSVg7CiAKIHN1YiBmb3JtYXRCdWlsZFRpbWUoJCk7CiBzdWIgd3Jp dGVDb25ncmF0cygpOworc3ViIGNoZWNrRm9ySmF2YVNESygpOwogCiBteSAkb3JpZ2luYWxXb3Jr aW5nRGlyZWN0b3J5ID0gZ2V0Y3dkKCk7CiBjaGRpcldlYktpdCgpOwpAQCAtMzgyLDYgKzM4Myw3 IEBAIGlmIChpc0d0aygpKSB7CiAgICAgcHVzaCBAb3B0aW9ucywgIi0tcHJlZml4PSIgLiAkcHJl Zml4UGF0aCBpZiBkZWZpbmVkKCRwcmVmaXhQYXRoKTsKICAgICBwdXNoIEBvcHRpb25zLCAiLS1t YWtlYXJncz0iIC4gJG1ha2VBcmdzIGlmIGRlZmluZWQoJG1ha2VBcmdzKTsKIH0gZWxzaWYgKGlz QXBwbGVNYWNXZWJLaXQoKSkgeworICAgIGNoZWNrRm9ySmF2YVNESygpOwogICAgIHB1c2ggQG9w dGlvbnMsIFhjb2RlT3B0aW9ucygpOwogCiAgICAgc3ViIG9wdGlvbigkJCQpCkBAIC01NTksNiAr NTYxLDIxIEBAIHdyaXRlQ29uZ3JhdHMoKTsKIAogZXhpdCAwOwogCitzdWIgY2hlY2tGb3JKYXZh U0RLKCkKK3sKKyAgICBteSAkam5pSGVhZGVyID0gIi9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtz L0phdmFWTS5mcmFtZXdvcmsvSGVhZGVycy9qbmkuaCI7CisgICAgaWYgKC1lICRqbmlIZWFkZXIp IHsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBwcmludCAiXG5DYW4ndCBmaW5kIHJlcXVp cmVkICRqbmlIZWFkZXIsIGJ1aWxkIHdpbGwgZmFpbC5cblxuIjsKKyAgICBwcmludCAiQWZ0ZXIg aW5zdGFsbGluZyBcIkphdmEgZm9yIE1hYyBPUyBYIDEwLjYgVXBkYXRlIDNcIiwgdGhlIEphdmEg RGV2ZWxvcGVyIFBhY2thZ2UgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0LlxuIjsKKyAgICBw cmludCAiUGxlYXNlIGluc3RhbGwgdGhlIHBhY2thZ2UgZnJvbSBodHRwOi8vY29ubmVjdC5hcHBs ZS5jb20gKGZvdW5kIHVuZGVyIERvd2xvYWRzID4gSmF2YSkuXG5cbiI7CisgICAgcHJpbnQgIkZv ciBtb3JlIGluZm9ybWF0aW9uLCBzZWU6XG4iOworICAgIHByaW50ICJodHRwczovL2xpc3RzLndl YmtpdC5vcmcvcGlwZXJtYWlsL3dlYmtpdC1kZXYvMjAxMC1PY3RvYmVyLzAxNDg2Ny5odG1sXG4i OworICAgIHByaW50ICJodHRwczovL3dlYmtpdC5vcmcvYnVpbGRpbmcvdG9vbHMuaHRtbFxuXG4i OworICAgIGV4aXQgMTsKK30KKwogc3ViIGZvcm1hdEJ1aWxkVGltZSgkKQogewogICAgIG15ICgk YnVpbGRUaW1lKSA9IEBfOwo=