51643 2010-12-27 06:59:38 -0800 [WINCE] Provide 3rd party directory via environment variable 2011-01-03 16:18:48 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga abarth commit-queue eric webkit.review.bot oldest_to_newest 327034 0 paroga 2010-12-27 06:59:38 -0800 see patch 327035 1 77503 paroga 2010-12-27 07:01:48 -0800 Created attachment 77503 Patch 327356 2 77503 eric 2010-12-28 14:00:06 -0800 Comment on attachment 77503 Patch This seems confusing. Since we already have a ThirdParty directory in our sources. Seems like this is a WINCE3RDPARTY directory or similar? Also, why not spell out THRID? 327361 3 paroga 2010-12-28 14:05:19 -0800 (In reply to comment #2) > (From update of attachment 77503 [details]) > This seems confusing. Since we already have a ThirdParty directory in our sources. Seems like this is a WINCE3RDPARTY directory or similar? Also, why not spell out THRID? IMHO it's not WinCE specific. Other (embedded) port, where you can't use the system libraries of the host, maybe need a 3rd party directory for png, jpeg, xml, ... too. It's ok to spell out, but we should change it everywhere in the CMake files. ;-) 328749 4 77840 paroga 2011-01-03 13:30:06 -0800 Created attachment 77840 Patch 328751 5 77840 darin 2011-01-03 13:32:07 -0800 Comment on attachment 77840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77840&action=review > Sources/cmake/OptionsWinCE.cmake:14 > + IF (EXISTS $ENV{WEBKITTHRIDPARTYDIR}) > + SET(3RDPARTY_DIR $ENV{WEBKITTHRIDPARTYDIR}) Typo: THRID 328763 6 paroga 2011-01-03 13:43:30 -0800 (In reply to comment #5) > (From update of attachment 77840 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=77840&action=review > > > Sources/cmake/OptionsWinCE.cmake:14 > > + IF (EXISTS $ENV{WEBKITTHRIDPARTYDIR}) > > + SET(3RDPARTY_DIR $ENV{WEBKITTHRIDPARTYDIR}) > > Typo: THRID Good catch! Manually committed r74938: <http://trac.webkit.org/changeset/74938> 328825 7 webkit.review.bot 2011-01-03 16:18:48 -0800 http://trac.webkit.org/changeset/74942 might have broken Windows Release (Build) and Windows Debug (Build) 77503 2010-12-27 07:01:48 -0800 2011-01-03 13:30:06 -0800 Patch bug-51643.patch text/plain 1148 paroga ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzNWY2NmI4Li5jMTZhZTg1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTItMjcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dJTkNFXSBQcm92 aWRlIDNyZCBwYXJ0eSBkaXJlY3RvcnkgdmlhIGVudmlyb25tZW50IHZhcmlhYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTY0MworCisgICAgICAg ICogU291cmNlcy9jbWFrZS9PcHRpb25zV2luQ0UuY21ha2U6CisKIDIwMTAtMTItMjYgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNp ZWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJjZXMvY21ha2UvT3B0aW9uc1dpbkNFLmNtYWtlIGIvU291 cmNlcy9jbWFrZS9PcHRpb25zV2luQ0UuY21ha2UKaW5kZXggNzg4NDUzMC4uZjViMjhjZCAxMDA2 NDQKLS0tIGEvU291cmNlcy9jbWFrZS9PcHRpb25zV2luQ0UuY21ha2UKKysrIGIvU291cmNlcy9j bWFrZS9PcHRpb25zV2luQ0UuY21ha2UKQEAgLTEwLDcgKzEwLDExIEBAIEFERF9ERUZJTklUSU9O UygtRFVTRV9TWVNURU1fTUFMTE9DPTEpCiBBRERfREVGSU5JVElPTlMoLURKU0NDT0xMRUNUT1Jf VklSVFVBTE1FTV9SRVNFUlZBVElPTj0weDIwMDAwMCkKIAogSUYgKE5PVCAzUkRQQVJUWV9ESVIp Ci0gICAgTUVTU0FHRShGQVRBTF9FUlJPUiAiWW91IG11c3QgcHJvdmlkZSBhIDNyZCBwYXJ0eSBk aXJlY3RvcnkgZm9yIFdpbkNFIHBvcnQuIikKKyAgICBJRiAoRVhJU1RTICRFTlZ7V0VCS0lUM1JE UEFSVFlESVJ9KQorICAgICAgICBTRVQoM1JEUEFSVFlfRElSICRFTlZ7V0VCS0lUM1JEUEFSVFlE SVJ9KQorICAgIEVMU0UgKCkKKyAgICAgICAgTUVTU0FHRShGQVRBTF9FUlJPUiAiWW91IG11c3Qg cHJvdmlkZSBhIDNyZCBwYXJ0eSBkaXJlY3RvcnkgZm9yIFdpbkNFIHBvcnQuIikKKyAgICBFTkRJ RiAoKQogRU5ESUYgKCkKIAogSU5DTFVERV9ESVJFQ1RPUklFUygkezNSRFBBUlRZX0RJUn0vY2Ut Y29tcGF0KQo= 77840 2011-01-03 13:30:06 -0800 2011-01-03 13:32:07 -0800 Patch bug-51643.patch text/plain 1153 paroga ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzNWY2NmI4Li5jMTZhZTg1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTItMjcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dJTkNFXSBQcm92 aWRlIHRoaXJkIHBhcnR5IGRpcmVjdG9yeSB2aWEgZW52aXJvbm1lbnQgdmFyaWFibGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjQzCisKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNFLmNtYWtlOgorCiAyMDEwLTEyLTI2ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT aWVkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2VzL2NtYWtlL09wdGlvbnNXaW5DRS5jbWFrZSBiL1Nv dXJjZXMvY21ha2UvT3B0aW9uc1dpbkNFLmNtYWtlCmluZGV4IDc4ODQ1MzAuLmY1YjI4Y2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luQ0UuY21ha2UKKysrIGIvU291cmNlL2Nt YWtlL09wdGlvbnNXaW5DRS5jbWFrZQpAQCAtMTAsNyArMTAsMTEgQEAgQUREX0RFRklOSVRJT05T KC1EVVNFX1NZU1RFTV9NQUxMT0M9MSkKIEFERF9ERUZJTklUSU9OUygtREpTQ0NPTExFQ1RPUl9W SVJUVUFMTUVNX1JFU0VSVkFUSU9OPTB4MjAwMDAwKQogCiBJRiAoTk9UIDNSRFBBUlRZX0RJUikK LSAgICBNRVNTQUdFKEZBVEFMX0VSUk9SICJZb3UgbXVzdCBwcm92aWRlIGEgM3JkIHBhcnR5IGRp cmVjdG9yeSBmb3IgV2luQ0UgcG9ydC4iKQorICAgIElGIChFWElTVFMgJEVOVntXRUJLSVRUSFJJ RFBBUlRZRElSfSkKKyAgICAgICAgU0VUKDNSRFBBUlRZX0RJUiAkRU5We1dFQktJVFRIUklEUEFS VFlESVJ9KQorICAgIEVMU0UgKCkKKyAgICAgICAgTUVTU0FHRShGQVRBTF9FUlJPUiAiWW91IG11 c3QgcHJvdmlkZSBhIHRoaXJkIHBhcnR5IGRpcmVjdG9yeSBmb3IgV2luQ0UgcG9ydC4iKQorICAg IEVORElGICgpCiBFTkRJRiAoKQogCiBJTkNMVURFX0RJUkVDVE9SSUVTKCR7M1JEUEFSVFlfRElS fS9jZS1jb21wYXQpCg==