51632 2010-12-26 23:37:27 -0800 Pass style for <area> instead of associated <img> when querying whether the theme draws the focus ring for an <area> 2010-12-31 16:37:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dbates dbates eric hyatt tonikitoo oldest_to_newest 326986 0 dbates 2010-12-26 23:37:27 -0800 We should pass the style of the focused <area> to RenderTheme::supportsFocusRing() to determine whether theme is responsible for painting focus rings for <area>s. Currently, we pass the style of the <img> associated with the focused <area>. 326987 1 77481 dbates 2010-12-26 23:39:31 -0800 Created attachment 77481 Patch It's not possible to test this at this time since there are no themes that override focus ring drawing for <area>s. 327360 2 77481 eric 2010-12-28 14:03:45 -0800 Comment on attachment 77481 Patch If its not posible to test this, why make the change? 327924 3 tonikitoo 2010-12-30 07:34:01 -0800 +2010-12-26 Daniel Bates <dbates@rim.com@rim.com> Dan, please fix your email before landing. 327940 4 dbates 2010-12-30 09:15:41 -0800 (In reply to comment #2) > (From update of attachment 77481 [details]) > If its not posible to test this, why make the change? I spoke with Eric Seidel on IRC on 12/28/10 about this: [3:22pm] dydz: eseidel: hi. With regards to <https://bugs.webkit.org/show_bug.cgi?id=51632> I thought to make this change for correctness [3:23pm] dydz: Although, you're right the move does not have any impact at this time [3:23pm] dydz: Maybe it is sufficient to just keep the bug around to remember to move this should someone what to detect <area>s [3:24pm] dydz: *want to detect <area>s and do custom focus ring drawing [3:25pm] dydz: Notice, <img>s do not have a concept of a focus ring since they are not focusable. It is the <area> element this is focusable. [3:28pm] dydz: eseidel: That being said, would you suggest we don't make this change at this time? [3:29pm] eseidel: dydz: I'm just not sure what it's doing or why [3:31pm] dydz: eseidel: It's a semantic change based on the idea that when drawing a focus ring for an image map we are really drawing a focus ring for an <area> not an <img> (see <http://www.w3.org/TR/html5/the-map-element.html#the-area-element>) [3:32pm] eseidel: dydz: ok. so I would just leave it up for review and forget about ti. eventually hyatt or someone will look 327941 5 dbates 2010-12-30 09:16:04 -0800 (In reply to comment #3) > +2010-12-26 Daniel Bates <dbates@rim.com@rim.com> > > Dan, please fix your email before landing. Thanks for pointing this out. Will fix before landing. 328230 6 dbates 2010-12-31 16:37:08 -0800 Committed r74839: <http://trac.webkit.org/changeset/74839> 77481 2010-12-26 23:39:31 -0800 2010-12-29 17:16:59 -0800 Patch Bug51632.patch text/plain 2604 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDY3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTItMjYgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29t QHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUGFzcyBzdHlsZSBmb3IgPGFyZWE+IGluc3RlYWQgb2YgYXNzb2NpYXRlZCA8aW1nPiB3aGVu IHF1ZXJ5aW5nIHdoZXRoZXIKKyAgICAgICAgdGhlIHRoZW1lIGRyYXdzIHRoZSBmb2N1cyByaW5n IGZvciBhbiA8YXJlYT4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxNjMyCisKKyAgICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgdGhlIHN0eWxlIGZv ciB0aGUgYXNzb2NpYXRlZCA8aW1nPiBvZiBhbiA8YXJlYT4KKyAgICAgICAgd2FzIHBhc3NlZCB3 aGVuIGNvbnNpZGVyaW5nIHdoZXRoZXIgdGhlIHRoZW1lIHNob3VsZCBkcmF3IGEgZm9jdXMgcmlu ZworICAgICAgICBmb3IgdGhlIDxhcmVhPi4gSW5zdGVhZCwgd2Ugc2hvdWxkIHBhc3MgdGhlIHRo ZW1lIHRoZSBzdHlsZSBmb3IgdGhlIDxhcmVhPi4KKworICAgICAgICBJdCdzIG5vdCBwb3NzaWJs ZSB0byB0ZXN0IHRoaXMgYXQgdGhpcyB0aW1lIHNpbmNlIHRoZXJlIGFyZSBubyB0aGVtZXMKKyAg ICAgICAgdGhhdCBvdmVycmlkZSBmb2N1cyByaW5nIGRyYXdpbmcgZm9yIDxhcmVhPnMuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVySW1hZ2U6OnBhaW50Rm9jdXNSaW5nKTogTW92ZWQgY2FsbCB0byBSZW5kZXJUaGVtZTo6c3Vw cG9ydHNGb2N1c1JpbmcoKQorICAgICAgICBzdWNoIHRoYXQgaXQncyBjYWxsZWQgd2l0aCByZXNw ZWN0IHRvIHRoZSBmb2N1c2VkIDxhcmVhPi4KKwogMjAxMC0xMi0yNiAgTU9SSVRBIEhhamltZSAg PG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWlu LgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcAkocmV2aXNpb24gNzQ2NzgpCisrKyBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyNSw3 ICszMjUsNyBAQCB2b2lkIFJlbmRlckltYWdlOjpwYWludChQYWludEluZm8mIHBhaW50CiAgICAg ICAgIHBhaW50Rm9jdXNSaW5nKHBhaW50SW5mbywgc3R5bGUoKSk7CiB9CiAgICAgCi12b2lkIFJl bmRlckltYWdlOjpwYWludEZvY3VzUmluZyhQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgUmVu ZGVyU3R5bGUqIHN0eWxlKQordm9pZCBSZW5kZXJJbWFnZTo6cGFpbnRGb2N1c1JpbmcoUGFpbnRJ bmZvJiBwYWludEluZm8sIGNvbnN0IFJlbmRlclN0eWxlKikKIHsKICAgICAvLyBEb24ndCBkcmF3 IGZvY3VzIHJpbmdzIGlmIHByaW50aW5nLgogICAgIGlmIChkb2N1bWVudCgpLT5wcmludGluZygp IHx8ICFmcmFtZSgpLT5zZWxlY3Rpb24oKS0+aXNGb2N1c2VkQW5kQWN0aXZlKCkpCkBAIC0zNDgs OSArMzQ4LDYgQEAgdm9pZCBSZW5kZXJJbWFnZTo6cGFpbnRGb2N1c1JpbmcoUGFpbnRJbgogICAg IAogICAgIFJlZlB0cjxIVE1MQ29sbGVjdGlvbj4gYXJlYXMgPSBtYXBFbGVtZW50LT5hcmVhcygp OwogICAgIHVuc2lnbmVkIG51bUFyZWFzID0gYXJlYXMtPmxlbmd0aCgpOwotCi0gICAgaWYgKHRo ZW1lKCktPnN1cHBvcnRzRm9jdXNSaW5nKHN0eWxlKSkKLSAgICAgICAgcmV0dXJuOyAvLyBUaGUg dGhlbWUgZHJhd3MgdGhlIGZvY3VzIHJpbmcuCiAgICAgCiAgICAgLy8gRklYTUU6IENsaXAgdGhl IHBhdGhzIHRvIHRoZSBpbWFnZSBib3VuZGluZyBib3guCiAgICAgZm9yICh1bnNpZ25lZCBrID0g MDsgayA8IG51bUFyZWFzOyArK2spIHsKQEAgLTM1OSw2ICszNTYsOCBAQCB2b2lkIFJlbmRlcklt YWdlOjpwYWludEZvY3VzUmluZyhQYWludEluCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAg ICAgICBSZW5kZXJTdHlsZSogc3R5bGVUb1VzZSA9IGFyZWFFbGVtZW50LT5jb21wdXRlZFN0eWxl KCk7CisgICAgICAgIGlmICh0aGVtZSgpLT5zdXBwb3J0c0ZvY3VzUmluZyhzdHlsZVRvVXNlKSkK KyAgICAgICAgICAgIHJldHVybjsgLy8gVGhlIHRoZW1lIGRyYXdzIHRoZSBmb2N1cyByaW5nLgog ICAgICAgICBwYWludEluZm8uY29udGV4dC0+ZHJhd0ZvY3VzUmluZyhhcmVhRWxlbWVudC0+Z2V0 UGF0aCh0aGlzKSwgc3R5bGVUb1VzZS0+b3V0bGluZVdpZHRoKCksIHN0eWxlVG9Vc2UtPm91dGxp bmVPZmZzZXQoKSwgc3R5bGVUb1VzZS0+dmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5 T3V0bGluZUNvbG9yKSk7CiAgICAgICAgIGJyZWFrOwogICAgIH0K