51627 2010-12-26 18:39:36 -0800 [Qt] Support for CSS color and background-color properties on select element's dropdown list 2011-03-27 23:35:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ext-xianlin.han kling benjamin kling laszlo.gombos oldest_to_newest 326947 0 ext-xianlin.han 2010-12-26 18:39:36 -0800 Webkit Qt Need support for css color and background-color properties on select element's dropdown list。 See Bug 9846. The same appearance, but I tried under Google Chrome, this bug do not reappear. So I think Bug 9846 may fixed. But Webkit Qt still have this problem. 326949 1 77471 ext-xianlin.han 2010-12-26 19:00:24 -0800 Created attachment 77471 test html file Add the test html file 334415 2 benjamin 2011-01-14 10:54:12 -0800 Please follow this to report bugs on QtWebKit: http://trac.webkit.org/wiki/QtWebKitBugs Because you did not use the template, we did not have this bug in our list. Good catch otherwise. Thanks for attaching a test case as well. 374141 3 87071 kling 2011-03-27 08:35:20 -0700 Created attachment 87071 Proposed patch 374193 4 87071 kenneth 2011-03-27 12:07:44 -0700 Comment on attachment 87071 Proposed patch Looks ok, though I wonder how useful it is supporting this 374195 5 87071 kling 2011-03-27 12:12:26 -0700 Comment on attachment 87071 Proposed patch Clearing flags on attachment: 87071 Committed r82075: <http://trac.webkit.org/changeset/82075> 374196 6 kling 2011-03-27 12:12:33 -0700 All reviewed patches have been landed. Closing bug. 374294 7 laszlo.gombos 2011-03-27 23:35:45 -0700 I think together with this change we need to increment the version in qwebkitplatformplugin.h (to 1.8). 77471 2010-12-26 19:00:24 -0800 2010-12-26 19:00:24 -0800 test html file bg_color_on_select.html text/html 327 ext-xianlin.han PGh0bWw+CjxoZWFkPgo8dGl0bGU+CmJhY2tncm91bmQtY29sb3IgZmFpbHMgb24gc2VsZWN0IHBv cHVwCjwvdGl0bGU+CjwvaGVhZD4KPGJvZHk+Cgo8c2VsZWN0IHN0eWxlPSJiYWNrZ3JvdW5kLWNv bG9yOiByZ2IoMjA0LCAwLCAwKTsgY29sb3I6IHJnYigyNTUsIDI1NSwgMjU1KTsiID4KPG9wdGlv bj4yMDA2PC9vcHRpb24+CjxvcHRpb24+MjAwNzwvb3B0aW9uPgo8b3B0aW9uPjIwMDg8L29wdGlv bj4KPG9wdGlvbj4yMDA5PC9vcHRpb24+CjxvcHRpb24+MjAxMDwvb3B0aW9uPgo8b3B0aW9uPjIw MTE8L29wdGlvbj4KPC9zZWxlY3Q+CgoKCgoKPC9ib2R5Pgo8L2h0bWw+ 87071 2011-03-27 08:35:20 -0700 2011-03-27 12:12:26 -0700 Proposed patch bug-51627.diff text/plain 4416 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5o IGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmgKaW5kZXggMmE5 NGUwYy4uZjI3NGEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmtpdHBs YXRmb3JtcGx1Z2luLmgKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmtpdHBsYXRmb3Jt cGx1Z2luLmgKQEAgLTI2LDYgKzI2LDcgQEAKICAqICBhbmQgbWF5IGJlIGNoYW5nZWQgZnJvbSB2 ZXJzaW9uIHRvIHZlcnNpb24gb3IgZXZlbiBiZSBjb21wbGV0ZWx5IHJlbW92ZWQuCiAqLwogCisj aW5jbHVkZSA8UUNvbG9yPgogI2luY2x1ZGUgPFFPYmplY3Q+CiAjaW5jbHVkZSA8UVVybD4KICNp ZiBkZWZpbmVkKEVOQUJMRV9RVF9NVUxUSU1FRElBKSAmJiBFTkFCTEVfUVRfTVVMVElNRURJQQpA QCAtNDYsNiArNDcsMTAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBpdGVtSXNTZWxlY3Rl ZChpbnQgaW5kZXgpIGNvbnN0ID0gMDsKICAgICB2aXJ0dWFsIGludCBpdGVtQ291bnQoKSBjb25z dCA9IDA7CiAgICAgdmlydHVhbCBib29sIG11bHRpcGxlKCkgY29uc3QgPSAwOworICAgIHZpcnR1 YWwgUUNvbG9yIGJhY2tncm91bmRDb2xvcigpIGNvbnN0ID0gMDsKKyAgICB2aXJ0dWFsIFFDb2xv ciBmb3JlZ3JvdW5kQ29sb3IoKSBjb25zdCA9IDA7CisgICAgdmlydHVhbCBRQ29sb3IgaXRlbUJh Y2tncm91bmRDb2xvcihpbnQgaW5kZXgpIGNvbnN0ID0gMDsKKyAgICB2aXJ0dWFsIFFDb2xvciBp dGVtRm9yZWdyb3VuZENvbG9yKGludCBpbmRleCkgY29uc3QgPSAwOwogfTsKIAogY2xhc3MgUVdl YlNlbGVjdE1ldGhvZCA6IHB1YmxpYyBRT2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDkwZTliZTUu LjM1MmNmM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDMtMjcgIEFu ZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gU3VwcG9ydCBmb3IgQ1NTIGNvbG9yIGFuZCBi YWNrZ3JvdW5kLWNvbG9yIHByb3BlcnRpZXMgb24gc2VsZWN0IGVsZW1lbnQncyBkcm9wZG93biBs aXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTYy NworCisgICAgICAgIEV4dGVuZCB0aGUgUVdlYlNlbGVjdERhdGEgaW50ZXJmYWNlIHdpdGggYmFj a2dyb3VuZCBhbmQgZm9yZWdyb3VuZCBjb2xvcnMKKyAgICAgICAgZm9yIHRoZSB3aG9sZSBtZW51 LCBhcyB3ZWxsIGFzIHBlci1pdGVtLiBIb29rIGl0IHVwIHRvIHRoZSBQb3B1cE1lbnVTdHlsZQor ICAgICAgICBnZXR0ZXJzIGluIFJlbmRlck1lbnVMaXN0LgorCisgICAgICAgICogQXBpL3F3ZWJr aXRwbGF0Zm9ybXBsdWdpbi5oOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1BvcHVwTWVudVF0 LmNwcDoKKyAgICAgICAgKFNlbGVjdERhdGE6OmJhY2tncm91bmRDb2xvcik6CisgICAgICAgIChT ZWxlY3REYXRhOjpmb3JlZ3JvdW5kQ29sb3IpOgorICAgICAgICAoU2VsZWN0RGF0YTo6aXRlbUJh Y2tncm91bmRDb2xvcik6CisgICAgICAgIChTZWxlY3REYXRhOjppdGVtRm9yZWdyb3VuZENvbG9y KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KToKKyAgICAgICAgKFdlYkNv cmU6OlF0RmFsbGJhY2tXZWJQb3B1cDo6cG9wdWxhdGUpOgorCiAyMDExLTAzLTI3ICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvUG9wdXBNZW51UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9Qb3B1cE1lbnVRdC5jcHAKaW5kZXggYjhlNDVhZi4uYjY2MmY1YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Qb3B1cE1lbnVRdC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Qb3B1cE1lbnVRdC5jcHAKQEAgLTQ0LDYgKzQ0LDEw IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGludCBpdGVtQ291bnQoKSBjb25zdCB7IHJldHVybiBk ID8gZC0+bGlzdFNpemUoKSA6IDA7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXRlbUlzU2VsZWN0ZWQo aW50IGlkeCkgY29uc3QgeyByZXR1cm4gZCA/IGQtPml0ZW1Jc1NlbGVjdGVkKGlkeCkgOiBmYWxz ZTsgfQogICAgIHZpcnR1YWwgYm9vbCBtdWx0aXBsZSgpIGNvbnN0OworICAgIHZpcnR1YWwgUUNv bG9yIGJhY2tncm91bmRDb2xvcigpIGNvbnN0IHsgcmV0dXJuIGQgPyBRQ29sb3IoZC0+bWVudVN0 eWxlKCkuYmFja2dyb3VuZENvbG9yKCkpIDogUUNvbG9yKCk7IH0KKyAgICB2aXJ0dWFsIFFDb2xv ciBmb3JlZ3JvdW5kQ29sb3IoKSBjb25zdCB7IHJldHVybiBkID8gUUNvbG9yKGQtPm1lbnVTdHls ZSgpLmZvcmVncm91bmRDb2xvcigpKSA6IFFDb2xvcigpOyB9CisgICAgdmlydHVhbCBRQ29sb3Ig aXRlbUJhY2tncm91bmRDb2xvcihpbnQgaWR4KSBjb25zdCB7IHJldHVybiBkID8gUUNvbG9yKGQt Pml0ZW1TdHlsZShpZHgpLmJhY2tncm91bmRDb2xvcigpKSA6IFFDb2xvcigpOyB9CisgICAgdmly dHVhbCBRQ29sb3IgaXRlbUZvcmVncm91bmRDb2xvcihpbnQgaWR4KSBjb25zdCB7IHJldHVybiBk ID8gUUNvbG9yKGQtPml0ZW1TdHlsZShpZHgpLmZvcmVncm91bmRDb2xvcigpKSA6IFFDb2xvcigp OyB9CiAKIHByaXZhdGU6CiAgICAgV2ViQ29yZTo6UG9wdXBNZW51Q2xpZW50KiYgZDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUXRGYWxsYmFja1dlYlBvcHVw LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUXRGYWxsYmFja1dlYlBvcHVw LmNwcAppbmRleCBhZmE2NDkyLi41ZTY0MWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L1F0RmFsbGJhY2tXZWJQb3B1cC5jcHAKKysrIGIvU291cmNlL1dlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuY3BwCkBAIC0xMjQsNiArMTI0 LDE3IEBAIHZvaWQgUXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KGNvbnN0IFFXZWJTZWxlY3REYXRh JiBkYXRhKQogCiAgICAgcG9wdWxhdGUoZGF0YSk7CiAKKyAgICBRQ29sb3IgYmFja2dyb3VuZENv bG9yID0gZGF0YS5iYWNrZ3JvdW5kQ29sb3IoKTsKKyAgICBRQ29sb3IgZm9yZWdyb3VuZENvbG9y ID0gZGF0YS5mb3JlZ3JvdW5kQ29sb3IoKTsKKworICAgIFFQYWxldHRlIHBhbGV0dGUgPSBtX2Nv bWJvLT5wYWxldHRlKCk7CisgICAgaWYgKGJhY2tncm91bmRDb2xvci5pc1ZhbGlkKCkpCisgICAg ICAgIHBhbGV0dGUuc2V0Q29sb3IoUVBhbGV0dGU6OkJhY2tncm91bmQsIGJhY2tncm91bmRDb2xv cik7CisgICAgaWYgKGZvcmVncm91bmRDb2xvci5pc1ZhbGlkKCkpCisgICAgICAgIHBhbGV0dGUu c2V0Q29sb3IoUVBhbGV0dGU6OkZvcmVncm91bmQsIGZvcmVncm91bmRDb2xvcik7CisgICAgbV9j b21iby0+c2V0UGFsZXR0ZShwYWxldHRlKTsKKworCiAgICAgUVJlY3QgcmVjdCA9IGdlb21ldHJ5 KCk7CiAgICAgaWYgKFFHcmFwaGljc1dlYlZpZXcgKndlYlZpZXcgPSBxb2JqZWN0X2Nhc3Q8UUdy YXBoaWNzV2ViVmlldyo+KHBhZ2VDbGllbnQoKS0+cGx1Z2luUGFyZW50KCkpKSB7CiAgICAgICAg IFFHcmFwaGljc1Byb3h5V2lkZ2V0KiBwcm94eSA9IG5ldyBRR3JhcGhpY3NQcm94eVdpZGdldCh3 ZWJWaWV3KTsKQEAgLTIzNSw2ICsyNDYsOCBAQCB2b2lkIFF0RmFsbGJhY2tXZWJQb3B1cDo6cG9w dWxhdGUoY29uc3QgUVdlYlNlbGVjdERhdGEmIGRhdGEpCiAjaWZuZGVmIFFUX05PX1RPT0xUSVAK ICAgICAgICAgICAgIG1vZGVsLT5pdGVtKGkpLT5zZXRUb29sVGlwKGRhdGEuaXRlbVRvb2xUaXAo aSkpOwogI2VuZGlmCisgICAgICAgICAgICBtb2RlbC0+aXRlbShpKS0+c2V0QmFja2dyb3VuZChk YXRhLml0ZW1CYWNrZ3JvdW5kQ29sb3IoaSkpOworICAgICAgICAgICAgbW9kZWwtPml0ZW0oaSkt PnNldEZvcmVncm91bmQoZGF0YS5pdGVtRm9yZWdyb3VuZENvbG9yKGkpKTsKICAgICAgICAgICAg IGlmIChkYXRhLml0ZW1Jc1NlbGVjdGVkKGkpKQogICAgICAgICAgICAgICAgIGN1cnJlbnRJbmRl eCA9IGk7CiAgICAgICAgICAgICBicmVhazsK