51625 2010-12-26 15:16:00 -0800 [GTK] Add support for build-jsc 2010-12-27 11:08:12 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned dbates eric xan.lopez oldest_to_newest 326929 0 mrobinson 2010-12-26 15:16:00 -0800 Building jsc as a standalone target is now simple as of https://bugs.webkit.org/show_bug.cgi?id=51607, so it makes sense that build-jsc should work for the GTK+ port. 326930 1 77464 mrobinson 2010-12-26 15:24:33 -0800 Created attachment 77464 Add build-jsc support 326955 2 77464 dbates 2010-12-26 20:30:18 -0800 Comment on attachment 77464 Add build-jsc support View in context: https://bugs.webkit.org/attachment.cgi?id=77464&action=review > Tools/Scripts/build-jsc:71 > + $result = buildGtkProject("JavaScriptCore", "", ""); We should remove the the "($@)" from the function name buildAutotoolsProject($@) and then we don't need to pass the empty string for the second and third argument. 327083 3 mrobinson 2010-12-27 11:08:12 -0800 Committed r74689: <http://trac.webkit.org/changeset/74689> 77464 2010-12-26 15:24:33 -0800 2010-12-26 20:30:18 -0800 Add build-jsc support bug-51625-20101226152435.patch text/plain 3939 mrobinson ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODlm MmM0MGE2YWIzMGJlNjBkYTBkODYyZTk2MjlkNzFjYWNkYzc0Li42MGQ4NDRkZTVlMmNkOTkyYjlj OWU3NjVlNDI5YjlmYTBjM2M4ODhkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMjYgIE1hcnRpbiBSb2Jp bnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBidWlsZC1qc2MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjI1CisKKyAg ICAgICAgQWRkIEdUSysgc3VwcG9ydCB0byBidWlsZC1qc2Mgbm93IHRoYXQgYnVpbGRpbmcgdGhl IGpzYyBleGVjdXRhYmxlIGFzCisgICAgICAgIGEgc3RhbmRhbG9uZSB0YXJnZXQgaXMgZWFzeS4K KworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOiBDYWxsIGJ1aWxkR3RrUHJvamVjdCBmb3Ig dGhlIEdUSysgY2FzZSBub3cuCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6IFBhc3Mg aW4gdGhlIHByb3BlciB0YXJnZXQgbmFtZSB0byBidWlsZEd0a1Byb2plY3QuCisgICAgICAgICog U2NyaXB0cy93ZWJraXRkaXJzLnBtOiBBY3R1YWxseSBwcm9jZXNzIHRoZSBwcm9qZWN0IHBhcmFt ZXRlciBpbiBidWlsZEd0a1Byb2plY3QKKyAgICAgICAgYW5kIHBhc3MgaXQgYWxvbmcgdG8gYnVp bGRBdXRvdG9vbHNQcm9qZWN0LgorCiAyMDEwLTEyLTI2ICBEYXZpZCBMZXZpbiAgPGxldmluQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKaW5k ZXggMDMxNjM0OTZkYzU4NTJjZjRkN2U5NTM3NTM2MzE1MzYwODRmYWE5Yy4uOGEwM2FiZTZiOTFj NWJmNDEwNmE5MDIxNTQ2MmE5MWE2MGNlMzIxYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9i dWlsZC1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKQEAgLTY3LDggKzY3LDEwIEBA IGlmIChpc0FwcGxlTWFjV2ViS2l0KCkpIHsKICAgICAkcmVzdWx0ID0gc3lzdGVtICJzaCIsICIt YyIsICd4Y29kZWJ1aWxkIC1wcm9qZWN0IEphdmFTY3JpcHRDb3JlLnhjb2RlcHJvaiAiJEAiIHwg Z3JlcCAtdiBzZXRlbnYgJiYgZXhpdCAke1BJUEVTVEFUVVNbMF19JywgInhjb2RlYnVpbGQiLCAg QG9wdGlvbnMsIEBBUkdWLCBAY292ZXJhZ2VTdXBwb3J0T3B0aW9uczsKIH0gZWxzaWYgKGlzQXBw bGVXaW5XZWJLaXQoKSkgewogICAgICRyZXN1bHQgPSBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3Qo IkphdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS5zbG4iKTsKLX0gZWxzaWYgKGlz UXQoKSBvciBpc0d0aygpIG9yIGlzV3goKSkgewotICAgICMgUXQgYW5kIEd0ayBidWlsZCBldmVy eXRoaW5nIGluIG9uZS1zaG90LiBObyBuZWVkIHRvIGJ1aWxkIGFueXRoaW5nIGhlcmUuCit9IGVs c2lmIChpc0d0aygpKSB7CisgICAgJHJlc3VsdCA9IGJ1aWxkR3RrUHJvamVjdCgiSmF2YVNjcmlw dENvcmUiLCAiIiwgIiIpOworfSBlbHNpZiAoaXNRdCgpIG9yIGlzV3goKSkgeworICAgICMgUXQg YnVpbGRzIGV2ZXJ5dGhpbmcgaW4gb25lLXNob3QuIE5vIG5lZWQgdG8gYnVpbGQgYW55dGhpbmcg aGVyZS4KICAgICAkcmVzdWx0ID0gMDsKIH0gZWxzZSB7CiAgICAgZGllICJCdWlsZGluZyBub3Qg ZGVmaW5lZCBmb3IgdGhpcyBwbGF0Zm9ybSFcbiI7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDg1MGRhMzQ3 NTg5ZWFkYzJiZTgzNmY2YTgyMjBiZGFiNTIxMzFkZDUuLjM3ZmJkMzFmODI3ZTZmZDNhNWNjNjE4 NjNjM2UwMGE0NmNhNDQyZmUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0 CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC01MTcsOCArNTE3LDcgQEAgZm9y IG15ICRkaXIgKEBwcm9qZWN0cykgewogCiAgICAgbXkgJHByb2plY3QgPSBiYXNlbmFtZSgkZGly KTsKICAgICBpZiAoaXNHdGsoKSkgewotICAgICAgICAjRklYTUU6ICRkaXIgc2hvdWxkIHByb2Jh Ymx5IGJlICRwcm9qZWN0LgotICAgICAgICAkcmVzdWx0ID0gYnVpbGRHdGtQcm9qZWN0KCRkaXIs ICRjbGVhbiwgIEBvcHRpb25zKTsKKyAgICAgICAgJHJlc3VsdCA9IGJ1aWxkR3RrUHJvamVjdCgk cHJvamVjdCwgJGNsZWFuLCAgQG9wdGlvbnMpOwogICAgIH0gZWxzaWYgKGlzUXQoKSkgewogICAg ICAgICAjRklYTUU6ICRkaXIgc2hvdWxkIHByb2JhYmx5IGJlICRwcm9qZWN0LgogICAgICAgICAk cmVzdWx0ID0gYnVpbGRRTWFrZVF0UHJvamVjdCgkZGlyLCAkY2xlYW4sIEBvcHRpb25zKTsKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQppbmRleCBhYzQwZWM2ZWI5NjljOWRiNjEyY2FlZGNkYzJiMWZmN2RkNDFiMzk0 Li40ZTUwNmQ2MGViOTVkNmE2NGNiYzdmNzJlMTJjYTI3NzUyMzQwYjZhIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCkBAIC0xMzM3LDcgKzEzMzcsNyBAQCBzdWIgYXV0b2dlbkFyZ3VtZW50c0hhdmVDaGFuZ2Vk KCRAKQogCiBzdWIgYnVpbGRBdXRvdG9vbHNQcm9qZWN0KCRAKQogewotICAgIG15ICgkY2xlYW4s IEBidWlsZFBhcmFtcykgPSBAXzsKKyAgICBteSAoJHByb2plY3QsICRjbGVhbiwgQGJ1aWxkUGFy YW1zKSA9IEBfOwogCiAgICAgbXkgJG1ha2UgPSAnbWFrZSc7CiAgICAgbXkgJGRpciA9IHByb2R1 Y3REaXIoKTsKQEAgLTEzNjMsNiArMTM2MywxMSBAQCBzdWIgYnVpbGRBdXRvdG9vbHNQcm9qZWN0 KCRAKQogICAgICAgICAkbWFrZUFyZ3MgPSAiLWoiIC4gbnVtYmVyT2ZDUFVzKCk7CiAgICAgfQog CisgICAgIyBXZWJLaXQgaXMgdGhlIGRlZmF1bHQgdGFyZ2V0LCBzbyB3ZSBkb24ndCBuZWVkIHRv IHNwZWNpZnkgYW55dGhpbmcuCisgICAgaWYgKCRwcm9qZWN0IGVxICJKYXZhU2NyaXB0Q29yZSIp IHsKKyAgICAgICAgJG1ha2VBcmdzIC49ICIganNjIjsKKyAgICB9CisKICAgICAkcHJlZml4ID0g JEVOVnsiV2ViS2l0SW5zdGFsbGF0aW9uUHJlZml4In0gaWYgIWRlZmluZWQoJHByZWZpeCk7CiAg ICAgcHVzaCBAYnVpbGRBcmdzLCAiLS1wcmVmaXg9IiAuICRwcmVmaXggaWYgZGVmaW5lZCgkcHJl Zml4KTsKIApAQCAtMTYyNiwxMSArMTYzMSwxMSBAQCBzdWIgYnVpbGRHdGtQcm9qZWN0KCQkQCkK IHsKICAgICBteSAoJHByb2plY3QsICRjbGVhbiwgQGJ1aWxkQXJncykgPSBAXzsKIAotICAgIGlm ICgkcHJvamVjdCBuZSAiV2ViS2l0IikgewotICAgICAgICBkaWUgIlRoZSBHdGsgcG9ydCBidWls ZHMgSmF2YVNjcmlwdENvcmUsIFdlYkNvcmUgYW5kIFdlYktpdCBpbiBvbmUgc2hvdCEgT25seSBj YWxsIGl0IGZvciAnV2ViS2l0Jy5cbiI7CisgICAgaWYgKCRwcm9qZWN0IG5lICJXZWJLaXQiIGFu ZCAkcHJvamVjdCBuZSAiSmF2YVNjcmlwdENvcmUiKSB7CisgICAgICAgIGRpZSAiVW5zdXBwb3J0 ZWQgcHJvamVjdDogJHByb2plY3QuIFN1cHBvcnRlZCBwcm9qZWN0czogV2ViS2l0LCBKYXZhU2Ny aXB0Q29yZVxuIjsKICAgICB9CiAKLSAgICByZXR1cm4gYnVpbGRBdXRvdG9vbHNQcm9qZWN0KCRj bGVhbiwgQGJ1aWxkQXJncyk7CisgICAgcmV0dXJuIGJ1aWxkQXV0b3Rvb2xzUHJvamVjdCgkcHJv amVjdCwgJGNsZWFuLCBAYnVpbGRBcmdzKTsKIH0KIAogc3ViIGJ1aWxkQ2hyb21pdW1NYWtlZmls ZSgkJCkK