51623 2010-12-26 13:14:57 -0800 REGRESSION (r73337): Incorrect text match count when a match occurs in a text field 2011-01-02 21:34:26 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz abarth eric webkit.review.bot oldest_to_newest 326907 0 mitz 2010-12-26 13:14:57 -0800 REGRESSION (r73337): Incorrect text match count when a match occurs in a text field 326914 1 77462 mitz 2010-12-26 13:29:13 -0800 Created attachment 77462 Patch 326917 2 77462 eric 2010-12-26 13:31:26 -0800 Comment on attachment 77462 Patch How do we test this? 326939 3 mitz 2010-12-26 16:56:39 -0800 <rdar://problem/8806570> 326942 4 77462 sam 2010-12-26 17:20:58 -0800 Comment on attachment 77462 Patch Can we test this? 328475 5 mitz 2011-01-02 20:46:54 -0800 Fixed and added a manual test in <http://trac.webkit.org/changeset/74886>. 328478 6 webkit.review.bot 2011-01-02 21:34:26 -0800 http://trac.webkit.org/changeset/74886 might have broken Leopard Intel Debug (Tests) 77462 2010-12-26 13:29:13 -0800 2010-12-26 17:20:58 -0800 Patch bug-51623-20101226132912.patch text/plain 2230 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDY3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMjYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyNzMzMzcpOiBJbmNvcnJlY3QgdGV4dCBtYXRjaCBjb3VudCB3aGVuIGEgbWF0Y2gg b2NjdXJzIGluIGEgdGV4dCBmaWVsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTE2MjMKKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dCk6IEFjdHVhbGx5IHJl bWVtYmVyIHRoZSBvcmlnaW5hbCBzZWFyY2ggcmFuZ2UgZW5kCisgICAgICAgIGNvbnRhaW5lciBh bmQgb2Zmc2V0IGFuZCByZXN0b3JlIHRoZW0gd2hlbiBuZWVkZWQsIGluc3RlYWQgb2YgdXNpbmcg dHdvIHJlZmVyZW5jZXMgdG8gdGhlCisgICAgICAgIHNhbWUgUmFuZ2UuCisKIDIwMTAtMTItMjYg IEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkocmV2aXNpb24gNzQ2NTcpCisr KyBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM2MiwxNyAr MzM2MiwxOCBAQCB1bnNpZ25lZCBFZGl0b3I6OmNvdW50TWF0Y2hlc0ZvclRleHQoY29uCiAgICAg aWYgKHRhcmdldC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgUmVmUHRyPFJh bmdlPiBvcmlnaW5hbFNlYXJjaFJhbmdlOworICAgIFJlZlB0cjxSYW5nZT4gc2VhcmNoUmFuZ2U7 CiAgICAgaWYgKHJhbmdlKSB7CiAgICAgICAgIGlmIChyYW5nZS0+b3duZXJEb2N1bWVudCgpID09 IG1fZnJhbWUtPmRvY3VtZW50KCkpCi0gICAgICAgICAgICBvcmlnaW5hbFNlYXJjaFJhbmdlID0g cmFuZ2U7CisgICAgICAgICAgICBzZWFyY2hSYW5nZSA9IHJhbmdlOwogICAgICAgICBlbHNlIGlm ICghaXNGcmFtZUluUmFuZ2UobV9mcmFtZSwgcmFuZ2UpKQogICAgICAgICAgICAgcmV0dXJuIDA7 CiAgICAgfQotICAgIGlmICghb3JpZ2luYWxTZWFyY2hSYW5nZSkKLSAgICAgICAgb3JpZ2luYWxT ZWFyY2hSYW5nZSA9IHJhbmdlT2ZDb250ZW50cyhtX2ZyYW1lLT5kb2N1bWVudCgpKTsKKyAgICBp ZiAoIXNlYXJjaFJhbmdlKQorICAgICAgICBzZWFyY2hSYW5nZSA9IHJhbmdlT2ZDb250ZW50cyht X2ZyYW1lLT5kb2N1bWVudCgpKTsKIAotICAgIFJlZlB0cjxSYW5nZT4gc2VhcmNoUmFuZ2Uob3Jp Z2luYWxTZWFyY2hSYW5nZSk7CisgICAgTm9kZSogb3JpZ2luYWxFbmRDb250YWluZXIgPSBzZWFy Y2hSYW5nZS0+ZW5kQ29udGFpbmVyKCk7CisgICAgaW50IG9yaWdpbmFsRW5kT2Zmc2V0ID0gc2Vh cmNoUmFuZ2UtPmVuZE9mZnNldCgpOwogCiAgICAgRXhjZXB0aW9uQ29kZSBleGNlcHRpb24gPSAw OwogICAgIHVuc2lnbmVkIG1hdGNoQ291bnQgPSAwOwpAQCAtMzM4Miw4ICszMzgzLDggQEAgdW5z aWduZWQgRWRpdG9yOjpjb3VudE1hdGNoZXNGb3JUZXh0KGNvbgogICAgICAgICAgICAgaWYgKCFy ZXN1bHRSYW5nZS0+c3RhcnRDb250YWluZXIoKS0+aXNJblNoYWRvd1RyZWUoKSkKICAgICAgICAg ICAgICAgICBicmVhazsKIAotICAgICAgICAgICAgc2VhcmNoUmFuZ2UgPSBvcmlnaW5hbFNlYXJj aFJhbmdlOwogICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldFN0YXJ0QWZ0ZXIocmVzdWx0UmFu Z2UtPnN0YXJ0Q29udGFpbmVyKCktPnNoYWRvd0FuY2VzdG9yTm9kZSgpLCBleGNlcHRpb24pOwor ICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldEVuZChvcmlnaW5hbEVuZENvbnRhaW5lciwgb3Jp Z2luYWxFbmRPZmZzZXQsIGV4Y2VwdGlvbik7CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAg ICAgfQogCg==