51603 2010-12-24 17:04:48 -0800 REGRESSION (r74648): XHR layout test failures 2010-12-24 17:52:46 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED LayoutTestFailure, Regression P1 Normal --- 1 mitz webkit-unassigned ap beidson oldest_to_newest 326771 0 mitz 2010-12-24 17:04:48 -0800 After r74648, xmlhttprequest/logout.html is failing and xmlhttprequest/basic-auth-default.html is failing whe run interactively. 326775 1 77430 mitz 2010-12-24 17:21:35 -0800 Created attachment 77430 Revert the shouldUseCredentialStorage() change from r74648 326778 2 mitz 2010-12-24 17:30:05 -0800 I am going to resolve this by reverting r74648. 326779 3 77430 ap 2010-12-24 17:31:39 -0800 Comment on attachment 77430 Revert the shouldUseCredentialStorage() change from r74648 Hmm, does this also make connectionShouldUseCredentialStorage: return YES? If so, then the consequences are more profound than described in the ChangeLog. 326781 4 77431 mitz 2010-12-24 17:37:44 -0800 Created attachment 77431 Revert r74648 326786 5 mitz 2010-12-24 17:52:46 -0800 Fixed in <http://trac.webkit.org/changeset/74657>. 77430 2010-12-24 17:21:35 -0800 2010-12-24 17:31:39 -0800 Revert the shouldUseCredentialStorage() change from r74648 51603_r1.diff text/plain 1642 mitz SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDY1NikKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMjQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyNzQ2NDgpOiBYSFIgbGF5b3V0IHRlc3QgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjAzCisKKyAgICAgICAgUmV2ZXJ0 IHNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKCkgdG8gcmV0dXJuaW5nIHRydWUsIGxpa2UgZGlk IGJlZm9yZSByNzQ2NDguIEEgbW9yZSBhcHByb3ByaWF0ZQorICAgICAgICBkZXNjcmlwdGlvbiBm b3IgdGhlIGJ1ZyB0aGF0IHRoZSByZW1haW5pbmcgY2hhbmdlcyBmcm9tIHI3NDY0OCBhZGRyZXNz IHdvdWxkIGJlIOKAnFRoZSB3ZWIgcHJvY2VzcworICAgICAgICBpcyB1c2luZyB0aGUgTWFjIE9T IFgga2V5Y2hhaW4gZm9yIEhUVFAgYXV0aGVudGljYXRpb27igJ0uIFVzZSBvZiBDcmVkZW50aWFs U3RvcmFnZSBpbiB0aGUgd2ViCisgICAgICAgIHByb2Nlc3MgaXMgYSBzZXBhcmF0ZSBpc3N1ZS4K KworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGll bnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6c2hvdWxkVXNl Q3JlZGVudGlhbFN0b3JhZ2UpOiBDaGFuZ2VkIGJhY2sgdG8gcmV0dXJuIHRydWUuCisKIDIwMTAt MTItMjQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg Rml4IHRoZSBRdCBidWlsZCBhZnRlciByNzQ2NTAuCkluZGV4OiBXZWJLaXQyL1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAJ KHJldmlzaW9uIDc0NjU2KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYxLDcgKzE2MSw3IEBA IHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoV2lsbFMKIAogYm9vbCBXZWJGcmFt ZUxvYWRlckNsaWVudDo6c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UoRG9jdW1lbnRMb2FkZXIq LCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIpCiB7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIHJl dHVybiB0cnVlOwogfQogCiB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJl Y2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShEb2N1bWVudExvYWRlciosIHVuc2lnbmVkIGxv bmcsIGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiBjaGFsbGVuZ2UpCg== 77431 2010-12-24 17:37:44 -0800 2010-12-24 17:51:31 -0800 Revert r74648 51603_r2.diff text/plain 5430 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDY1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMjQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyNzQ2NDgpOiBYSFIgbGF5b3V0IHRlc3QgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNjAzCisKKyAgICAgICAgUmV2ZXJ0 ZWQgcjc0NjQ4LgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisKIDIwMTAtMTItMjQgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IHRoZSBR dCBidWlsZCBhZnRlciByNzQ2NDguCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUuZXhwLmluCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJldmlzaW9uIDc0NjU2KQorKysgV2Vi Q29yZS9XZWJDb3JlLmV4cC5pbgkod29ya2luZyBjb3B5KQpAQCAtNDM1LDcgKzQzNSw2IEBAIF9f Wk43V2ViQ29yZTE2ZW5jbG9zaW5nSW50UmVjdEVSSzdfTlNSZWMKIF9fWk43V2ViQ29yZTE2ZW5j bG9zaW5nSW50UmVjdEVSS05TXzlGbG9hdFJlY3RFCiBfX1pON1dlYkNvcmUxNmlzRW5kT2ZQYXJh Z3JhcGhFUktOU18xNVZpc2libGVQb3NpdGlvbkVOU18yN0VkaXRpbmdCb3VuZGFyeUNyb3NzaW5n UnVsZUUKIF9fWk43V2ViQ29yZTE2anNTdHJpbmdTbG93Q2FzZUVQTjNKU0M5RXhlY1N0YXRlRVJO UzBfOVdlYWtHQ01hcElQTjNXVEYxMFN0cmluZ0ltcGxFUE5TMF84SlNTdHJpbmdFRUVTNl8KLV9f Wk43V2ViQ29yZTE3Q3JlZGVudGlhbFN0b3JhZ2UyNGdldEZyb21QZXJzaXN0ZW50U3RvcmFnZUVS S05TXzE1UHJvdGVjdGlvblNwYWNlRQogX19aTjdXZWJDb3JlMTdDcmVkZW50aWFsU3RvcmFnZTNn ZXRFUktOU18xNVByb3RlY3Rpb25TcGFjZUUKIF9fWk43V2ViQ29yZTE3RE9NSW1wbGVtZW50YXRp b24xM2lzWE1MTUlNRVR5cGVFUktOM1dURjZTdHJpbmdFCiBfX1pON1dlYkNvcmUxN0RPTUltcGxl bWVudGF0aW9uMTRpc1RleHRNSU1FVHlwZUVSS04zV1RGNlN0cmluZ0UKQEAgLTkzNCwxMCArOTMz LDggQEAgX19aTjdXZWJDb3JlOXBsYWluVGV4dEVQS05TXzVSYW5nZUVOU18yMAogX19aTjdXZWJD b3JlOXRvRWxlbWVudEVOM0pTQzdKU1ZhbHVlRQogX19aTkszSlNDOEJpbmRpbmdzMTBSb290T2Jq ZWN0MTJnbG9iYWxPYmplY3RFdgogX19aTkszV1RGNlN0cmluZzE0Y3JlYXRlQ0ZTdHJpbmdFdgot X19aTks3V2ViQ29yZTEwQ3JlZGVudGlhbDExaGFzUGFzc3dvcmRFdgogX19aTks3V2ViQ29yZTEw Q3JlZGVudGlhbDExcGVyc2lzdGVuY2VFdgogX19aTks3V2ViQ29yZTEwQ3JlZGVudGlhbDR1c2Vy RXYKLV9fWk5LN1dlYkNvcmUxMENyZWRlbnRpYWw3aXNFbXB0eUV2CiBfX1pOSzdXZWJDb3JlMTBD cmVkZW50aWFsOHBhc3N3b3JkRXYKIF9fWk5LN1dlYkNvcmUxMEZsb2F0UG9pbnRjdjhfTlNQb2lu dEV2CiBfX1pOSzdXZWJDb3JlMTBQbHVnaW5EYXRhMTZzdXBwb3J0c01pbWVUeXBlRVJLTjNXVEY2 U3RyaW5nRQpJbmRleDogV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9D aGFuZ2VMb2cJKHJldmlzaW9uIDc0NjU2KQorKysgV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0yNCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJFR1JFU1NJT04gKHI3NDY0OCk6IFhIUiBsYXlvdXQgdGVzdCBmYWlsdXJlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE2MDMKKworICAgICAg ICBSZXZlcnRlZCByNzQ2NDguCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRSZWNlaXZlQXV0aGVudGljYXRp b25DaGFsbGVuZ2UpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVu dDo6c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UpOgorICAgICAgICAqIFdlYlByb2Nlc3MvbWFj L1dlYlByb2Nlc3NNYWluTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzTWFpbik6 CisKIDIwMTAtMTItMjQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IHRoZSBRdCBidWlsZCBhZnRlciByNzQ2NTAuCkluZGV4OiBXZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDc0NjU2KQorKysgV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNiBAQAogCiAjaW5j bHVkZSAiQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eS5oIgogI2luY2x1ZGUgIkF1dGhlbnRp Y2F0aW9uRGVjaXNpb25MaXN0ZW5lci5oIgotI2luY2x1ZGUgIkF1dGhlbnRpY2F0aW9uTWFuYWdl ck1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiRGF0YVJlZmVyZW5jZS5oIgogI2luY2x1ZGUgIkRyYXdp bmdBcmVhUHJveHkuaCIKICNpbmNsdWRlICJGaW5kSW5kaWNhdG9yLmgiCkBAIC02Miw3ICs2MSw2 IEBACiAjaW5jbHVkZSAiV2ViUHJvdGVjdGlvblNwYWNlLmgiCiAjaW5jbHVkZSAiV2ViU2VjdXJp dHlPcmlnaW4uaCIKICNpbmNsdWRlICJXZWJVUkxSZXF1ZXN0LmgiCi0jaW5jbHVkZSA8V2ViQ29y ZS9DcmVkZW50aWFsU3RvcmFnZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRmxvYXRSZWN0Lmg+CiAj aW5jbHVkZSA8V2ViQ29yZS9NSU1FVHlwZVJlZ2lzdHJ5Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9X aW5kb3dGZWF0dXJlcy5oPgpAQCAtMTk4NCwxNCArMTk4Miw2IEBAIHZvaWQgV2ViUGFnZVByb3h5 OjpkaWRSZWNlaXZlQXV0aGVudGljYXQKICAgICBXZWJGcmFtZVByb3h5KiBmcmFtZSA9IHByb2Nl c3MoKS0+d2ViRnJhbWUoZnJhbWVJRCk7CiAgICAgTUVTU0FHRV9DSEVDSyhmcmFtZSk7CiAKLSAg ICBpZiAoIWNvcmVDaGFsbGVuZ2UucHJldmlvdXNGYWlsdXJlQ291bnQoKSkgewotICAgICAgICBD cmVkZW50aWFsIGRlZmF1bHRDcmVkZW50aWFsID0gQ3JlZGVudGlhbFN0b3JhZ2U6OmdldEZyb21Q ZXJzaXN0ZW50U3RvcmFnZShjb3JlQ2hhbGxlbmdlLnByb3RlY3Rpb25TcGFjZSgpKTsKLSAgICAg ICAgaWYgKCFkZWZhdWx0Q3JlZGVudGlhbC5pc0VtcHR5KCkgJiYgZGVmYXVsdENyZWRlbnRpYWwu aGFzUGFzc3dvcmQoKSAmJiAhZGVmYXVsdENyZWRlbnRpYWwucGFzc3dvcmQoKS5pc0VtcHR5KCkp IHsKLSAgICAgICAgICAgIHByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6QXV0aGVudGljYXRpb25N YW5hZ2VyOjpVc2VDcmVkZW50aWFsRm9yQ2hhbGxlbmdlKGNoYWxsZW5nZUlELCBkZWZhdWx0Q3Jl ZGVudGlhbCksIHBhZ2VJRCgpKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQotICAg IH0KLQogICAgIFJlZlB0cjxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5PiBhdXRoZW50aWNh dGlvbkNoYWxsZW5nZSA9IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlUHJveHk6OmNyZWF0ZShjb3Jl Q2hhbGxlbmdlLCBjaGFsbGVuZ2VJRCwgdGhpcyk7CiAgICAgCiAgICAgbV9sb2FkZXJDbGllbnQu ZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlSW5GcmFtZSh0aGlzLCBmcmFtZSwgYXV0 aGVudGljYXRpb25DaGFsbGVuZ2UuZ2V0KCkpOwpJbmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShy ZXZpc2lvbiA3NDY1NikKKysrIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJG cmFtZUxvYWRlckNsaWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2MSw3ICsxNjEsNyBAQCB2 b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaFdpbGxTCiAKIGJvb2wgV2ViRnJhbWVM b2FkZXJDbGllbnQ6OnNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKERvY3VtZW50TG9hZGVyKiwg dW5zaWduZWQgbG9uZyBpZGVudGlmaWVyKQogewotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1 cm4gdHJ1ZTsKIH0KIAogdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRSZWNl aXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoRG9jdW1lbnRMb2FkZXIqLCB1bnNpZ25lZCBsb25n LCBjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYgY2hhbGxlbmdlKQpJbmRleDogV2ViS2l0 Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFpbk1hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQyL1dlYlByb2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWluTWFjLm1tCShyZXZpc2lvbiA3NDY1NikK KysrIFdlYktpdDIvV2ViUHJvY2Vzcy9tYWMvV2ViUHJvY2Vzc01haW5NYWMubW0JKHdvcmtpbmcg Y29weSkKQEAgLTEwNCw5ICsxMDQsNiBAQCBpbnQgV2ViUHJvY2Vzc01haW4oY29uc3QgQ29tbWFu ZExpbmUmIGNvCiAgICAgICAgIHJldHVybiAyOwogICAgIH0KIAotICAgIC8vIERpc2FsbG93IGFj Y2VzcyB0byB0aGUgdXNlciBrZXljaGFpbi4KLSAgICBTZWNLZXljaGFpblNldFByZWZlcmVuY2VE b21haW4oa1NlY1ByZWZlcmVuY2VzRG9tYWluU3lzdGVtKTsKLQogI2lmICFTSE9XX0NSQVNIX1JF UE9SVEVSCiAgICAgLy8gSW5zdGFsbHMgc2lnbmFsIGhhbmRsZXJzIHRoYXQgZXhpdCBvbiBhIGNy YXNoIHNvIHRoYXQgQ3Jhc2hSZXBvcnRlciBkb2VzIG5vdCBzaG93IHVwLgogICAgIHNpZ25hbChT SUdJTEwsIF9leGl0KTsK