51598 2010-12-24 12:07:45 -0800 [Qt] [WK2] WebKit 2 does not build on mac, missing reference to RetainPtr 2010-12-26 03:50:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Major --- 43505 1 benjamin benjamin commit-queue mitz ossy webkit-ews oldest_to_newest 326710 0 benjamin 2010-12-24 12:07:45 -0800 WebKit 2 does not build on Mac with default options. The problem comes from the following code: static String formatLocalizedString(const String& format, ...) { #if PLATFORM(CF) va_list arguments; va_start(arguments, format); RetainPtr<CFStringRef> formatCFString(AdoptCF, format.createCFString()); RetainPtr<CFStringRef> result(AdoptCF, CFStringCreateWithFormatAndArguments(0, 0, formatCFString.get(), arguments)); va_end(arguments); return result.get(); #else notImplemented(); return format; #endif } It uses RetainPtr(), but does not include the header file. This break has been introduced by 43505. 326711 1 77425 benjamin 2010-12-24 12:12:51 -0800 Created attachment 77425 Patch I apologize not to push that directly. I do not have my tools here so I figured it would be easier to use the commit queue. 326717 2 webkit-ews 2010-12-24 12:26:52 -0800 Attachment 77425 did not build on qt: Build output: http://queues.webkit.org/results/7205164 326731 3 77425 commit-queue 2010-12-24 12:55:45 -0800 Comment on attachment 77425 Patch Clearing flags on attachment: 77425 Committed r74650: <http://trac.webkit.org/changeset/74650> 326732 4 commit-queue 2010-12-24 12:55:50 -0800 All reviewed patches have been landed. Closing bug. 326740 5 mitz 2010-12-24 13:21:34 -0800 I don’t think this works. 326746 6 benjamin 2010-12-24 13:55:34 -0800 (In reply to comment #5) > I don’t think this works. Why? 326752 7 mitz 2010-12-24 14:24:28 -0800 (In reply to comment #6) > (In reply to comment #5) > > I don’t think this works. > > Why? Breaking Qt Linux <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/25687/steps/compile-webkit/logs/stdio> 326753 8 mitz 2010-12-24 14:25:26 -0800 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > I don’t think this works. > > > > Why? > > Breaking Qt Linux <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/25687/steps/compile-webkit/logs/stdio> Fixed by Simon in <http://trac.webkit.org/projects/webkit/changeset/74654>. 326758 9 benjamin 2010-12-24 15:09:17 -0800 (In reply to comment #8) > > > Why? > > > > Breaking Qt Linux <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/25687/steps/compile-webkit/logs/stdio> > > Fixed by Simon in <http://trac.webkit.org/projects/webkit/changeset/74654>. Thanks Mitz and Simon for fixing the build on Linux. 326873 10 ossy 2010-12-26 03:50:57 -0800 (In reply to comment #9) > > Fixed by Simon in <http://trac.webkit.org/projects/webkit/changeset/74654>. > > Thanks Mitz and Simon for fixing the build on Linux. You could have avoided this breakage if you had taken the comment of Qt-EWS seriously. 77425 2010-12-24 12:12:51 -0800 2010-12-24 12:55:44 -0800 Patch 51598.patch text/plain 1072 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NWE2ZjliNy4uYzA3YmE1NCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0yNCAgQmVuamFtaW4gUG91 bGFpbiAgPGlraXBvdUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBbV0syXSBXZWJLaXQgMiBkb2VzIG5vdCBidWlsZCBvbiBt YWMsIG1pc3NpbmcgcmVmZXJlbmNlIHRvIFJldGFpblB0cgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE1OTgKKworICAgICAgICBGaXggdGhlIGJ1aWxk LCBhZGQgdGhlIG1pc3NpbmcgaGVhZGVyLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwOgorCiAyMDEwLTEyLTIzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5p Zy4KZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0 Zm9ybVN0cmF0ZWdpZXMuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAKaW5kZXggODEwNjllMy4uN2FjNTg5NyAxMDA2NDQKLS0t IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2ll cy5jcHAKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3Jt U3RyYXRlZ2llcy5jcHAKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL1BhZ2Uu aD4KICNpbmNsdWRlIDxXZWJDb3JlL1BhZ2VHcm91cC5oPgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0 cmFzLmg+CisjaW5jbHVkZSA8d3RmL1JldGFpblB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NT dHJpbmcuaD4KIAogLy8gRklYTUU6IEltcGxlbWVudCBsb2NhbGl6YXRpb24uCg==