51581 2010-12-23 22:07:36 -0800 Web Inspector: Pasting a style property with value should automatically split it into prop/value 2010-12-30 12:25:34 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 temp01irc+bugzilla apavlov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 326472 0 temp01irc+bugzilla 2010-12-23 22:07:36 -0800 1) Copy a style rule e.g. "color: red" (without quotes) 2) Double click in inspector/style panel to create a new rule 3) Try to paste style rule from 1) Currently, pasting the rule puts the whole rule (including value) in the "property" column/input and that doesn't work. It should either get split into the two input boxes automatically or inspector should parse it as a whole rule when you hit enter (with blank value). 327883 1 77672 apavlov 2010-12-30 04:50:22 -0800 Created attachment 77672 [PATCH] Suggested solution 327894 2 77672 pfeldman 2010-12-30 05:15:52 -0800 Comment on attachment 77672 [PATCH] Suggested solution View in context: https://bugs.webkit.org/attachment.cgi?id=77672&action=review > WebCore/inspector/front-end/StylesSidebarPane.js:1589 > + var nameValue = data.split(":", 2); If we are supporting pasting "name:value" snippets, why don't we support pasting name1 : value1; name2 : value2; name3 : value3; ? 327903 3 apavlov 2010-12-30 05:58:50 -0800 (In reply to comment #2) > (From update of attachment 77672 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=77672&action=review > > > WebCore/inspector/front-end/StylesSidebarPane.js:1589 > > + var nameValue = data.split(":", 2); > > If we are supporting pasting "name:value" snippets, why don't we support pasting > name1 : value1; > name2 : value2; > name3 : value3; > ? It is not so easy to handle similar strings in the current editing infrastructure. I also envision a small UX inconsistency: a single name:value pair pasted into a new property does not commit it but allows tweaking of the name/value. In multiline texts, all properties but the last one should be committed and hence there is no way to tweak them as needed. 327945 4 apavlov 2010-12-30 09:27:21 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.js Committed r74799 327999 5 webkit.review.bot 2010-12-30 12:25:34 -0800 http://trac.webkit.org/changeset/74799 might have broken Leopard Intel Debug (Tests) 77672 2010-12-30 04:50:22 -0800 2010-12-30 05:15:52 -0800 [PATCH] Suggested solution paste.patch text/plain 5924 apavlov Y29tbWl0IDRhMzcwOTEwMGU2NDMzNDgxYWFlZWI4NjQ4ZDQ4ZTQwMWNiODNiZTIKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUaHUgRGVjIDMw IDE1OjQ1OjA0IDIwMTAgKzAzMDAKCiAgICBQYXN0ZSBmdWxsIHByb3BlcnRpZXMgd2l0aCBwYXJz aW5nCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBhOTcxNTQ1Li41OTNhNTU3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTEyLTMwICBBbGV4YW5k ZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUGFzdGluZyBhIHN0eWxl IHByb3BlcnR5IHdpdGggdmFsdWUgc2hvdWxkIGF1dG9tYXRpY2FsbHkgc3BsaXQgaXQgaW50byBw cm9wL3ZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MTU4MQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFu ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJv dG90eXBlLnNlbGVjdEVsZW1lbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVy dHlUcmVlRWxlbWVudC5wcm90b3R5cGUpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv aW5zcGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLnN0YXJ0RWRpdGluZy5jbGVhblVw QWZ0ZXJFZGl0aW5nKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5zdGFydEVkaXRpbmcpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLnN0YXJ0RWRpdGluZy5wYXN0ZUV2ZW50TGlzdGVuZXIpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLnN0YXJ0RWRpdGluZy5rZXlEb3duRXZlbnRMaXN0ZW5lcik6CisK IDIwMTAtMTItMjkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwppbmRleCAwYmM5NDFjLi41Y2MwZjNk IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5l LmpzCkBAIC0xNTgxLDExICsxNTgxLDM5IEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJl ZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIHJldHVybiAibW92ZS0iICsg KGV2ZW50LnNoaWZ0S2V5ID8gImJhY2t3YXJkIiA6ICJmb3J3YXJkIik7CiAgICAgICAgIH0KIAor ICAgICAgICBmdW5jdGlvbiBwYXN0ZUhhbmRsZXIoY29udGV4dCwgaXNFZGl0aW5nTmFtZSwgZXZl bnQpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhciBkYXRhID0gZXZlbnQuY2xpcGJvYXJkRGF0 YS5nZXREYXRhKCJUZXh0Iik7CisgICAgICAgICAgICBpZiAoIWRhdGEpCisgICAgICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICAgICAgdmFyIG5hbWVWYWx1ZSA9IGRhdGEuc3BsaXQoIjoiLCAy KTsKKyAgICAgICAgICAgIGlmIChuYW1lVmFsdWUubGVuZ3RoICE9PSAyKQorICAgICAgICAgICAg ICAgIHJldHVybjsKKworICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKworICAg ICAgICAgICAgdmFyIG5hbWUgPSBuYW1lVmFsdWVbMF0udHJpbSgpOworICAgICAgICAgICAgdmFy IHZhbHVlID0gbmFtZVZhbHVlWzFdLnRyaW0oKTsKKyAgICAgICAgICAgIHRoaXMubmFtZUVsZW1l bnQudGV4dENvbnRlbnQgPSBuYW1lOworICAgICAgICAgICAgdGhpcy52YWx1ZUVsZW1lbnQudGV4 dENvbnRlbnQgPSB2YWx1ZTsKKyAgICAgICAgICAgIHRoaXMubmFtZUVsZW1lbnQubm9ybWFsaXpl KCk7CisgICAgICAgICAgICB0aGlzLnZhbHVlRWxlbWVudC5ub3JtYWxpemUoKTsKKworICAgICAg ICAgICAgaWYgKGlzRWRpdGluZ05hbWUpCisgICAgICAgICAgICAgICAgcmV0dXJuICJtb3ZlLWZv cndhcmQiOworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgdmFyIGZpcnN0Q2hp bGQgPSB0aGlzLnZhbHVlRWxlbWVudC5maXJzdENoaWxkOworICAgICAgICAgICAgICAgIGlmIChm aXJzdENoaWxkICYmIGZpcnN0Q2hpbGQuc2VsZWN0KQorICAgICAgICAgICAgICAgICAgICBmaXJz dENoaWxkLnNlbGVjdChmaXJzdENoaWxkLnRleHRDb250ZW50Lmxlbmd0aCk7CisgICAgICAgICAg ICB9CisgICAgICAgIH0KKwogICAgICAgICBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nKHNlbGVj dEVsZW1lbnQsIHsKICAgICAgICAgICAgIGNvbnRleHQ6IGNvbnRleHQsCiAgICAgICAgICAgICBj b21taXRIYW5kbGVyOiB0aGlzLmVkaXRpbmdDb21taXR0ZWQuYmluZCh0aGlzKSwKICAgICAgICAg ICAgIGNhbmNlbEhhbmRsZXI6IHRoaXMuZWRpdGluZ0NhbmNlbGxlZC5iaW5kKHRoaXMpLAotICAg ICAgICAgICAgY3VzdG9tRmluaXNoSGFuZGxlcjogbmFtZVZhbHVlRmluaXNoSGFuZGxlci5iaW5k KHRoaXMsIGNvbnRleHQsIGlzRWRpdGluZ05hbWUpCisgICAgICAgICAgICBjdXN0b21GaW5pc2hI YW5kbGVyOiBuYW1lVmFsdWVGaW5pc2hIYW5kbGVyLmJpbmQodGhpcywgY29udGV4dCwgaXNFZGl0 aW5nTmFtZSksCisgICAgICAgICAgICBwYXN0ZUhhbmRsZXI6IHBhc3RlSGFuZGxlci5iaW5kKHRo aXMsIGNvbnRleHQsIGlzRWRpdGluZ05hbWUpCiAgICAgICAgIH0pOwogICAgICAgICB3aW5kb3cu Z2V0U2VsZWN0aW9uKCkuc2V0QmFzZUFuZEV4dGVudChzZWxlY3RFbGVtZW50LCAwLCBzZWxlY3RF bGVtZW50LCAxKTsKICAgICB9LApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3Iu anMKaW5kZXggY2MyNTVhYS4uZWNkY2Q5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv aW5zcGVjdG9yLmpzCkBAIC0xNzUzLDYgKzE3NTMsNyBAQCBXZWJJbnNwZWN0b3IuaXNFZGl0aW5n QW55RmllbGQgPSBmdW5jdGlvbigpCiAvLyBjb21taXRIYW5kbGVyOiBGdW5jdGlvbiAtIGhhbmRs ZXMgZWRpdGluZyAiY29tbWl0IiBvdXRjb21lCiAvLyBjYW5jZWxIYW5kbGVyOiBGdW5jdGlvbiAt IGhhbmRsZXMgZWRpdGluZyAiY2FuY2VsIiBvdXRjb21lCiAvLyBjdXN0b21GaW5pc2hIYW5kbGVy OiBGdW5jdGlvbiAtIGN1c3RvbSBmaW5pc2ggaGFuZGxlciBmb3IgdGhlIGVkaXRpbmcgc2Vzc2lv biAoaW52b2tlZCBvbiBrZXlkb3duKQorLy8gcGFzdGVIYW5kbGVyOiBGdW5jdGlvbiAtIGhhbmRs ZXMgdGhlICJwYXN0ZSIgZXZlbnQsIHJldHVybiB2YWx1ZXMgYXJlIHRoZSBzYW1lIGFzIHRob3Nl IGZvciBjdXN0b21GaW5pc2hIYW5kbGVyCiAvLyBtdWx0aWxpbmU6IEJvb2xlYW4gLSB3aGV0aGVy IHRoZSBlZGl0ZWQgZWxlbWVudCBpcyBtdWx0aWxpbmUKIFdlYkluc3BlY3Rvci5zdGFydEVkaXRp bmcgPSBmdW5jdGlvbihlbGVtZW50LCBjb25maWcpCiB7CkBAIC0xNzY0LDYgKzE3NjUsNyBAQCBX ZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nID0gZnVuY3Rpb24oZWxlbWVudCwgY29uZmlnKQogICAg IGNvbmZpZyA9IGNvbmZpZyB8fCB7fTsKICAgICB2YXIgY29tbWl0dGVkQ2FsbGJhY2sgPSBjb25m aWcuY29tbWl0SGFuZGxlcjsKICAgICB2YXIgY2FuY2VsbGVkQ2FsbGJhY2sgPSBjb25maWcuY2Fu Y2VsSGFuZGxlcjsKKyAgICB2YXIgcGFzdGVDYWxsYmFjayA9IGNvbmZpZy5wYXN0ZUhhbmRsZXI7 CiAgICAgdmFyIGNvbnRleHQgPSBjb25maWcuY29udGV4dDsKICAgICB2YXIgb2xkVGV4dCA9IGdl dENvbnRlbnQoZWxlbWVudCk7CiAgICAgdmFyIG1vdmVEaXJlY3Rpb24gPSAiIjsKQEAgLTE3OTYs NiArMTc5OCw4IEBAIFdlYkluc3BlY3Rvci5zdGFydEVkaXRpbmcgPSBmdW5jdGlvbihlbGVtZW50 LCBjb25maWcpCiAKICAgICAgICAgZWxlbWVudC5yZW1vdmVFdmVudExpc3RlbmVyKCJibHVyIiwg Ymx1ckV2ZW50TGlzdGVuZXIsIGZhbHNlKTsKICAgICAgICAgZWxlbWVudC5yZW1vdmVFdmVudExp c3RlbmVyKCJrZXlkb3duIiwga2V5RG93bkV2ZW50TGlzdGVuZXIsIHRydWUpOworICAgICAgICBp ZiAocGFzdGVDYWxsYmFjaykKKyAgICAgICAgICAgIGVsZW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5l cigicGFzdGUiLCBwYXN0ZUV2ZW50TGlzdGVuZXIsIHRydWUpOwogCiAgICAgICAgIGlmIChlbGVt ZW50ID09PSBXZWJJbnNwZWN0b3IuY3VycmVudEZvY3VzRWxlbWVudCB8fCBlbGVtZW50LmlzQW5j ZXN0b3IoV2ViSW5zcGVjdG9yLmN1cnJlbnRGb2N1c0VsZW1lbnQpKQogICAgICAgICAgICAgV2Vi SW5zcGVjdG9yLmN1cnJlbnRGb2N1c0VsZW1lbnQgPSBXZWJJbnNwZWN0b3IucHJldmlvdXNGb2N1 c0VsZW1lbnQ7CkBAIC0xODMzLDEwICsxODM3LDggQEAgV2ViSW5zcGVjdG9yLnN0YXJ0RWRpdGlu ZyA9IGZ1bmN0aW9uKGVsZW1lbnQsIGNvbmZpZykKICAgICAgICAgICAgIHJldHVybiAibW92ZS0i ICsgKGV2ZW50LnNoaWZ0S2V5ID8gImJhY2t3YXJkIiA6ICJmb3J3YXJkIik7CiAgICAgfQogCi0g ICAgZnVuY3Rpb24ga2V5RG93bkV2ZW50TGlzdGVuZXIoZXZlbnQpCisgICAgZnVuY3Rpb24gaGFu ZGxlRWRpdGluZ1Jlc3VsdChyZXN1bHQsIGV2ZW50KQogICAgIHsKLSAgICAgICAgdmFyIGhhbmRs ZXIgPSBjb25maWcuY3VzdG9tRmluaXNoSGFuZGxlciB8fCBkZWZhdWx0RmluaXNoSGFuZGxlcjsK LSAgICAgICAgdmFyIHJlc3VsdCA9IGhhbmRsZXIoZXZlbnQpOwogICAgICAgICBpZiAocmVzdWx0 ID09PSAiY29tbWl0IikgewogICAgICAgICAgICAgZWRpdGluZ0NvbW1pdHRlZC5jYWxsKGVsZW1l bnQpOwogICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKQEAgLTE4NTIsOCArMTg1 NCwyMyBAQCBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nID0gZnVuY3Rpb24oZWxlbWVudCwgY29u ZmlnKQogICAgICAgICB9CiAgICAgfQogCisgICAgZnVuY3Rpb24gcGFzdGVFdmVudExpc3RlbmVy KGV2ZW50KQorICAgIHsKKyAgICAgICAgdmFyIHJlc3VsdCA9IHBhc3RlQ2FsbGJhY2soZXZlbnQp OworICAgICAgICBoYW5kbGVFZGl0aW5nUmVzdWx0KHJlc3VsdCwgZXZlbnQpOworICAgIH0KKwor ICAgIGZ1bmN0aW9uIGtleURvd25FdmVudExpc3RlbmVyKGV2ZW50KQorICAgIHsKKyAgICAgICAg dmFyIGhhbmRsZXIgPSBjb25maWcuY3VzdG9tRmluaXNoSGFuZGxlciB8fCBkZWZhdWx0RmluaXNo SGFuZGxlcjsKKyAgICAgICAgdmFyIHJlc3VsdCA9IGhhbmRsZXIoZXZlbnQpOworICAgICAgICBo YW5kbGVFZGl0aW5nUmVzdWx0KHJlc3VsdCwgZXZlbnQpOworICAgIH0KKwogICAgIGVsZW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigiYmx1ciIsIGJsdXJFdmVudExpc3RlbmVyLCBmYWxzZSk7CiAgICAg ZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwga2V5RG93bkV2ZW50TGlzdGVuZXIs IHRydWUpOworICAgIGlmIChwYXN0ZUNhbGxiYWNrKQorICAgICAgICBlbGVtZW50LmFkZEV2ZW50 TGlzdGVuZXIoInBhc3RlIiwgcGFzdGVFdmVudExpc3RlbmVyLCB0cnVlKTsKIAogICAgIFdlYklu c3BlY3Rvci5jdXJyZW50Rm9jdXNFbGVtZW50ID0gZWxlbWVudDsKICAgICByZXR1cm4gewo=