51576 2010-12-23 18:06:36 -0800 setTargetAttributeAnimatedValue should check for a null shadowTreeElement. 2010-12-24 03:54:45 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jschuh jschuh commit-queue eric zimmermann oldest_to_newest 326403 0 jschuh 2010-12-23 18:06:36 -0800 setTargetAttributeAnimatedValue should check for a null shadowTreeElement. 326407 1 77392 jschuh 2010-12-23 18:12:59 -0800 Created attachment 77392 Patch 326434 2 eric 2010-12-23 19:19:49 -0800 I dont' really understand shadowtree pruning. But I suspect Niko does. 326447 3 jschuh 2010-12-23 19:44:06 -0800 I bug Niko a lot. I thought I'd give him a reprieve for the holidays since I'm just cleaning out some annoyance bugs that I'd stumbled on while fixing security issues. :) 326493 4 zimmermann 2010-12-24 00:31:03 -0800 Good catch Justin, happy x-mas! :-) 326580 5 commit-queue 2010-12-24 03:53:22 -0800 The commit-queue encountered the following flaky tests while processing attachment 77392: inspector/elements-panel-styles.html bug 50987 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch. 326581 6 77392 commit-queue 2010-12-24 03:54:39 -0800 Comment on attachment 77392 Patch Clearing flags on attachment: 77392 Committed r74629: <http://trac.webkit.org/changeset/74629> 326582 7 commit-queue 2010-12-24 03:54:45 -0800 All reviewed patches have been landed. Closing bug. 77392 2010-12-23 18:12:59 -0800 2010-12-24 03:54:39 -0800 Patch bug-51576-20101223181257.patch text/plain 3681 jschuh SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDYwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMjMgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg c2V0VGFyZ2V0QXR0cmlidXRlQW5pbWF0ZWRWYWx1ZSBzaG91bGQgY2hlY2sgZm9yIGEgbnVsbCBz aGFkb3dUcmVlRWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUxNTc2CisKKyAgICAgICAgRGlzYWxsb3dlZCBlbGVtZW50cyBtYXkgYmUgcHJ1 bmVkIGZyb20gdGhlIHNoYWRvdyB0cmVlLCBsZWF2aW5nIGEgbnVsbAorICAgICAgICBzaGFkb3dU cmVlRWxlbWVudC4gV2Ugc2hvdWxkIGNoZWNrIGZvciB0aGF0IGJlZm9yZSBzZXR0aW5nIGF0dHJp YnV0ZXMuCisKKyAgICAgICAgVGVzdDogc3ZnL2N1c3RvbS9hbmltYXRlLWRpc2FsbG93ZWQtdXNl LWVsZW1lbnQuc3ZnCisKKyAgICAgICAgKiBzdmcvU1ZHQW5pbWF0aW9uRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTVkdBbmltYXRpb25FbGVtZW50OjpzZXRUYXJnZXRBdHRyaWJ1dGVB bmltYXRlZFZhbHVlKToKKwogMjAxMC0xMi0yMyAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJDb3Jl L3N2Zy9TVkdBbmltYXRpb25FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N2Zy9T VkdBbmltYXRpb25FbGVtZW50LmNwcAkocmV2aXNpb24gNzQ1NzgpCisrKyBXZWJDb3JlL3N2Zy9T VkdBbmltYXRpb25FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUyLDcgKzM1Miw4IEBA IHZvaWQgU1ZHQW5pbWF0aW9uRWxlbWVudDo6c2V0VGFyZ2V0QXR0cmkKICAgICBjb25zdCBIYXNo U2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBpbnN0YW5jZXMu ZW5kKCk7CiAgICAgZm9yIChIYXNoU2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+Ojpjb25zdF9pdGVy YXRvciBpdCA9IGluc3RhbmNlcy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKICAgICAgICAg U1ZHRWxlbWVudCogc2hhZG93VHJlZUVsZW1lbnQgPSAoKml0KS0+c2hhZG93VHJlZUVsZW1lbnQo KTsKLSAgICAgICAgQVNTRVJUKHNoYWRvd1RyZWVFbGVtZW50KTsKKyAgICAgICAgaWYgKCFzaGFk b3dUcmVlRWxlbWVudCkKKyAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBpZiAoaXNDU1Mp CiAgICAgICAgICAgICBzaGFkb3dUcmVlRWxlbWVudC0+c3R5bGUoKS0+c2V0UHJvcGVydHkoYXR0 cmlidXRlTmFtZSwgdmFsdWUsICIiLCBlYyk7CiAgICAgICAgIGVsc2UKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDc0NjAwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMTItMjMgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2V0 VGFyZ2V0QXR0cmlidXRlQW5pbWF0ZWRWYWx1ZSBzaG91bGQgY2hlY2sgZm9yIGEgbnVsbCBzaGFk b3dUcmVlRWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxNTc2CisKKyAgICAgICAgKiBzdmcvY3VzdG9tL2FuaW1hdGUtZGlzYWxsb3dlZC11 c2UtZWxlbWVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vYW5p bWF0ZS1kaXNhbGxvd2VkLXVzZS1lbGVtZW50LnN2ZzogQWRkZWQuCisKIDIwMTAtMTItMjMgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBRdCBy ZWJhc2VsaW5lcyBmb3Igcjc0NTkzLgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9hbmlt YXRlLWRpc2FsbG93ZWQtdXNlLWVsZW1lbnQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3N2Zy9jdXN0b20vYW5pbWF0ZS1kaXNhbGxvd2VkLXVzZS1lbGVtZW50LWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N2Zy9jdXN0b20vYW5pbWF0ZS1k aXNhbGxvd2VkLXVzZS1lbGVtZW50LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSBAQAorUEFTUzogQW5pbWF0aW5nIHBydW5lZCBzaGFkb3cgdHJlZSBkaWQgbm90IGNhdXNlIGEg Y3Jhc2guCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2FuaW1hdGUtZGlzYWxsb3dlZC11 c2UtZWxlbWVudC5zdmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9hbmlt YXRlLWRpc2FsbG93ZWQtdXNlLWVsZW1lbnQuc3ZnCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvc3ZnL2N1c3RvbS9hbmltYXRlLWRpc2FsbG93ZWQtdXNlLWVsZW1lbnQuc3ZnCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDE4IEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAw L3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPgorICAgIDxz Y3JpcHQ+CisgICAgICAgIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgICAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICAgICAgICAgIHNldFRpbWVvdXQo ZnVuY3Rpb24oKXsgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpIH0sIDApOworICAg ICAgICAgICAgfQorICAgICAgICB9CisgICAgPC9zY3JpcHQ+CisgICAgPGRlZnM+CisgICAgICAg IDxhbmltYXRlIGlkPSJhbmltYXRlIiAvPgorICAgIDwvZGVmcz4KKyAgICA8dXNlIHhsaW5rOmhy ZWY9IiNpbm5lcl91c2UiIC8+CisgICAgPHVzZSBpZD0iaW5uZXJfdXNlIiB4bGluazpocmVmPSIj YW5pbWF0ZSIgLz4KKyAgICA8c2V0IGZyb209IjAiIHRvPSIxMCIgZHVyPSIwLjFzIiB4bGluazpo cmVmPSIjYW5pbWF0ZSIgYXR0cmlidXRlTmFtZT0ieCIgLz4KKyAgICA8dGV4dCB4PSIyMCIgeT0i MjAiIGZpbGw9ImdyZWVuIj5QQVNTOiBBbmltYXRpbmcgcHJ1bmVkIHNoYWRvdyB0cmVlIGRpZCBu b3QgY2F1c2UgYSBjcmFzaC48L3RleHQ+Cis8L3N2Zz4K