51566 2010-12-23 15:20:43 -0800 TextMetrics::width is an integer, but the member is a float 2010-12-24 03:50:55 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 51551 1 evan webkit-unassigned commit-queue hyatt jamesr mitz oldest_to_newest 326316 0 evan 2010-12-23 15:20:43 -0800 In WebCore/html/TextMetrics.idl it says: readonly attribute float width; in .../TextMetrics.h: float m_width; But there's a getter with this confusing comment: // FIXME: Is coercing to an integer value intentional? If so, there should be a static_cast<unsigned>() here. unsigned width() const { return m_width; } From my greps around, it appears this getter is unused, but I unsure how the idl interacts with this (perhaps the idl generates code that calls width().) 326324 1 evan 2010-12-23 15:26:15 -0800 CC hyatt, original author of the code (correct bug this time) 326326 2 evan 2010-12-23 15:28:41 -0800 in LayoutTests/fast/canvas/canvas-text-baseline.html if I dump out all the widths found by ctx.measureText(text).width they are always integers. Not sure if it's intentional (or perhaps in Chrome we always have integer width fonts for other reasons) 326355 3 evan 2010-12-23 16:26:23 -0800 I tried changing it to a float and still got integers out. Spec says the width should be "CSS pixels", which I think can be floating point. I'll upload a patch and see what y'all think. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-measuretext 326363 4 77385 evan 2010-12-23 16:43:13 -0800 Created attachment 77385 Patch 326365 5 evan 2010-12-23 16:44:34 -0800 I tried modifying the test to use text of width 32.1 pixels, but even after this change the "width" field came out as an integer. Again, this could be due to some other code in Chrome rounding text widths. 326575 6 commit-queue 2010-12-24 03:49:32 -0800 The commit-queue encountered the following flaky tests while processing attachment 77385: inspector/elements-panel-styles.html bug 50987 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch. 326577 7 77385 commit-queue 2010-12-24 03:50:48 -0800 Comment on attachment 77385 Patch Clearing flags on attachment: 77385 Committed r74628: <http://trac.webkit.org/changeset/74628> 326578 8 commit-queue 2010-12-24 03:50:55 -0800 All reviewed patches have been landed. Closing bug. 77385 2010-12-23 16:43:13 -0800 2010-12-24 03:50:48 -0800 Patch bug-51566-20101223164309.patch text/plain 1488 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTBiZGE4NGYyYjUwMDc5ODNlNjZmNGY1ODUxYzYzNGJlZTc1ZTlmZS4uNTUwYWY4MmI0ZGNhNDc4 MzhiNzNhMGU4OWI4Y2U4MDBkYmRiZGQyZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0yMyAgRXZh biBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUZXh0TWV0cmljczo6d2lkdGggaXMgYW4gaW50ZWdlciwg YnV0IHRoZSBtZW1iZXIgaXMgYSBmbG9hdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTE1NjYKKworICAgICAgICBDaGFuZ2UgdGhlIHJldHVybiB0eXBl IHRvIGEgZmxvYXQuCisKKyAgICAgICAgTm8gdGVzdHMsIGZpeGluZyBhIGNvbXBpbGVyIHdhcm5p bmcuCisgICAgICAgIChJIHdhcyB1bmFibGUgdG8gcHJvZHVjZSBhIGRpZmZlcmVuY2UgaW4gdGhl IHZhbHVlcyBleHBvc2VkIHRvIHBhZ2VzCisgICAgICAgIHdpdGggYSBmbG9hdCB2ZXJzdXMgdGhl IHByZXZpb3VzIGNvbnZlcnNpb24gdG8gYW4gaW50ZWdlci4pCisKKyAgICAgICAgKiBodG1sL1Rl eHRNZXRyaWNzLmg6CisgICAgICAgIChXZWJDb3JlOjpUZXh0TWV0cmljczo6d2lkdGgpOgorCiAy MDEwLTEyLTIyICBNYXR0aGV3IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL1Rl eHRNZXRyaWNzLmggYi9XZWJDb3JlL2h0bWwvVGV4dE1ldHJpY3MuaAppbmRleCBjNzg2ZmNhMzJi OGY3OGM4OTI3M2MxZTE2NTYxYmRkMzlmNmQyMjRhLi5iMjcyZWY2NjRiODdmNzJmY2NiNzMzMWZj YTc0MzQwZTAxZmMwNDMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvVGV4dE1ldHJpY3MuaAor KysgYi9XZWJDb3JlL2h0bWwvVGV4dE1ldHJpY3MuaApAQCAtMzUsOCArMzUsNyBAQCBjbGFzcyBU ZXh0TWV0cmljcyA6IHB1YmxpYyBSZWZDb3VudGVkPFRleHRNZXRyaWNzPiB7CiBwdWJsaWM6CiAg ICAgc3RhdGljIFBhc3NSZWZQdHI8VGV4dE1ldHJpY3M+IGNyZWF0ZSgpIHsgcmV0dXJuIGFkb3B0 UmVmKG5ldyBUZXh0TWV0cmljcyk7IH0KIAotICAgIC8vIEZJWE1FOiBJcyBjb2VyY2luZyB0byBh biBpbnRlZ2VyIHZhbHVlIGludGVudGlvbmFsPyBJZiBzbywgdGhlcmUgc2hvdWxkIGJlIGEgc3Rh dGljX2Nhc3Q8dW5zaWduZWQ+KCkgaGVyZS4KLSAgICB1bnNpZ25lZCB3aWR0aCgpIGNvbnN0IHsg cmV0dXJuIG1fd2lkdGg7IH0KKyAgICBmbG9hdCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fd2lk dGg7IH0KICAgICB2b2lkIHNldFdpZHRoKGZsb2F0IHcpIHsgbV93aWR0aCA9IHc7IH0KIAogcHJp dmF0ZToK