51542 2010-12-23 10:21:42 -0800 Web Inspector: Missing Localized Strings 2011-01-10 22:23:34 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 326139 0 joepeck 2010-12-23 10:21:42 -0800 As seen on the build bot: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r74563%20(8973)/inspector/syntax-highlight-html-stderr.txt • I did not search deeply for other strings. • I did not search to see if any strings are no longer needed. 326141 1 77343 joepeck 2010-12-23 10:24:27 -0800 Created attachment 77343 [PATCH] Adds the missing strings Can't commit queue git delta binary patches. 326368 2 joepeck 2010-12-23 16:51:39 -0800 No-one reviewed this and I had some spare time. I did a quick check to verify that the strings listed in localizedStrings.js are still valid. Here is what I found: No longer seem to be used: "%s (%s transferred)" "Enable resource tracking" "Enabling resource tracking will reload the page and make page loading slower." "Resource tracking disabled. Click to enable." "Resource tracking enabled. Click to disable." "You need to enable resource tracking to use this panel." "GRAPHS" "Prototype" "RESOURCES" "Recording…" "Sort by Duration" "Sort by End Time" "Sort by Latency" "Sort by Response Time" "Sort by Size" "Sort by Start Time" "Sort by Transfer Size" "Stop on Attributes Modifications" "Stop on Node Removal" "Stop on Subtree Modifications" "Any Request" "Set XHR Breakpoint" "Timing." Might be used? Its a key in WebInspector.Resource.Type "Media" Used, but is different in Source Code: "Assertion failed: " 326491 3 yurys 2010-12-24 00:28:41 -0800 (In reply to comment #2) > No-one reviewed this and I had some spare time. I did a quick check to > Used, but is different in Source Code: > "Assertion failed: " This one must be my fault. I recently changed the code that formats console messages. Will look into it. 326632 4 yurys 2010-12-24 09:02:13 -0800 Committed r74635: <http://trac.webkit.org/changeset/74635> 332158 5 joepeck 2011-01-10 22:23:34 -0800 Thanks for landing this for me! I'll file a new bug with the comment I had about the other localized strings. 77343 2010-12-23 10:24:27 -0800 2010-12-24 00:27:50 -0800 [PATCH] Adds the missing strings patch.patch text/plain 1118 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjQ3NjI1NC4uY2ZiM2U5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0yMyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1pc3NpbmcgTG9jYWxpemVkIFN0cmlu Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNTQy CisKKyAgICAgICAgQWRkZWQgbWlzc2luZyBzdHJpbmdzOiAiV2ViU29ja2V0IiwgICJGcmFtZXMi LCAiVGV4dCIsICJUcmFuc2ZlciIsCisgICAgICAgICJQcmVzZXJ2ZSBMb2cgdXBvbiBOYXZpZ2F0 aW9uIiwgYW5kICJHbyB0byBMaW5lIi4KKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovbG9jYWxp emVkU3RyaW5ncy5qczoKKwogMjAxMC0xMi0yMCAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9XZWJDb3Jl L0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCBkOTY2NzFhMzdiZDBhZjY1 Yjg4MzVjNmJjYmViMTEyODVkYjg4MTNkLi5kOTMwNDYwODM2NzUwYThjY2NiMzc4YWEwMTMwNDIy OTUyMTNiZGRkIDEwMDY0NApHSVQgYmluYXJ5IHBhdGNoCmRlbHRhIDMyNAp6Y21iUVhmY2VmNjxf I2hqQ2hON1Q9IVA/LUc5KW5zR3ZxVFFHaF9xVkJAOVhvdT96fGZ3bV9gSmZGP1YrdXwtJGoKempp SERra3Mla1R3aXJiJVJEQU5wSmJsUiFwbGspMlN6c31jM0Y7d1c2WV94aSh9MyFWUCl0RlJvNGx9 OGV7dz8oCnppemRoPmtoKEc7c2xlYV5iWmFgMEVAZGJIdmhzaXxLY0lXYzclfn5zQ3ZUSnkqOWAh d0J3b2pRUzx9Zm1lbXJfVQphSz5jfEBlYU9DZDJiISt7XmFZNFMkWGhkVEYjckhoTT93ayEKCmRl bHRhIDEyClRjbWNiIWduOE5tPF8jaGpuNzl9S0Jma1YpCgo=