51540 2010-12-23 10:04:19 -0800 Nothing happens clicking "launch live player" on live.cnn.com 2010-12-23 10:16:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca oldest_to_newest 326124 0 andersca 2010-12-23 10:04:19 -0800 Nothing happens clicking "launch live player" on live.cnn.com 326125 1 andersca 2010-12-23 10:07:54 -0800 <rdar://problem/8791086> 326126 2 77341 andersca 2010-12-23 10:08:20 -0800 Created attachment 77341 Patch 326129 3 77341 sullivan 2010-12-23 10:12:02 -0800 Comment on attachment 77341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77341&action=review > WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:391 > + // FIXME: Check if the current event is a user gesture. As we discussed, this could use a better comment about why it's not important to address. 326132 4 andersca 2010-12-23 10:16:18 -0800 Committed r74564: <http://trac.webkit.org/changeset/74564> 77341 2010-12-23 10:08:20 -0800 2010-12-23 10:12:02 -0800 Patch bug-51540-20101223100818.patch text/plain 5817 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDU2MykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzUgQEAKKzIwMTAtMTItMjMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBOb3RoaW5nIGhhcHBlbnMgY2xpY2tpbmcgImxhdW5jaCBsaXZlIHBsYXllciIgb24gbGl2ZS5j bm4uY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MTU0MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODc5MTA4Nj4KKworICAgICAgICBJbXBsZW1l bnQgTlBOX1B1c2hQb3B1cHNFbmFibGVkU3RhdGUvTlBOX1BvcFBvcHVwc0VuYWJsZWRTdGF0ZS4K KworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJG dW5jcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5QTl9QdXNoUG9wdXBzRW5hYmxlZFN0YXRlKToK KyAgICAgICAgQ2FsbCBOZXRzY2FwZVBsdWdpbjo6cHVzaFBvcHVwc0VuYWJsZWRTdGF0ZS4KKwor ICAgICAgICAoV2ViS2l0OjpOUE5fUG9wUG9wdXBzRW5hYmxlZFN0YXRlKToKKyAgICAgICAgQ2Fs bCBOZXRzY2FwZVBsdWdpbjo6cG9wUG9wdXBzRW5hYmxlZFN0YXRlLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcDoKKyAgICAgICAgKFdl YktpdDo6TmV0c2NhcGVQbHVnaW46OnB1c2hQb3B1cHNFbmFibGVkU3RhdGUpOgorICAgICAgICBB cHBlbmQgdGhlIGJvb2xlYW4gdG8gdGhlIHZlY3Rvci4KKworICAgICAgICAoV2ViS2l0OjpOZXRz Y2FwZVBsdWdpbjo6cG9wUG9wdXBzRW5hYmxlZFN0YXRlKToKKyAgICAgICAgUmVtb3ZlIHRoZSBs YXN0IGJvb2xlYW4gZnJvbSB0aGUgdmVjdG9yLgorCisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBl UGx1Z2luOjphbGxvd1BvcHVwcyk6CisgICAgICAgIFJldHVybiB0aGUgbGFzdCBib29sZWFuIGZy b20gdGhlIHZlY3Rvci4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O ZXRzY2FwZVBsdWdpbi5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luVmlldzo6cGVyZm9ybUphdmFTY3JpcHRVUkxS ZXF1ZXN0KToKKyAgICAgICAgVXBkYXRlIHRoZSAiYWxsb3dQb3B1cHNGcm9tUGx1Z2luIiBzdGF0 ZS4KKwogMjAxMC0xMi0yMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkocmV2aXNpb24gNzQ1MTUpCisrKyBXZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzAzLDkg KzcwMywxNCBAQCB2b2lkIFBsdWdpblZpZXc6OnBlcmZvcm1KYXZhU2NyaXB0VVJMUmVxCiAgICAg Ly8gRXZhbHVhdGUgdGhlIEphdmFTY3JpcHQgY29kZS4gTm90ZSB0aGF0IHJ1bm5pbmcgSmF2YVNj cmlwdCBoZXJlIGNvdWxkIGNhdXNlIHRoZSBwbHVnLWluIHRvIGJlIGRlc3Ryb3llZCwgc28gd2UK ICAgICAvLyBncmFiIHJlZmVyZW5jZXMgdG8gdGhlIHBsdWctaW4gaGVyZS4KICAgICBSZWZQdHI8 UGx1Z2luPiBwbHVnaW4gPSBtX3BsdWdpbjsKKworICAgIGJvb2wgb2xkQWxsb3dQb3B1cHMgPSBm cmFtZS0+c2NyaXB0KCktPmFsbG93UG9wdXBzRnJvbVBsdWdpbigpOworICAgIGZyYW1lLT5zY3Jp cHQoKS0+c2V0QWxsb3dQb3B1cHNGcm9tUGx1Z2luKHJlcXVlc3QtPmFsbG93UG9wdXBzKCkpOwog ICAgIAogICAgIFNjcmlwdFZhbHVlIHJlc3VsdCA9IG1fcGx1Z2luRWxlbWVudC0+ZG9jdW1lbnQo KS0+ZnJhbWUoKS0+c2NyaXB0KCktPmV4ZWN1dGVTY3JpcHQoanNTdHJpbmcpOwogCisgICAgZnJh bWUtPnNjcmlwdCgpLT5zZXRBbGxvd1BvcHVwc0Zyb21QbHVnaW4ob2xkQWxsb3dQb3B1cHMpOwor CiAgICAgLy8gQ2hlY2sgaWYgZXZhbHVhdGluZyB0aGUgSmF2YVNjcmlwdCBkZXN0cm95ZWQgdGhl IHBsdWctaW4uCiAgICAgaWYgKCFwbHVnaW4tPmNvbnRyb2xsZXIoKSkKICAgICAgICAgcmV0dXJu OwpAQCAtODg4LDcgKzg5Myw3IEBAIE5QT2JqZWN0KiBQbHVnaW5WaWV3OjpwbHVnaW5FbGVtZW50 TlBPYmoKICAgICByZXR1cm4gbV9ucFJ1bnRpbWVPYmplY3RNYXAuZ2V0T3JDcmVhdGVOUE9iamVj dChvYmplY3QpOwogfQogCi1ib29sIFBsdWdpblZpZXc6OmV2YWx1YXRlKE5QT2JqZWN0KiBucE9i amVjdCwgY29uc3QgU3RyaW5nJnNjcmlwdFN0cmluZywgTlBWYXJpYW50KiByZXN1bHQsIGJvb2wg YWxsb3dQb3B1cHMpCitib29sIFBsdWdpblZpZXc6OmV2YWx1YXRlKE5QT2JqZWN0KiBucE9iamVj dCwgY29uc3QgU3RyaW5nJiBzY3JpcHRTdHJpbmcsIE5QVmFyaWFudCogcmVzdWx0LCBib29sIGFs bG93UG9wdXBzKQogewogICAgIGlmICghZnJhbWUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpJ bmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2Vy RnVuY3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcAkocmV2aXNpb24gNzQ1MTUpCisrKyBXZWJLaXQy L1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY0OCwxNCArNjQ4LDE2IEBAIHN0YXRpYyB2b2lkIE5QTl9TZXRFeGNl cHRpb24oTlBPYmplY3QqLCAKICAgICBOZXRzY2FwZVBsdWdpbjo6c2V0RXhjZXB0aW9uKG1lc3Nh Z2UpOwogfQogCi1zdGF0aWMgdm9pZCBOUE5fUHVzaFBvcHVwc0VuYWJsZWRTdGF0ZShOUFAgaW5z dGFuY2UsIE5QQm9vbCBlbmFibGVkKQorc3RhdGljIHZvaWQgTlBOX1B1c2hQb3B1cHNFbmFibGVk U3RhdGUoTlBQIG5wcCwgTlBCb29sIGVuYWJsZWQpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsK KyAgICBSZWZQdHI8TmV0c2NhcGVQbHVnaW4+IHBsdWdpbiA9IE5ldHNjYXBlUGx1Z2luOjpmcm9t TlBQKG5wcCk7CisgICAgcGx1Z2luLT5wdXNoUG9wdXBzRW5hYmxlZFN0YXRlKGVuYWJsZWQpOwog fQogICAgIAotc3RhdGljIHZvaWQgTlBOX1BvcFBvcHVwc0VuYWJsZWRTdGF0ZShOUFAgaW5zdGFu Y2UpCitzdGF0aWMgdm9pZCBOUE5fUG9wUG9wdXBzRW5hYmxlZFN0YXRlKE5QUCBucHApCiB7Ci0g ICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBSZWZQdHI8TmV0c2NhcGVQbHVnaW4+IHBsdWdpbiA9 IE5ldHNjYXBlUGx1Z2luOjpmcm9tTlBQKG5wcCk7CisgICAgcGx1Z2luLT5wb3BQb3B1cHNFbmFi bGVkU3RhdGUoKTsKIH0KICAgICAKIHN0YXRpYyBib29sIE5QTl9FbnVtZXJhdGUoTlBQLCBOUE9i amVjdCogbnBPYmplY3QsIE5QSWRlbnRpZmllcioqIGlkZW50aWZpZXJzLCB1aW50MzJfdCogaWRl bnRpZmllckNvdW50KQpJbmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv TmV0c2NhcGVQbHVnaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9QbHVn aW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcAkocmV2aXNpb24gNzQ1MzEpCisrKyBXZWJL aXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI0OSw2ICsyNDksMTggQEAgYm9vbCBOZXRzY2FwZVBsdWdpbjo6aXNBY2Nl bGVyYXRlZENvbXBvcwogI2VuZGlmCiB9CiAKK3ZvaWQgTmV0c2NhcGVQbHVnaW46OnB1c2hQb3B1 cHNFbmFibGVkU3RhdGUoYm9vbCBzdGF0ZSkKK3sKKyAgICBtX3BvcHVwRW5hYmxlZFN0YXRlcy5h cHBlbmQoc3RhdGUpOworfQorIAordm9pZCBOZXRzY2FwZVBsdWdpbjo6cG9wUG9wdXBzRW5hYmxl ZFN0YXRlKCkKK3sKKyAgICBBU1NFUlQoIW1fcG9wdXBFbmFibGVkU3RhdGVzLmlzRW1wdHkoKSk7 CisKKyAgICBtX3BvcHVwRW5hYmxlZFN0YXRlcy5yZW1vdmVMYXN0KCk7Cit9CisKIFN0cmluZyBO ZXRzY2FwZVBsdWdpbjo6cHJveGllc0ZvclVSTChjb25zdCBTdHJpbmcmIHVybFN0cmluZykKIHsK ICAgICByZXR1cm4gbV9wbHVnaW5Db250cm9sbGVyLT5wcm94aWVzRm9yVVJMKHVybFN0cmluZyk7 CkBAIC0zNzEsNyArMzgzLDEyIEBAIHZvaWQgTmV0c2NhcGVQbHVnaW46OnN0b3BBbGxTdHJlYW1z KCkKIAogYm9vbCBOZXRzY2FwZVBsdWdpbjo6YWxsb3dQb3B1cHMoKSBjb25zdAogewotICAgIC8v IEZJWE1FOiBIYW5kbGUgcG9wdXBzLgorICAgIGlmIChtX3BsdWdpbk1vZHVsZS0+cGx1Z2luRnVu Y3MoKS52ZXJzaW9uID49IE5QVkVSU19IQVNfUE9QVVBTX0VOQUJMRURfU1RBVEUpIHsKKyAgICAg ICAgaWYgKCFtX3BvcHVwRW5hYmxlZFN0YXRlcy5pc0VtcHR5KCkpCisgICAgICAgICAgICByZXR1 cm4gbV9wb3B1cEVuYWJsZWRTdGF0ZXMubGFzdCgpOworICAgIH0KKworICAgIC8vIEZJWE1FOiBD aGVjayBpZiB0aGUgY3VycmVudCBldmVudCBpcyBhIHVzZXIgZ2VzdHVyZS4KICAgICByZXR1cm4g ZmFsc2U7CiB9CiAKSW5kZXg6IFdlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05l dHNjYXBlUGx1Z2luLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMv TmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaAkocmV2aXNpb24gNzQ1MTUpCisrKyBXZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oCSh3b3JraW5nIGNvcHkp CkBAIC04Nyw2ICs4Nyw5IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaXNBY2NlbGVyYXRlZENvbXBv c2l0aW5nRW5hYmxlZCgpOwogCisgICAgdm9pZCBwdXNoUG9wdXBzRW5hYmxlZFN0YXRlKGJvb2wg ZW5hYmxlZCk7CisgICAgdm9pZCBwb3BQb3B1cHNFbmFibGVkU3RhdGUoKTsKKwogICAgIFN0cmlu ZyBwcm94aWVzRm9yVVJMKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nKTsKICAgICBTdHJpbmcgY29v a2llc0ZvclVSTChjb25zdCBTdHJpbmcmIHVybFN0cmluZyk7CiAgICAgdm9pZCBzZXRDb29raWVz Rm9yVVJMKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBTdHJpbmcmIGNvb2tpZVN0cmlu Zyk7CkBAIC0xOTUsNiArMTk4LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1faW5OUFBOZXc7CiAg ICAgYm9vbCBtX2xvYWRNYW51YWxseTsKICAgICBSZWZQdHI8TmV0c2NhcGVQbHVnaW5TdHJlYW0+ IG1fbWFudWFsU3RyZWFtOworICAgIFZlY3Rvcjxib29sLCA4PiBtX3BvcHVwRW5hYmxlZFN0YXRl czsKIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICBOUERyYXdpbmdNb2RlbCBtX2RyYXdpbmdNb2Rl bDsK