51529 2010-12-23 03:26:53 -0800 [EFL] Clean warnings in Tiled Backing Store 2010-12-23 06:08:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi commit-queue kenneth tonikitoo oldest_to_newest 326011 0 lucas.de.marchi 2010-12-23 03:26:53 -0800 [EFL] Clean warnings in Tiled Backing Store 326012 1 77320 lucas.de.marchi 2010-12-23 03:31:44 -0800 Created attachment 77320 Patch 326054 2 77320 commit-queue 2010-12-23 06:08:42 -0800 Comment on attachment 77320 Patch Clearing flags on attachment: 77320 Committed r74554: <http://trac.webkit.org/changeset/74554> 326055 3 commit-queue 2010-12-23 06:08:49 -0800 All reviewed patches have been landed. Closing bug. 77320 2010-12-23 03:31:44 -0800 2010-12-23 06:08:42 -0800 Patch bug-51529-20101223093141.patch text/plain 6397 lucas.de.marchi ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggYTg2NmJlMDYzNGQzODY1ZGJiOWNkOGU1NjVlODM0MDY4MTRkMWQ2MC4uYTNmOWU3YjA2 OTk0OWU3ZTJiMTNjNTZhNzk3Njg4ZGJkMGU5ZjllMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAx MC0xMi0yMyAgTHVjYXMgRGUgTWFyY2hpICA8bHVjYXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VGTF0g Q2xlYW4gd2FybmluZ3MgaW4gVGlsZWQgQmFja2luZyBTdG9yZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE1MjkKKworICAgICAgICBUaWxlZCBiYWNr aW5nIHN0b3JlIGluIEVGTCB3YXMgZ2l2aW5nIHRoZSBmb2xsb3dpbmcgd2FybmluZ3MgdGhhdCBh cmUKKyAgICAgICAgZ29uZSBub3c6CisKKyAgICAgICAgLSBTdGF0aWMgZnVuY3Rpb24gZGVmaW5l ZCBidXQgbm90IHVzZWQ7CisgICAgICAgIC0gQ29tcGFyaXNvbiBiZXR3ZWVuIHNpZ25lZCBhbmQg dW5zaWduZWQgaW50ZWdlciBleHByZXNzaW9uczsKKworICAgICAgICAqIGV3ay9ld2tfdGlsZWRf YmFja2luZ19zdG9yZS5jOgorICAgICAgICAoX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2l0ZW1f ZmlsbCk6CisgICAgICAgIChfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfc21hcnRfY2FsY3VsYXRl KToKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21hdHJpeC5jOgorICAgICAgICAoX2V3a190aWxl X21hdHJpeF9zbGljZXJfc2V0dXApOgorCiAyMDEwLTEyLTIzICBHeXV5b3VuZyBLaW0gIDxneXV5 b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCB3YXJuaW5n IGZpeC4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3Jl LmMgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5jCmluZGV4IGE5OThj NWMyOTllZTkwNzE0YzVkMGJmMDZlYjk4NGI2YjZlNTUzODAuLjRmYmQ5MDUxOWRlYzRhZDkwZDcz ZTUzMjBmNDViZTdjZDdkOGYwYzIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9iYWNraW5nX3N0b3JlLmMKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdf c3RvcmUuYwpAQCAtNDkxLDY2ICs0OTEsMTUgQEAgc3RhdGljIEVpbmFfQm9vbCBfZXdrX3RpbGVk X2JhY2tpbmdfc3RvcmVfZW5hYmxlX3JlbmRlcihFd2tfVGlsZWRfQmFja2luZ19TdG9yZV8KICAg ICByZXR1cm4gRUlOQV9UUlVFOwogfQogCi0vKioKLSAqIFJldHVybnMgYSByZWN0YW5nbGUgd2hv c2UgY29vcmRpbmF0ZXMgaW5kaWNhdGUgd2hpY2ggdGlsZXMgYXJlCi0gKiBjdXJyZW50bHkgaW5z aWRlIHRoZSB2aWV3cG9ydC4KLSAqCi0gKiBTcGVjaWZpY2FsbHksIHRoZSByZXR1cm5lZCByZWN0 YW5nbGUncyBjb29yZGluYXRlcyBoYXZlIHRoZQotICogZm9sbG93aW5nIG1lYW5pbmc6Ci0gKiAg LSB4OiBDb2x1bW4gbnVtYmVyIGZvciB0aGUgdG9wLWxldmVsIHRpbGUgaW5zaWRlIHRoZSB2aWV3 cG9ydC4KLSAqICAtIHk6IFJvdyBudW1iZXIgZm9yIHRoZSB0b3AtbGV2ZWwgdGlsZSBpbnNpZGUg dGhlIHZpZXdwb3J0LgotICogIC0gdzogTnVtYmVyIG9mIHRpbGVzIGhvcml6b250YWxseSBpbnNp ZGUgdGhlIHZpZXdwb3J0LgotICogIC0gaDogTnVtYmVyIG9mIHRpbGVzIHZlcnRpY2FsbHkgaW5z aWRlIHRoZSB2aWV3cG9ydC4KLSAqLwotc3RhdGljIEVpbmFfUmVjdGFuZ2xlIF9ld2tfdGlsZWRf YmFja2luZ19zdG9yZV92aXNpYmxlX3RpbGVzX3JlY3QoRXdrX1RpbGVkX0JhY2tpbmdfU3RvcmVf RGF0YSAqcHJpdikKLXsKLSAgICAgRWluYV9SZWN0YW5nbGUgcjsKLQotICAgICBjb25zdCBFdmFz X0Nvb3JkIG94ID0gLXByaXYtPnZpZXcub2Zmc2V0LmN1ci54OwotICAgICBjb25zdCBFdmFzX0Nv b3JkIG95ID0gLXByaXYtPnZpZXcub2Zmc2V0LmN1ci55OwotICAgICBjb25zdCBFdmFzX0Nvb3Jk IHR3ID0gcHJpdi0+dmlldy50aWxlLnc7Ci0gICAgIGNvbnN0IEV2YXNfQ29vcmQgdGggPSBwcml2 LT52aWV3LnRpbGUuaDsKLQotICAgICByLnggPSBNQVgoMCwgb3ggLyB0dyk7Ci0gICAgIHIueSA9 IE1BWCgwLCBveSAvIHRoKTsKLSAgICAgci53ID0gTUlOKHByaXYtPm1vZGVsLmN1ci5jb2xzLAot ICAgICAgICAgICAgICAgY2VpbCgoZmxvYXQpKHByaXYtPnZpZXcudyArIChveCAlIHR3KSkgLyB0 dykpOwotICAgICByLmggPSBNSU4ocHJpdi0+bW9kZWwuY3VyLnJvd3MsCi0gICAgICAgICAgICAg ICBjZWlsKChmbG9hdCkocHJpdi0+dmlldy5oICsgKG95ICUgdGgpKSAvIHRoKSk7Ci0KLSAgICAg REJHKCJSZXR1cm5pbmcgJWQsJWQrJWR4JWQiLCByLngsIHIueSwgci53LCByLmgpOwotCi0gICAg IHJldHVybiByOwotfQotCi1zdGF0aWMgRWluYV9Cb29sIF9ld2tfdGlsZWRfYmFja2luZ19zdG9y ZV90aWxlX2lzX2luc2lkZV92aWV3cG9ydChFd2tfVGlsZWRfQmFja2luZ19TdG9yZV9EYXRhICpw cml2LCBpbnQgY29sLCBpbnQgcm93KQotewotICAgIGNvbnN0IEVpbmFfUmVjdGFuZ2xlIHIgPSBf ZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfdmlzaWJsZV90aWxlc19yZWN0KHByaXYpOwotCi0gICAg cmV0dXJuIGVpbmFfcmVjdGFuZ2xlX2Nvb3Jkc19pbnNpZGUoJnIsIGNvbCwgcm93KTsKLX0KLQot c3RhdGljIEVpbmFfQm9vbCBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfdGlsZV9pc19hZGphY2Vu dF90b192aWV3cG9ydChFd2tfVGlsZWRfQmFja2luZ19TdG9yZV9EYXRhICpwcml2LCBpbnQgY29s LCBpbnQgcm93KQotewotICAgIGNvbnN0IEVpbmFfUmVjdGFuZ2xlIHIgPSBfZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmVfdmlzaWJsZV90aWxlc19yZWN0KHByaXYpOwotCi0gICAgaWYgKHJvdyA9PSAo ci55IC0gMSkgfHwgcm93ID09IChyLnkgKyByLmgpKQotICAgICAgICByZXR1cm4gKGNvbCA+PSAo ci54IC0gMSkgJiYgY29sIDw9IChyLnggKyByLncpKTsKLQotICAgIGlmIChjb2wgPT0gKHIueCAt IDEpIHx8IGNvbCA9PSAoci54ICsgci53KSkKLSAgICAgICAgcmV0dXJuIChyb3cgPj0gKHIueSAt IDEpICYmIHJvdyA8PSAoci55ICsgci5oKSk7Ci0KLSAgICByZXR1cm4gRUlOQV9GQUxTRTsKLX0K LQogc3RhdGljIGlubGluZSBFaW5hX0Jvb2wgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2l0ZW1f ZmlsbChFd2tfVGlsZWRfQmFja2luZ19TdG9yZV9EYXRhICpwcml2LCBFd2tfVGlsZWRfQmFja2lu Z19TdG9yZV9JdGVtICppdCwgbG9uZyBjb2wsIGludCByb3cpCiB7Ci0gICAgaW50IG1fY29sID0g cHJpdi0+bW9kZWwuYmFzZS5jb2wgKyBjb2w7Ci0gICAgaW50IG1fcm93ID0gcHJpdi0+bW9kZWwu YmFzZS5yb3cgKyByb3c7CisgICAgbG9uZyBtX2NvbCA9IHByaXYtPm1vZGVsLmJhc2UuY29sICsg Y29sOworICAgIGxvbmcgbV9yb3cgPSBwcml2LT5tb2RlbC5iYXNlLnJvdyArIHJvdzsKICAgICBk b3VibGUgbGFzdF91c2VkID0gZWNvcmVfbG9vcF90aW1lX2dldCgpOwogCiAgICAgaWYgKG1fY29s IDwgMCB8fCBtX3JvdyA8IDAKLSAgICAgICAgfHwgbV9jb2wgPj0gcHJpdi0+bW9kZWwuY3VyLmNv bHMgfHwgbV9yb3cgPj0gcHJpdi0+bW9kZWwuY3VyLnJvd3MpIHsKKyAgICAgICAgfHwgKHVuc2ln bmVkIGxvbmcpKG1fY29sKSA+PSBwcml2LT5tb2RlbC5jdXIuY29scworICAgICAgICB8fCAodW5z aWduZWQgbG9uZykobV9yb3cpID49IHByaXYtPm1vZGVsLmN1ci5yb3dzKSB7CiAKICAgICAgICAg aWYgKGl0LT50aWxlKSB7CiAgICAgICAgICAgICBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfdGls ZV9kaXNzb2NpYXRlKHByaXYsIGl0LCBsYXN0X3VzZWQpOwpAQCAtNTYyLDggKzUxMSw4IEBAIHN0 YXRpYyBpbmxpbmUgRWluYV9Cb29sIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9pdGVtX2ZpbGwo RXdrX1RpbGVkX0JhY2tpbmdfU3RvCiAgICAgICAgIGNvbnN0IGZsb2F0IHpvb20gPSBwcml2LT52 aWV3LnRpbGUuem9vbTsKIAogICAgICAgICBpZiAoaXQtPnVwZGF0ZS5wcm9jZXNzKSB7Ci0gICAg ICAgICAgICBpZiAoaXQtPnVwZGF0ZS5yb3cgPT0gbV9yb3cKLSAgICAgICAgICAgICAgICAmJiBp dC0+dXBkYXRlLmNvbCA9PSBtX2NvbAorICAgICAgICAgICAgaWYgKGl0LT51cGRhdGUucm93ID09 ICh1bnNpZ25lZCBsb25nKShtX3JvdykKKyAgICAgICAgICAgICAgICAmJiBpdC0+dXBkYXRlLmNv bCA9PSAodW5zaWduZWQgbG9uZykobV9jb2wpCiAgICAgICAgICAgICAgICAgJiYgaXQtPnVwZGF0 ZS56b29tID09IHpvb20pCiAgICAgICAgICAgICAgICAgcmV0dXJuIEVJTkFfVFJVRTsKIApAQCAt NTcyLDEyICs1MjEsMTUgQEAgc3RhdGljIGlubGluZSBFaW5hX0Jvb2wgX2V3a190aWxlZF9iYWNr aW5nX3N0b3JlX2l0ZW1fZmlsbChFd2tfVGlsZWRfQmFja2luZ19TdG8KIAogICAgICAgICBpZiAo aXQtPnRpbGUpIHsKICAgICAgICAgICAgIEV3a19UaWxlICpvbGQgPSBpdC0+dGlsZTsKLSAgICAg ICAgICAgIGlmIChvbGQtPnJvdyAhPSBtX3JvdyB8fCBvbGQtPmNvbCAhPSBtX2NvbCB8fCBvbGQt Pnpvb20gIT0gem9vbSkgeworICAgICAgICAgICAgaWYgKG9sZC0+cm93ICE9ICh1bnNpZ25lZCBs b25nKShtX3JvdykKKyAgICAgICAgICAgICAgICB8fCBvbGQtPmNvbCAhPSAodW5zaWduZWQgbG9u ZykobV9jb2wpCisgICAgICAgICAgICAgICAgfHwgb2xkLT56b29tICE9IHpvb20pIHsKICAgICAg ICAgICAgICAgICBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfdGlsZV9kaXNzb2NpYXRlKHByaXYs IGl0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbGFzdF91c2VkKTsKICAgICAgICAgICAgICAgICBpZiAoaXQtPnVwZGF0ZS5wcm9jZXNz KQogICAgICAgICAgICAgICAgICAgICBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9yZXF1 ZXN0X2RlbChwcml2LCBpdCk7Ci0gICAgICAgICAgICB9IGVsc2UgaWYgKG9sZC0+cm93ID09IG1f cm93ICYmIG9sZC0+Y29sID09IG1fY29sCisgICAgICAgICAgICB9IGVsc2UgaWYgKG9sZC0+cm93 ID09ICh1bnNpZ25lZCBsb25nKShtX3JvdykKKyAgICAgICAgICAgICAgICAgICAgICAgJiYgb2xk LT5jb2wgPT0gKHVuc2lnbmVkIGxvbmcpKG1fY29sKQogICAgICAgICAgICAgICAgICAgICAgICAm JiBvbGQtPnpvb20gPT0gem9vbSkKICAgICAgICAgICAgICAgICBnb3RvIGVuZDsKICAgICAgICAg fQpAQCAtMTQ1MCw3ICsxNDAyLDcgQEAgc3RhdGljIHZvaWQgX2V3a190aWxlZF9iYWNraW5nX3N0 b3JlX3NtYXJ0X2NhbGN1bGF0ZShFdmFzX09iamVjdCAqbykKICAgICBld2tfdGlsZV9tYXRyaXhf ZnJlZXplKHByaXYtPm1vZGVsLm1hdHJpeCk7CiAKICAgICBpZiAoIXByaXYtPnJlbmRlci5zdXNw ZW5kICYmIHByaXYtPmNoYW5nZWQubW9kZWwpIHsKLSAgICAgICAgbG9uZyBjb2xzLCByb3dzOwor ICAgICAgICB1bnNpZ25lZCBsb25nIGNvbHMsIHJvd3M7CiAKICAgICAgICAgY29scyA9IHByaXYt Pm1vZGVsLndpZHRoIC8gcHJpdi0+dmlldy50aWxlLncgKyAxOwogICAgICAgICByb3dzID0gcHJp di0+bW9kZWwuaGVpZ2h0IC8gcHJpdi0+dmlldy50aWxlLmggKyAxOwpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJpeC5jIGIvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVk X21hdHJpeC5jCmluZGV4IGZjY2JmYTEwOTI2M2RiNzRkYWYzYWM1NDMxOTA2OTY0NTZhYjhiNzEu LjEzMGE0OGFjODg2ZWE2N2FkNWQ5NTY0MDhhZjQ2ODcyOWMzNGVmMjEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9lZmwvZXdrL2V3a190aWxlZF9tYXRyaXguYworKysgYi9XZWJLaXQvZWZsL2V3ay9ld2tf dGlsZWRfbWF0cml4LmMKQEAgLTYwMCw5ICs2MDAsOSBAQCBzdGF0aWMgRWluYV9Cb29sIF9ld2tf dGlsZV9tYXRyaXhfc2xpY2VyX3NldHVwKEV3a19UaWxlX01hdHJpeCAqdG0sIGNvbnN0IEVpbmFf UgogICAgICAgICB5ID0gMDsKICAgICB9CiAKLSAgICBpZiAoeSArIGggLSAxID4gcm93cyAqIHRo KQorICAgIGlmICh5ICsgaCAtIDEgPiAobG9uZykocm93cyAqIHRoKSkKICAgICAgICAgaCA9IHJv d3MgKiB0aCAtIHk7Ci0gICAgaWYgKHggKyB3IC0gMSA+IGNvbHMgKiB0dykKKyAgICBpZiAoeCAr IHcgLSAxID4gKGxvbmcpKGNvbHMgKiB0dykpCiAgICAgICAgIHcgPSBjb2xzICogdHcgLSB4Owog CiAgICAgcmV0dXJuIGVpbmFfdGlsZV9ncmlkX3NsaWNlcl9zZXR1cChzbGljZXIsIHgsIHksIHcs IGgsIHR3LCB0aCk7Cg==