51528 2010-12-23 03:02:15 -0800 [v8] ScriptController::evaluate returns empty result for undefined. Can't distinguish errors from undefined results. 2011-03-01 01:00:18 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 tom.rathbone webkit-unassigned anthony.taranto magreenblatt yurys oldest_to_newest 326006 0 tom.rathbone 2010-12-23 03:02:15 -0800 ScriptController::evaluate contains: if (object.IsEmpty() || object->IsUndefined()) return ScriptValue(); Should be: if (object.IsEmpty()) return ScriptValue(); Returning an empty ScriptValue should indicate an error. As undefined is a valid return value for void calls returning an empty ScriptValue makes it impossible to distinguish undefined results from errors. Related mailing list thread: https://lists.webkit.org/pipermail/webkit-dev/2010-December/015417.html 326060 1 77331 tom.rathbone 2010-12-23 06:39:17 -0800 Created attachment 77331 fix, allow the "undefined" v8 object to be returned 330850 2 magreenblatt 2011-01-07 10:29:08 -0800 Hi Yury, please review this patch. 332216 3 77331 eric 2011-01-11 03:08:49 -0800 Comment on attachment 77331 fix, allow the "undefined" v8 object to be returned This patch was not created correctly. Please create from a WebKit checkout. Also, all patches require a ChangeLog. webkit-patch upload will walk you through much of this. 332236 4 yurys 2011-01-11 03:30:55 -0800 Hi Tom, please add proper ChangeLog entry to the patch as Eric suggested, otherwise the change looks good to me. (In reply to comment #2) > Hi Yury, please review this patch. 355470 5 83357 anthony.taranto 2011-02-22 12:04:55 -0800 Created attachment 83357 Patch 355472 6 anthony.taranto 2011-02-22 12:06:50 -0800 Generated a patch with webkit-patch upload and included a ChangeLog. Let me know if anything else is needed. 358114 7 magreenblatt 2011-02-25 12:16:56 -0800 Can someone add this patch to the commit queue? Thanks. 359736 8 83357 yurys 2011-03-01 01:00:11 -0800 Comment on attachment 83357 Patch Clearing flags on attachment: 83357 Committed r79981: <http://trac.webkit.org/changeset/79981> 359737 9 yurys 2011-03-01 01:00:18 -0800 All reviewed patches have been landed. Closing bug. 77331 2010-12-23 06:39:17 -0800 2011-03-01 00:57:05 -0800 fix, allow the "undefined" v8 object to be returned 51528-fix.patch text/plain 511 tom.rathbone SW5kZXg6IHNyYy90aGlyZF9wYXJ0eS9XZWJLaXQvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRD b250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcmMvdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNv cmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDc0MTgyKQorKysg c3JjL3RoaXJkX3BhcnR5L1dlYktpdC9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xs ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTcsNyArMjU3LDcgQEAKIAogICAgIG1fc291cmNl VVJMID0gc2F2ZWRTb3VyY2VVUkw7CiAKLSAgICBpZiAob2JqZWN0LklzRW1wdHkoKSB8fCBvYmpl Y3QtPklzVW5kZWZpbmVkKCkpCisgICAgaWYgKG9iamVjdC5Jc0VtcHR5KCkpCiAgICAgICAgIHJl dHVybiBTY3JpcHRWYWx1ZSgpOwogCiAgICAgcmV0dXJuIFNjcmlwdFZhbHVlKG9iamVjdCk7Cg== 83357 2011-02-22 12:04:55 -0800 2011-03-01 01:00:11 -0800 Patch bug-51528-20110216114639.patch text/plain 1232 anthony.taranto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjYWEyMTYyZjk4NWQ5YWYwNzNhYzJhYzllYmQ1ZTk5NTE2YzA5ZjMwLi5m MzFhMDE5NTVlZjkzNDI1Yjk5Y2M3MGM4Njc1ZjBkMjUzMjg3NWNiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTEgQEAKKzIwMTEtMDItMTYgIGFudGhvbnkgdGFyYW50byAgPGFudGhvbnkudGFyYW50 b0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV0dXJuIHVuZGVmaW5lZCB2YWx1ZSBmcm9tIFNjcmlw dENvbnRyb2xsZXI6OmV2YWx1YXRlKCksIGFsbG93aW5nIHRoZQorICAgICAgICBjYWxsZXIgdG8g ZGlzdGluZ3Vpc2ggYmV0d2VlbiBhbiBlcnJvciBhbmQgYW4gdW5kZWZpbmVkIHJldHVybiB2YWx1 ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNTI4 CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcDogCisKIDIwMTEt MDItMTUgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggRUZM IGJ1aWxkIGZvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9s bGVyLmNwcAppbmRleCA1ZDE3NWIzZGIyMzlkNTJlMWMyYTUxMTNiMTlhYzRiYmQxYTY2MzhjLi44 YTFlNGM2YjIwZTliMmJjNDY1ZDc2NjQzOTgwNDYwMzgxOWY1NWE1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcApAQCAtMjQwLDcgKzI0MCw3 IEBAIFNjcmlwdFZhbHVlIFNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKGNvbnN0IFNjcmlwdFNv dXJjZUNvZGUmIHNvdXJjZUNvZGUpCiAKICAgICBtX3NvdXJjZVVSTCA9IHNhdmVkU291cmNlVVJM OwogCi0gICAgaWYgKG9iamVjdC5Jc0VtcHR5KCkgfHwgb2JqZWN0LT5Jc1VuZGVmaW5lZCgpKQor ICAgIGlmIChvYmplY3QuSXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gU2NyaXB0VmFsdWUoKTsK IAogICAgIHJldHVybiBTY3JpcHRWYWx1ZShvYmplY3QpOwo=