51520 2010-12-22 21:41:42 -0800 [EFL] Remove warning messages during the webkit efl compiling 2010-12-23 00:17:34 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim antognolli+webkit commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 325891 0 gyuyoung.kim 2010-12-22 21:41:42 -0800 There are warning messages during the webkit efl compiling. I fix them except for tiled backing store files. Because, I think they should be fixed by the tiled backing store owner. [100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_tiled_backing_store.c.o [100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_tiled_matrix.c.o /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c: In function ‘_ewk_tiled_backing_store_item_fill’: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:553: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:553: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:566: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:567: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:575: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:575: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:580: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:581: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c: In function ‘_ewk_tiled_backing_store_smart_calculate’: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:1462: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:1464: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c: At top level: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:526: warning: ‘_ewk_tiled_backing_store_tile_is_inside_viewport’ defined but not used /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:533: warning: ‘_ewk_tiled_backing_store_tile_is_adjacent_to_viewport’ defined but not used /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_matrix.c: In function ‘_ewk_tile_matrix_slicer_setup’: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_matrix.c:603: warning: comparison between signed and unsigned integer expressions /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_matrix.c:605: warning: comparison between signed and unsigned integer expressions [100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_tiled_model.c.o [100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_util.cpp.o [100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view.cpp.o [100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view_single.c.o /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:31: warning: missing initializer /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:31: warning: (near initialization for ‘_parent_sc.navigation_policy_decision’) /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c: In function ‘_ewk_view_single_smart_class_new’: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:569: warning: missing initializer /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:569: warning: (near initialization for ‘api.navigation_policy_decision’) [100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view_tiled.c.o [100%] /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:30: warning: missing initializer /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:30: warning: (near initialization for ‘_parent_sc.navigation_policy_decision’) Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_window_features.cpp.o /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c: In function ‘_ewk_view_tiled_smart_class_new’: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:274: warning: missing initializer /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:274: warning: (near initialization for ‘api.navigation_policy_decision’) /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp: In function ‘void _ewk_view_smart_show(Evas_Object*)’: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp:867: warning: unused variable ‘priv’ /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp: In function ‘void _ewk_view_smart_hide(Evas_Object*)’: /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp:877: warning: unused variable ‘priv’ Linking CXX shared library libewebkit.so [100%] Built target ewebkit Scanning dependencies of target EWebLauncher [100%] Building C object CMakeFiles/Programs/EWebLauncher.dir/Tools/EWebLauncher/main.c.o Linking CXX executable Programs/EWebLauncher [100%] Built target Programs/EWebLauncher 325892 1 77304 gyuyoung.kim 2010-12-22 21:43:49 -0800 Created attachment 77304 Patch 325907 2 77304 commit-queue 2010-12-22 23:27:37 -0800 Comment on attachment 77304 Patch Rejecting attachment 77304 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77304]" exit_code: 1 Last 500 characters of output: =edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=51520&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 77304 from bug 51520. NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/WebKit/efl/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/7323097 325911 3 77310 gyuyoung.kim 2010-12-22 23:40:23 -0800 Created attachment 77310 Patch 325926 4 77310 commit-queue 2010-12-23 00:17:27 -0800 Comment on attachment 77310 Patch Clearing flags on attachment: 77310 Committed r74542: <http://trac.webkit.org/changeset/74542> 325927 5 commit-queue 2010-12-23 00:17:34 -0800 All reviewed patches have been landed. Closing bug. 77304 2010-12-22 21:43:49 -0800 2010-12-22 23:40:23 -0800 Patch patch-warningmsg.patch text/plain 2180 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggZmRlOWZlYS4uMTQyNWFmOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMC0xMi0yMiAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJlbW92ZSB3YXJuaW5nIG1l c3NhZ2VzIGR1cmluZyB0aGUgd2Via2l0IGVmbCBjb21waWxpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNTIwCisKKyAgICAgICAgUmVtb3ZlIGJ1 aWxkIHdhcm5pbmcgbWVzc2FnZXMuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAg ICAgICAoX2V3a192aWV3X3NtYXJ0X3Nob3cpOgorICAgICAgICAoX2V3a192aWV3X3NtYXJ0X2hp ZGUpOgorICAgICAgICAqIGV3ay9ld2tfdmlldy5oOgorCisyMDEwLTEyLTIyICBHeXV5b3VuZyBL aW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50 b25pbyBHb21lcy4KIAogICAgICAgICBbRUZMXSBTZXRzIGRlZmF1bHQgdXNlciBhZ2VudApkaWZm IC0tZ2l0IGEvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwCmluZGV4IDllZWU5Y2IuLjhkMzQ1OGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcAorKysgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTg2 NCw3ICs4NjQsNiBAQCBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfc21hcnRfY2FsY3VsYXRlKEV2YXNf T2JqZWN0KiBvKQogc3RhdGljIHZvaWQgX2V3a192aWV3X3NtYXJ0X3Nob3coRXZhc19PYmplY3Qg Km8pCiB7CiAgICAgRVdLX1ZJRVdfU0RfR0VUKG8sIHNkKTsKLSAgICBFV0tfVklFV19QUklWX0dF VChzZCwgcHJpdik7CiAKICAgICBpZiAoZXZhc19vYmplY3RfY2xpcGVlc19nZXQoc2QtPmJhc2Uu Y2xpcHBlcikpCiAgICAgICAgIGV2YXNfb2JqZWN0X3Nob3coc2QtPmJhc2UuY2xpcHBlcik7CkBA IC04NzQsNyArODczLDYgQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3NtYXJ0X3Nob3coRXZhc19P YmplY3QgKm8pCiBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfc21hcnRfaGlkZShFdmFzX09iamVjdCAq bykKIHsKICAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOwotICAgIEVXS19WSUVXX1BSSVZfR0VU KHNkLCBwcml2KTsKIAogICAgIGV2YXNfb2JqZWN0X2hpZGUoc2QtPmJhc2UuY2xpcHBlcik7CiAg ICAgZXZhc19vYmplY3RfaGlkZShzZC0+YmFja2luZ19zdG9yZSk7CmRpZmYgLS1naXQgYS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAppbmRleCA2 OTAyOTQ5Li5lNDg3ZjVlIDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCisr KyBiL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAgLTE1NSw3ICsxNTUsNyBAQCBzdHJ1Y3Qg X0V3a19WaWV3X1NtYXJ0X0NsYXNzIHsKICAqIEBzZWUgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5J VF9WRVJTSU9OCiAgKiBAc2VlIEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFNRV9WRVJTSU9O CiAgKi8KLSNkZWZpbmUgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVChzbWFydF9jbGFzc19pbml0 KSB7c21hcnRfY2xhc3NfaW5pdCwgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfVkVSU0lPTiwgMCwgMCwg MCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwg MCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMH0KKyNkZWZpbmUgRVdLX1ZJRVdfU01BUlRfQ0xB U1NfSU5JVChzbWFydF9jbGFzc19pbml0KSB7c21hcnRfY2xhc3NfaW5pdCwgRVdLX1ZJRVdfU01B UlRfQ0xBU1NfVkVSU0lPTiwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwg MCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMH0K IAogLyoqCiAgKiBJbml0aWFsaXplciB0byB6ZXJvIGEgd2hvbGUgRXdrX1ZpZXdfU21hcnRfQ2xh c3Mgc3RydWN0dXJlLgo= 77310 2010-12-22 23:40:23 -0800 2010-12-23 00:17:27 -0800 Patch patch-warningmsg.patch text/plain 2182 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggZmRlOWZlYS4uNGQ1Y2UyZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMC0xMi0yMiAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCisgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGQgd2FybmluZyBmaXguCisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIHdhcm5pbmcg bWVzc2FnZXMgZHVyaW5nIHRoZSB3ZWJraXQgZWZsIGNvbXBpbGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE1MjAKKworICAgICAgICBSZW1vdmUg YnVpbGQgd2FybmluZyBtZXNzYWdlcy4KKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6Cisg ICAgICAgIChfZXdrX3ZpZXdfc21hcnRfc2hvdyk6CisgICAgICAgIChfZXdrX3ZpZXdfc21hcnRf aGlkZSk6CisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKKzIwMTAtMTItMjIgIEd5dXlvdW5n IEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBB bnRvbmlvIEdvbWVzLgogCiAgICAgICAgIFtFRkxdIFNldHMgZGVmYXVsdCB1c2VyIGFnZW50CmRp ZmYgLS1naXQgYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5jcHAKaW5kZXggOWVlZTljYi4uOGQzNDU4ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAt ODY0LDcgKzg2NCw2IEBAIHN0YXRpYyB2b2lkIF9ld2tfdmlld19zbWFydF9jYWxjdWxhdGUoRXZh c19PYmplY3QqIG8pCiBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfc21hcnRfc2hvdyhFdmFzX09iamVj dCAqbykKIHsKICAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOwotICAgIEVXS19WSUVXX1BSSVZf R0VUKHNkLCBwcml2KTsKIAogICAgIGlmIChldmFzX29iamVjdF9jbGlwZWVzX2dldChzZC0+YmFz ZS5jbGlwcGVyKSkKICAgICAgICAgZXZhc19vYmplY3Rfc2hvdyhzZC0+YmFzZS5jbGlwcGVyKTsK QEAgLTg3NCw3ICs4NzMsNiBAQCBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfc21hcnRfc2hvdyhFdmFz X09iamVjdCAqbykKIHN0YXRpYyB2b2lkIF9ld2tfdmlld19zbWFydF9oaWRlKEV2YXNfT2JqZWN0 ICpvKQogewogICAgIEVXS19WSUVXX1NEX0dFVChvLCBzZCk7Ci0gICAgRVdLX1ZJRVdfUFJJVl9H RVQoc2QsIHByaXYpOwogCiAgICAgZXZhc19vYmplY3RfaGlkZShzZC0+YmFzZS5jbGlwcGVyKTsK ICAgICBldmFzX29iamVjdF9oaWRlKHNkLT5iYWNraW5nX3N0b3JlKTsKZGlmZiAtLWdpdCBhL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmggYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmluZGV4 IDY5MDI5NDkuLmU0ODdmNWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgK KysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaApAQCAtMTU1LDcgKzE1NSw3IEBAIHN0cnVj dCBfRXdrX1ZpZXdfU21hcnRfQ2xhc3MgewogICogQHNlZSBFV0tfVklFV19TTUFSVF9DTEFTU19J TklUX1ZFUlNJT04KICAqIEBzZWUgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9OQU1FX1ZFUlNJ T04KICAqLwotI2RlZmluZSBFV0tfVklFV19TTUFSVF9DTEFTU19JTklUKHNtYXJ0X2NsYXNzX2lu aXQpIHtzbWFydF9jbGFzc19pbml0LCBFV0tfVklFV19TTUFSVF9DTEFTU19WRVJTSU9OLCAwLCAw LCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAw LCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwfQorI2RlZmluZSBFV0tfVklFV19TTUFSVF9D TEFTU19JTklUKHNtYXJ0X2NsYXNzX2luaXQpIHtzbWFydF9jbGFzc19pbml0LCBFV0tfVklFV19T TUFSVF9DTEFTU19WRVJTSU9OLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAw LCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAwLCAw fQogCiAvKioKICAqIEluaXRpYWxpemVyIHRvIHplcm8gYSB3aG9sZSBFd2tfVmlld19TbWFydF9D bGFzcyBzdHJ1Y3R1cmUuCg==