51517 2010-12-22 19:30:47 -0800 RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line 2012-10-09 12:08:20 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED HasReduction P2 Normal --- 1 kalman webkit-unassigned abarth eric kadam mitz ossy playmobil rniwa tonikitoo webkit.review.bot xji yael oldest_to_newest 325857 0 kalman 2010-12-22 19:30:47 -0800 To reproduce, run the attached test case. The cursor should be at the end (i.e. right side, since this is RTL) of the 2nd line, but instead is after the 1st character on the /left/ of the 2nd line. The test can also be reproduced by pressing down (when the cursor is at the rightmost position of the 1st line in the div). Another observation (probably unrelated): it seems like it's impossible to actually select the start (right) of the text using the mouse, you need to select somewhere else then navigate with arrow keys. Another observation (probably related): the qt linux build behaves the worst, it isn't even possible to place the cursor on the rightmost position. A similar bug exists when using hebrew rather than english text, see second attachment, and it seems the behaviour diverges depending on build. - chromium linux/mac and gtk: cursor is on the left side of the 1st line - qt linux: cursor is after the 1st character on the left side of the 2nd line Both of which are wrong. 325858 1 77298 kalman 2010-12-22 19:31:44 -0800 Created attachment 77298 Test case with english text 325860 2 77299 kalman 2010-12-22 19:32:14 -0800 Created attachment 77299 Test case with hebrew text 338977 3 ossy 2011-01-24 06:35:45 -0800 I removed the "expected fail" and added the failing test to the Qt Skipped file: http://trac.webkit.org/changeset/76513 339039 4 webkit.review.bot 2011-01-24 08:46:33 -0800 http://trac.webkit.org/changeset/76513 might have broken GTK Linux 32-bit Debug The following tests are not passing: editing/selection/extend-selection-bidi.html 733564 5 kadam 2012-10-03 04:37:01 -0700 Is Anybody working this bug? 733977 6 166949 tullio.lucena 2012-10-03 13:20:32 -0700 Created attachment 166949 Unskipping test The problem of this test is with Hebrew fonts. With this change [1] in testfonts, it's passing. [1] https://gitorious.org/qtwebkit/testfonts/merge_requests/1 738037 7 166949 webkit.review.bot 2012-10-09 12:08:15 -0700 Comment on attachment 166949 Unskipping test Clearing flags on attachment: 166949 Committed r130787: <http://trac.webkit.org/changeset/130787> 738038 8 webkit.review.bot 2012-10-09 12:08:20 -0700 All reviewed patches have been landed. Closing bug. 77298 2010-12-22 19:31:44 -0800 2010-12-22 19:31:44 -0800 Test case with english text move-down-by-line-rtl.html text/html 1825 kalman PCFET0NUWVBFIGh0bWw+Cjxib2R5Pgo8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KPHNjcmlwdD4K ZnVuY3Rpb24gbG9nKHMpIHsKICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIiku aW5uZXJIVE1MICs9IHMgKyAiXG4iOwp9CgpmdW5jdGlvbiBjcmVhdGVFZGl0YWJsZU11bHRpbGlu ZURpdih0ZXh0LCBudW1MaW5lcykgewogICAgLy8gUHV0IHRleHQgaW4gYSBzcGFuIHNvIHRoYXQg dGhlIHdpZHRoIGNhbiBiZSBtZWFzdXJlZC4KICAgIHZhciBzcGFuID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgic3BhbiIpOwogICAgc3Bhbi5pbm5lckhUTUwgPSB0ZXh0OwogICAgZG9jdW1lbnQu Ym9keS5hcHBlbmRDaGlsZChzcGFuKTsKICAgIHZhciB3aWR0aFB4ID0gc3Bhbi5vZmZzZXRXaWR0 aDsKICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQoc3Bhbik7CgogICAgLy8gTWFrZSBkaXYg d2l0aCB0aG9zZSBkaW1lbnNpb25zIHNvIHRoYXQgdGhlIHRleHQgd3JhcHMgcHJlZGljdGFibHkg cmVnYXJkbGVzcyBvZiBwbGF0Zm9ybS4KICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCJkaXYiKTsKICAgIGRpdi5zZXRBdHRyaWJ1dGUoInN0eWxlIiwgIndpZHRoOiAiICsgd2lk dGhQeCArICJweCIpOwogICAgZGl2LmNvbnRlbnRFZGl0YWJsZSA9IHRydWU7CiAgICBmb3IgKHZh ciBpID0gMDsgaSA8IG51bUxpbmVzOyBpKyspCiAgICAgICAgZGl2LmFwcGVuZENoaWxkKGRvY3Vt ZW50LmNyZWF0ZVRleHROb2RlKHRleHQgKyAiICIpKTsKCiAgICByZXR1cm4gZGl2Owp9CgpmdW5j dGlvbiB1bmVzY2FwZVJ0bChydGxUZXh0KSB7CiAgICB2YXIgZSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoInNwYW4iKTsKICAgIGUuaW5uZXJIVE1MID0gcnRsVGV4dDsKICAgIHJldHVybiBlLmlu bmVySFRNTDsKfQoKcnRsVGV4dCA9IHVuZXNjYXBlUnRsKCImI3gwNUU5OyYjeDA1RDU7JiN4MDVC QzsmI3gwNUU4OyYjeDA1RDQ7ICIgKwogICAgICAgICAgICAgICAgICAgICAgIiYjeDA1RTk7JiN4 MDVENTsmI3gwNUJDOyYjeDA1RTg7JiN4MDVENDsgIiArCiAgICAgICAgICAgICAgICAgICAgICAi JiN4MDVFOTsmI3gwNUQ1OyYjeDA1QkM7JiN4MDVFODsmI3gwNUQ0OyIpOwovLyBCdWdzIGV4aXN0 IGJvdGggd2l0aCBwbGFpbiB0ZXh0IGFuZCBoZWJyZXcgdGV4dC4gIEl0J3MgZWFzaWVyIHRvIHNl ZSB3aXRoIHBsYWluIHRleHQuCnJ0bFRleHQgPSAidGhlIHF1aWNrIGJyb3duIGZveCI7CnJ0bFRl eHRDb250YWluZXIgPSBjcmVhdGVFZGl0YWJsZU11bHRpbGluZURpdihydGxUZXh0LCAzKTsKcnRs VGV4dENvbnRhaW5lci5zZXRBdHRyaWJ1dGUoImRpciIsICJydGwiKTsKZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChydGxUZXh0Q29udGFpbmVyKTsKCmxvZygiRllJOiBydGxUZXh0ICgiICsgcnRs VGV4dCArICIpIGhhcyBsZW5ndGggIiArIHJ0bFRleHQubGVuZ3RoKTsKZ2V0U2VsZWN0aW9uKCku c2V0UG9zaXRpb24ocnRsVGV4dENvbnRhaW5lci5jaGlsZE5vZGVzWzBdLCAwKTsKbG9nKCJTZWxl Y3Rpb24gaGFzIG9mZnNldCAiICsgZ2V0U2VsZWN0aW9uKCkuYW5jaG9yT2Zmc2V0KTsKZ2V0U2Vs ZWN0aW9uKCkubW9kaWZ5KCJtb3ZlIiwgImZvcndhcmQiLCAibGluZSIpOwpsb2coIlNlbGVjdGlv biBoYXMgb2Zmc2V0ICIgKyBnZXRTZWxlY3Rpb24oKS5hbmNob3JPZmZzZXQpOwoKcnRsVGV4dENv bnRhaW5lci5vbmtleXVwID0gZnVuY3Rpb24oKSB7CiAgICBsb2coIlNlbGVjdGlvbiBoYXMgb2Zm c2V0ICIgKyBnZXRTZWxlY3Rpb24oKS5hbmNob3JPZmZzZXQpOwp9Cjwvc2NyaXB0Pgo8L2JvZHk+ Cg== 77299 2010-12-22 19:32:14 -0800 2010-12-22 19:32:14 -0800 Test case with hebrew text move-down-by-line-rtl-2.html text/html 1703 kalman PCFET0NUWVBFIGh0bWw+Cjxib2R5Pgo8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KPHNjcmlwdD4K ZnVuY3Rpb24gbG9nKHMpIHsKICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIiku aW5uZXJIVE1MICs9IHMgKyAiXG4iOwp9CgpmdW5jdGlvbiBjcmVhdGVFZGl0YWJsZU11bHRpbGlu ZURpdih0ZXh0LCBudW1MaW5lcykgewogICAgLy8gUHV0IHRleHQgaW4gYSBzcGFuIHNvIHRoYXQg dGhlIHdpZHRoIGNhbiBiZSBtZWFzdXJlZC4KICAgIHZhciBzcGFuID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgic3BhbiIpOwogICAgc3Bhbi5pbm5lckhUTUwgPSB0ZXh0OwogICAgZG9jdW1lbnQu Ym9keS5hcHBlbmRDaGlsZChzcGFuKTsKICAgIHZhciB3aWR0aFB4ID0gc3Bhbi5vZmZzZXRXaWR0 aDsKICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQoc3Bhbik7CgogICAgLy8gTWFrZSBkaXYg d2l0aCB0aG9zZSBkaW1lbnNpb25zIHNvIHRoYXQgdGhlIHRleHQgd3JhcHMgcHJlZGljdGFibHkg cmVnYXJkbGVzcyBvZiBwbGF0Zm9ybS4KICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCJkaXYiKTsKICAgIGRpdi5zZXRBdHRyaWJ1dGUoInN0eWxlIiwgIndpZHRoOiAiICsgd2lk dGhQeCArICJweCIpOwogICAgZGl2LmNvbnRlbnRFZGl0YWJsZSA9IHRydWU7CiAgICBmb3IgKHZh ciBpID0gMDsgaSA8IG51bUxpbmVzOyBpKyspCiAgICAgICAgZGl2LmFwcGVuZENoaWxkKGRvY3Vt ZW50LmNyZWF0ZVRleHROb2RlKHRleHQgKyAiICIpKTsKCiAgICByZXR1cm4gZGl2Owp9CgpmdW5j dGlvbiB1bmVzY2FwZVJ0bChydGxUZXh0KSB7CiAgICB2YXIgZSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoInNwYW4iKTsKICAgIGUuaW5uZXJIVE1MID0gcnRsVGV4dDsKICAgIHJldHVybiBlLmlu bmVySFRNTDsKfQoKcnRsVGV4dCA9IHVuZXNjYXBlUnRsKCImI3gwNUU5OyYjeDA1RDU7JiN4MDVC QzsmI3gwNUU4OyYjeDA1RDQ7ICIgKwogICAgICAgICAgICAgICAgICAgICAgIiYjeDA1RTk7JiN4 MDVENTsmI3gwNUJDOyYjeDA1RTg7JiN4MDVENDsgIiArCiAgICAgICAgICAgICAgICAgICAgICAi JiN4MDVFOTsmI3gwNUQ1OyYjeDA1QkM7JiN4MDVFODsmI3gwNUQ0OyIpOwpydGxUZXh0Q29udGFp bmVyID0gY3JlYXRlRWRpdGFibGVNdWx0aWxpbmVEaXYocnRsVGV4dCwgMyk7CnJ0bFRleHRDb250 YWluZXIuc2V0QXR0cmlidXRlKCJkaXIiLCAicnRsIik7CmRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQocnRsVGV4dENvbnRhaW5lcik7Cgpsb2coIkZZSTogcnRsVGV4dCAoIiArIHJ0bFRleHQgKyAi KSBoYXMgbGVuZ3RoICIgKyBydGxUZXh0Lmxlbmd0aCk7CmdldFNlbGVjdGlvbigpLnNldFBvc2l0 aW9uKHJ0bFRleHRDb250YWluZXIuY2hpbGROb2Rlc1swXSwgMCk7CmxvZygiU2VsZWN0aW9uIGhh cyBvZmZzZXQgIiArIGdldFNlbGVjdGlvbigpLmFuY2hvck9mZnNldCk7CmdldFNlbGVjdGlvbigp Lm1vZGlmeSgibW92ZSIsICJmb3J3YXJkIiwgImxpbmUiKTsKbG9nKCJTZWxlY3Rpb24gaGFzIG9m ZnNldCAiICsgZ2V0U2VsZWN0aW9uKCkuYW5jaG9yT2Zmc2V0KTsKCnJ0bFRleHRDb250YWluZXIu b25rZXl1cCA9IGZ1bmN0aW9uKCkgewogICAgbG9nKCJTZWxlY3Rpb24gaGFzIG9mZnNldCAiICsg Z2V0U2VsZWN0aW9uKCkuYW5jaG9yT2Zmc2V0KTsKfQo8L3NjcmlwdD4KPC9ib2R5Pgo= 166949 2012-10-03 13:20:32 -0700 2012-10-09 12:08:15 -0700 Unskipping test patch.diff text/plain 1509 tullio.lucena ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MDI4NWFmLi5iMmQ0MzZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAt MDMgIFR1bGxpbyBMdWNlbmEgIDx0dWxsaW8ubHVjZW5hQG9wZW5ib3NzYS5vcmc+CisKKyAgICAg ICAgUlRMOiBzZWxlY3Rpb24ubW9kaWZ5KCJtb3ZlIiwgImZvcndhcmQiLCAibGluZSIpIHdoZW4g Y3Vyc29yIGlzIGF0IHN0YXJ0IG9mIGEgbGluZSBkb2VzIG5vdCBtb3ZlIGRvd24gYSBsaW5lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTUxNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcHBpbmcg YSB0ZXN0IHRoYXQgaXMgcGFzc2luZywgd2l0aCB0ZXN0Zm9udHMgY2hhbmdlIGluIGh0dHBzOi8v Z2l0b3Jpb3VzLm9yZy9xdHdlYmtpdC90ZXN0Zm9udHMvbWVyZ2VfcmVxdWVzdHMvMQorCisgICAg ICAgICogcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0xMC0wMyAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIHdoZW4gY2FsbGluZyBk b2N1bWVudC5vcGVuIGR1cmluZyB1bmxvYWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGUyODA2MjguLjYzZTBiZWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvVGVzdEV4cGVjdGF0aW9ucwpAQCAtODgzLDEwICs4ODMsNiBAQCBlZGl0aW5nL3NlbGVjdGlv bi9jb2xsYXBzZS1zZWxlY3Rpb24taW4tYmlkaS5odG1sCiAjIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTg4NAogZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtYmlkaS1m aXJzdC1hbmQtbGFzdC1sZXR0ZXJzLmh0bWwKIAotIyBSVEw6IHNlbGVjdGlvbi5tb2RpZnkoIm1v dmUiLCAiZm9yd2FyZCIsICJsaW5lIikgd2hlbiBjdXJzb3IgaXMgYXQgc3RhcnQgb2YgYSBsaW5l IGRvZXMgbm90IG1vdmUgZG93biBhIGxpbmUKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTUxNTE3Ci1lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtdG8tbGluZS1ib3Vu ZGFyeS5odG1sCi0KICMgW1F0XSBlZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXZlcnRpY2FsbHktd2l0 aC1wYWRkaW5ncy1ib3JkZXJzLmh0bWwgZmFpbHMKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYyODIxCiBlZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXZlcnRpY2FsbHkt d2l0aC1wYWRkaW5ncy1ib3JkZXJzLmh0bWwK