51500 2010-12-22 14:54:52 -0800 [chromium] Timebar css needs adjusting when there is no current time element displayed 2010-12-22 21:25:56 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 sjl webkit-unassigned ajwong commit-queue levin scherkus oldest_to_newest 325714 0 sjl 2010-12-22 14:54:52 -0800 Currently the timebar does not expand when the current time is dropped from display. 325828 1 77289 sjl 2010-12-22 18:14:26 -0800 Created attachment 77289 Patch 325829 2 sjl 2010-12-22 18:17:00 -0800 Change css for chromium media controls to deal with the timeline not expanding when the current time disappears. This happens when the width of the control drops below 240px. This change results in a minor pixel difference - the timebar now aligns better with the time and when the time is not displayed is now perfectly centered. Disabling the affected tests for now and will rebaseline. 325872 3 77289 scherkus 2010-12-22 20:22:31 -0800 Comment on attachment 77289 Patch Looks good! 325887 4 77289 commit-queue 2010-12-22 21:25:49 -0800 Comment on attachment 77289 Patch Clearing flags on attachment: 77289 Committed r74535: <http://trac.webkit.org/changeset/74535> 325888 5 commit-queue 2010-12-22 21:25:56 -0800 All reviewed patches have been landed. Closing bug. 77289 2010-12-22 18:14:26 -0800 2010-12-22 21:25:49 -0800 Patch bug-51500-20101222181425.patch text/plain 6584 sjl ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMzI0NDEzMmYwOTk3MDVkMTgzNjQyNzNhZGFhYTA1M2E3Y2Y0OTdkLi44NjYwNzdm YTkzZmViNjg1MmFjNTdmMjU2OTM3Y2JjZmE5N2E3MDU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTAtMTItMjIgIFN0ZXZlIExhY2V5ICA8c2psQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgY3NzIGZvciBjaHJv bWl1bSBtZWRpYSBjb250cm9scyB0byBkZWFsIHdpdGggdGhlIHRpbWVsaW5lCisgICAgICAgIG5v dCBleHBhbmRpbmcgd2hlbiB0aGUgY3VycmVudCB0aW1lIGRpc2FwcGVhcnMuIFRoaXMgaGFwcGVu cyB3aGVuCisgICAgICAgIHRoZSB3aWR0aCBvZiB0aGUgY29udHJvbCBkcm9wcyBiZWxvdyAyNDBw eC4KKworICAgICAgICBUaGlzIGNoYW5nZSByZXN1bHRzIGluIGEgbWlub3IgcGl4ZWwgZGlmZmVy ZW5jZSAtIHRoZSB0aW1lYmFyIG5vdworICAgICAgICBhbGlnbnMgYmV0dGVyIHdpdGggdGhlIHRp bWUgYW5kIHdoZW4gdGhlIHRpbWUgaXMgbm90IGRpc3BsYXllZCBpcworICAgICAgICBub3cgcGVy ZmVjdGx5IGNlbnRlcmVkLiBEaXNhYmxpbmcgdGhlIGFmZmVjdGVkIHRlc3RzIGZvciBub3cKKyAg ICAgICAgYW5kIHdpbGwgcmViYXNlbGluZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE1MDAKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMC0xMi0yMiAgSmlhbiBMaSAgPGppYW5saUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5k ZXggZjkzMWZkNGNiNGJiZGVkNmFhYjc5Y2Q5MTg5YTMyOGY2MTJiZGEyNC4uNTBiMmJhMjJhODc0 ODVlYzU4NzY3ZDVlMjQ2NjdkNDc2YzE5NzAwZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMzIwOSw3ICszMjA5LDgg QEAgQlVHQ1I2NjA4NSBMSU5VWCA6IG1lZGlhL2NvbnN0cnVjdG9ycy5odG1sID0gUEFTUyBUSU1F T1VUCiBCVUdDUjY2MDg1IDogbWVkaWEvcmVtb3ZlLWZyb20tZG9jdW1lbnQuaHRtbCA9IFBBU1Mg VElNRU9VVAogQlVHQ1I2NjA4NSBXSU4gOiBtZWRpYS92aWRlby1jdXJyZW50VGltZS5odG1sID0g VElNRU9VVAogQlVHQ1I2NjA4NSBMSU5VWCA6IG1lZGlhL3ZpZGVvLWN1cnJlbnRUaW1lLmh0bWwg PSBQQVNTIFRJTUVPVVQKLUJVR0NSNjYwODUgOiBtZWRpYS92aWRlby1kaXNwbGF5LXRvZ2dsZS5o dG1sID0gUEFTUyBUSU1FT1VUCisvLyBSZS1lbmFibGUgdGhpcyBvbmNlIDU5NzA0IGlzIGZpeGVk IChyZWJhc2VsaW5lZCkuCisvL0JVR0NSNjYwODUgOiBtZWRpYS92aWRlby1kaXNwbGF5LXRvZ2ds ZS5odG1sID0gUEFTUyBUSU1FT1VUCiBCVUdDUjY2MDg1IDogbWVkaWEvdmlkZW8tcGxheS1wYXVz ZS1leGNlcHRpb24uaHRtbCA9IFBBU1MgVElNRU9VVAogQlVHQ1I2NjA4NSA6IG1lZGlhL3ZpZGVv LXNvdXJjZS5odG1sID0gUEFTUyBUSU1FT1VUCiBCVUdDUjY2MDg1IDogbWVkaWEvdmlkZW8tc291 cmNlLW1vdmVkLmh0bWwgPSBQQVNTIFRJTUVPVVQKQEAgLTMyNjEsMyArMzI2MiwxNSBAQCBCVUdD UjY3NjYyIFdJTiA6IGh0dHAvdGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtd2Vic29ja2V0LWVycm9y Lmh0bWwgPSBURVhUIFRJTUVPVQogCiBCVUdXSzUxMzk4IE1BQyA6IGluc3BlY3Rvci9jb25zb2xl LWRpci1nbG9iYWwuaHRtbCA9IFRJTUVPVVQKIEJVR1dLNTEzOTggTUFDIDogaW5zcGVjdG9yL2Rl YnVnZ2VyLWV4cGFuZC1zY29wZS5odG1sID0gVElNRU9VVAorCisvLyBDaGFuZ2UgZm9yIDU5NzA0 IHJlcXVpcmVzIGEgcmViYXNlbGluZSBvZiB2YXJpb3VzIG1lZGlhIHRlc3RzCitCVUdDUjU5NzA0 IDogbWVkaWEvYXVkaW8tY29udHJvbHMtcmVuZGVyaW5nLmh0bWwgPSBJTUFHRStURVhUCitCVUdD UjU5NzA0IDogbWVkaWEvY29udHJvbHMtYWZ0ZXItcmVsb2FkLmh0bWwgPSBJTUFHRStURVhUCitC VUdDUjU5NzA0IDogbWVkaWEvY29udHJvbHMtc3RyaWN0Lmh0bWwgPSBJTUFHRStURVhUCitCVUdD UjU5NzA0IDogbWVkaWEvY29udHJvbHMtc3R5bGluZy5odG1sID0gSU1BR0UrVEVYVAorQlVHQ1I1 OTcwNCA6IG1lZGlhL2NvbnRyb2xzLXdpdGhvdXQtcHJlbG9hZC5odG1sID0gSU1BR0UrVEVYVAor QlVHQ1I1OTcwNCA6IG1lZGlhL3ZpZGVvLWNvbnRyb2xzLXJlbmRlcmluZy5odG1sID0gSU1BR0Ur VEVYVAorQlVHQ1I1OTcwNCA6IG1lZGlhL3ZpZGVvLWRpc3BsYXktdG9nZ2xlLmh0bWwgPSBJTUFH RStURVhUIFRJTUVPVVQKK0JVR0NSNTk3MDQgOiBtZWRpYS92aWRlby1lbXB0eS1zb3VyY2UuaHRt bCA9IElNQUdFK1RFWFQKK0JVR0NSNTk3MDQgOiBtZWRpYS92aWRlby1uby1hdWRpby5odG1sID0g SU1BR0UrVEVYVAorQlVHQ1I1OTcwNCA6IG1lZGlhL3ZpZGVvLXZvbHVtZS1zbGlkZXIuaHRtbCA9 IElNQUdFK1RFWFQKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggM2QzZDNhMDc4YjBlNmE2MjRlYTk4YWUwMTcyMjRkZDY1ZTE5OTY4MC4uMWQ3 OTdiZDA2N2IxNjM5ZjhmNzZlN2U1YzhhYmNkNTNhZmIwMDlkYyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAx MC0xMi0yMiAgU3RldmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBjc3MgZm9yIGNocm9taXVt IG1lZGlhIGNvbnRyb2xzIHRvIGRlYWwgd2l0aCB0aGUgdGltZWxpbmUKKyAgICAgICAgbm90IGV4 cGFuZGluZyB3aGVuIHRoZSBjdXJyZW50IHRpbWUgZGlzYXBwZWFycy4gVGhpcyBoYXBwZW5zIHdo ZW4KKyAgICAgICAgdGhlIHdpZHRoIG9mIHRoZSBjb250cm9sIGRyb3BzIGJlbG93IDI0MHB4Lgor CisgICAgICAgIFRoaXMgY2hhbmdlIHJlc3VsdHMgaW4gYSBtaW5vciBwaXhlbCBkaWZmZXJlbmNl IC0gdGhlIHRpbWViYXIgbm93CisgICAgICAgIGFsaWducyBiZXR0ZXIgd2l0aCB0aGUgdGltZSBh bmQgd2hlbiB0aGUgdGltZSBpcyBub3QgZGlzcGxheWVkIGlzCisgICAgICAgIG5vdyBwZXJmZWN0 bHkgY2VudGVyZWQuIERpc2FibGluZyB0aGUgYWZmZWN0ZWQgdGVzdHMgZm9yIG5vdworICAgICAg ICBhbmQgd2lsbCByZWJhc2VsaW5lLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MTUwMAorCisgICAgICAgICogY3NzL21lZGlhQ29udHJvbHNDaHJv bWl1bS5jc3M6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lbGlu ZS1jb250YWluZXIsIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLWNvbnRh aW5lcik6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRp bWUtZGlzcGxheSwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1lLWRp c3BsYXkpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1h aW5pbmctZGlzcGxheSwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1haW5p bmctZGlzcGxheSk6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1l bGluZSwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmUpOgorCiAyMDEwLTEy LTIyICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL21lZGlh Q29udHJvbHNDaHJvbWl1bS5jc3MgYi9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzQ2hyb21pdW0u Y3NzCmluZGV4IDg3MWEzMjQ5ZDgzZjgyZWVhN2NhNTBlODdmYTdhYjRkNGU2ODI2NjQuLjYxY2Ji MGQwZTI4ZDhhNWNkN2Q2OWNjODg0N2YxOGQxY2Q5NzljYzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv Y3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3MKKysrIGIvV2ViQ29yZS9jc3MvbWVkaWFDb250 cm9sc0Nocm9taXVtLmNzcwpAQCAtNzMsNiArNzMsMTEgQEAgYXVkaW86Oi13ZWJraXQtbWVkaWEt Y29udHJvbHMtcGxheS1idXR0b24sIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBsYXkt YnUKIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLWNvbnRhaW5lciwgdmlk ZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmUtY29udGFpbmVyIHsKICAgICAtd2Vi a2l0LWFwcGVhcmFuY2U6IG1lZGlhLXRpbWVsaW5lLWNvbnRhaW5lcjsKICAgICAtd2Via2l0LXVz ZXItc2VsZWN0OiBub25lOworICAgIC13ZWJraXQtYm94LW9yaWVudDogaG9yaXpvbnRhbDsKKyAg ICAtd2Via2l0LWJveC1hbGlnbjogY2VudGVyOworICAgIC13ZWJraXQtYm94LXBhY2s6IGNlbnRl cjsKKyAgICAtd2Via2l0LWJveC1kaXJlY3Rpb246IHJldmVyc2U7CisgICAgLXdlYmtpdC1ib3gt ZmxleDogMTsKIAogICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICB0b3A6IGF1dG87CkBAIC05 MCwxOCArOTUsMTUgQEAgYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmUtY29u dGFpbmVyLCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy0KIGF1ZGlvOjotd2Via2l0LW1l ZGlhLWNvbnRyb2xzLWN1cnJlbnQtdGltZS1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1j b250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxheSB7CiAgICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBt ZWRpYS1jdXJyZW50LXRpbWUtZGlzcGxheTsKICAgICAtd2Via2l0LXVzZXItc2VsZWN0OiBub25l OwotICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgICBkaXNwbGF5OiAtd2Via2l0LWJveDsK KyAgICAtd2Via2l0LWJveC1mbGV4OiAwOworICAgIC13ZWJraXQtYm94LXBhY2s6IGNlbnRlcjsK KyAgICAtd2Via2l0LWJveC1hbGlnbjogY2VudGVyOwogCiAgICAgb3ZlcmZsb3c6IGhpZGRlbjsK ICAgICBjdXJzb3I6IGRlZmF1bHQ7CiAKLSAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgbGlu ZS1oZWlnaHQ6IDIxcHg7Ci0gICAgdG9wOiBhdXRvOwotICAgIGJvdHRvbTogNnB4OwotICAgIGxl ZnQ6IGF1dG87Ci0gICAgcmlnaHQ6IDBweDsKLQogICAgIGhlaWdodDogMjBweDsKICAgICB3aWR0 aDogNThweDsKIApAQCAtMTIzLDE3ICsxMjUsMTQgQEAgYXVkaW86Oi13ZWJraXQtbWVkaWEtY29u dHJvbHMtdGltZS1yZW1haW5pbmctZGlzcGxheSwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHIK ICAgICAtd2Via2l0LWFwcGVhcmFuY2U6IG1lZGlhLXRpbWUtcmVtYWluaW5nLWRpc3BsYXk7CiAg ICAgLXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZTsKICAgICBkaXNwbGF5OiBub25lOworICAgIC13 ZWJraXQtYm94LWZsZXg6IDA7CisgICAgLXdlYmtpdC1ib3gtcGFjazogY2VudGVyOworICAgIC13 ZWJraXQtYm94LWFsaWduOiBjZW50ZXI7CiAKICAgICBvdmVyZmxvdzogaGlkZGVuOwogICAgIGN1 cnNvcjogZGVmYXVsdDsKIAotICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICBsaW5lLWhlaWdo dDogMjFweDsKLSAgICB0b3A6IGF1dG87Ci0gICAgYm90dG9tOiA2cHg7Ci0gICAgbGVmdDogYXV0 bzsKLSAgICByaWdodDogMHB4OwotCiAgICAgaGVpZ2h0OiAyMHB4OwogICAgIHdpZHRoOiA1OHB4 OwogCkBAIC0xNTMsMTEgKzE1MiwxMSBAQCBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10 aW1lLXJlbWFpbmluZy1kaXNwbGF5LCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cgogCiBhdWRp bzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lbGluZSwgdmlkZW86Oi13ZWJraXQtbWVkaWEt Y29udHJvbHMtdGltZWxpbmUgewogICAgIC13ZWJraXQtYXBwZWFyYW5jZTogbWVkaWEtc2xpZGVy OwotICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKLSAgICB0b3A6IGF1dG87Ci0gICAgYm90dG9tOiA3 cHg7Ci0gICAgbGVmdDogNnB4OwotICAgIHJpZ2h0OiA2NXB4OworICAgIGRpc3BsYXk6IC13ZWJr aXQtYm94OworICAgIC13ZWJraXQtYm94LWZsZXg6IDE7CisKKyAgICBwYWRkaW5nOiAwcHg7Cisg ICAgbWFyZ2luOiAwcHggNnB4OwogICAgIGhlaWdodDogMTZweDsKIAogICAgIGJvcmRlci1jb2xv cjogcmdiYSgyNTUsIDI1NSwgMjU1LCAwLjIpOwo=