51494 2010-12-22 14:14:46 -0800 Restoring lost WebGL context causes a crash 2010-12-22 16:27:10 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 51492 1 enne enne amarinichev commit-queue enne kbr zmo oldest_to_newest 325690 0 enne 2010-12-22 14:14:46 -0800 It appears as though the context lost flag is still true when the context is recreated and the fallback 1x1 black textures are created. As createTexture() returns null in the case of a lost context, these textures fail to be created and there's a null pointer deref. 325693 1 77259 enne 2010-12-22 14:17:15 -0800 Created attachment 77259 Patch 325707 2 77259 kbr 2010-12-22 14:39:48 -0800 Comment on attachment 77259 Patch Looks good. 325777 3 enne 2010-12-22 16:27:10 -0800 Committed r74516: <http://trac.webkit.org/changeset/74516> 77259 2010-12-22 14:17:15 -0800 2010-12-22 16:22:21 -0800 Patch bug-51494-20101222141714.patch text/plain 1681 enne ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGJhNTQ0MTBmZjhmZGEyNzQxNDhhOGY3ZmZhNTA3NWY2YzkyOWY0NC4uMzA4MWFjZTJmNmY0NzVj MzcyOTMwMjcxYmQxNDg2NDAwZjU4ZWIwZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0yMiAgQWRy aWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBudWxsIHBvaW50ZXIgZGVyZWYgd2hlbiByZXN0 b3JpbmcgYSBsb3N0IFdlYkdMIGNvbnRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTQ5NAorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgY29u dGV4dCByZXN0b3JlZCBldmVudHMgYXJlIG5vdCBjdXJyZW50bHkgdGVzdGFibGUuCisKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0Ojppbml0aWFsaXplTmV3Q29udGV4dCk6CisgICAg ICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnJlc3RvcmVDb250ZXh0KToKKwog MjAxMC0xMi0yMSAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvV2ViQ29yZS9odG1sL2Nh bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IDY1NzY5ZTFhMjkwNDM0YzcyMzhj ZWQ2Zjg5Y2ZiNjA0YWViMTZlOTcuLjhjYzQ1NTUwZDg4ZmE5ZjQ3MjhlZDNiNzBmY2I0OTUxMWZl Y2UwN2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250 ZXh0LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5j cHAKQEAgLTE0MCw2ICsxNDAsNyBAQCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OldlYkdMUmVuZGVy aW5nQ29udGV4dChIVE1MQ2FudmFzRWxlbWVudCogcGFzc2VkQ2FudmFzLCBQYQogCiB2b2lkIFdl YkdMUmVuZGVyaW5nQ29udGV4dDo6aW5pdGlhbGl6ZU5ld0NvbnRleHQoKQogeworICAgIEFTU0VS VCghbV9jb250ZXh0TG9zdCk7CiAgICAgbV9uZWVkc1VwZGF0ZSA9IHRydWU7CiAgICAgbV9tYXJr ZWRDYW52YXNEaXJ0eSA9IGZhbHNlOwogICAgIG1fYWN0aXZlVGV4dHVyZVVuaXQgPSAwOwpAQCAt MzMzMyw4ICszMzM0LDggQEAgdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnJlc3RvcmVDb250 ZXh0KCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9jb250ZXh0ID0gY29udGV4dDsKLSAgICBp bml0aWFsaXplTmV3Q29udGV4dCgpOwogICAgIG1fY29udGV4dExvc3QgPSBmYWxzZTsKKyAgICBp bml0aWFsaXplTmV3Q29udGV4dCgpOwogICAgIGNhbnZhcygpLT5kaXNwYXRjaEV2ZW50KFdlYkdM Q29udGV4dEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLndlYmdsY29udGV4dHJlc3RvcmVkRXZl bnQsIGZhbHNlLCB0cnVlLCAiIikpOwogfQogCg==