51483 2010-12-22 11:02:06 -0800 CSS 2.1 failure: counter-increment-013 fails 2010-12-22 12:45:12 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser abarth eric mitz simon.fraser webkit.review.bot oldest_to_newest 325582 0 simon.fraser 2010-12-22 11:02:06 -0800 html4/counter-increment-013 fails. 325583 1 77239 simon.fraser 2010-12-22 11:03:20 -0800 Created attachment 77239 Patch 325585 2 77239 mitz 2010-12-22 11:07:22 -0800 Comment on attachment 77239 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77239&action=review > WebCore/css/CSSParser.cpp:131 > + const double minIntAsDouble = INT_MIN; > + const double maxIntAsDouble = INT_MAX; Please use numeric_limits<int> instead of the C macros. 325592 3 simon.fraser 2010-12-22 11:19:47 -0800 http://trac.webkit.org/changeset/74491 325640 4 webkit.review.bot 2010-12-22 12:45:12 -0800 http://trac.webkit.org/changeset/74491 might have broken GTK Linux 32-bit Release The following tests are not passing: http/tests/local/stylesheet-and-script-load-order-media-print.html 77239 2010-12-22 11:03:20 -0800 2010-12-22 11:07:22 -0800 Patch bug-51483-20101222110318.patch text/plain 4237 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzM2QxODEyNjI4OWY1NjY2YmE0NmE0NmI4NDI0YmQzNjQ3NGUzNTA4Li4zMjg5NDRi NzA3YThhNjFlMDY0ZTZiZDYwZTU4ZTAyY2U1MjJkMjY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTItMjIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ1NTIDIuMSBmYWls dXJlOiBjb3VudGVyLWluY3JlbWVudC0wMTMgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNDgzCisgICAgICAgIAorICAgICAgICBMYXlvdXQg dGVzdCB2ZXJzaW9uIG9mIENTUyAyLjEgY291bnRlci1pbmNyZW1lbnQtMDEzIHRlc3QuCisKKyAg ICAgICAgKiBmYXN0L2Nzcy9jb3VudGVycy9jb3VudGVyLWluY3JlbWVudC1vdmVyZmxvdy1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2NvdW50ZXJzL2NvdW50ZXItaW5j cmVtZW50LW92ZXJmbG93Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTEyLTIxICBHYXZpbiBCYXJyYWNs b3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2 ZXIgSHVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NvdW50ZXJzL2NvdW50 ZXItaW5jcmVtZW50LW92ZXJmbG93LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L2NvdW50ZXJzL2NvdW50ZXItaW5jcmVtZW50LW92ZXJmbG93LWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi45YzI1NzM5Y2Y2NDgxODFlMTFjMzM1MmQ1MWE3ZGQyM2VkYzdmMzUzCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY291bnRlcnMvY291bnRlci1pbmNyZW1lbnQt b3ZlcmZsb3ctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGVzdCBwYXNzZXMgaWYgdGhl IG51bWJlciAnMjE0NzQ4MzY0NycgYXBwZWFycyBiZWxvdy4KKworMjE0NzQ4MzY0NwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY291bnRlcnMvY291bnRlci1pbmNyZW1lbnQtb3Zl cmZsb3cuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NvdW50ZXJzL2NvdW50ZXItaW5jcmVt ZW50LW92ZXJmbG93Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTg4OTMwMDkzNTg1ZTNhOTU3MzQ1OTM2NGYw OWQ1YmI5MjJiM2E0NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2Nv dW50ZXJzL2NvdW50ZXItaW5jcmVtZW50LW92ZXJmbG93Lmh0bWwKQEAgLTAsMCArMSwzMiBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICA8c3R5bGUgdHlwZT0idGV4 dC9jc3MiPgorICAgICAgICBkaXYKKyAgICAgICAgeworICAgICAgICAgICAgY291bnRlci1pbmNy ZW1lbnQ6IGlkZW50IDIxNDc0ODM2NDg7CisgICAgICAgIH0KKyAgICAgICAgZGl2OmJlZm9yZQor ICAgICAgICB7CisgICAgICAgICAgICBjb250ZW50OiBjb3VudGVyKGlkZW50KTsKKyAgICAgICAg fQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAg ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgIGZ1bmN0aW9uIGRvVGVzdCgp CisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvdW50ZWQnKS5pbm5l clRleHQgPSBsYXlvdXRUZXN0Q29udHJvbGxlci5jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZCgn Y291bnRlZCcpOworICAgICAgICB9CisKKyAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIo J2xvYWQnLCBkb1Rlc3QsIGZhbHNlKTsKKyAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisgICAg PGJvZHk+CisgICAgPHA+VGVzdCBwYXNzZXMgaWYgdGhlIG51bWJlciAnMjE0NzQ4MzY0NycgYXBw ZWFycyBiZWxvdy48L3A+CisgICAgPGRpdiBpZD0iY291bnRlZCI+PC9kaXY+CisKKyAgICA8L2Jv ZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNWQwN2UwNTljMWRkYWZi NTBiOTQ0NmExMWMyZmVhMjQxN2M3MzRlLi5hYjFmZjAyNDQ0OTRjNmViY2QyMWNlNTZmZThlYzA1 OWQwYTRhYWUwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTEyLTIyICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENTUyAyLjEgZmFpbHVyZTogY291bnRlci1pbmNyZW1lbnQtMDEzIGZhaWxz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTQ4Mwor ICAgICAgICAKKyAgICAgICAgQ2xhbXAgdGhlIGNvdW50ZXItaW5jcmVtZW50IHByb3BlcnR5IHRv IHRoZSB2YWxpZCByYW5nZSBvZiBzaWduZWQKKyAgICAgICAgaW50ZWdlcnMuCisKKyAgICAgICAg VGVzdDogZmFzdC9jc3MvY291bnRlcnMvY291bnRlci1pbmNyZW1lbnQtb3ZlcmZsb3cuaHRtbAor CisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjbGFtcFRv U2lnbmVkSW50ZWdlcik6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlQ291bnRl cik6CisKIDIwMTAtMTItMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2Nzcy9DU1NQYXJzZXIuY3BwIGIvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCA3NDRk OWI3Y2NmZGE3NzVkMjU5YzgxNjNmNTM1ODRiZDRjODBjM2NhLi5lNDQyMGFjYWY0MjE2NTNjYmVk MmUyYjY2NzQ1ZWI1YjgxNTU0MjExIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCisrKyBiL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTEyNSw2ICsxMjUsMTMgQEAg c3RhdGljIGJvb2wgaGFzUHJlZml4KGNvbnN0IGNoYXIqIHN0cmluZywgdW5zaWduZWQgbGVuZ3Ro LCBjb25zdCBjaGFyKiBwcmVmaXgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitzdGF0aWMgaW50 IGNsYW1wVG9TaWduZWRJbnRlZ2VyKGRvdWJsZSBkKQoreworICAgIGNvbnN0IGRvdWJsZSBtaW5J bnRBc0RvdWJsZSA9IElOVF9NSU47CisgICAgY29uc3QgZG91YmxlIG1heEludEFzRG91YmxlID0g SU5UX01BWDsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8aW50PihtYXgobWluSW50QXNEb3VibGUs IG1pbihkLCBtYXhJbnRBc0RvdWJsZSkpKTsKK30KKwogQ1NTUGFyc2VyOjpDU1NQYXJzZXIoYm9v bCBzdHJpY3RQYXJzaW5nKQogICAgIDogbV9zdHJpY3Qoc3RyaWN0UGFyc2luZykKICAgICAsIG1f aW1wb3J0YW50KGZhbHNlKQpAQCAtNDYyNSw3ICs0NjMyLDcgQEAgYm9vbCBDU1NQYXJzZXI6OnBh cnNlQ291bnRlcihpbnQgcHJvcElkLCBpbnQgZGVmYXVsdFZhbHVlLCBib29sIGltcG9ydGFudCkK ICAgICAgICAgICAgIGNhc2UgVkFMOiB7CiAgICAgICAgICAgICAgICAgaW50IGkgPSBkZWZhdWx0 VmFsdWU7CiAgICAgICAgICAgICAgICAgaWYgKHZhbCAmJiB2YWwtPnVuaXQgPT0gQ1NTUHJpbWl0 aXZlVmFsdWU6OkNTU19OVU1CRVIpIHsKLSAgICAgICAgICAgICAgICAgICAgaSA9IChpbnQpdmFs LT5mVmFsdWU7CisgICAgICAgICAgICAgICAgICAgIGkgPSBjbGFtcFRvU2lnbmVkSW50ZWdlcih2 YWwtPmZWYWx1ZSk7CiAgICAgICAgICAgICAgICAgICAgIG1fdmFsdWVMaXN0LT5uZXh0KCk7CiAg ICAgICAgICAgICAgICAgfQogCg==