51476 2010-12-22 09:50:43 -0800 Web Inspector: Can't backspace from CSS value to CSS key field 2010-12-23 10:11:45 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 thakis apavlov abarth apavlov bweinstein commit-queue eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 325529 0 thakis 2010-12-22 09:50:43 -0800 I like the change that made CSS keys and values to different text fields. However, it made it hard to delete new rules. Repro: 1. Double-click "Element style" 2. "color" : "red" but don't hit enter 3. Change your mind, hit backspace Expected: I'm able to backspace all the way to the left, deleting everything i wrote Actual: Only "red" gets deleted. The caret should move back the the key field if backspace is pressed and the caret is on the left edge of the value field. 325547 1 joepeck 2010-12-22 10:18:22 -0800 Thanks for the report Nico. I think many others would expect the opposite, that backspacing would be limited to just the value. However, you have a very good point. If the user actually types out the ":" and is jumped editing the property to value, then they would also expect that behavior going backwards. The user flow I would have used didn't work as I expected: <http://webkit.org/b/51480> Web Inspector: Tabbing from new rule with empty value should create a new property 326022 2 77324 apavlov 2010-12-23 04:14:39 -0800 Created attachment 77324 [PATCH] Suggested solution I believe this behavior is only useful for new properties, as blurring a changed value of an existing property results in the property being committed (effectively removing the property if the value is empty), which may be far from what the user could expect. Does that sound reasonable? 326108 3 77324 joepeck 2010-12-23 09:08:01 -0800 Comment on attachment 77324 [PATCH] Suggested solution Good solution. Thanks! r=me 326112 4 77324 commit-queue 2010-12-23 09:26:30 -0800 Comment on attachment 77324 [PATCH] Suggested solution Clearing flags on attachment: 77324 Committed r74562: <http://trac.webkit.org/changeset/74562> 326113 5 commit-queue 2010-12-23 09:26:37 -0800 All reviewed patches have been landed. Closing bug. 326128 6 webkit.review.bot 2010-12-23 10:11:45 -0800 http://trac.webkit.org/changeset/74562 might have broken SnowLeopard Intel Release (Tests) 77324 2010-12-23 04:14:39 -0800 2010-12-23 09:26:30 -0800 [PATCH] Suggested solution backspacevalue.patch text/plain 2179 apavlov Y29tbWl0IDg1M2UwMGVlNTY4MTc3ZTI1ZmM2ZGY0YzM1OWMwOTE0OThkYzQ0YzAKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUaHUgRGVjIDIz IDE1OjA1OjUxIDIwMTAgKzAzMDAKCiAgICBIYW5kbGUgQmFja3NwYWNlIHdoZW4gZWRpdGluZyBi bGFuayBwcm9wZXJ0eSB2YWx1ZQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggM2I1Y2UzYi4uN2I3MGFlNSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAx MC0xMi0yMyAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IENhbid0IGJhY2tzcGFjZSBmcm9tIENTUyB2YWx1ZSB0byBDU1Mga2V5IGZpZWxkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTQ3NgorCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlLik6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSk6CisKKzIw MTAtMTItMjMgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKwogICAg ICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogQWZ0ZXIgc2Nyb2xsaW5nIG5ldyBwcm9wZXJ0eSB2YWx1ZSBhbmQgY2FuY2VsbGluZywgcmVt b3ZlZCBwcm9wZXJ0eSByZW1haW5zIGFjdGl2ZSBpbiBwYWdlIHN0eWxlCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggOGM1MDQzNi4u NzU2MTFhMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1Np ZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRl YmFyUGFuZS5qcwpAQCAtMTU1OSw3ICsxNTU5LDE0IEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3Bl cnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIHJldHVybiAibW92 ZS1mb3J3YXJkIjsKICAgICAgICAgICAgIH0gZWxzZSBpZiAoZXZlbnQua2V5Q29kZSA9PT0gV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5cy5Fc2MuY29kZSkKICAgICAgICAgICAgICAg ICByZXR1cm4gImNhbmNlbCI7Ci0gICAgICAgICAgICBlbHNlIGlmIChldmVudC5rZXlJZGVudGlm aWVyID09PSAiVSswMDA5IikgLy8gVGFiIGtleS4KKyAgICAgICAgICAgIGVsc2UgaWYgKCFpc0Vk aXRpbmdOYW1lICYmIHRoaXMuX25ld1Byb3BlcnR5ICYmIGV2ZW50LmtleUNvZGUgPT09IFdlYklu c3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleXMuQmFja3NwYWNlLmNvZGUpIHsKKyAgICAgICAg ICAgICAgICAvLyBGb3IgYSBuZXcgcHJvcGVydHksIHdoZW4gQmFja3NwYWNlIGlzIHByZXNzZWQg YXQgdGhlIGJlZ2lubmluZyBvZiBuZXcgcHJvcGVydHkgdmFsdWUsIG1vdmUgYmFjayB0byB0aGUg cHJvcGVydHkgbmFtZS4KKyAgICAgICAgICAgICAgICB2YXIgc2VsZWN0aW9uID0gd2luZG93Lmdl dFNlbGVjdGlvbigpOworICAgICAgICAgICAgICAgIGlmIChzZWxlY3Rpb24uaXNDb2xsYXBzZWQg JiYgIXNlbGVjdGlvbi5mb2N1c09mZnNldCkgeworICAgICAgICAgICAgICAgICAgICBldmVudC5w cmV2ZW50RGVmYXVsdCgpOworICAgICAgICAgICAgICAgICAgICByZXR1cm4gIm1vdmUtYmFja3dh cmQiOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0gZWxzZSBpZiAoZXZlbnQua2V5 SWRlbnRpZmllciA9PT0gIlUrMDAwOSIpIC8vIFRhYiBrZXkuCiAgICAgICAgICAgICAgICAgcmV0 dXJuICJtb3ZlLSIgKyAoZXZlbnQuc2hpZnRLZXkgPyAiYmFja3dhcmQiIDogImZvcndhcmQiKTsK ICAgICAgICAgfQogCg==