<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51471</bug_id>
          
          <creation_ts>2010-12-22 08:35:39 -0800</creation_ts>
          <short_desc>TestNetscapePlugIn should use #if defined</short_desc>
          <delta_ts>2010-12-22 11:17:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ariya Hidayat">ariya.hidayat</reporter>
          <assigned_to name="Ariya Hidayat">ariya.hidayat</assigned_to>
          <cc>abarth</cc>
    
    <cc>aroben</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>325506</commentid>
    <comment_count>0</comment_count>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-12-22 08:35:39 -0800</bug_when>
    <thetext>TestNetscapePlugIn should use #if defined</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325507</commentid>
    <comment_count>1</comment_count>
      <attachid>77221</attachid>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-12-22 08:43:19 -0800</bug_when>
    <thetext>Created attachment 77221
2010-12-22  Ariya Hidayat  &lt;ariya@sencha.com&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325508</commentid>
    <comment_count>2</comment_count>
      <attachid>77221</attachid>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-12-22 08:44:14 -0800</bug_when>
    <thetext>Comment on attachment 77221
2010-12-22  Ariya Hidayat  &lt;ariya@sencha.com&gt;

Missing ChangeLog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325513</commentid>
    <comment_count>3</comment_count>
      <attachid>77222</attachid>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-12-22 08:50:05 -0800</bug_when>
    <thetext>Created attachment 77222
2010-12-22  Ariya Hidayat  &lt;ariya@sencha.com&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325543</commentid>
    <comment_count>4</comment_count>
      <attachid>77222</attachid>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-12-22 10:12:39 -0800</bug_when>
    <thetext>Comment on attachment 77222
2010-12-22  Ariya Hidayat  &lt;ariya@sencha.com&gt;

Clearing flags on attachment: 77222

Committed r74482: &lt;http://trac.webkit.org/changeset/74482&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325544</commentid>
    <comment_count>5</comment_count>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-12-22 10:12:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>325590</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-22 11:17:26 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/74482 might have broken GTK Linux 32-bit Release</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77221</attachid>
            <date>2010-12-22 08:43:19 -0800</date>
            <delta_ts>2010-12-22 08:50:01 -0800</delta_ts>
            <desc>2010-12-22  Ariya Hidayat  &lt;ariya@sencha.com&gt;</desc>
            <filename>bug-51471-20101222084318.patch</filename>
            <type>text/plain</type>
            <size>1310</size>
            <attacher name="Ariya Hidayat">ariya.hidayat</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWlu
LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcApp
bmRleCAzOWEzMzkyMjM4NDZjOGNiOTYzZDA2MWMxMTJjMTExODExYmFiOWU2Li5iNGI3ZmEzOGEw
OGY4YWQ0MWY0ZThlZWExYTc1OWVjYmFmZWRkZjdhIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVu
ZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vbWFpbi5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRl
clRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4uY3BwCkBAIC00Nyw3ICs0Nyw3IEBAIHVzaW5n
IG5hbWVzcGFjZSBzdGQ7CiBzdGF0aWMgYm9vbCBnZXRFbnRyeVBvaW50c1dhc0NhbGxlZDsKIHN0
YXRpYyBib29sIGluaXRpYWxpemVXYXNDYWxsZWQ7CiAKLSNpZiBYUF9XSU4KKyNpZiBkZWZpbmVk
KFhQX1dJTikKICNkZWZpbmUgU1REQ0FMTCBfX3N0ZGNhbGwKIAogc3RhdGljIGlubGluZSBpbnQg
c3RyY2FzZWNtcChjb25zdCBjaGFyKiBzMSwgY29uc3QgY2hhciogczIpCkBAIC03Myw3ICs3Myw3
IEBAIE5QRXJyb3IgU1REQ0FMTCBOUF9Jbml0aWFsaXplKE5QTmV0c2NhcGVGdW5jcyAqYnJvd3Nl
ckZ1bmNzCiB7CiAgICAgaW5pdGlhbGl6ZVdhc0NhbGxlZCA9IHRydWU7CiAKLSNpZiBYUF9XSU4K
KyNpZiBkZWZpbmVkKFhQX1dJTikKICAgICAvLyBTaW11bGF0ZSBGbGFzaCBhbmQgUXVpY2tUaW1l
J3MgYmVoYXZpb3Igb2YgY3Jhc2hpbmcgd2hlbiBOUF9Jbml0aWFsaXplIGlzIGNhbGxlZCBiZWZv
cmUgTlBfR2V0RW50cnlQb2ludHMuCiAgICAgaWYgKCFnZXRFbnRyeVBvaW50c1dhc0NhbGxlZCkK
ICAgICAgICAgQ1JBU0goKTsKQEAgLTIzOSw3ICsyMzksNyBAQCBOUEVycm9yIE5QUF9OZXcoTlBN
SU1FVHlwZSBwbHVnaW5UeXBlLCBOUFAgaW5zdGFuY2UsIHVpbnQxNl90IG1vZGUsIGludDE2X3Qg
YXJnYwogICAgICAgICAgICAgICAgIHJldHVybiBOUEVSUl9JTkNPTVBBVElCTEVfVkVSU0lPTl9F
UlJPUjsKICNlbmRpZgogICAgICAgICB9IGVsc2UgaWYgKHN0cmNhc2VjbXAoYXJnbltpXSwgInRl
c3RHZXRVUkxPbkRlc3Ryb3kiKSA9PSAwKSB7Ci0jaWYgWFBfV0lOCisjaWYgZGVmaW5lZChYUF9X
SU4pCiAgICAgICAgICAgICAvLyBGSVhNRTogV2hlbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NDE4MzEgaXMgZml4ZWQsIHRoaXMgI2lmZGVmIGNhbiBiZSByZW1vdmVk
LgogICAgICAgICAgICAgb2JqLT50ZXN0R2V0VVJMT25EZXN0cm95ID0gVFJVRTsKICNlbmRpZgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77222</attachid>
            <date>2010-12-22 08:50:05 -0800</date>
            <delta_ts>2010-12-22 10:12:39 -0800</delta_ts>
            <desc>2010-12-22  Ariya Hidayat  &lt;ariya@sencha.com&gt;</desc>
            <filename>bug-51471-20101222085004.patch</filename>
            <type>text/plain</type>
            <size>1902</size>
            <attacher name="Ariya Hidayat">ariya.hidayat</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZjMw
NDUxYmFhZDNiMzM4NzcwZWFjOGU2ODg1ODAzZDY4MWExZTdjLi5mMTYzZjdlOTFmODM0ODYxMzBl
ZDc5NjA2NTFmZmRhMWZhMzFiZDg4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv
VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMjIgIEFyaXlhIEhpZGF5
YXQgIDxhcml5YUBzZW5jaGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIFRlc3ROZXRzY2FwZVBsdWdJbiBzaG91bGQgdXNlICNpZiBkZWZpbmVk
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTQ3MQor
CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4uY3BwOgor
ICAgICAgICAoTlBfSW5pdGlhbGl6ZSk6CisgICAgICAgIChOUFBfTmV3KToKKwogMjAxMC0xMi0y
MiAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgU2hpbmljaGlybyBIYW1hamkuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9U
ZXN0TmV0c2NhcGVQbHVnSW4vbWFpbi5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0
c2NhcGVQbHVnSW4vbWFpbi5jcHAKaW5kZXggMzlhMzM5MjIzODQ2YzhjYjk2M2QwNjFjMTEyYzEx
MTgxMWJhYjllNi4uYjRiN2ZhMzhhMDhmOGFkNDFmNGU4ZWVhMWE3NTllY2JhZmVkZGY3YSAxMDA2
NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4uY3Bw
CisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcApA
QCAtNDcsNyArNDcsNyBAQCB1c2luZyBuYW1lc3BhY2Ugc3RkOwogc3RhdGljIGJvb2wgZ2V0RW50
cnlQb2ludHNXYXNDYWxsZWQ7CiBzdGF0aWMgYm9vbCBpbml0aWFsaXplV2FzQ2FsbGVkOwogCi0j
aWYgWFBfV0lOCisjaWYgZGVmaW5lZChYUF9XSU4pCiAjZGVmaW5lIFNURENBTEwgX19zdGRjYWxs
CiAKIHN0YXRpYyBpbmxpbmUgaW50IHN0cmNhc2VjbXAoY29uc3QgY2hhciogczEsIGNvbnN0IGNo
YXIqIHMyKQpAQCAtNzMsNyArNzMsNyBAQCBOUEVycm9yIFNURENBTEwgTlBfSW5pdGlhbGl6ZShO
UE5ldHNjYXBlRnVuY3MgKmJyb3dzZXJGdW5jcwogewogICAgIGluaXRpYWxpemVXYXNDYWxsZWQg
PSB0cnVlOwogCi0jaWYgWFBfV0lOCisjaWYgZGVmaW5lZChYUF9XSU4pCiAgICAgLy8gU2ltdWxh
dGUgRmxhc2ggYW5kIFF1aWNrVGltZSdzIGJlaGF2aW9yIG9mIGNyYXNoaW5nIHdoZW4gTlBfSW5p
dGlhbGl6ZSBpcyBjYWxsZWQgYmVmb3JlIE5QX0dldEVudHJ5UG9pbnRzLgogICAgIGlmICghZ2V0
RW50cnlQb2ludHNXYXNDYWxsZWQpCiAgICAgICAgIENSQVNIKCk7CkBAIC0yMzksNyArMjM5LDcg
QEAgTlBFcnJvciBOUFBfTmV3KE5QTUlNRVR5cGUgcGx1Z2luVHlwZSwgTlBQIGluc3RhbmNlLCB1
aW50MTZfdCBtb2RlLCBpbnQxNl90IGFyZ2MKICAgICAgICAgICAgICAgICByZXR1cm4gTlBFUlJf
SU5DT01QQVRJQkxFX1ZFUlNJT05fRVJST1I7CiAjZW5kaWYKICAgICAgICAgfSBlbHNlIGlmIChz
dHJjYXNlY21wKGFyZ25baV0sICJ0ZXN0R2V0VVJMT25EZXN0cm95IikgPT0gMCkgewotI2lmIFhQ
X1dJTgorI2lmIGRlZmluZWQoWFBfV0lOKQogICAgICAgICAgICAgLy8gRklYTUU6IFdoZW4gaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxODMxIGlzIGZpeGVkLCB0aGlz
ICNpZmRlZiBjYW4gYmUgcmVtb3ZlZC4KICAgICAgICAgICAgIG9iai0+dGVzdEdldFVSTE9uRGVz
dHJveSA9IFRSVUU7CiAjZW5kaWYK
</data>

          </attachment>
      

    </bug>

</bugzilla>