51457 2010-12-22 02:47:03 -0800 [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension() 2010-12-24 03:23:38 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim antognolli+webkit commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 325429 0 gyuyoung.kim 2010-12-22 02:47:03 -0800 WebKit EFL can't play html5 audio now. I look into WebCore in order to find the reason. When MediaPlayer loads content via url, it checks mediaType with file extension. But, if getMIMETypeForExtension() of MIMETypeRegistryEfl.cpp cannot find same mime type with the extension, it returns "application/octet-stream". String MIMETypeRegistry::getMIMETypeForExtension(const String &ext) { String s = ext.lower(); const ExtensionMap *e = extensionMap; while (e->extension) { if (s == e->extension) return e->mimeType; ++e; } return "application/octet-stream"; } But, if the getMIMETypeForExtension() of MIMETypeRegistryEfl.cpp cannot find appropriate mime type, getMIMETypeForExtension() of MIMETypeRegistry.cpp tries to find mime type in mediaMIMETypeMap() of MIMETypeRegistry.cpp. Unfortunately, HTML5 Audio doesn't be played in WebKit EFL because getMIMETypeForExtension() of MIMETypeRegistryEfl.cpp returns "application/octet-stream". String MIMETypeRegistry::getMediaMIMETypeForExtension(const String& ext) { // Look in the system-specific registry first. String type = getMIMETypeForExtension(ext); if (!type.isEmpty()) return type; Vector<String>* typeList = mediaMIMETypeMap().get(ext); if (typeList) return (*typeList)[0]; return String(); } So, I change the "application/octet-stream" with "String()". Below demo sites can be worked based on this patch. - http://moztw.org/demo/audioplayer/ - http://www.scottandrew.com/pub/html5audioplayer/ 325430 1 77199 gyuyoung.kim 2010-12-22 02:54:42 -0800 Created attachment 77199 Patch 325477 2 tonikitoo 2010-12-22 06:17:28 -0800 Is it what other ports do? (On the airport now, and can not check myself at the moment) 325754 3 gyuyoung.kim 2010-12-22 16:08:10 -0800 (In reply to comment #2) > Is it what other ports do? > > (On the airport now, and can not check myself at the moment) Yes, other port also tries to find mime type for the extension type. But, if it cannot find mime type, it just returns empty string. Then, if the other port's getMIMETypeForExtension() returns empty string, the getMediaMIMETypeForExtension() of MIMETypeRegistry.cpp finds a proper mime type in mediaMIMETypeMap() for the extension. (The mediaMIMETypeMap() is defined in MIMETypeRegistry.cpp). In MIMETypeRegistryGtk.cpp String MIMETypeRegistry::getMIMETypeForExtension(const String &ext) { String s = ext.lower(); const ExtensionMap *e = extensionMap; while (e->extension) { if (s == e->extension) return e->mimeType; ++e; } return String(); } In MIMETypeRegistryQt.cpp String MIMETypeRegistry::getMIMETypeForExtension(const String &ext) { String s = ext.lower(); const ExtensionMap *e = extensionMap; while (e->extension) { if (s == e->extension) return e->mimeType; ++e; } return String(); } In MIMETypeRegistryWinCE.cpp String MIMETypeRegistry::getMIMETypeForExtension(const String &ext) { if (ext.isEmpty()) return String(); initMIMETypeEntensionMap(); String result = mimetypeMap.get(ext.lower()); if (result.isEmpty()) { result = mimeTypeForExtension(ext); if (!result.isEmpty()) mimetypeMap.add(ext, result); } return result.isEmpty() ? "unknown/unknown" : result; } 325976 4 77199 eric 2010-12-23 01:16:00 -0800 Comment on attachment 77199 Patch Tests should be layout tests. Does EFL run the layout tests yet? 325991 5 gyuyoung.kim 2010-12-23 01:58:09 -0800 (In reply to comment #4) > (From update of attachment 77199 [details]) > Tests should be layout tests. Does EFL run the layout tests yet? Yes, right. WebKit EFL doesn't have layout test yet. But, we are preparing to contribute DRT for WebKit EFL. 326010 6 gyuyoung.kim 2010-12-23 03:20:07 -0800 Should I remove the test sites in ChangeLog ? 326320 7 77375 gyuyoung.kim 2010-12-23 15:23:15 -0800 Created attachment 77375 Patch Remove test sites in ChangeLog 326567 8 77375 commit-queue 2010-12-24 03:23:31 -0800 Comment on attachment 77375 Patch Clearing flags on attachment: 77375 Committed r74625: <http://trac.webkit.org/changeset/74625> 326568 9 commit-queue 2010-12-24 03:23:38 -0800 All reviewed patches have been landed. Closing bug. 77199 2010-12-22 02:54:42 -0800 2010-12-23 15:23:15 -0800 Patch patch-mimetype.patch text/plain 1426 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGEyMjY2My4uYWIzN2Q0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0yMiAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJldHVybiAnbnVsbCcgaW5zdGVhZCBvZiAnYXBw bGljYXRpb24vb2N0ZXQtc3RyZWFtJyBpbiBnZXRNSU1FVHlwZUZvckV4dGVuc2lvbigpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTQ1NworCisgICAg ICAgIFdlYktpdCBFRkwgY2FuJ3QgcGxheSBodG1sNSBhdWRpbyBiZWNhdXNlIG9mIHdyb25nIG1p bWUgdHlwZSBjaGVja2luZy4KKyAgICAgICAgU28sICdhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0n IGlzIGNoYW5nZWQgd2l0aCAnbnVsbCcuCisKKyAgICAgICAgVGVzdHMgOiBodHRwOi8vbW96dHcu b3JnL2RlbW8vYXVkaW9wbGF5ZXIvLCBodHRwOi8vd3d3LnNjb3R0YW5kcmV3LmNvbS9wdWIvaHRt bDVhdWRpb3BsYXllci8KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9NSU1FVHlwZVJlZ2lzdHJ5 RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1JTUVUeXBlUmVnaXN0cnk6OmdldE1JTUVUeXBl Rm9yRXh0ZW5zaW9uKTogCisgICAgICAgIFJldHVybnMgbnVsbCBpbnN0ZWFkIG9mIGFwcGxpY2F0 aW9uL29jdGV0LXN0cmVhbSB3aGVuIGl0IGNhbid0IGZpbmQgcHJvcGVyIG1pbWUgdHlwZS4KKwog MjAxMC0xMi0yMCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9NSU1FVHlwZVJlZ2lzdHJ5RWZsLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZWZs L01JTUVUeXBlUmVnaXN0cnlFZmwuY3BwCmluZGV4IGI5OGM4MTguLmQwYzk1YmYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZWZsL01JTUVUeXBlUmVnaXN0cnlFZmwuY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vZWZsL01JTUVUeXBlUmVnaXN0cnlFZmwuY3BwCkBAIC04MCw3ICs4MCw3 IEBAIFN0cmluZyBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlwZUZvckV4dGVuc2lvbihjb25z dCBTdHJpbmcgJmV4dCkKICAgICAgICAgKytlOwogICAgIH0KIAotICAgIHJldHVybiAiYXBwbGlj YXRpb24vb2N0ZXQtc3RyZWFtIjsKKyAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKIGJvb2wgTUlN RVR5cGVSZWdpc3RyeTo6aXNBcHBsaWNhdGlvblBsdWdpbk1JTUVUeXBlKGNvbnN0IFN0cmluZyYp Cg== 77375 2010-12-23 15:23:15 -0800 2010-12-24 03:23:31 -0800 Patch patch-mimetype.patch text/plain 1346 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTQ3NWQ4NS4uZjcwMTAxNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0yMyAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJldHVybiBhbiBlbXB0eSBzdHJpbmcgaW5zdGVh ZCBvZiAnYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtJyBpbiBnZXRNSU1FVHlwZUZvckV4dGVuc2lv bigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTQ1 NworCisgICAgICAgIFdlYktpdCBFRkwgY2FuJ3QgcGxheSBodG1sNSBhdWRpbyBiZWNhdXNlIG9m IHdyb25nIG1pbWUgdHlwZSBjaGVja2luZy4KKyAgICAgICAgU28sICdhcHBsaWNhdGlvbi9vY3Rl dC1zdHJlYW0nIGlzIGNoYW5nZWQgd2l0aCBhbiBlbXB0eSBzdHJpbmcuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9lZmwvTUlNRVR5cGVSZWdpc3RyeUVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpN SU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlwZUZvckV4dGVuc2lvbik6CisgICAgICAgIFJldHVy bnMgYW4gZW1wdHkgc3RyaW5nIGluc3RlYWQgb2YgYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtIHdo ZW4gaXQgY2FuJ3QgZmluZCBwcm9wZXIgbWltZSB0eXBlLgorCiAyMDEwLTEyLTIyICBBZHJpZW5u ZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0 aCBSdXNzZWxsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTUlNRVR5cGVSZWdp c3RyeUVmbC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9NSU1FVHlwZVJlZ2lzdHJ5RWZsLmNw cAppbmRleCBiOThjODE4Li5kMGM5NWJmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9NSU1FVHlwZVJlZ2lzdHJ5RWZsLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9NSU1F VHlwZVJlZ2lzdHJ5RWZsLmNwcApAQCAtODAsNyArODAsNyBAQCBTdHJpbmcgTUlNRVR5cGVSZWdp c3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24oY29uc3QgU3RyaW5nICZleHQpCiAgICAgICAg ICsrZTsKICAgICB9CiAKLSAgICByZXR1cm4gImFwcGxpY2F0aW9uL29jdGV0LXN0cmVhbSI7Cisg ICAgcmV0dXJuIFN0cmluZygpOwogfQogCiBib29sIE1JTUVUeXBlUmVnaXN0cnk6OmlzQXBwbGlj YXRpb25QbHVnaW5NSU1FVHlwZShjb25zdCBTdHJpbmcmKQo=