51453 2010-12-22 00:17:06 -0800 [Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded() 2011-01-06 09:35:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED P3 Normal --- 0 apple64 webkit-unassigned abarth commit-queue eric jhanssen markus webkit.review.bot oldest_to_newest 325405 0 apple64 2010-12-22 00:17:06 -0800 While working with a 3rd-party html/js widget loaded into QWebView, I've experienced a crash in QNetworkReplyHandler::sendResponseIfNeeded(). The crash happens when this method tries to call m_reply->error(), while m_reply value is NULL. (Qt 4.6: qnetworkreplyhandler.cpp line 262) (WebKit Trac (Dec 22nd 2010): qnetworkreplyhandler.cpp line 352) Please find full call stack (Qt 4.6 opensource) attached. The problem was initially reproduced on Qt 4.6, later - confirmed on Qt 4.7, but is likely to be present also in latest qnetworkreplyhandler.cpp version retrieved on 22.12.2010 via WebKit Trac (http://trac.webkit.org/browser/trunk/WebCore/platform/network/qt/QNetworkReplyHandler.cpp). Steps to reproduce are not available, unfortunately, as I'm not authorized to upload the problematic widget here. Anyway, the crash can be fixed by adding a check whether m_reply value is NULL, prior to performing any actions on the pointer. 325406 1 77193 apple64 2010-12-22 00:18:21 -0800 Created attachment 77193 Call stack for the crash 329882 2 78068 jhanssen 2011-01-05 16:59:34 -0800 Created attachment 78068 Patch Check if m_reply is NULL before using as suggested by the reporter 330104 3 78068 jhanssen 2011-01-06 05:45:00 -0800 Comment on attachment 78068 Patch Appears to need more investigation, clearing flags. 330123 4 78114 jhanssen 2011-01-06 06:52:59 -0800 Created attachment 78114 Patch The problem encountered with the manual test in this case is that emitting processQueuedItems() may cause the ResourceHandle that owns the current QNetworkReplyHandler to be destroyed, setting m_reply to 0. This patch checks if m_reply is 0 before using. This may be related to bug 51641 330136 5 78114 kling 2011-01-06 07:35:04 -0800 Comment on attachment 78114 Patch r=me, and thanks for digging into this! :) 330160 6 78114 commit-queue 2011-01-06 08:32:00 -0800 Comment on attachment 78114 Patch Clearing flags on attachment: 78114 Committed r75157: <http://trac.webkit.org/changeset/75157> 330161 7 commit-queue 2011-01-06 08:32:06 -0800 All reviewed patches have been landed. Closing bug. 330184 8 webkit.review.bot 2011-01-06 09:35:17 -0800 http://trac.webkit.org/changeset/75157 might have broken Leopard Intel Debug (Tests) 77193 2010-12-22 00:18:21 -0800 2010-12-22 00:18:21 -0800 Call stack for the crash callstack.txt text/plain 3263 apple64 IAlRdE5ldHdvcmtkNC5kbGwhUVNjb3BlZFBvaW50ZXI8UU9iamVjdERhdGEsUVNjb3BlZFBvaW50 ZXJEZWxldGVyPFFPYmplY3REYXRhPiA+OjpkYXRhKCkgIExpbmUgMTM1ICsgMHgzIGJ5dGVzCUMr Kw0KIAlRdE5ldHdvcmtkNC5kbGwhcUdldFB0ckhlbHBlcjxRU2NvcGVkUG9pbnRlcjxRT2JqZWN0 RGF0YSxRU2NvcGVkUG9pbnRlckRlbGV0ZXI8UU9iamVjdERhdGE+ID4gPihjb25zdCBRU2NvcGVk UG9pbnRlcjxRT2JqZWN0RGF0YSxRU2NvcGVkUG9pbnRlckRlbGV0ZXI8UU9iamVjdERhdGE+ID4g JiBwPXsuLi59KSAgTGluZSAyMzE1ICsgMHhiIGJ5dGVzCUMrKw0KIAlRdE5ldHdvcmtkNC5kbGwh UU5ldHdvcmtSZXBseTo6ZF9mdW5jKCkgIExpbmUgMTY4ICsgMHgxMyBieXRlcwlDKysNCj4JUXRO ZXR3b3JrZDQuZGxsIVFOZXR3b3JrUmVwbHk6OmVycm9yKCkgIExpbmUgNDUxICsgMHg4IGJ5dGVz CUMrKw0KIAlRdFdlYktpdGQ0LmRsbCFXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6c2Vu ZFJlc3BvbnNlSWZOZWVkZWQoKSAgTGluZSAyNjIgKyAweGYgYnl0ZXMJQysrDQogCVF0V2ViS2l0 ZDQuZGxsIVdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpmb3J3YXJkRGF0YSgpICBMaW5l IDM0NglDKysNCiAJUXRXZWJLaXRkNC5kbGwhV2ViQ29yZTo6UU5ldHdvcmtSZXBseUhhbmRsZXI6 OnNlbmRRdWV1ZWRJdGVtcygpICBMaW5lIDQ2MglDKysNCiAJUXRXZWJLaXRkNC5kbGwhV2ViQ29y ZTo6UU5ldHdvcmtSZXBseUhhbmRsZXI6OnF0X21ldGFjYWxsKFFNZXRhT2JqZWN0OjpDYWxsIF9j PUludm9rZU1ldGFNZXRob2QsIGludCBfaWQ9NCwgdm9pZCAqICogX2E9MHgxNWU3YWVjOCkgIExp bmUgODgJQysrDQogCVF0Q29yZWQ0LmRsbCFRTWV0YU9iamVjdDo6bWV0YWNhbGwoUU9iamVjdCAq IG9iamVjdD0weDE2MmNhNTAwLCBRTWV0YU9iamVjdDo6Q2FsbCBjbD1JbnZva2VNZXRhTWV0aG9k LCBpbnQgaWR4PTgsIHZvaWQgKiAqIGFyZ3Y9MHgxNWU3YWVjOCkgIExpbmUgMjM4CUMrKw0KIAlR dENvcmVkNC5kbGwhUU1ldGFDYWxsRXZlbnQ6OnBsYWNlTWV0YUNhbGwoUU9iamVjdCAqIG9iamVj dD0weDE2MmNhNTAwKSAgTGluZSA1NzQgKyAweDE5IGJ5dGVzCUMrKw0KIAlRdENvcmVkNC5kbGwh UU9iamVjdDo6ZXZlbnQoUUV2ZW50ICogZT0weDE2MWI3YzkwKSAgTGluZSAxMjUyICsgMHgxNCBi eXRlcwlDKysNCiAJUXRHdWlkNC5kbGwhUUFwcGxpY2F0aW9uUHJpdmF0ZTo6bm90aWZ5X2hlbHBl cihRT2JqZWN0ICogcmVjZWl2ZXI9MHgxNjJjYTUwMCwgUUV2ZW50ICogZT0weDE2MWI3YzkwKSAg TGluZSA0MjQyICsgMHgxMSBieXRlcwlDKysNCiAJUXRHdWlkNC5kbGwhUUFwcGxpY2F0aW9uOjpu b3RpZnkoUU9iamVjdCAqIHJlY2VpdmVyPTB4MTYyY2E1MDAsIFFFdmVudCAqIGU9MHgxNjFiN2M5 MCkgIExpbmUgMzY2MSArIDB4MTAgYnl0ZXMJQysrDQogCVF0Q29yZWQ0LmRsbCFRQ29yZUFwcGxp Y2F0aW9uOjpub3RpZnlJbnRlcm5hbChRT2JqZWN0ICogcmVjZWl2ZXI9MHgxNjJjYTUwMCwgUUV2 ZW50ICogZXZlbnQ9MHgxNjFiN2M5MCkgIExpbmUgNzA0ICsgMHgxNSBieXRlcwlDKysNCiAJUXRD b3JlZDQuZGxsIVFDb3JlQXBwbGljYXRpb246OnNlbmRFdmVudChRT2JqZWN0ICogcmVjZWl2ZXI9 MHgxNjJjYTUwMCwgUUV2ZW50ICogZXZlbnQ9MHgxNjFiN2M5MCkgIExpbmUgMjE1ICsgMHgzOSBi eXRlcwlDKysNCiAJUXRDb3JlZDQuZGxsIVFDb3JlQXBwbGljYXRpb25Qcml2YXRlOjpzZW5kUG9z dGVkRXZlbnRzKFFPYmplY3QgKiByZWNlaXZlcj0weDAwMDAwMDAwLCBpbnQgZXZlbnRfdHlwZT0w LCBRVGhyZWFkRGF0YSAqIGRhdGE9MHgwNDBkMWNmOCkgIExpbmUgMTM0NSArIDB4ZCBieXRlcwlD KysNCiAJUXRDb3JlZDQuZGxsIXF0X2ludGVybmFsX3Byb2MoSFdORF9fICogaHduZD0weDAwMDIw ODkyLCB1bnNpZ25lZCBpbnQgbWVzc2FnZT0xMDI1LCB1bnNpZ25lZCBpbnQgd3A9MCwgbG9uZyBs cD0wKSAgTGluZSA1MDcgKyAweDEwIGJ5dGVzCUMrKw0KIAl1c2VyMzIuZGxsITdlNDE4NzM0KCkg CQ0KIAlbRnJhbWVzIGJlbG93IG1heSBiZSBpbmNvcnJlY3QgYW5kL29yIG1pc3NpbmcsIG5vIHN5 bWJvbHMgbG9hZGVkIGZvciB1c2VyMzIuZGxsXQkNCiAJdXNlcjMyLmRsbCE3ZTQxODgxNigpIAkN CiAJdXNlcjMyLmRsbCE3ZTQxODljZCgpIAkNCiAJdXNlcjMyLmRsbCE3ZTQxOTQwMigpIAkNCiAJ dXNlcjMyLmRsbCE3ZTQxOGExMCgpIAkNCiAJUXRDb3JlZDQuZGxsIVFFdmVudERpc3BhdGNoZXJX aW4zMjo6cHJvY2Vzc0V2ZW50cyhRRmxhZ3M8ZW51bSBRRXZlbnRMb29wOjpQcm9jZXNzRXZlbnRz RmxhZz4gZmxhZ3M9ey4uLn0pICBMaW5lIDc1MwlDKysNCiAJUXRHdWlkNC5kbGwhUUd1aUV2ZW50 RGlzcGF0Y2hlcldpbjMyOjpwcm9jZXNzRXZlbnRzKFFGbGFnczxlbnVtIFFFdmVudExvb3A6OlBy b2Nlc3NFdmVudHNGbGFnPiBmbGFncz17Li4ufSkgIExpbmUgMTEzMyArIDB4MTUgYnl0ZXMJQysr DQogCVF0Q29yZWQ0LmRsbCFRRXZlbnRMb29wOjpwcm9jZXNzRXZlbnRzKFFGbGFnczxlbnVtIFFF dmVudExvb3A6OlByb2Nlc3NFdmVudHNGbGFnPiBmbGFncz17Li4ufSkgIExpbmUgMTUwCUMrKw0K IAlRdENvcmVkNC5kbGwhUUV2ZW50TG9vcDo6ZXhlYyhRRmxhZ3M8ZW51bSBRRXZlbnRMb29wOjpQ cm9jZXNzRXZlbnRzRmxhZz4gZmxhZ3M9ey4uLn0pICBMaW5lIDIwMSArIDB4MmQgYnl0ZXMJQysr DQogCVF0Q29yZWQ0LmRsbCFRQ29yZUFwcGxpY2F0aW9uOjpleGVjKCkgIExpbmUgOTgxICsgMHgx NSBieXRlcwlDKysNCiAJUXRHdWlkNC5kbGwhUUFwcGxpY2F0aW9uOjpleGVjKCkgIExpbmUgMzU3 MQlDKysNCiAJQ29tbXVuaWNhdG9yLmV4ZSFtYWluKGludCBhcmdjPTEsIGNoYXIgKiAqIGFyZ3Y9 MHgwNDBkMDkyOCkgIExpbmUgNTQgKyAweDggYnl0ZXMJQysrDQogCUNvbW11bmljYXRvci5leGUh V2luTWFpbihISU5TVEFOQ0VfXyAqIGluc3RhbmNlPTB4MDA0MDAwMDAsIEhJTlNUQU5DRV9fICog cHJldkluc3RhbmNlPTB4MDAwMDAwMDAsIGNoYXIgKiBfX2Zvcm1hbD0weDAwMDUxZjEyLCBpbnQg Y21kU2hvdz0xKSAgTGluZSAxMzEgKyAweDEyIGJ5dGVzCUMrKw0KIAlDb21tdW5pY2F0b3IuZXhl IV9fdG1haW5DUlRTdGFydHVwKCkgIExpbmUgNTg5ICsgMHgzNSBieXRlcwlDDQogCUNvbW11bmlj YXRvci5leGUhV2luTWFpbkNSVFN0YXJ0dXAoKSAgTGluZSA0MTQJQw0KIAlrZXJuZWwzMi5kbGwh N2M4MTcwNzcoKSAJDQo= 78068 2011-01-05 16:59:34 -0800 2011-01-06 06:52:52 -0800 Patch bug-51453-20110106015931.patch text/plain 3030 jhanssen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODEyZWQ5ZWNmN2NkOTU2ODNlZjg5YzMyMjNlNTg3MGRhMTgwODgwOS4uNTk2YjFhMDQxM2ZkYmZm NTdiMTQwZDA1OGIxOTU4YTE4MGYwNDNjMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wMS0wNSAgSmFu IEVyaWsgSGFuc3NlbiAgPGpoYW5zc2VuQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBjcmFzaCBpbiBRTmV0d29ya1JlcGx5 SGFuZGxlcjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE0NTMKKworICAgICAgICBDaGVjayBpZiBtX3JlcGx5 IGlzIE5VTEwgYmVmb3JlIGFjY2Vzc2luZworCisgICAgICAgICogbWFudWFsLXRlc3RzL2xvYWQt ZGVmZXJyZXItcmVzdW1lLWNyYXNoLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UU5l dHdvcmtSZXBseUhhbmRsZXI6OnNldExvYWRNb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3 b3JrUmVwbHlIYW5kbGVyOjpzZW5kUmVzcG9uc2VJZk5lZWRlZCk6CisKIDIwMTEtMDEtMDUgIEFi aGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvbG9hZC1kZWZlcnJlci1yZXN1bWUt Y3Jhc2guaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2xvYWQtZGVmZXJyZXItcmVzdW1lLWNy YXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uODlmMTViMTNjNDUxZWNjMGMxYzE0NmYyODIyN2VlODNiNDVi ODY5NAotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2xvYWQtZGVmZXJy ZXItcmVzdW1lLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwzMyBAQAorPGh0bWw+Cis8aGVhZD4KKzxz Y3JpcHQ+Cit2YXIgY291bnRlciA9IDA7CisKK2Z1bmN0aW9uIGxvYWRKU0ZpbGUoKXsKKyAgICB2 YXIgaSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2ltZycpCisgICAgaS5zZXRBdHRyaWJ1dGUo InNyYyIsICJyZXNvdXJjZXMvYXBwbGUuanBnP2NvdW50ZXI9IiArIGNvdW50ZXIpOworCisgICAg Y291bnRlcisrOworCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltYWdlcyIpLmFwcGVu ZENoaWxkKGkpOworfQorCitmdW5jdGlvbiBydW5Nb2RhbCgpCit7CisgICAgbG9hZEpTRmlsZSgp OworIAorICAgIGFsZXJ0KCJEZWZlcnJpbmcgbG9hZHMiKTsKK30KKzwvc2NyaXB0PgorPC9oZWFk PgorIAorPGJvZHk+CisKKzxpbnB1dCBpZD0iYnV0dG9uIiB0eXBlPSJidXR0b24iIHZhbHVlPSJj bGljayBtZSIgb25jbGljaz0icnVuTW9kYWwoKSIvPgorICAgIAorPGRpdiBpZD0iaW1hZ2VzIj48 L2Rpdj4KKworPHA+Q2xpY2sgdGhlIGFib3ZlIGJ1dHRvbiB0byBzdGFydCBsb2FkaW5nIGFuIGlt YWdlIGFuZCB0aGVuIG9wZW4gYW4gYWxlcnQoKSBib3guIEZvciB0aGUgdGVzdCB0byBwYXNzIHRo ZXJlIHNob3VsZCBiZSBubyBjcmFzaCB3aGVuIGNsb3NpbmcgdGhlIGFsZXJ0IGJveC48L3A+CisK KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9x dC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQv UU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCmluZGV4IDJmZjdkOWNjNGQ1MGZjMGVjYjgxNTkzNjJi ZTUzNzFiMmVjZTAwMDMuLmFiOTY5ZjMyMTM0MjZhODk3MjhmMTc5MWY0ZmZhYzUwNGUzYjEyNzQg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFu ZGxlci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlI YW5kbGVyLmNwcApAQCAtMjQ0LDExICsyNDQsMTMgQEAgdm9pZCBRTmV0d29ya1JlcGx5SGFuZGxl cjo6c2V0TG9hZE1vZGUoTG9hZE1vZGUgbW9kZSkKICAgICAgICAgZW1pdCBwcm9jZXNzUXVldWVk SXRlbXMoKTsKICAgICAgICAgLy8gUmVzdGFydCBmb3J3YXJkaW5nIG9ubHkgYWZ0ZXIgcHJvY2Vz c1F1ZXVlZEl0ZW1zIHRvIG1ha2Ugc3VyZQogICAgICAgICAvLyBvdXIgYnVmZmVyZWQgZGF0YSB3 YXMgaGFuZGxlZCBiZWZvcmUgYW55IGluY29taW5nIGRhdGEuCi0gICAgICAgIG1fcmVwbHktPnNl dEZvcndhcmRpbmdEZWZlcmVkKGZhbHNlKTsKKyAgICAgICAgaWYgKG1fcmVwbHkpCisgICAgICAg ICAgICBtX3JlcGx5LT5zZXRGb3J3YXJkaW5nRGVmZXJlZChmYWxzZSk7CiAgICAgICAgIGJyZWFr OwogICAgIGNhc2UgTG9hZERlZmVycmVkOgogICAgICAgICBtX2xvYWRNb2RlID0gTG9hZERlZmVy cmVkOwotICAgICAgICBtX3JlcGx5LT5zZXRGb3J3YXJkaW5nRGVmZXJlZCh0cnVlKTsKKyAgICAg ICAgaWYgKG1fcmVwbHkpCisgICAgICAgICAgICBtX3JlcGx5LT5zZXRGb3J3YXJkaW5nRGVmZXJl ZCh0cnVlKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBMb2FkUmVzdW1pbmc6CiAgICAgICAg IFFfQVNTRVJUKDApOyAvLyBzaG91bGQgbmV2ZXIgaGFwcGVuCkBAIC0zNDksNiArMzUxLDkgQEAg dm9pZCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQoKQogICAgIGlm IChtX3Nob3VsZFNlbmRSZXNwb25zZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKCFtX3Jl cGx5KQorICAgICAgICByZXR1cm47CisKICAgICBpZiAobV9yZXBseS0+ZXJyb3IoKSAmJiAhaWdu b3JlSHR0cEVycm9yKG1fcmVwbHksIG1fcmVzcG9uc2VDb250YWluc0RhdGEpKQogICAgICAgICBy ZXR1cm47CiAK 78114 2011-01-06 06:52:59 -0800 2011-01-06 08:31:59 -0800 Patch bug-51453-20110106155256.patch text/plain 3522 jhanssen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWRiZTcyZDI0ZTVhYzRkNzVlMmZmYzg3YzNkNmUzZmViZjg4NDAzYS4uNzY2ZWIyNDk4Y2VjZGQ0 NTI3MGQxN2VmMWE5NWIxZWNkYjAzYzE4ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wMS0wNiAgSmFu IEVyaWsgSGFuc3NlbiAgPGpoYW5zc2VuQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBjcmFzaCBpbiBRTmV0d29ya1JlcGx5 SGFuZGxlcjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE0NTMKKworICAgICAgICBDaGVjayBpZiBtX3JlcGx5 IGlzIE5VTEwgYmVmb3JlIGFjY2Vzc2luZy4KKworICAgICAgICAqIG1hbnVhbC10ZXN0cy9sb2Fk LWRlZmVycmVyLXJlc3VtZS1jcmFzaC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFO ZXR3b3JrUmVwbHlIYW5kbGVyOjpzZXRMb2FkTW9kZSk6CisgICAgICAgIChXZWJDb3JlOjpRTmV0 d29ya1JlcGx5SGFuZGxlcjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQpOgorCiAyMDExLTAxLTA2ICBI ZWxkZXIgQ29ycmVpYSAgPGhlbGRlckBzZW5jaGEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwt dGVzdHMvbG9hZC1kZWZlcnJlci1yZXN1bWUtY3Jhc2guaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRl c3RzL2xvYWQtZGVmZXJyZXItcmVzdW1lLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODlmMTViMTNj NDUxZWNjMGMxYzE0NmYyODIyN2VlODNiNDViODY5NAotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNv cmUvbWFudWFsLXRlc3RzL2xvYWQtZGVmZXJyZXItcmVzdW1lLWNyYXNoLmh0bWwKQEAgLTAsMCAr MSwzMyBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+Cit2YXIgY291bnRlciA9IDA7CisKK2Z1 bmN0aW9uIGxvYWRKU0ZpbGUoKXsKKyAgICB2YXIgaSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J2ltZycpCisgICAgaS5zZXRBdHRyaWJ1dGUoInNyYyIsICJyZXNvdXJjZXMvYXBwbGUuanBnP2Nv dW50ZXI9IiArIGNvdW50ZXIpOworCisgICAgY291bnRlcisrOworCisgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImltYWdlcyIpLmFwcGVuZENoaWxkKGkpOworfQorCitmdW5jdGlvbiBydW5N b2RhbCgpCit7CisgICAgbG9hZEpTRmlsZSgpOworIAorICAgIGFsZXJ0KCJEZWZlcnJpbmcgbG9h ZHMiKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorIAorPGJvZHk+CisKKzxpbnB1dCBpZD0iYnV0 dG9uIiB0eXBlPSJidXR0b24iIHZhbHVlPSJjbGljayBtZSIgb25jbGljaz0icnVuTW9kYWwoKSIv PgorICAgIAorPGRpdiBpZD0iaW1hZ2VzIj48L2Rpdj4KKworPHA+Q2xpY2sgdGhlIGFib3ZlIGJ1 dHRvbiB0byBzdGFydCBsb2FkaW5nIGFuIGltYWdlIGFuZCB0aGVuIG9wZW4gYW4gYWxlcnQoKSBi b3guIEZvciB0aGUgdGVzdCB0byBwYXNzIHRoZXJlIHNob3VsZCBiZSBubyBjcmFzaCB3aGVuIGNs b3NpbmcgdGhlIGFsZXJ0IGJveC48L3A+CisKKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCmluZGV4 IDJmZjdkOWNjNGQ1MGZjMGVjYjgxNTkzNjJiZTUzNzFiMmVjZTAwMDMuLjk4ZmQ2OGQyNmVmN2Ew NTkzYjM0MmIyMjUyNzZhOGJiYWI5MjY1NDkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcApAQCAtMjQyLDEzICsyNDIsMjAg QEAgdm9pZCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6c2V0TG9hZE1vZGUoTG9hZE1vZGUgbW9kZSkK ICAgICBjYXNlIExvYWROb3JtYWw6CiAgICAgICAgIG1fbG9hZE1vZGUgPSBMb2FkUmVzdW1pbmc7 CiAgICAgICAgIGVtaXQgcHJvY2Vzc1F1ZXVlZEl0ZW1zKCk7Ci0gICAgICAgIC8vIFJlc3RhcnQg Zm9yd2FyZGluZyBvbmx5IGFmdGVyIHByb2Nlc3NRdWV1ZWRJdGVtcyB0byBtYWtlIHN1cmUKLSAg ICAgICAgLy8gb3VyIGJ1ZmZlcmVkIGRhdGEgd2FzIGhhbmRsZWQgYmVmb3JlIGFueSBpbmNvbWlu ZyBkYXRhLgotICAgICAgICBtX3JlcGx5LT5zZXRGb3J3YXJkaW5nRGVmZXJlZChmYWxzZSk7CisK KyAgICAgICAgLy8gc2VuZFF1ZXVlZEl0ZW1zKCkgbWF5IGNhdXNlIG1fcmVwbHkgdG8gYmUgc2V0 IHRvIDAgZHVlIHRvIHRoZSBmaW5pc2goKSBjYWxsIGNhdXNpbmcKKyAgICAgICAgLy8gdGhlIFJl c291cmNlSGFuZGxlIGluc3RhbmNlIHRoYXQgb3ducyB0aGlzIFFOZXR3b3JrUmVwbHlIYW5kbGVy IHRvIGJlIGRlc3Ryb3llZC4KKyAgICAgICAgaWYgKG1fcmVwbHkpIHsKKyAgICAgICAgICAgIC8v IFJlc3RhcnQgZm9yd2FyZGluZyBvbmx5IGFmdGVyIHByb2Nlc3NRdWV1ZWRJdGVtcyB0byBtYWtl IHN1cmUKKyAgICAgICAgICAgIC8vIG91ciBidWZmZXJlZCBkYXRhIHdhcyBoYW5kbGVkIGJlZm9y ZSBhbnkgaW5jb21pbmcgZGF0YS4KKyAgICAgICAgICAgIG1fcmVwbHktPnNldEZvcndhcmRpbmdE ZWZlcmVkKGZhbHNlKTsKKyAgICAgICAgfQogICAgICAgICBicmVhazsKICAgICBjYXNlIExvYWRE ZWZlcnJlZDoKLSAgICAgICAgbV9sb2FkTW9kZSA9IExvYWREZWZlcnJlZDsKLSAgICAgICAgbV9y ZXBseS0+c2V0Rm9yd2FyZGluZ0RlZmVyZWQodHJ1ZSk7CisgICAgICAgIGlmIChtX3JlcGx5KSB7 CisgICAgICAgICAgICBtX2xvYWRNb2RlID0gTG9hZERlZmVycmVkOworICAgICAgICAgICAgbV9y ZXBseS0+c2V0Rm9yd2FyZGluZ0RlZmVyZWQodHJ1ZSk7CisgICAgICAgIH0KICAgICAgICAgYnJl YWs7CiAgICAgY2FzZSBMb2FkUmVzdW1pbmc6CiAgICAgICAgIFFfQVNTRVJUKDApOyAvLyBzaG91 bGQgbmV2ZXIgaGFwcGVuCkBAIC0zNDksNiArMzU2LDkgQEAgdm9pZCBRTmV0d29ya1JlcGx5SGFu ZGxlcjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQoKQogICAgIGlmIChtX3Nob3VsZFNlbmRSZXNwb25z ZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKCFtX3JlcGx5KQorICAgICAgICByZXR1cm47 CisKICAgICBpZiAobV9yZXBseS0+ZXJyb3IoKSAmJiAhaWdub3JlSHR0cEVycm9yKG1fcmVwbHks IG1fcmVzcG9uc2VDb250YWluc0RhdGEpKQogICAgICAgICByZXR1cm47CiAK