51433 2010-12-21 16:50:01 -0800 Enable extensions used in accelerated 2D canvas implementation 2010-12-21 19:32:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth cmarrin dglazkov eric fishd jamesr levin senorblanco simon.fraser webkit.review.bot oldest_to_newest 325269 0 kbr 2010-12-21 16:50:01 -0800 Chromium's Extensions3D implementation requires the caller to ensure that extensions advertised as supported are enabled. (This makes implementing WebGL extensions easier, since those extensions are enabled on-demand.) The accelerated 2D Canvas code needs to enable the BGRA and multisampling-related extensions before using them. 325275 1 77167 kbr 2010-12-21 17:00:19 -0800 Created attachment 77167 Patch 325294 2 kbr 2010-12-21 17:34:50 -0800 Committed r74442: <http://trac.webkit.org/changeset/74442> 325338 3 webkit.review.bot 2010-12-21 19:32:11 -0800 http://trac.webkit.org/changeset/74442 might have broken GTK Linux 64-bit Debug 77167 2010-12-21 17:00:19 -0800 2010-12-21 17:19:35 -0800 Patch bug-51433-20101221170018.patch text/plain 4318 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDQzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTItMjEgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVu YWJsZSBleHRlbnNpb25zIHVzZWQgaW4gYWNjZWxlcmF0ZWQgMkQgY2FudmFzIGltcGxlbWVudGF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTQz MworCisgICAgICAgIENhbGwgRXh0ZW5zaW9uczNEOjplbnN1cmVFbmFibGVkKCkgZm9yIGFsbCBz dXBwb3J0ZWQgZXh0ZW5zaW9ucworICAgICAgICB0aGUgYWNjZWxlcmF0ZWQgMkQgQ2FudmFzIGlt cGxlbWVudGF0aW9uIHVzZXMuIFRlc3RlZCB3aXRoIGEgZmV3CisgICAgICAgIGxheW91dCB0ZXN0 cyBwcmV2aW91c2x5IGZhaWxpbmcgd2hlbiBydW4gaW4gQ2hyb21pdW0gZHVlIHRvIE9wZW5HTAor ICAgICAgICBJTlZBTElEX0VOVU0gYW5kIG90aGVyIGVycm9ycy4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRy YXdpbmdCdWZmZXI6OmNyZWF0ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1No YXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEdyYXBo aWNzQ29udGV4dDNEOjpTaGFyZWRHcmFwaGljc0NvbnRleHQzRCk6CisgICAgICAgIChXZWJDb3Jl OjpTaGFyZWRHcmFwaGljc0NvbnRleHQzRDo6c3VwcG9ydHNCR1JBKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuaDoKKwogMjAxMC0xMi0y MSAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L0RyYXdpbmdCdWZmZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwCShyZXZpc2lvbiA3NDQzNSkKKysrIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 MSw3ICs0MSwxMyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBQYXNzUmVmUHRyPERyYXdpbmdCdWZm ZXI+IERyYXdpbmdCdWZmZXI6OmNyZWF0ZShHcmFwaGljc0NvbnRleHQzRCogY29udGV4dCwgY29u c3QgSW50U2l6ZSYgc2l6ZSkKIHsKICAgICBSZWZQdHI8RHJhd2luZ0J1ZmZlcj4gZHJhd2luZ0J1 ZmZlciA9IGFkb3B0UmVmKG5ldyBEcmF3aW5nQnVmZmVyKGNvbnRleHQsIHNpemUpKTsKLSAgICBk cmF3aW5nQnVmZmVyLT5tX211bHRpc2FtcGxlRXh0ZW5zaW9uU3VwcG9ydGVkID0gY29udGV4dC0+ Z2V0RXh0ZW5zaW9ucygpLT5zdXBwb3J0cygiR0xfQU5HTEVfZnJhbWVidWZmZXJfYmxpdCIpICYm IGNvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+c3VwcG9ydHMoIkdMX0FOR0xFX2ZyYW1lYnVmZmVy X211bHRpc2FtcGxlIik7CisgICAgRXh0ZW5zaW9uczNEKiBleHRlbnNpb25zID0gY29udGV4dC0+ Z2V0RXh0ZW5zaW9ucygpOworICAgIGJvb2wgbXVsdGlzYW1wbGVTdXBwb3J0ZWQgPSBleHRlbnNp b25zLT5zdXBwb3J0cygiR0xfQU5HTEVfZnJhbWVidWZmZXJfYmxpdCIpICYmIGV4dGVuc2lvbnMt PnN1cHBvcnRzKCJHTF9BTkdMRV9mcmFtZWJ1ZmZlcl9tdWx0aXNhbXBsZSIpOworICAgIGlmICht dWx0aXNhbXBsZVN1cHBvcnRlZCkgeworICAgICAgICBleHRlbnNpb25zLT5lbnN1cmVFbmFibGVk KCJHTF9BTkdMRV9mcmFtZWJ1ZmZlcl9ibGl0Iik7CisgICAgICAgIGV4dGVuc2lvbnMtPmVuc3Vy ZUVuYWJsZWQoIkdMX0FOR0xFX2ZyYW1lYnVmZmVyX211bHRpc2FtcGxlIik7CisgICAgfQorICAg IGRyYXdpbmdCdWZmZXItPm1fbXVsdGlzYW1wbGVFeHRlbnNpb25TdXBwb3J0ZWQgPSBtdWx0aXNh bXBsZVN1cHBvcnRlZDsKICAgICByZXR1cm4gKGRyYXdpbmdCdWZmZXItPm1fY29udGV4dCkgPyBk cmF3aW5nQnVmZmVyLnJlbGVhc2UoKSA6IDA7CiB9CiAKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAJ KHJldmlzaW9uIDc0NDM1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVk R3JhcGhpY3NDb250ZXh0M0QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OCwxMSArNjgsMTggQEAg UGFzc1JlZlB0cjxTaGFyZWRHcmFwaGljc0NvbnRleHQzRD4gU2hhcgogCiBTaGFyZWRHcmFwaGlj c0NvbnRleHQzRDo6U2hhcmVkR3JhcGhpY3NDb250ZXh0M0QoUGFzc1JlZlB0cjxHcmFwaGljc0Nv bnRleHQzRD4gY29udGV4dCwgUGFzc093blB0cjxTb2xpZEZpbGxTaGFkZXI+IHNvbGlkRmlsbFNo YWRlciwgUGFzc093blB0cjxUZXhTaGFkZXI+IHRleFNoYWRlcikKICAgICA6IG1fY29udGV4dChj b250ZXh0KQorICAgICwgbV9iZ3JhU3VwcG9ydGVkKGZhbHNlKQogICAgICwgbV9xdWFkVmVydGlj ZXMoMCkKICAgICAsIG1fc29saWRGaWxsU2hhZGVyKHNvbGlkRmlsbFNoYWRlcikKICAgICAsIG1f dGV4U2hhZGVyKHRleFNoYWRlcikKIHsKICAgICBhbGxDb250ZXh0cygpLT5hZGQodGhpcyk7Cisg ICAgRXh0ZW5zaW9uczNEKiBleHRlbnNpb25zID0gbV9jb250ZXh0LT5nZXRFeHRlbnNpb25zKCk7 CisgICAgbV9iZ3JhU3VwcG9ydGVkID0gZXh0ZW5zaW9ucy0+c3VwcG9ydHMoIkdMX0VYVF90ZXh0 dXJlX2Zvcm1hdF9CR1JBODg4OCIpICYmIGV4dGVuc2lvbnMtPnN1cHBvcnRzKCJHTF9FWFRfcmVh ZF9mb3JtYXRfYmdyYSIpOworICAgIGlmIChtX2JncmFTdXBwb3J0ZWQpIHsKKyAgICAgICAgZXh0 ZW5zaW9ucy0+ZW5zdXJlRW5hYmxlZCgiR0xfRVhUX3RleHR1cmVfZm9ybWF0X0JHUkE4ODg4Iik7 CisgICAgICAgIGV4dGVuc2lvbnMtPmVuc3VyZUVuYWJsZWQoIkdMX0VYVF9yZWFkX2Zvcm1hdF9i Z3JhIik7CisgICAgfQogfQogCiBTaGFyZWRHcmFwaGljc0NvbnRleHQzRDo6flNoYXJlZEdyYXBo aWNzQ29udGV4dDNEKCkKQEAgLTE4MCw4ICsxODcsNyBAQCB2b2lkIFNoYXJlZEdyYXBoaWNzQ29u dGV4dDNEOjpyZWFkUGl4ZWxzCiAKIGJvb2wgU2hhcmVkR3JhcGhpY3NDb250ZXh0M0Q6OnN1cHBv cnRzQkdSQSgpCiB7Ci0gICAgcmV0dXJuIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5zdXBw b3J0cygiR0xfRVhUX3RleHR1cmVfZm9ybWF0X0JHUkE4ODg4IikKLSAgICAgICAgJiYgbV9jb250 ZXh0LT5nZXRFeHRlbnNpb25zKCktPnN1cHBvcnRzKCJHTF9FWFRfcmVhZF9mb3JtYXRfYmdyYSIp OworICAgIHJldHVybiBtX2JncmFTdXBwb3J0ZWQ7CiB9CiAKIFRleHR1cmUqIFNoYXJlZEdyYXBo aWNzQ29udGV4dDNEOjpjcmVhdGVUZXh0dXJlKE5hdGl2ZUltYWdlUHRyIHB0ciwgVGV4dHVyZTo6 Rm9ybWF0IGZvcm1hdCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0KQpJbmRleDogV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5o CShyZXZpc2lvbiA3NDQzNSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJl ZEdyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNCw2ICsxMjQsNyBAQCBw cml2YXRlOgogICAgIHZvaWQgcmVtb3ZlVGV4dHVyZUZvcihOYXRpdmVJbWFnZVB0cik7CiAKICAg ICBSZWZQdHI8R3JhcGhpY3NDb250ZXh0M0Q+IG1fY29udGV4dDsKKyAgICBib29sIG1fYmdyYVN1 cHBvcnRlZDsKIAogICAgIHVuc2lnbmVkIG1fcXVhZFZlcnRpY2VzOwogCg==