51413 2010-12-21 12:08:44 -0800 REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent 2010-12-21 21:15:06 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac All RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned abarth ap darin eric japhet koivisto nate.chapin tonyg webkit.review.bot oldest_to_newest 325134 0 77142 mitz 2010-12-21 12:08:44 -0800 Created attachment 77142 Project showing the bug <rdar://problem/8668230> To reproduce this bug, build and run the attached project. With r71883, the program reports that all requests will be sent, and finishes after logging “Frame load finished”. With r71884, it only reports the first seven requests and never finishes. 325259 1 mitz 2010-12-21 16:31:36 -0800 r71884 was wrong in moving willSendRequest to ResourceLoader::start(). It’s wrong to do all the scheduling, which is host-dependent, before calling willSendRequest, because the latter can change the host. 325260 2 mitz 2010-12-21 16:31:55 -0800 Unfortunately, it is not easy to revert r71884 because of later changes to the code. 325320 3 77176 mitz 2010-12-21 18:29:22 -0800 Created attachment 77176 Call willSendRequest() before scheduling the request 325348 4 77176 mitz 2010-12-21 20:10:43 -0800 Comment on attachment 77176 Call willSendRequest() before scheduling the request Clearing flags on attachment: 77176 Committed r74453: <http://trac.webkit.org/changeset/74453> 325349 5 mitz 2010-12-21 20:10:48 -0800 All reviewed patches have been landed. Closing bug. 325362 6 webkit.review.bot 2010-12-21 20:33:34 -0800 http://trac.webkit.org/changeset/74453 might have broken Leopard Intel Release (Build), Leopard Intel Debug (Build), Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, and Qt Windows 32-bit Debug 325368 7 tonyg 2010-12-21 21:09:52 -0800 Committed r74459: <http://trac.webkit.org/changeset/74459> 325370 8 mitz 2010-12-21 21:11:52 -0800 (In reply to comment #7) > Committed r74459: <http://trac.webkit.org/changeset/74459> I don’t think this is related to this bug. 325372 9 tonyg 2010-12-21 21:15:06 -0800 (In reply to comment #8) > (In reply to comment #7) > > Committed r74459: <http://trac.webkit.org/changeset/74459> > > I don’t think this is related to this bug. No, I'm sorry. It belonged to https://bugs.webkit.org/show_bug.cgi?id=51445, but a ChangeLog merge error at commit time left my entry below the top :-( 77142 2010-12-21 12:08:44 -0800 2010-12-21 12:08:44 -0800 Project showing the bug 8668230.zip application/zip 5662 mitz UEsDBAoAAAAAAEdglT0AAAAAAAAAAAAAAAAIABAAODY2ODIzMC9VWAwA7QcRTcYHEU31AVAAUEsD BBQACAAIAFpVlT0AAAAAAAAAAAAAAAARABAAODY2ODIzMC84NjY4MjMwLjFVWAwArgcRTSz1EE31 AVAApVbfb+I4EH7nrxjxcq1UwkKl1apvdEl3kVpADV1dda2Qk5jE18TO2k5Z/vudsUmg0FbXvTw5 429+fTMeO3jo3qhUrARPYaVVCSWTJ4NTUCu40pxfRuMzsDmHKbe4hjJVSWB5WRXM8jNgMvUiw1DE TdAJHroR5zAqjLqgHzT3AgErpYFBoujPciiEsUJm5E9VVihp9rUcmtybXGnrwITkqfBKO41+bXTf 5EzzfilM0n8RaCcYpzAY9oeD/uATvPweujAeLUJAjIUvnz9/GZ5/gkG7N9cq06wEyUru02WyZgUY npBvkHUZc43aMwNjptdCdoIoh+noJoTDD81FW7XvnKWo1gPNf9ZCI/k9SJX8y0JJ1digwWnZhHNG CcICaVipolBrSr0QEsnEdNECS0FIyLjkmjleiDFWaVUpc0JU9p5OIWWWxczwAO4MByWLDTzxjbO8 Vjo1kHM0xoxTbsAgDMS1KCzQX4pqbntfQTrnJA2mYxdW4IOfoUwvibclVnFpaFF5Nk9Ozxzknls0 oAjoCW7LTT9bsOspFzSplCzRCqyClBuRSSwu7PRNawCrX5dcWox5Z2aaIomYEQUJFdOUESmsc6TN 7BhyFYzup7N5NIn+tIKUIHZFBVcFsDhJj1rhnx6JH1sMjDQGZfMDjJM9goMhYiUKfmyKpI8N5Phr IBAEAcIQw3R2eBAc7E5iUsRPShBHIeZVE/mkJTdrV3Xkv26QHQQOyfJr9kZbI8ZxOg6jr7eT+WIy m/4Zp9QFvtX2OkHzFSrhYqNq3ZQbYVrVWa5q6zToGFQso4HzhP1VJ/mFq1CTMB0b7AGWuMkkTI7O 1wKr4dxh7t6d07bYRBeOxnpHl+W/LGDrzKtXCuDTnEjDtUUnYCqW8M6oHWgCJ5Xx/rCvEy38YEMn lwX0LMugtxYp7vYEesSakLlLnglJ1nA/wwicsU4wsc4cyo8CCFmS+81K84SnqBRvgDRcdp3xzncT FbCdxfhVQNwJwuLNnEOZ+pFC0RE7e1mvCpYZN0EQIPQHUh+LFdbc+BuLxeqZuyGEYM1L/Es9D+5Y HQeFh4pc07BjPhhK5DC5LaoxdJR8L97ufyh7mmV0FMLpj8ntbHoTThct+oZtAKchxBwkp+p49AEP XVRd/hjdLgfdlhNy1UipjT0Sg3TD1Grq7hbgrWJW4fOB8CDDdzWG72n4zTeZccPganIdRoc7qHVF g6p2t42GBG8369uUUrGqEkmTV3Okjzql28c5oU3/X8XRju5fi1gzvemjraLYLAslsyWNQ3c5IYl0 5FliXaXnDPaeEi2qQ9Eit3st2sI/4MybGb4089/7Z9s748no23QWLSZfox30neZJBbXptoRj/JEK H10JLLbiPZGQeCGWrpw06IP/pRYW/iYNQxhdRzNw0ms6bzgynwwdWWYSLlP3ltM0+rHO25cVPi6L KmcxR/vEpJuOpNEAvJN5wemdkiqXvLsKuEy4uyeJOmabPf6LPJMVuhNwn7wyfN7Q0KjwedkJ/qan 6QDOwC1jWrpV0q4YDLeruF0xOG9l59BW6fLuW3RU0PH2XQJPUq0xx1riwMLnLLV4jcOw1f4+iRaz 2/s3tPECskpvQKzoJV3SCI15zp65JxXNip+1OyH4JvwNUEsHCCMHCSTLBAAA4wsAAFBLAwQUAAgA CAAnYJU9AAAAAAAAAAAAAAAAEQAQADg2NjgyMzAvODY2ODIzMC5tVVgMAK4HEU2KBxFN9QEUAK1W bW/TMBD+3l9hgpDaaTDeX7IXFbRVSJRuahgTRNHkJk5qSOPMcdYP0/4757c46VroxCptudjn5+4e 313uMV2UjAt0cEFmX6jY049n86Neb0gLQXiKY4LGDCfHJCcZFgT5aBKczn6RWPRuegh+cOY7JUu0 c7nU0r5a/nR6OkaXtBrRglZzkujVSXA+HYNqzfP93m2v9xT1aTIAFXFBxdxA+f0Gc9BggqaEHLQR e0NSJNLVRZmTBSkEFpQVHX/vY0LHU5E8RYcorOqScCTPRdp3mqL+I7k7UK/yx4moeaGOgDdyxZIg EawIWpgWBiVsNCoipqRiNY9J22Nfoq1THnG8WKupVZ3uAqwp5QjloP7529dxIDgtMn/oHdBFhioe H744asSXTnzlxNdOfOPEt05858T3TvzgROzEmRNjJyZHHprhikBO+KFODfiT19T4Oxei9Pf2ILTf kJiMZ3teZEPusK+T6ZrBXScE5zmLzX3+g8OC5lvfzDpdDpsQQrMOmb26pjPJeBVZV1ey2XhrYuoU Tiu05d30raAGAJ4bh32V7QkUA02pNEuTEaa5jAMYldyecM64358ESgAEop4pZ4tjLHBgYMCCewWt pHkxrk6CMcv6Q2+DBfRk6O1CWrpz4ONVTSoRyVuOBg8QmKLIGB79j/+bgbYOQ+XvVG+5rnKPgJY0 zwNQMRj+KqIxC+cTyqH/QoqWrKhIo6hflWZX4x53u79CzopThg3riiGg6Y5h2NlCeFaxvBZEl3OE aHVyVeN8Q10P0E3TWa19KU9VTQCAZR6lkF4zltUVQHjGgVb1hB3mzCGZmH9pNA1cZMr2ttNkDMiW OdtJqRHjqu0oPSWBYiqflmzJnVpAh/LDozFcF1/Hi8aR7R2lplG0iWj1D/gS/TgJbExbu28q+m8N Y2NcDxMWeADeL8EBRFxDUeKWkerxAAYZZRXmAJAwz+JdFENZCBTPMYQjl67DaNBk/sdaMNPCzxjL 0U4p/0MI4d093dPtmNAdiFqjQGgXW/qSWk3gJPhJOJtCxSLF10QuDj0PZZzVpX2z+J1xbCexkrTS 2VoxZScf45VFW86BZlm6DZAjNHKTjox9WhdjxkpFppEjxOviHDpYfiw/kKAkn5BAlcCFOMPQJZsB pTGw8nm8+yXV64r1hOvRqV2Lz2UV/gFQSwcIIibWPnADAAC7CgAAUEsDBAoAAAAAAGBglT0AAAAA AAAAAAAAAAAJABAAX19NQUNPU1gvVVgMAPMHEU3zBxFN9QEUAFBLAwQKAAAAAABgYJU9AAAAAAAA AAAAAAAAEQAQAF9fTUFDT1NYLzg2NjgyMzAvVVgMAPMHEU3zBxFN9QEUAFBLAwQUAAgACAAnYJU9 AAAAAAAAAAAAAAAAHAAQAF9fTUFDT1NYLzg2NjgyMzAvLl84NjY4MjMwLm1VWAwArgcRTYoHEU31 ARQAY2AVY2dgYmDwTUxW8A9WiFCAApAYAycQGwFxJRCD+KsZiAKOISFBUCZIxxwg5kdTwogQF0/O z9VLLCjISdULSa0occ1Lzk/JzEsHSpaWpOlaWBsamxgZmltamAAAUEsHCHAajcBdAAAAqwAAAFBL AwQKAAAAAABAYJU9AAAAAAAAAAAAAAAAGgAQADg2NjgyMzAvODY2ODIzMC54Y29kZXByb2ovVVgM APMHEU23BxFN9QFQAFBLAwQUAAgACAA6YJU9AAAAAAAAAAAAAAAAKQAQADg2NjgyMzAvODY2ODIz MC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qVVgMAK8HEU2vBxFN9QFQAM1YWW+jShZ+dn6Fr9UP t6NuG7xbvjNSAeWE2w5YgNOdeUEYl2OmMSCWTqJR//epAsxug7NIV+rFVJ1z6izfWap6vfYfn67X ymJ6/emPq/9dtTRX3xu/0D1yPcO22v9q0/Orlm5qnoc8/IUpfuMFe/NfpPsp0XCULEZUV73rNoMe Dau9Yn4wgWFuF4aJ2h4mIBzXvatWazABkwHDsXSf/GEYippS9ABwbcz7HW2+GX5352oH9GS7P9tY 0uL44WF+corhafi/7AHz9g7/K6EdXo/FM43EX/fmbWJYrBQcRFwsneUCjvM+SsF+I/GJUlOOm4wX M0ANp2MAJmOK4mZjZgQJ13Q8nvYHVPdAtJHtwNVRM1Wo6YKZTGbjBZwO6dGIY6k+ACw1yQslOnjI 9w3rMYwsUBSJZ9YKlPHXn5+Jgjkd2SodF3ZgbTUS+Tc5L9YYVmlceUTRgYtzDqSJRqztvJBjmynE jqejGQQDqj+jZn3IUUN2Rk+m/bzYWAu8Bq3tyXzIZUyiRki62mteIXdig2CVQUUbMHkrsaNCMnFQ a0M+QXjCneb9xMTTcH3r+SvN3+PvXuC5PW+vuah30Czyl+4dSeRgs7PNLXJlB+kkUuHGLlQCw4R8 vC4GXwjr51CaG1iiZb4sbJdDjmm/HJDlr2zPd1wbQ97DAI2rVSvn7BpX5ty+iCKLXGTpBYc3zZYc aHLyIuBAS7e3ka7DeRvXVf+bZT9ZhFJ5cRBe9sIcxlSoq3dxTdXnbSeKQHLOPCZSXEQ4On89unbg /LsTo/0VeXJO7Soln1zNcZCbypi3LfwL71QdkFjQk188Hx16S2Pjau5LLy0AvWq+gp3axrPNwEeJ qYM+mFAAMNRgQo0gvaCoMAMHmbCoKxftjOeuo+/fPz77YnAyp9VE6cL+9H4RKgpPTDgdnDJLzjSZ +yaJopJvoU173PsZVhTewLAyyxnDogoG6DMVrMYe9OyYhm74GXM6un1w8Oe2e9D0/Ve7i56RHvja xkQYKYalm8EW8RZvbdFzWFkLgCtozKz5paKuJJFbs4qscrwUK9+0V10aDh89+1h1q1Sl6LP4Twv0 yaKbL81JzGpaIlM5gBQHjVxPrJJ9oin26eFkOB2Mh5PTHe71I1DY7d42F2dFvHKKvbTnUqWeWxes XGRvCCoqm+3wTLOtimMoKdQb32HMLQZUEppY4qhKYjQ0J76LE6UfJwqdTRTO1gPiAy3W9UtWOFcl HD77yLU0M+tiDXspqkVGOuS0aMCMJ0OApcy40ZAZ0TQLSPiJlJVrbwNyt8pFJy57x0JAlk5kXBSg hm64xK8X99+cx2qnqbKxkZYX2PrqqFzkhstaXs4Jl4xpuQLRdHIoO7FTa3+niYcbIvYSRzZrsWWL jsc1UfuSBL9E96Ydtqx97tR6E9JCW6qducoqYHm/kKK5j8iv7JXj+kkmZ3xWYNogWdvaGY+BG2q/ NDyf3MM4yMz6kyE1nQwGHDekKJqCMzaEaNgT2nqWq20Stp3tltTuxOp0yDU6OTLsKKXGO6syJ30S +ZKlrR8TcuS1F+1MUEMNpSAzGUTrW+QgPMVZulHcqSjkTgRo3vJ8zTTjK3jn05+34h383NsYVidL JpwUkE5WeLtRcmW5MzNqF0/dJurGG199vNP1bdssg/IU7HLYxAlLXgsr+/6gqiIeGaJXxip0xhSN gDl9DTCPKpQwSUZ4TL4xTMN/SV9FOz/ILbE96NKdGAC/kGk7JNMl7IeQBlqP+Ih9uI9BLeuaZaEt HriOF1Hv+KrR+kkm74gxhX7MH4H1b83RLOSh6GtB4h7v3CAXz+gZkB40w4qqR/KuVjNuHXFBXMAZ 7hGSney6ZNt+uuiHECilaU3VSZXMoaoCMDlAxXleczuoKRElTJWkvuFecMnz7dtn8LP+SD33g2VK qZL3XJwxo6qM4dAmeCz5rUpm6jc585ocugcsv4MHWZUhkNhbdS1DSV0B5ZY8MAviPGqt4upBXd0C GaqyIvGrzNYNy6rcgwDueFYVRHXFs4VNKABmCdUF/0MFAqeyoqDwwhpiqgcop2R3IgeXqrIWeOEG 792M0i1xpfB3/H+AwouCuoT3cJk8cYb7Kwmy4t2Kx6fgn+SgWwg4KBWPKG5WPBmFtLwgK2C5DL1w fHg1bV0zSd2PSOILvorthoXC/zs3WZAApQNbFMpxVSglZCKCko8PJlZifaPywkKU7iKfRr9I4dg+ ae7u65Ph779uvZdDp1F8/sH+j71ajMDs45IJu12ORoXwJ84XjHogceqgr46HKsMrnzNeZdUlEG7W 4AYmhJj50Qpms+b4/w4kQQWMuFZUCSpr/KE8rEoJFlKtBQwJTr0HEk+yMksjCssHFbAKfw9Vonp2 D0eO4QUuCv0RR/HjHF45aLrtPdNUd9wwA8BHZsAHROB9PPwGL+ZxHHeZut6R7TLlWayqybzvfaEY xpIOJ0bFtHM36X1fspQ1pTXT1rdopwWmnzuY9+4Nz9iYKMmvKirhbGl5t8n23bx3ttjlvFeTlh/n vQTQ52FK/OziEVeM7iDJ5NzswjK/+n31f1BLBwijpdGagAcAAHAhAABQSwMEFAAIAAgAWlWVPQAA AAAAAAAAAAAAABoAEAA4NjY4MjMwLzg2NjgyMzBfUHJlZml4LnBjaFVYDACuBxFNLPUQTfUBUABd jLEKwkAQBfv7igcp0uVEIaQQCwULG/2D48jteivxNmwu4OebTnCqYYrx3nmPhxHLB5liIgOrIU4T Fl1tJLBMtEAZNRPaoe+H/WHXokZ7UoWUvz6bvmis3fZ1rhFOxAjhfr5dQnDYaOQ9q1Ucr7qWFKto 8T/t8sk1VJKw+wJQSwcIT2arM34AAACcAAAAUEsBAhUDCgAAAAAAR2CVPQAAAAAAAAAAAAAAAAgA DAAAAAAAAAAAQO1BAAAAADg2NjgyMzAvVVgIAO0HEU3GBxFNUEsBAhUDFAAIAAgAWlWVPSMHCSTL BAAA4wsAABEADAAAAAAAAAAAQKSBNgAAADg2NjgyMzAvODY2ODIzMC4xVVgIAK4HEU0s9RBNUEsB AhUDFAAIAAgAJ2CVPSIm1j5wAwAAuwoAABEADAAAAAAAAAAAQKSBUAUAADg2NjgyMzAvODY2ODIz MC5tVVgIAK4HEU2KBxFNUEsBAhUDCgAAAAAAYGCVPQAAAAAAAAAAAAAAAAkADAAAAAAAAAAAQP1B DwkAAF9fTUFDT1NYL1VYCADzBxFN8wcRTVBLAQIVAwoAAAAAAGBglT0AAAAAAAAAAAAAAAARAAwA AAAAAAAAAED9QUYJAABfX01BQ09TWC84NjY4MjMwL1VYCADzBxFN8wcRTVBLAQIVAxQACAAIACdg lT1wGo3AXQAAAKsAAAAcAAwAAAAAAAAAAECkgYUJAABfX01BQ09TWC84NjY4MjMwLy5fODY2ODIz MC5tVVgIAK4HEU2KBxFNUEsBAhUDCgAAAAAAQGCVPQAAAAAAAAAAAAAAABoADAAAAAAAAAAAQO1B PAoAADg2NjgyMzAvODY2ODIzMC54Y29kZXByb2ovVVgIAPMHEU23BxFNUEsBAhUDFAAIAAgAOmCV PaOl0ZqABwAAcCEAACkADAAAAAAAAAAAQKSBhAoAADg2NjgyMzAvODY2ODIzMC54Y29kZXByb2ov cHJvamVjdC5wYnhwcm9qVVgIAK8HEU2vBxFNUEsBAhUDFAAIAAgAWlWVPU9mqzN+AAAAnAAAABoA DAAAAAAAAAAAQKSBaxIAADg2NjgyMzAvODY2ODIzMF9QcmVmaXgucGNoVVgIAK4HEU0s9RBNUEsF BgAAAAAJAAkAxwIAAEETAAAAAA== 77176 2010-12-21 18:29:22 -0800 2010-12-21 20:10:42 -0800 Call willSendRequest() before scheduling the request 8668230_r1.diff text/plain 6726 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDQ0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMTItMjEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRh cjovL3Byb2JsZW0vODY2ODIzMD4gUkVHUkVTU0lPTiAocjcxODg0KTogUmV0dXJuaW5nIGFsdGVy bmF0ZSByZXF1ZXN0cyBmcm9tIHdpbGxTZW5kUmVxdWVzdCBjYW4gcHJldmVudCBvdGhlciByZXF1 ZXN0cyBmcm9tIGV2ZXIgYmVpbmcgc2VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTE0MTMKKworICAgICAgICA3MTg4NCB3YXMgd3JvbmcgaW4gbW92 aW5nIHdpbGxTZW5kUmVxdWVzdCB0byBSZXNvdXJjZUxvYWRlcjo6c3RhcnQoKS4gSXTigJlzIHdy b25nIHRvIGRvIGFsbCB0aGUKKyAgICAgICAgc2NoZWR1bGluZywgd2hpY2ggaXMgaG9zdC1kZXBl bmRlbnQsIGJlZm9yZSBjYWxsaW5nIHdpbGxTZW5kUmVxdWVzdCwgYmVjYXVzZSB0aGUgbGF0dGVy IGNhbgorICAgICAgICBjaGFuZ2UgdGhlIGhvc3QuCisKKyAgICAgICAgKiBsb2FkZXIvTmV0c2Nh cGVQbHVnSW5TdHJlYW1Mb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0c2NhcGVQbHVn SW5TdHJlYW1Mb2FkZXI6OmNyZWF0ZSk6IENoZWNrIHRoZSByZXR1cm4gdmFsdWUgZnJvbSBSZXNv dXJjZUxvYWRlcjo6aW5pdCgpCisgICAgICAgIGFuZCByZXR1cm4gMCBpZiBpdCBpcyBmYWxzZS4K KyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VMb2FkZXI6OmluaXQpOiBNYWRlIHRoaXMgZnVuY3Rpb24gcmV0dXJuIGEgYm9vbGVh bi4gTW92ZWQgdGhlIGNhbGwgdG8gd2lsbFNlbmRSZXF1ZXN0KCkKKyAgICAgICAgZnJvbSBzdGFy dCgpIGludG8gaGVyZS4gUmV0dXJuIGZhbHNlIGlmIHdpbGxTZW5kUmVxdWVzdCgpIGNhbmNlbGVk IHRoZSByZXF1ZXN0LgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OnN0YXJ0KTog TW92ZWQgdGhlIGNhbGwgdG8gd2lsbFNlbmRSZXF1ZXN0KCkgZnJvbSBoZXJlIHRvIGluaXQoKS4K KyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuaDoKKyAgICAgICAgKiBsb2FkZXIvU3Vi cmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3VicmVzb3VyY2VMb2FkZXI6 OmNyZWF0ZSk6IENoZWNrIHRoZSByZXR1cm4gdmFsdWUgZnJvbSBSZXNvdXJjZUxvYWRlcjo6aW5p dCgpCisgICAgICAgIGFuZCByZXR1cm4gMCBpZiBpdCBpcyBmYWxzZS4KKwogMjAxMC0xMi0yMSAg RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpv aG4gU3VsbGl2YW4uCkluZGV4OiBXZWJDb3JlL2xvYWRlci9OZXRzY2FwZVBsdWdJblN0cmVhbUxv YWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvTmV0c2NhcGVQbHVnSW5TdHJl YW1Mb2FkZXIuY3BwCShyZXZpc2lvbiA3NDM1MikKKysrIFdlYkNvcmUvbG9hZGVyL05ldHNjYXBl UGx1Z0luU3RyZWFtTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDksNyArNDksOSBAQCBQ YXNzUmVmUHRyPE5ldHNjYXBlUGx1Z0luU3RyZWFtTG9hZGVyPiBOCiAgICAgUmVmUHRyPE5ldHNj YXBlUGx1Z0luU3RyZWFtTG9hZGVyPiBsb2FkZXIoYWRvcHRSZWYobmV3IE5ldHNjYXBlUGx1Z0lu U3RyZWFtTG9hZGVyKGZyYW1lLCBjbGllbnQpKSk7CiAgICAgbG9hZGVyLT5zZXRTaG91bGRCdWZm ZXJEYXRhKGZhbHNlKTsKICAgICBsb2FkZXItPmRvY3VtZW50TG9hZGVyKCktPmFkZFBsdWdJblN0 cmVhbUxvYWRlcihsb2FkZXIuZ2V0KCkpOwotICAgIGxvYWRlci0+aW5pdChyZXF1ZXN0KTsKKyAg ICBpZiAoIWxvYWRlci0+aW5pdChyZXF1ZXN0KSkKKyAgICAgICAgcmV0dXJuIDA7CisKICAgICBy ZXR1cm4gbG9hZGVyLnJlbGVhc2UoKTsKIH0KIApJbmRleDogV2ViQ29yZS9sb2FkZXIvUmVzb3Vy Y2VMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVy LmNwcAkocmV2aXNpb24gNzQzNTIpCisrKyBXZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTExMCw3ICsxMTAsNyBAQCB2b2lkIFJlc291cmNlTG9hZGVy OjpyZWxlYXNlUmVzb3VyY2VzKCkKICAgICBtX2RlZmVycmVkUmVxdWVzdCA9IFJlc291cmNlUmVx dWVzdCgpOwogfQogCi12b2lkIFJlc291cmNlTG9hZGVyOjppbml0KGNvbnN0IFJlc291cmNlUmVx dWVzdCYgcikKK2Jvb2wgUmVzb3VyY2VMb2FkZXI6OmluaXQoY29uc3QgUmVzb3VyY2VSZXF1ZXN0 JiByKQogewogICAgIEFTU0VSVCghbV9oYW5kbGUpOwogICAgIEFTU0VSVChtX3JlcXVlc3QuaXNO dWxsKCkpOwpAQCAtMTMwLDYgKzEzMCwxNCBAQCB2b2lkIFJlc291cmNlTG9hZGVyOjppbml0KGNv bnN0IFJlc291cmNlCiAgICAgfQogCiAgICAgbV9yZXF1ZXN0ID0gY2xpZW50UmVxdWVzdDsKKwor ICAgIHdpbGxTZW5kUmVxdWVzdChtX3JlcXVlc3QsIFJlc291cmNlUmVzcG9uc2UoKSk7CisgICAg aWYgKG1fcmVxdWVzdC5pc051bGwoKSkgeworICAgICAgICBkaWRGYWlsKGZyYW1lTG9hZGVyKCkt PmNhbmNlbGxlZEVycm9yKG1fcmVxdWVzdCkpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg fQorCisgICAgcmV0dXJuIHRydWU7CiB9CiAKIHZvaWQgUmVzb3VyY2VMb2FkZXI6OnN0YXJ0KCkK QEAgLTEzOCwxMiArMTQ2LDYgQEAgdm9pZCBSZXNvdXJjZUxvYWRlcjo6c3RhcnQoKQogICAgIEFT U0VSVCghbV9yZXF1ZXN0LmlzTnVsbCgpKTsKICAgICBBU1NFUlQobV9kZWZlcnJlZFJlcXVlc3Qu aXNOdWxsKCkpOwogCi0gICAgd2lsbFNlbmRSZXF1ZXN0KG1fcmVxdWVzdCwgUmVzb3VyY2VSZXNw b25zZSgpKTsKLSAgICBpZiAobV9yZXF1ZXN0LmlzTnVsbCgpKSB7Ci0gICAgICAgIGRpZEZhaWwo ZnJhbWVMb2FkZXIoKS0+Y2FuY2VsbGVkRXJyb3IobV9yZXF1ZXN0KSk7Ci0gICAgICAgIHJldHVy bjsKLSAgICB9ICAgIAotICAgIAogICAgIGlmIChtX2RvY3VtZW50TG9hZGVyLT5zY2hlZHVsZUFy Y2hpdmVMb2FkKHRoaXMsIG1fcmVxdWVzdCwgbV9yZXF1ZXN0LnVybCgpKSkKICAgICAgICAgcmV0 dXJuOwogICAgIApJbmRleDogV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5oCShyZXZpc2lvbiA3NDM1MikK KysrIFdlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTU0 LDcgKzU0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgY2FuY2VsKCk7 CiAKLSAgICAgICAgdmlydHVhbCB2b2lkIGluaXQoY29uc3QgUmVzb3VyY2VSZXF1ZXN0Jik7Cisg ICAgICAgIHZpcnR1YWwgYm9vbCBpbml0KGNvbnN0IFJlc291cmNlUmVxdWVzdCYpOwogCiAgICAg ICAgIEZyYW1lTG9hZGVyKiBmcmFtZUxvYWRlcigpIGNvbnN0OwogICAgICAgICBEb2N1bWVudExv YWRlciogZG9jdW1lbnRMb2FkZXIoKSBjb25zdCB7IHJldHVybiBtX2RvY3VtZW50TG9hZGVyLmdl dCgpOyB9CkluZGV4OiBXZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiA3 NDM1MikKKysrIFdlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODYsNyArODYsOCBAQCBQYXNzUmVmUHRyPFN1YnJlc291cmNlTG9hZGVyPiBTdWJy ZXNvdXJjCiAKICAgICBSZWZQdHI8U3VicmVzb3VyY2VMb2FkZXI+IHN1YmxvYWRlcihhZG9wdFJl ZihuZXcgU3VicmVzb3VyY2VMb2FkZXIoZnJhbWUsIGNsaWVudCwgc2VuZFJlc291cmNlTG9hZENh bGxiYWNrcywgc2hvdWxkQ29udGVudFNuaWZmKSkpOwogICAgIHN1YmxvYWRlci0+ZG9jdW1lbnRM b2FkZXIoKS0+YWRkU3VicmVzb3VyY2VMb2FkZXIoc3VibG9hZGVyLmdldCgpKTsKLSAgICBzdWJs b2FkZXItPmluaXQobmV3UmVxdWVzdCk7CisgICAgaWYgKCFzdWJsb2FkZXItPmluaXQobmV3UmVx dWVzdCkpCisgICAgICAgIHJldHVybiAwOwogCiAgICAgcmV0dXJuIHN1YmxvYWRlci5yZWxlYXNl KCk7CiB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3NDQ0NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEwLTEyLTIxICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg2NjgyMzA+IFJFR1JFU1NJT04gKHI3MTg4 NCk6IFJldHVybmluZyBhbHRlcm5hdGUgcmVxdWVzdHMgZnJvbSB3aWxsU2VuZFJlcXVlc3QgY2Fu IHByZXZlbnQgb3RoZXIgcmVxdWVzdHMgZnJvbSBldmVyIGJlaW5nIHNlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNDEzCisKKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMvc2VjdXJpdHkvYmxvY2stdGVzdC1leHBlY3RlZC50eHQ6IFJldmVydGVkIHI3 MTg4NC4KKwogMjAxMC0xMi0yMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvc2VjdXJpdHkvYmxvY2stdGVzdC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3NlY3VyaXR5L2Jsb2NrLXRlc3QtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiA3NDM1MikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zZWN1cml0eS9i bG9jay10ZXN0LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcgQEAKIGh0 dHA6Ly8yNTUuMjU1LjI1NS4yNTU6MS90ZXN0LmpwZyAtIHdpbGxTZW5kUmVxdWVzdCA8TlNVUkxS ZXF1ZXN0IFVSTCBodHRwOi8vMjU1LjI1NS4yNTUuMjU1OjEvdGVzdC5qcGcsIG1haW4gZG9jdW1l bnQgVVJMIGJsb2NrLXRlc3QuaHRtbCwgaHR0cCBtZXRob2QgR0VUPiByZWRpcmVjdFJlc3BvbnNl IChudWxsKQogPHVua25vd24+IC0gZGlkRmluaXNoTG9hZGluZwotaHR0cDovLzI1NS4yNTUuMjU1 LjI1NToxL3Rlc3QuanBnIC0gZGlkRmFpbExvYWRpbmdXaXRoRXJyb3I6IDxOU0Vycm9yIGRvbWFp biBXZWJLaXRFcnJvckRvbWFpbiwgY29kZSAxMDMsIGZhaWxpbmcgVVJMICJodHRwOi8vMjU1LjI1 NS4yNTUuMjU1OjEvdGVzdC5qcGciPgogaHR0cDovLzI1NS4yNTUuMjU1LjI1NTo3L3Rlc3QuanBn IC0gd2lsbFNlbmRSZXF1ZXN0IDxOU1VSTFJlcXVlc3QgVVJMIGh0dHA6Ly8yNTUuMjU1LjI1NS4y NTU6Ny90ZXN0LmpwZywgbWFpbiBkb2N1bWVudCBVUkwgYmxvY2stdGVzdC5odG1sLCBodHRwIG1l dGhvZCBHRVQ+IHJlZGlyZWN0UmVzcG9uc2UgKG51bGwpCitodHRwOi8vMjU1LjI1NS4yNTUuMjU1 OjEvdGVzdC5qcGcgLSBkaWRGYWlsTG9hZGluZ1dpdGhFcnJvcjogPE5TRXJyb3IgZG9tYWluIFdl YktpdEVycm9yRG9tYWluLCBjb2RlIDEwMywgZmFpbGluZyBVUkwgImh0dHA6Ly8yNTUuMjU1LjI1 NS4yNTU6MS90ZXN0LmpwZyI+CiBodHRwOi8vMjU1LjI1NS4yNTUuMjU1OjcvdGVzdC5qcGcgLSBk aWRGYWlsTG9hZGluZ1dpdGhFcnJvcjogPE5TRXJyb3IgZG9tYWluIFdlYktpdEVycm9yRG9tYWlu LCBjb2RlIDEwMywgZmFpbGluZyBVUkwgImh0dHA6Ly8yNTUuMjU1LjI1NS4yNTU6Ny90ZXN0Lmpw ZyI+CiBodHRwOi8vMjU1LjI1NS4yNTUuMjU1OjkvdGVzdC5qcGcgLSB3aWxsU2VuZFJlcXVlc3Qg PE5TVVJMUmVxdWVzdCBVUkwgaHR0cDovLzI1NS4yNTUuMjU1LjI1NTo5L3Rlc3QuanBnLCBtYWlu IGRvY3VtZW50IFVSTCBibG9jay10ZXN0Lmh0bWwsIGh0dHAgbWV0aG9kIEdFVD4gcmVkaXJlY3RS ZXNwb25zZSAobnVsbCkKIGh0dHA6Ly8yNTUuMjU1LjI1NS4yNTU6OS90ZXN0LmpwZyAtIGRpZEZh aWxMb2FkaW5nV2l0aEVycm9yOiA8TlNFcnJvciBkb21haW4gV2ViS2l0RXJyb3JEb21haW4sIGNv ZGUgMTAzLCBmYWlsaW5nIFVSTCAiaHR0cDovLzI1NS4yNTUuMjU1LjI1NTo5L3Rlc3QuanBnIj4K