51406 2010-12-21 10:23:46 -0800 [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin 2010-12-21 12:16:02 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 51151 1 mihaip mihaip abarth fishd mihaip tkent oldest_to_newest 325057 0 mihaip 2010-12-21 10:23:46 -0800 We'll need a WebThemeEngine for the Chromium/Mac DRT (to match the Mac DRT's scrollabars, see discussion on bug 51151), so the existing Skia-based implementation should be renamed to *DRTWin to avoid confusion. 325059 1 77129 mihaip 2010-12-21 10:26:50 -0800 Created attachment 77129 Patch 325071 2 mihaip 2010-12-21 10:45:34 -0800 I'm having trouble getting webkit-patch upload to show the edits that I did after the move (I did the move with git mv). Any ideas? 325075 3 mihaip 2010-12-21 11:00:31 -0800 It looks like locally the changes are correct, it's just webkit-patch that's confused. This should be OK if I land locally. 325138 4 mihaip 2010-12-21 12:16:02 -0800 Committed r74421: <http://trac.webkit.org/changeset/74421> 77129 2010-12-21 10:26:50 -0800 2010-12-21 11:59:07 -0800 Patch bug-51406-20101221102648.patch text/plain 3016 mihaip ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMDlm MDViNDFhYjVhMzg1ZWFlMTA5NmJmOWZhMzlkNWZmYmZmNmFiLi5jOTk3MTgzODEyOWE0MzcxN2Iy ZjIwOWFlZTUwM2M1ODVhNjJlOTVjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMTItMjEgIE1paGFpIFBhcnBh cml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBSZW5hbWUgV2ViVGhlbWVFbmdpbmUvQ29u dHJvbERSVCB0byBXZWJUaGVtZUVuZ2luZS9Db250cm9sRFJUV2luCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTQwNiAKKyAgICAgICAgCisgICAgICAg IFJlbmFtZSBXZWJUaGVtZUNvbnRyb2xEUlQgdG8gV2ViVGhlbWVDb250cm9sRFJUV2luIGFuZCBX ZWJUaGVtZUVuZ2luZURSVAorICAgICAgICB0byBXZWJUaGVtZUVuZ2luZURSVFdpbiBhbmQgdXBk YXRlIHJlZmVyZW5jZXMgZXZlcnl3aGVyZS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1 bXBSZW5kZXJUcmVlLmd5cGk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVz dFNoZWxsV2luLmNwcDoKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVt ZUNvbnRyb2xEUlRXaW4uY3BwOiBSZW5hbWVkIGZyb20gVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vV2ViVGhlbWVDb250cm9sRFJULmNwcC4KKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJUaGVtZUNvbnRyb2xEUlRXaW4uaDogUmVuYW1lZCBmcm9tIFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVC5oLgorICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJUV2luLmNwcDogUmVuYW1lZCBmcm9t IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJULmNwcC4KKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVFdpbi5oOiBS ZW5hbWVkIGZyb20gVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVE UlQuaC4KKwogMjAxMC0xMi0yMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXBpIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJl bmRlclRyZWUuZ3lwaQppbmRleCBiNDM3ZWFmZjcwZTA4NDRhOTFiMTFhNThhNmZjMTE2ODdiMjZj ODhiLi4wNGNhZWU3ZjhiN2FhZjMxMjQ2NDlmNzdiZjhlZWM2YTkwNmFkODA1IDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXBpCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cGkKQEAgLTYxLDEwICs2MSwxMCBAQAogICAg ICAgICAnY29uZGl0aW9ucyc6IFsKICAgICAgICAgICAgIFsnT1M9PSJ3aW4iJywgewogICAgICAg ICAgICAgICAgICdkcnRfZmlsZXMnOiBbCi0gICAgICAgICAgICAgICAgICAgICdjaHJvbWl1bS9X ZWJUaGVtZUNvbnRyb2xEUlQuY3BwJywKLSAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dl YlRoZW1lQ29udHJvbERSVC5oJywKLSAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlRo ZW1lRW5naW5lRFJULmNwcCcsCi0gICAgICAgICAgICAgICAgICAgICdjaHJvbWl1bS9XZWJUaGVt ZUVuZ2luZURSVC5oJywKKyAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlRoZW1lQ29u dHJvbERSVFdpbi5jcHAnLAorICAgICAgICAgICAgICAgICAgICAnY2hyb21pdW0vV2ViVGhlbWVD b250cm9sRFJUV2luLmgnLAorICAgICAgICAgICAgICAgICAgICAnY2hyb21pdW0vV2ViVGhlbWVF bmdpbmVEUlRXaW4uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlRoZW1l RW5naW5lRFJUV2luLmgnLAogICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICB9XSwKICAg ICAgICAgXSwKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RT aGVsbFdpbi5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGxXaW4u Y3BwCmluZGV4IDllZmNmNWFkZmEzYTIzYjliNjU4NDcxZTZjY2VjYWUwN2I1MTNlOTMuLjNiM2Rk ZDkzNTAxNDZkNjFiOWE4OGNlYjBkZjM3N2Y2MTRjNWUwMzkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbFdpbi5jcHAKKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsV2luLmNwcApAQCAtMzEsNyArMzEsNyBAQAogI2lu Y2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRlc3RTaGVsbC5oIgogCi0jaW5jbHVkZSAiV2Vi VGhlbWVFbmdpbmVEUlQuaCIKKyNpbmNsdWRlICJXZWJUaGVtZUVuZ2luZURSVFdpbi5oIgogI2lu Y2x1ZGUgIndlYmtpdC9zdXBwb3J0L3dlYmtpdF9zdXBwb3J0LmgiCiAjaW5jbHVkZSA8ZmNudGwu aD4KICNpbmNsdWRlIDxpby5oPgpAQCAtNDksNyArNDksNyBAQAogICAgIFNJWkVPRl9TVFJVQ1Rf V0lUSF9TUEVDSUZJRURfTEFTVF9NRU1CRVIoTk9OQ0xJRU5UTUVUUklDUywgbGZNZXNzYWdlRm9u dCkKIAogLy8gVGhlbWUgZW5naW5lCi1zdGF0aWMgV2ViVGhlbWVFbmdpbmVEUlQgdGhlbWVFbmdp bmU7CitzdGF0aWMgV2ViVGhlbWVFbmdpbmVEUlRXaW4gdGhlbWVFbmdpbmU7CiAKIC8vIFRocmVh ZCBtYWluIHRvIHJ1biBmb3IgdGhlIHRocmVhZCB3aGljaCBqdXN0IHRlc3RzIGZvciB0aW1lb3V0 LgogdW5zaWduZWQgaW50IF9fc3RkY2FsbCB3YXRjaERvZ1RocmVhZCh2b2lkKiBhcmcpCg==