51394 2010-12-21 06:57:01 -0800 [GTK] minimal build with --database fails 2010-12-24 02:13:14 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric oldest_to_newest 324987 0 pnormand 2010-12-21 06:57:01 -0800 ../../WebKit/gtk/webkit/webkitprivate.cpp: In function ‘void webkit_init()’: ../../WebKit/gtk/webkit/webkitprivate.cpp:137: error: ‘cacheStorage’ is not a member of ‘WebCore’ make[1]: *** [WebKit/gtk/webkit/libwebkitgtk_3_0_la-webkitprivate.lo] Error 1 cacheStorage usage there should be guarded with ENABLE(OFFLINE_WEB_APPLICATIONS) as in ApplicationCacheStorage.cpp where it is implemented. 324991 1 77109 pnormand 2010-12-21 07:09:59 -0800 Created attachment 77109 proposed patch 326442 2 77109 eric 2010-12-23 19:30:37 -0800 Comment on attachment 77109 proposed patch OK. 326443 3 eric 2010-12-23 19:30:59 -0800 Does this need both DATABASE and OFFLINE_WEB_APPLICATIONS? 326503 4 pnormand 2010-12-24 01:05:22 -0800 (In reply to comment #3) > Does this need both DATABASE and OFFLINE_WEB_APPLICATIONS? Right webkit_set_web_database indeed needs DATABASE. Will fix up and commit, thanks for the review Eric! 326507 5 pnormand 2010-12-24 01:37:24 -0800 I'll guard the webkit_set_web_database_directory_path() call with ENABLE(DATABASE) and the cacheStorage() stuff with ENABLE(OFFLINE_WEB_APPLICATIONS) 326510 6 pnormand 2010-12-24 01:40:55 -0800 (In reply to comment #5) > I'll guard the webkit_set_web_database_directory_path() call with ENABLE(DATABASE) and the cacheStorage() stuff with ENABLE(OFFLINE_WEB_APPLICATIONS) Oh well ENABLE(DATABASE) is already checked in webkit_set_web_database_directory_path() code, so in the end I don't think it's needed in webkitprivate.cpp 326527 7 pnormand 2010-12-24 02:13:14 -0800 Committed r74620: <http://trac.webkit.org/changeset/74620> 77109 2010-12-21 07:09:59 -0800 2010-12-23 19:30:37 -0800 proposed patch proposed-patch.patch text/plain 1536 pnormand RnJvbSAwZjk2MWEwN2YyZDBlOGEzNjU2ODhkYzZmYzY4NTEzNzI2OTA2MTYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDIxIERlYyAyMDEwIDE2OjA5OjMzICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg fCAgIDExICsrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmNwcCB8 ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdl TG9nCmluZGV4IDEzOTNjMmEuLmY3Mzk3NzkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTIt MjEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIG1pbmltYWwgYnVpbGQg d2l0aCAtLWRhdGFiYXNlIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MTM5NAorCisgICAgICAgICogd2Via2l0L3dlYmtpdHByaXZhdGUuY3Bw OgorICAgICAgICAod2Via2l0X2luaXQpOiBVc2UgY2FjaGVTdG9yYWdlKCkgb25seSBpZiB0aGUK KyAgICAgICAgT0ZGTElORV9XRUJfQVBQTElDQVRJT05TIGZlYXR1cmUgaXMgZW5hYmxlZC4KKwog MjAxMC0xMi0yMCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxh Ym9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHByaXZhdGUuY3BwCmluZGV4IDQ2NTIwMzEuLjVkMzU0OGUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHByaXZhdGUuY3BwCkBAIC0xMjksNyArMTI5LDcgQEAgdm9pZCB3ZWJraXRfaW5pdCgp CiAgICAgLy8gdGhhdCBtYXkgb25seSBiZSBkb25lIGJ5IHRoZSBtYWluIHRocmVhZC4KICAgICBh dG9taWNDYW5vbmljYWxUZXh0RW5jb2RpbmdOYW1lKCJVVEYtOCIpOwogCi0jaWYgRU5BQkxFKERB VEFCQVNFKQorI2lmIEVOQUJMRShPRkZMSU5FX1dFQl9BUFBMSUNBVElPTlMpCiAgICAgZ2NoYXIq IGRhdGFiYXNlRGlyZWN0b3J5ID0gZ19idWlsZF9maWxlbmFtZShnX2dldF91c2VyX2RhdGFfZGly KCksICJ3ZWJraXQiLCAiZGF0YWJhc2VzIiwgTlVMTCk7CiAgICAgd2Via2l0X3NldF93ZWJfZGF0 YWJhc2VfZGlyZWN0b3J5X3BhdGgoZGF0YWJhc2VEaXJlY3RvcnkpOwogCi0tIAoxLjcuMi4z