<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51391</bug_id>
          
          <creation_ts>2010-12-21 06:13:31 -0800</creation_ts>
          <short_desc>[v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402</short_desc>
          <delta_ts>2010-12-21 06:59:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Andrei Popescu">andreip</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ager</cc>
    
    <cc>barraclough</cc>
    
    <cc>tonyg</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>324976</commentid>
    <comment_count>0</comment_count>
    <who name="Andrei Popescu">andreip</who>
    <bug_when>2010-12-21 06:13:31 -0800</bug_when>
    <thetext>In http://trac.webkit.org/changeset/74402/

Gavin Barraclough introduced changes in the way stack size is computed on a bunch of platforms. Since that change, the fast/js/large-expressions-expected.txt layout tests fails on Chromium:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/4498

Mads, is this something that affects V8? 

I will update our test expectations until we figure out a solution.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324983</commentid>
    <comment_count>1</comment_count>
    <who name="Mads Ager">ager</who>
    <bug_when>2010-12-21 06:44:27 -0800</bug_when>
    <thetext>We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324984</commentid>
    <comment_count>2</comment_count>
    <who name="Andrei Popescu">andreip</who>
    <bug_when>2010-12-21 06:54:52 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324985</commentid>
    <comment_count>3</comment_count>
    <who name="Andrei Popescu">andreip</who>
    <bug_when>2010-12-21 06:55:18 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #1)
&gt; &gt; We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.

Thanks Mads, I will rebaseline the test and close this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324988</commentid>
    <comment_count>4</comment_count>
    <who name="Andrei Popescu">andreip</who>
    <bug_when>2010-12-21 06:59:46 -0800</bug_when>
    <thetext>Committed r74413</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>