<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51372</bug_id>
          
          <creation_ts>2010-12-20 19:46:53 -0800</creation_ts>
          <short_desc>REGRESSION(r74349): We are going to do better than removing the code (Requested by tonikitoo on #webkit).</short_desc>
          <delta_ts>2010-12-20 21:24:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>51308</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="WebKit Review Bot">webkit.review.bot</reporter>
          <assigned_to name="WebKit Review Bot">webkit.review.bot</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>324735</commentid>
    <comment_count>0</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-20 19:46:53 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/74349 broke the build:
We are going to do better than reverting the code. (Requested by tonikitoo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don&apos;t already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

&quot;Only you can prevent forest fires.&quot; -- Smokey the Bear</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324736</commentid>
    <comment_count>1</comment_count>
      <attachid>77074</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-20 19:47:11 -0800</bug_when>
    <thetext>Created attachment 77074
ROLLOUT of r74349

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324771</commentid>
    <comment_count>2</comment_count>
      <attachid>77074</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-20 21:24:20 -0800</bug_when>
    <thetext>Comment on attachment 77074
ROLLOUT of r74349

Clearing flags on attachment: 77074

Committed r74389: &lt;http://trac.webkit.org/changeset/74389&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324772</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-20 21:24:26 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77074</attachid>
            <date>2010-12-20 19:47:11 -0800</date>
            <delta_ts>2010-12-20 21:24:20 -0800</delta_ts>
            <desc>ROLLOUT of r74349</desc>
            <filename>bug-51372-20101221034621.patch</filename>
            <type>text/plain</type>
            <size>1397</size>
            <attacher name="WebKit Review Bot">webkit.review.bot</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBkZWE4ZjQ0YjQxMmUxZGRhZDUxNjZmYjUzN2YwYjkzYTcyNTU4YTY0Li4wNTI3MGUy
MTI2NTI4NjMwYTc0OWU0MTkyYmE1NTQxNTlhYWE2NjE4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTAtMTItMjAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgor
CisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3NDM0OS4KKyAgICAgICAgaHR0cDov
L3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNzQzNDkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMzcyCisKKyAgICAgICAgV2UgYXJlIGdvaW5nIHRv
IGRvIGJldHRlciB0aGFuIHJldmVydGluZyB0aGUgY29kZS4gKFJlcXVlc3RlZAorICAgICAgICBi
eSB0b25pa2l0b28gb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBmYXN0L3JlcGFpbnQvbm8tY2Fy
ZXQtcmVwYWludC1pbi1ub24tY29udGVudC1lZGl0YWJsZS1lbGVtZW50Lmh0bWw6CisKIDIwMTAt
MTItMjAgIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KIAogICAgICAgICBV
bnJldmlld2VkIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVwYWlu
dC9uby1jYXJldC1yZXBhaW50LWluLW5vbi1jb250ZW50LWVkaXRhYmxlLWVsZW1lbnQuaHRtbCBi
L0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9uby1jYXJldC1yZXBhaW50LWluLW5vbi1jb250ZW50
LWVkaXRhYmxlLWVsZW1lbnQuaHRtbAppbmRleCBkZWUyNDIwNWRmMWVjYjVjOTZmNDJlZGEyNDE3
NzJlZmZkN2I1N2RiLi42MjljMGYyN2EyOGY3ZTEwNDFiNmQ0NWQwNjAyYWFmODNlNjBlZTQ5IDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvbm8tY2FyZXQtcmVwYWludC1pbi1u
b24tY29udGVudC1lZGl0YWJsZS1lbGVtZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9y
ZXBhaW50L25vLWNhcmV0LXJlcGFpbnQtaW4tbm9uLWNvbnRlbnQtZWRpdGFibGUtZWxlbWVudC5o
dG1sCkBAIC0yLDYgKzIsOCBAQAogPGhlYWQ+CiA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3JlcGFp
bnQuanMiPjwvc2NyaXB0PgogPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs
ZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRF
bmFibGVDYXJldEJyb3dzaW5nIiwgZmFsc2UpOwogZnVuY3Rpb24gcmVwYWludFRlc3QoKQogewog
ICAgIGlmICghd2luZG93LmV2ZW50U2VuZGVyKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>