<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51352</bug_id>
          
          <creation_ts>2010-12-20 13:23:25 -0800</creation_ts>
          <short_desc>Web process should only spin a run loop while waiting for replies to synchronous messages that invoke UI</short_desc>
          <delta_ts>2015-06-18 14:56:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, PlatformOnly</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>51351</dependson>
    
    <dependson>53211</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Roben (:aroben)">aroben</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>324537</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2010-12-20 13:23:25 -0800</bug_when>
    <thetext>As described in bug 51351, having the UI process respond to synchronous messages from the web process on the main thread can result in deadlocks when windowed plugins are involved. We&apos;re going to move all synchronous message processing off the main thread by default in the UI process. But synchronous messages that result in needing to display UI (e.g., WebPageProxy::RunJavaScriptAlert) require doing so on the main thread. In those cases, the web process will need to spin a run loop while waiting for the message reply to avoid the kinds of deadlocks described in bug 51351.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324541</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2010-12-20 13:25:05 -0800</bug_when>
    <thetext>&lt;rdar://problem/8790537&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>340676</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-01-26 18:10:29 -0800</bug_when>
    <thetext>As described in bug 51351 comment 4, we&apos;re going to spin a run loop while waiting for a reply to all synchronous messages. Once bug 51351 is fixed we&apos;ll only spin a run loop while waiting for replies to synchronous messages that present UI in the UI process.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>383200</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-04-11 09:08:56 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; As described in bug 51351 comment 4, we&apos;re going to spin a run loop while waiting for a reply to all synchronous messages.

Bug 58239 now covers this strategy.

&gt; Once bug 51351 is fixed we&apos;ll only spin a run loop while waiting for replies to synchronous messages that present UI in the UI process.

We&apos;ll continue to use this bug to track this future improvement.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1103045</commentid>
    <comment_count>4</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2015-06-18 14:56:35 -0700</bug_when>
    <thetext>We got rid of WK2 for Windows so this no longer applies.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>