51346 2010-12-20 12:24:20 -0800 Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit 2011-01-06 13:50:04 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue dbates ddkilzer dglazkov eric ossy tony tonyg oldest_to_newest 324500 0 laszlo.gombos 2010-12-20 12:24:20 -0800 Based on the feedback received at bug 51316. I'm not sure if most/all ports have interest in these build options, but perhaps worth considering. 324501 1 77025 laszlo.gombos 2010-12-20 12:26:08 -0800 Created attachment 77025 proposed patch 325001 2 ossy 2010-12-21 07:49:40 -0800 ENABLE_TOUCH_EVENTS is enabled by default for Android and Chromium build. But it seems that Android doesn't use build-webkit script and Chromium ignores all --FEATURE and --no-FEATURE options passed to build-webkit. Eric, could you confirm or disprove it? Otherwise this patch looks good to me. 325070 3 eric 2010-12-21 10:45:30 -0800 I know very little about Chromium's build, but that sounds right that they would ignore options passed to build-webkit. 329055 4 tony 2011-01-04 10:35:01 -0800 Yes, chromium ignores these flags to build-webkit. I think that's working as intended since flags can be modified in features.gypi. 330366 5 77025 eric 2011-01-06 13:20:36 -0800 Comment on attachment 77025 proposed patch OK. 330391 6 77025 commit-queue 2011-01-06 13:49:57 -0800 Comment on attachment 77025 proposed patch Clearing flags on attachment: 77025 Committed r75196: <http://trac.webkit.org/changeset/75196> 330392 7 commit-queue 2011-01-06 13:50:04 -0800 All reviewed patches have been landed. Closing bug. 77025 2010-12-20 12:26:08 -0800 2011-01-06 13:49:57 -0800 proposed patch 51346.patch text/plain 2834 laszlo.gombos ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MzVi Y2Q1Li5lODAwOGFmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTItMjAgIExhc3psbyBHb21ib3MgIDxsYXN6 bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSwgRU5BQkxFX09S SUVOVEFUSU9OX0VWRU5UUyBhbmQgRU5BQkxFX1RPVUNIX0VWRU5UUyBmbGFncyB0byBidWlsZC13 ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUx MzQ2CisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAxMC0xMi0yMCAgUnl1 YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIv VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggOTRiMmVhMi4uMjBlNTVlOCAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWls ZC13ZWJraXQKQEAgLTg1LDggKzg1LDEwIEBAIG15ICgKICAgICAkbGlua1ByZWZldGNoU3VwcG9y dCwKICAgICAkbWF0aG1sU3VwcG9ydCwKICAgICAkbWV0ZXJUYWdTdXBwb3J0LAorICAgICRuZXRz Y2FwZVBsdWdpblN1cHBvcnQsCiAgICAgJG5vdGlmaWNhdGlvbnNTdXBwb3J0LAogICAgICRvZmZs aW5lV2ViQXBwbGljYXRpb25TdXBwb3J0LAorICAgICRvcmllbnRhdGlvbkV2ZW50c1N1cHBvcnQs CiAgICAgJHByb2dyZXNzVGFnU3VwcG9ydCwKICAgICAkc2hhcmVkV29ya2Vyc1N1cHBvcnQsCiAg ICAgJHN2Z1N1cHBvcnQsCkBAIC05OCw2ICsxMDAsNyBAQCBteSAoCiAgICAgJHN2Z1VzZVN1cHBv cnQsCiAgICAgJHN5c3RlbU1hbGxvY1N1cHBvcnQsCiAgICAgJHRpbGVkQmFja2luZ1N0b3JlU3Vw cG9ydCwKKyAgICAkdG91Y2hFdmVudHNTdXBwb3J0LAogICAgICR2aWRlb1N1cHBvcnQsCiAgICAg JHdjc3NTdXBwb3J0LAogICAgICR3ZWJBdWRpb1N1cHBvcnQsCkBAIC0xOTMsMTIgKzE5NiwxOCBA QCBteSBAZmVhdHVyZXMgPSAoCiAgICAgeyBvcHRpb24gPT4gIm1ldGVyLXRhZyIsIGRlc2MgPT4g Ik1ldGVyIFRhZyBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX01FVEVSX1RBRyIs IGRlZmF1bHQgPT4gIWlzR3RrKCkgJiYgIWlzQXBwbGVXaW5XZWJLaXQoKSwgdmFsdWUgPT4gXCRt ZXRlclRhZ1N1cHBvcnQgfSwKIAorICAgIHsgb3B0aW9uID0+ICJuZXRzY2FwZS1wbHVnaW4iLCBk ZXNjID0+ICJOZXRzY2FwZSBQbHVnaW4gc3VwcG9ydCIsCisgICAgICBkZWZpbmUgPT4gIkVOQUJM RV9ORVRTQ0FQRV9QTFVHSU5fQVBJIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJG5ldHNjYXBl UGx1Z2luU3VwcG9ydCB9LAorCiAgICAgeyBvcHRpb24gPT4gIm5vdGlmaWNhdGlvbnMiLCBkZXNj ID0+ICJUb2dnbGUgRGVza3RvcCBOb3RpZmljYXRpb25zIFN1cHBvcnQiLAogICAgICAgZGVmaW5l ID0+ICJFTkFCTEVfTk9USUZJQ0FUSU9OUyIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRub3Rp ZmljYXRpb25zU3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4gIm9mZmxpbmUtd2ViLWFwcGxp Y2F0aW9ucyIsIGRlc2MgPT4gIlRvZ2dsZSBPZmZsaW5lIFdlYiBBcHBsaWNhdGlvbiBTdXBwb3J0 IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUyIsIGRl ZmF1bHQgPT4gMSwgdmFsdWUgPT4gXCRvZmZsaW5lV2ViQXBwbGljYXRpb25TdXBwb3J0IH0sCiAK KyAgICB7IG9wdGlvbiA9PiAib3JpZW50YXRpb24tZXZlbnRzIiwgZGVzYyA9PiAiVG9nZ2xlIE9y aWVudGF0aW9uIEV2ZW50cyBzdXBwb3J0IiwKKyAgICAgIGRlZmluZSA9PiAiRU5BQkxFX09SSUVO VEFUSU9OX0VWRU5UUyIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRvcmllbnRhdGlvbkV2ZW50 c1N1cHBvcnQgfSwKKwogICAgIHsgb3B0aW9uID0+ICJwcm9ncmVzcy10YWciLCBkZXNjID0+ICJQ cm9ncmVzcyBUYWcgc3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9QUk9HUkVTU19U QUciLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+IFwkcHJvZ3Jlc3NUYWdTdXBwb3J0IH0sCiAKQEAg LTIzMiw2ICsyNDEsOSBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgeyBvcHRpb24gPT4gInRpbGVk LWJhY2tpbmctc3RvcmUiLCBkZXNjID0+ICJUb2dnbGUgVGlsZWQgQmFja2luZyBTdG9yZSBzdXBw b3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX1RJTEVEX0JBQ0tJTkdfU1RPUkUiLCBkZWZh dWx0ID0+IGlzUXQoKSwgdmFsdWUgPT4gXCR0aWxlZEJhY2tpbmdTdG9yZVN1cHBvcnQgfSwKIAor ICAgIHsgb3B0aW9uID0+ICJ0b3VjaC1ldmVudHMiLCBkZXNjID0+ICJUb2dnbGUgVG91Y2ggRXZl bnRzIHN1cHBvcnQiLAorICAgICAgZGVmaW5lID0+ICJFTkFCTEVfVE9VQ0hfRVZFTlRTIiwgZGVm YXVsdCA9PiBpc1F0KCksIHZhbHVlID0+IFwkdG91Y2hFdmVudHNTdXBwb3J0IH0sCisKICAgICB7 IG9wdGlvbiA9PiAidmlkZW8iLCBkZXNjID0+ICJUb2dnbGUgVmlkZW8gc3VwcG9ydCIsCiAgICAg ICBkZWZpbmUgPT4gIkVOQUJMRV9WSURFTyIsIGRlZmF1bHQgPT4gKGlzQXBwbGVXZWJLaXQoKSB8 fCBpc0d0aygpKSwgdmFsdWUgPT4gXCR2aWRlb1N1cHBvcnQgfSwKIAo=