51341 2010-12-20 11:26:34 -0800 [Qt] Set BUILDING_QT__ only once 2010-12-21 04:40:10 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P4 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 324468 0 laszlo.gombos 2010-12-20 11:26:34 -0800 Qt build system defines BUILDING_QT__ inconsistently. WebKit.pri sets it to 1, while WebKit2.pro only defines it without a value even though WebKit2.pro includes WebKit.pri. Some other "pro's" don't define it at all and they rely on WebKit.pri. 324472 1 77015 laszlo.gombos 2010-12-20 11:32:12 -0800 Created attachment 77015 proposed patch 324925 2 77015 kling 2010-12-21 02:54:47 -0800 Comment on attachment 77015 proposed patch LGTM 324940 3 77015 commit-queue 2010-12-21 04:40:04 -0800 Comment on attachment 77015 proposed patch Clearing flags on attachment: 77015 Committed r74407: <http://trac.webkit.org/changeset/74407> 324942 4 commit-queue 2010-12-21 04:40:10 -0800 All reviewed patches have been landed. Closing bug. 77015 2010-12-20 11:32:12 -0800 2010-12-21 04:40:03 -0800 proposed patch 51341.patch text/plain 1998 laszlo.gombos ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA2NDMxNmJiLi45ZjRlMjA0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTAtMTItMjAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g U2V0IEJVSUxESU5HX1FUX18gY29uc2lzdGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTM0MQorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUu cHJpOiBSZW1vdmUgdGhlIGRlZmluaXRpb24gb2YgQlVJTERJTkdfUVRfXyBhcyBpdAorICAgICAg ICBpcyBhbHJlYWR5IGRlZmluZWQgaW4gV2ViS2l0LnByaS4KKwogMjAxMC0xMi0xNyAgTWljaGFl bCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2 ZXIgSHVudC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaSBi L0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQppbmRleCAwNTkwYjk0Li43ZjU1M2I5 IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKKysrIGIvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCkBAIC01Myw3ICs1Myw3IEBAIElOQ0xVREVQ QVRIID0gXAogCiB3aW4zMi0qOiBERUZJTkVTICs9IF9IQVNfVFIxPTAKIAotREVGSU5FUyArPSBC VUlMRElOR19RVF9fIEJVSUxESU5HX0phdmFTY3JpcHRDb3JlIEJVSUxESU5HX1dURgorREVGSU5F UyArPSBCVUlMRElOR19KYXZhU2NyaXB0Q29yZSBCVUlMRElOR19XVEYKIAogIyBDT05GSUcgKz0g dGV4dF9icmVha2luZ193aXRoX2ljdQogCmRpZmYgLS1naXQgYS9XZWJLaXQyL0NoYW5nZUxvZyBi L1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGU2NGUzZjcuLjU2MGM3ZGYgMTAwNjQ0Ci0tLSBhL1dl YktpdDIvQ2hhbmdlTG9nCisrKyBiL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTItMjAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gU2V0 IEJVSUxESU5HX1FUX18gY29uc2lzdGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTM0MQorCisgICAgICAgICogV2ViS2l0Mi5wcm86IFJlbW92 ZSB0aGUgZGVmaW5pdGlvbiBvZiBCVUlMRElOR19RVF9fIGFzIGl0CisgICAgICAgIGlzIGFscmVh ZHkgZGVmaW5lZCBpbiBXZWJLaXQucHJpLgorCiAyMDEwLTEyLTE5ICBEYW4gQmVybnN0ZWluICA8 bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAt LWdpdCBhL1dlYktpdDIvV2ViS2l0Mi5wcm8gYi9XZWJLaXQyL1dlYktpdDIucHJvCmluZGV4IDYw ZDZlYTUuLjFlNjRlMTMgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViS2l0Mi5wcm8KKysrIGIvV2Vi S2l0Mi9XZWJLaXQyLnBybwpAQCAtMTYxLDggKzE2MSw2IEBAIElOQ0xVREVQQVRIICs9IFwKIFBS RUZJWF9IRUFERVIgPSAkJFBXRC8uLi9XZWJLaXQyL1dlYktpdDJQcmVmaXguaAogUU1BS0VfQ1hY RkxBR1MgKz0gIi1pbmNsdWRlICQkUFJFRklYX0hFQURFUiIKIAotREVGSU5FUyArPSBCVUlMRElO R19RVF9fCi0KIFdFQktJVDJfR0VORVJBVEVEX0hFQURFUlMgPSBcCiAgICAgJCRXRUJLSVQyX0dF TkVSQVRFRF9TT1VSQ0VTX0RJUi9BdXRoZW50aWNhdGlvbk1hbmFnZXJNZXNzYWdlcy5oIFwKICAg ICAkJFdFQktJVDJfR0VORVJBVEVEX1NPVVJDRVNfRElSL0Rvd25sb2FkUHJveHlNZXNzYWdlcy5o IFwK