51338 2010-12-20 08:31:52 -0800 [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned 2010-12-20 15:37:47 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 andreip webkit-unassigned commit-queue jorlow steveblock oldest_to_newest 324411 0 andreip 2010-12-20 08:31:52 -0800 SerializedScriptValue::readUint32() should use v8::Integer::NewFromUnsigned() instead of v8::Integer::New() since the the latter treats the value as a signed integer. 324414 1 77006 andreip 2010-12-20 08:38:55 -0800 Created attachment 77006 Use NewFromUnsigned 324421 2 77006 jorlow 2010-12-20 08:48:49 -0800 Comment on attachment 77006 Use NewFromUnsigned r=me 324459 3 commit-queue 2010-12-20 10:59:53 -0800 The commit-queue encountered the following flaky tests while processing attachment 77006: fast/images/load-img-with-empty-src.html bug 50855 (author: mitz@webkit.org) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 324478 4 commit-queue 2010-12-20 11:35:40 -0800 The commit-queue encountered the following flaky tests while processing attachment 77006: fast/preloader/script.html bug 50879 (author: abarth@webkit.org) fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) The commit-queue is continuing to process your patch. 324488 5 commit-queue 2010-12-20 11:48:02 -0800 The commit-queue encountered the following flaky tests while processing attachment 77006: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 324607 6 77006 commit-queue 2010-12-20 15:37:41 -0800 Comment on attachment 77006 Use NewFromUnsigned Clearing flags on attachment: 77006 Committed r74372: <http://trac.webkit.org/changeset/74372> 324609 7 commit-queue 2010-12-20 15:37:47 -0800 All reviewed patches have been landed. Closing bug. 77006 2010-12-20 08:38:55 -0800 2010-12-20 15:37:41 -0800 Use NewFromUnsigned unsigned.patch text/plain 5732 andreip Y29tbWl0IGM5ZDY1NDBhM2ZhZDhiODZjZTk2ZWM5Yzk2ZDY5NzUzMmQ5MzkxYjgKQXV0aG9yOiBB bmRyZWkgUG9wZXNjdSA8YW5kcmVpcEBnb29nbGUuY29tPgpEYXRlOiAgIE1vbiBEZWMgMjAgMTY6 Mjc6NTMgMjAxMCArMDAwMAoKICAgIEZpeCBTZXJpYWxpemVkU2NyaXB0VmFsdWUKCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg ODJkMzE3OS4uN2FjMzMxNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTEyLTIwICBBbmRy ZWkgUG9wZXNjdSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIHY4L1NlcmlhbGl6ZWRTY3JpcHRW YWx1ZTo6cmVhZFVpbnQzMiB0cmVhdHMgaW5jb21pbmcgcmF3IHZhbHVlcyBhcyBzaWduZWQgaW5z dGVhZCBvZiB1bnNpZ25lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTEzMzgKKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1l c3NhZ2UtYXJncy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vV2luZG93L3dpbmRv dy1wb3N0bWVzc2FnZS1hcmdzLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0tbWFj L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0td2luL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9z dG1lc3NhZ2UtYXJncy1leHBlY3RlZC50eHQ6CisKIDIwMTAtMTItMTkgIEFudG9uaW8gR29tZXMg IDxhZ29tZXNAcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNzYWdlLWFy Z3MtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0 bWVzc2FnZS1hcmdzLWV4cGVjdGVkLnR4dAppbmRleCA5N2ZmOWRkLi4wNTRkOTE4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNzYWdlLWFyZ3Mt ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9z dG1lc3NhZ2UtYXJncy1leHBlY3RlZC50eHQKQEAgLTcsMTAgKzcsMTIgQEAgUEFTUzogUG9zdGlu ZyBtZXNzYWdlICgnNCcsIFtvYmplY3QgRE9NV2luZG93XSkgZGlkIG5vdCB0aHJvdyBhbiBleGNl cHRpb24KIFBBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzUnLCBudWxsKSBkaWQgbm90IHRocm93IGFu IGV4Y2VwdGlvbgogUEFTUzogUG9zdGluZyBtZXNzYWdlICgnNicsIHVuZGVmaW5lZCkgZGlkIG5v dCB0aHJvdyBhbiBleGNlcHRpb24KIFBBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzcnLCBbb2JqZWN0 IE1lc3NhZ2VQb3J0XSxbb2JqZWN0IE1lc3NhZ2VQb3J0XSkgZGlkIG5vdCB0aHJvdyBhbiBleGNl cHRpb24KK1BBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzIxNDc0ODM2NDgnLCBudWxsKSBkaWQgbm90 IHRocm93IGFuIGV4Y2VwdGlvbgogUEFTUzogUG9zdGluZyBtZXNzYWdlICgnZG9uZScsICopIGRp ZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBSZWNlaXZlZCBtZXNzYWdlICc0JwogUmVjZWl2ZWQg bWVzc2FnZSAnNScKIFJlY2VpdmVkIG1lc3NhZ2UgJzYnCiBSZWNlaXZlZCBtZXNzYWdlICc3JyB3 aXRoIDIgcG9ydHMuCitSZWNlaXZlZCBtZXNzYWdlICcyMTQ3NDgzNjQ4JwogUmVjZWl2ZWQgbWVz c2FnZSAnZG9uZScKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dp bmRvdy1wb3N0bWVzc2FnZS1hcmdzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cv d2luZG93LXBvc3RtZXNzYWdlLWFyZ3MuaHRtbAppbmRleCA1NDk3NTc2Li43MmEyN2U3IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNzYWdlLWFy Z3MuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3RtZXNz YWdlLWFyZ3MuaHRtbApAQCAtNDUsNiArNDUsNyBAQCB0cnlQb3N0TWVzc2FnZSgnNCcsIHdpbmRv dywgJyonKTsgIC8vIFBhc3NlcyBiZWNhdXNlIHdpbmRvdyBoYXMgYSAibGVuZ3RoIiBhdHRyaQog dHJ5UG9zdE1lc3NhZ2UoJzUnLCBudWxsLCAnKicpOwogdHJ5UG9zdE1lc3NhZ2UoJzYnLCB2b2lk IDAsICcqJyk7CiB0cnlQb3N0TWVzc2FnZSgnNycsIFtjaGFubmVsLnBvcnQxLCBjaGFubmVsLnBv cnQyXSwgJyonKTsKK3RyeVBvc3RNZXNzYWdlKDIxNDc0ODM2NDgsIG51bGwsICcqJyk7CiB0cnlQ b3N0TWVzc2FnZSgnZG9uZScsICcqJyk7CiA8L3NjcmlwdD4KIDwvYm9keT4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLW1hYy9mYXN0L2RvbS9XaW5kb3cvd2luZG93 LXBvc3RtZXNzYWdlLWFyZ3MtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0tbWFjL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy1leHBlY3Rl ZC50eHQKaW5kZXggNjFlZDMxMC4uNWVjZTg0MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0tbWFjL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJn cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjL2Zh c3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy1leHBlY3RlZC50eHQKQEAgLTcs MTAgKzcsMTIgQEAgUEFTUzogUG9zdGluZyBtZXNzYWdlICgnNCcsIFtvYmplY3QgRE9NV2luZG93 XSkgZGlkIG5vdCB0aHJvdyBhbiBleGNlcHRpb24KIFBBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzUn LCBudWxsKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgogUEFTUzogUG9zdGluZyBtZXNzYWdl ICgnNicsIHVuZGVmaW5lZCkgZGlkIG5vdCB0aHJvdyBhbiBleGNlcHRpb24KIFBBU1M6IFBvc3Rp bmcgbWVzc2FnZSAoJzcnLCBbb2JqZWN0IE1lc3NhZ2VQb3J0XSxbb2JqZWN0IE1lc3NhZ2VQb3J0 XSkgZGlkIG5vdCB0aHJvdyBhbiBleGNlcHRpb24KK1BBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzIx NDc0ODM2NDgnLCBudWxsKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgogUEFTUzogUG9zdGlu ZyBtZXNzYWdlICgnZG9uZScsICopIGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBSZWNlaXZl ZCBtZXNzYWdlICc0JwogUmVjZWl2ZWQgbWVzc2FnZSAnNScKIFJlY2VpdmVkIG1lc3NhZ2UgJzYn CiBSZWNlaXZlZCBtZXNzYWdlICc3JyB3aXRoIDIgcG9ydHMuCitSZWNlaXZlZCBtZXNzYWdlICcy MTQ3NDgzNjQ4JwogUmVjZWl2ZWQgbWVzc2FnZSAnZG9uZScKIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1l c3NhZ2UtYXJncy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS13 aW4vZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLWV4cGVjdGVkLnR4dApp bmRleCA2MWVkMzEwLi41ZWNlODQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS13aW4vZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS13aW4vZmFzdC9kb20v V2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLWV4cGVjdGVkLnR4dApAQCAtNywxMCArNywx MiBAQCBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCc0JywgW29iamVjdCBET01XaW5kb3ddKSBkaWQg bm90IHRocm93IGFuIGV4Y2VwdGlvbgogUEFTUzogUG9zdGluZyBtZXNzYWdlICgnNScsIG51bGwp IGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCc2Jywg dW5kZWZpbmVkKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgogUEFTUzogUG9zdGluZyBtZXNz YWdlICgnNycsIFtvYmplY3QgTWVzc2FnZVBvcnRdLFtvYmplY3QgTWVzc2FnZVBvcnRdKSBkaWQg bm90IHRocm93IGFuIGV4Y2VwdGlvbgorUEFTUzogUG9zdGluZyBtZXNzYWdlICgnMjE0NzQ4MzY0 OCcsIG51bGwpIGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBQQVNTOiBQb3N0aW5nIG1lc3Nh Z2UgKCdkb25lJywgKikgZGlkIG5vdCB0aHJvdyBhbiBleGNlcHRpb24KIFJlY2VpdmVkIG1lc3Nh Z2UgJzQnCiBSZWNlaXZlZCBtZXNzYWdlICc1JwogUmVjZWl2ZWQgbWVzc2FnZSAnNicKIFJlY2Vp dmVkIG1lc3NhZ2UgJzcnIHdpdGggMiBwb3J0cy4KK1JlY2VpdmVkIG1lc3NhZ2UgJzIxNDc0ODM2 NDgnCiBSZWNlaXZlZCBtZXNzYWdlICdkb25lJwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDg0YzQ0MTMuLmRkMGRhMjUgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MTUgQEAKIDIwMTAtMTItMjAgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29nbGUuY29tPgog CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1 bV0gdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpyZWFkVWludDMyIHRyZWF0cyBpbmNvbWluZyBy YXcgdmFsdWVzIGFzIHNpZ25lZCBpbnN0ZWFkIG9mIHVuc2lnbmVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTMzOAorCisgICAgICAgICogYmluZGlu Z3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlppZ1ph Zzo6UmVhZGVyOjpyZWFkVWludDMyKToKKworMjAxMC0xMi0yMCAgQW5kcmVpIFBvcGVzY3UgIDxh bmRyZWlwQGdvb2dsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93Lgog CiAgICAgICAgIElEQlRyYW5zYWN0aW9uQmFja2VkSW1wbCBpbnN0YW5jZXMgY2FuIGJlIGFjY2lk ZW50YWxseSBkZWxldGVkIGR1cmluZyBjYWxscyB0byBhYm9ydC9jb21taXQuCmRpZmYgLS1naXQg YS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggMzZmYzFmNi4uNWE4 OWUxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFs dWUuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNw cApAQCAtODQ0LDcgKzg0NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIHVpbnQzMl90IHJhd1ZhbHVl OwogICAgICAgICBpZiAoIWRvUmVhZFVpbnQzMigmcmF3VmFsdWUpKQogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwotICAgICAgICAqdmFsdWUgPSB2ODo6SW50ZWdlcjo6TmV3KHJhd1ZhbHVlKTsK KyAgICAgICAgKnZhbHVlID0gdjg6OkludGVnZXI6Ok5ld0Zyb21VbnNpZ25lZChyYXdWYWx1ZSk7 CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAo=