51331 2010-12-20 07:23:41 -0800 [Qt] REGRESSION (r73535): tst_QWebPage fails 2011-02-11 05:53:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Normal --- 50586 1 ossy webkit-unassigned commit-queue kenneth kling robert oldest_to_newest 324382 0 76997 ossy 2010-12-20 07:23:41 -0800 Created attachment 76997 GDB backtrace in debug mode QFATAL : tst_QWebPage::contextMenuCrash() Received signal 11 FAIL! : tst_QWebPage::contextMenuCrash() Received a fatal error. (GDB backtrace attached) 338593 1 79847 robert 2011-01-22 08:57:30 -0800 Created attachment 79847 Patch 344668 2 79847 ossy 2011-02-03 06:29:38 -0800 Comment on attachment 79847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79847&action=review > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:512 > - QVERIFY(contextMenu); > + QVERIFY(!contextMenu); > delete contextMenu; Deleting a null pointer is incorrect. Otherwise it worked for me locally. 344938 3 robert 2011-02-03 12:51:28 -0800 (In reply to comment #2) > (From update of attachment 79847 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79847&action=review > > > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:512 > > - QVERIFY(contextMenu); > > + QVERIFY(!contextMenu); > > delete contextMenu; > > Deleting a null pointer is incorrect. Otherwise it worked for me locally. Good point, though see https://bugs.webkit.org/show_bug.cgi?id=20357 The test is ensuring that contextMenu is a protected pointer. So attempting to delete it still tests that, I think. Could be confused though. 347606 4 81676 robert 2011-02-08 12:42:15 -0800 Created attachment 81676 Patch 348563 5 81676 commit-queue 2011-02-09 14:16:58 -0800 Comment on attachment 81676 Patch Clearing flags on attachment: 81676 Committed r78135: <http://trac.webkit.org/changeset/78135> 348564 6 commit-queue 2011-02-09 14:17:03 -0800 All reviewed patches have been landed. Closing bug. 348586 7 ossy 2011-02-09 14:37:14 -0800 r78135 fixed a bug and show us a previously hidden fail: QFATAL : tst_QWebPage::inputMethodsTextFormat(Qt by) Received signal 15 FAIL! : tst_QWebPage::inputMethodsTextFormat(Qt by) Received a fatal error. Robert, could you file a new bug report on it, please? 349193 8 robert 2011-02-10 10:59:08 -0800 (In reply to comment #7) > r78135 fixed a bug and show us a previously hidden fail: > QFATAL : tst_QWebPage::inputMethodsTextFormat(Qt by) Received signal 15 > FAIL! : tst_QWebPage::inputMethodsTextFormat(Qt by) Received a fatal error. > > Robert, could you file a new bug report on it, please? That didn't crash for me on Qt 6.X here. 349730 9 ossy 2011-02-11 05:53:49 -0800 (In reply to comment #8) > (In reply to comment #7) > > r78135 fixed a bug and show us a previously hidden fail: > > QFATAL : tst_QWebPage::inputMethodsTextFormat(Qt by) Received signal 15 > > FAIL! : tst_QWebPage::inputMethodsTextFormat(Qt by) Received a fatal error. > > > > Robert, could you file a new bug report on it, please? > > That didn't crash for me on Qt 6.X here. I did it yesterday by myself: https://bugs.webkit.org/show_bug.cgi?id=54217 76997 2010-12-20 07:23:41 -0800 2010-12-20 07:23:41 -0800 GDB backtrace in debug mode backtrace.txt text/plain 3005 ossy JCBnZGIgV2ViS2l0QnVpbGQvRGVidWcvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2Vi cGFnZQ0KR05VIGdkYiA2LjgtZGViaWFuDQpDb3B5cmlnaHQgKEMpIDIwMDggRnJlZSBTb2Z0d2Fy ZSBGb3VuZGF0aW9uLCBJbmMuDQpMaWNlbnNlIEdQTHYzKzogR05VIEdQTCB2ZXJzaW9uIDMgb3Ig bGF0ZXIgPGh0dHA6Ly9nbnUub3JnL2xpY2Vuc2VzL2dwbC5odG1sPg0KVGhpcyBpcyBmcmVlIHNv ZnR3YXJlOiB5b3UgYXJlIGZyZWUgdG8gY2hhbmdlIGFuZCByZWRpc3RyaWJ1dGUgaXQuDQpUaGVy ZSBpcyBOTyBXQVJSQU5UWSwgdG8gdGhlIGV4dGVudCBwZXJtaXR0ZWQgYnkgbGF3LiAgVHlwZSAi c2hvdyBjb3B5aW5nIg0KYW5kICJzaG93IHdhcnJhbnR5IiBmb3IgZGV0YWlscy4NClRoaXMgR0RC IHdhcyBjb25maWd1cmVkIGFzICJpNDg2LWxpbnV4LWdudSIuLi4NCihnZGIpIHJ1bg0KU3RhcnRp bmcgcHJvZ3JhbTogL2hvbWUvb3N6aS9XZWJLaXQvV2ViS2l0QnVpbGQvRGVidWcvV2ViS2l0L3F0 L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZQ0KW1RocmVhZCBkZWJ1Z2dpbmcgdXNpbmcgbGli dGhyZWFkX2RiIGVuYWJsZWRdDQpbTmV3IFRocmVhZCAweGYyZWQyNmMwIChMV1AgNTk3NyldDQoq KioqKioqKiogU3RhcnQgdGVzdGluZyBvZiB0c3RfUVdlYlBhZ2UgKioqKioqKioqDQpDb25maWc6 IFVzaW5nIFFUZXN0IGxpYnJhcnkgNC43LjEsIFF0IDQuNy4xDQpQQVNTICAgOiB0c3RfUVdlYlBh Z2U6OmluaXRUZXN0Q2FzZSgpDQpQQVNTICAgOiB0c3RfUVdlYlBhZ2U6OmFjY2VwdE5hdmlnYXRp b25SZXF1ZXN0KCkNClNLSVAgICA6IHRzdF9RV2ViUGFnZTo6Z2VvbG9jYXRpb25SZXF1ZXN0SlMo KSBUZXN0IGRpc2FibGVkIGFzIGxvbmcgYXMgZ2VvbG9jYXRpb24gaXMgZGlzYWJsZWQgZnJvbSB0 aGUgYnVpbGQuDQogICBMb2M6IFsvaG9tZS9vc3ppL1dlYktpdC9XZWJLaXQvcXQvdGVzdHMvcXdl YnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCgyNTYpXQ0KUEFTUyAgIDogdHN0X1FXZWJQYWdlOjpnZW9s b2NhdGlvblJlcXVlc3RKUygpDQpQQVNTICAgOiB0c3RfUVdlYlBhZ2U6OmxvYWRGaW5pc2hlZCgp DQpQQVNTICAgOiB0c3RfUVdlYlBhZ2U6OmFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0V2l0aE5ld1dp bmRvdygpDQpbTmV3IFRocmVhZCAweGYyNjBmYjkwIChMV1AgODY2MCldDQpQQVNTICAgOiB0c3Rf UVdlYlBhZ2U6OnVzZXJTdHlsZVNoZWV0KCkNClBBU1MgICA6IHRzdF9RV2ViUGFnZTo6bW9kaWZp ZWQoKQ0KDQpQcm9ncmFtIHJlY2VpdmVkIHNpZ25hbCBTSUdTRUdWLCBTZWdtZW50YXRpb24gZmF1 bHQuDQpbU3dpdGNoaW5nIHRvIFRocmVhZCAweGYyZWQyNmMwIChMV1AgNTk3NyldDQoweDA4MDdh Njc2IGluIFFMaXN0RGF0YTo6c2l6ZSAodGhpcz0weDApIGF0IC91c3IvbG9jYWwvVHJvbGx0ZWNo L1F0LTQuNy4xL2luY2x1ZGUvUXRDb3JlL3FsaXN0Lmg6OTQNCjk0ICAgICAgICAgIGlubGluZSBp bnQgc2l6ZSgpIGNvbnN0IHsgcmV0dXJuIGQtPmVuZCAtIGQtPmJlZ2luOyB9DQooZ2RiKSBidA0K IzAgIDB4MDgwN2E2NzYgaW4gUUxpc3REYXRhOjpzaXplICh0aGlzPTB4MCkgYXQgL3Vzci9sb2Nh bC9Ucm9sbHRlY2gvUXQtNC43LjEvaW5jbHVkZS9RdENvcmUvcWxpc3QuaDo5NA0KIzEgIDB4ZjY2 YTRhYWIgaW4gUUxpc3Q8V2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtPjo6Y291bnQgKHRoaXM9MHgw KSBhdCAvdXNyL2xvY2FsL1Ryb2xsdGVjaC9RdC00LjcuMS9pbmNsdWRlL1F0Q29yZS9xbGlzdC5o OjI2Nw0KIzIgIDB4ZjY3MTNiNDUgaW4gUVdlYlBhZ2VQcml2YXRlOjpjcmVhdGVDb250ZXh0TWVu dSAodGhpcz0weDg2NDMxOTgsIHdlYmNvcmVNZW51PTB4MCwgaXRlbXM9MHgwLCB2aXNpdGVkV2Vi QWN0aW9ucz0weGZmOTEwMDY4KSBhdCAuLi8uLi8uLi9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNw cDo0MzcNCiMzICAweGY2NzE0MDlhIGluIFFXZWJQYWdlOjp1cGRhdGVQb3NpdGlvbkRlcGVuZGVu dEFjdGlvbnMgKHRoaXM9MHg4NjQzMTEwLCBwb3M9QDB4ZmY5MTAxMmMpIGF0IC4uLy4uLy4uL1dl YktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwOjMyMjcNCiM0ICAweDA4MDY2YTUyIGluIHRzdF9RV2Vi UGFnZTo6Y29udGV4dE1lbnVDcmFzaCAodGhpcz0weGZmOTEwYTU0KSBhdCAvaG9tZS9vc3ppL1dl YktpdC9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDo0OTMNCiM1ICAw eDA4MDdhMWFkIGluIHRzdF9RV2ViUGFnZTo6cXRfbWV0YWNhbGwgKHRoaXM9MHhmZjkxMGE1NCwg X2M9UU1ldGFPYmplY3Q6Okludm9rZU1ldGFNZXRob2QsIF9pZD0xMSwgX2E9MHhmZjkxMDI1OCkg YXQgL2hvbWUvb3N6aS9XZWJLaXQvV2ViS2l0QnVpbGQvRGVidWcvV2ViS2l0L3F0L3Rlc3RzL3F3 ZWJwYWdlLy4vdHN0X3F3ZWJwYWdlLm1vYzoyMTcNCiM2ICAweGYzYzJlZWM1IGluIFFNZXRhT2Jq ZWN0OjptZXRhY2FsbCAoKSBmcm9tIC91c3IvbG9jYWwvVHJvbGx0ZWNoL1F0LTQuNy4xL2xpYi9s aWJRdENvcmUuc28uNA0KIzcgIDB4ZjNjMzI4MWIgaW4gUU1ldGFNZXRob2Q6Omludm9rZSAoKSBm cm9tIC91c3IvbG9jYWwvVHJvbGx0ZWNoL1F0LTQuNy4xL2xpYi9saWJRdENvcmUuc28uNA0KIzgg IDB4ZjNjMzNmOTAgaW4gUU1ldGFPYmplY3Q6Omludm9rZU1ldGhvZCAoKSBmcm9tIC91c3IvbG9j YWwvVHJvbGx0ZWNoL1F0LTQuNy4xL2xpYi9saWJRdENvcmUuc28uNA0KIzkgIDB4ZjQ5Njg5MmEg aW4gPz8gKCkgZnJvbSAvdXNyL2xvY2FsL1Ryb2xsdGVjaC9RdC00LjcuMS9saWIvbGliUXRUZXN0 LnNvLjQNCiMxMCAweGY0OTY5NmM3IGluIFFUZXN0OjpxRXhlYyAoKSBmcm9tIC91c3IvbG9jYWwv VHJvbGx0ZWNoL1F0LTQuNy4xL2xpYi9saWJRdFRlc3Quc28uNA0KIzExIDB4MDgwNTZjYTMgaW4g bWFpbiAoYXJnYz0xLCBhcmd2PTB4ZmY5MTBiMTQpIGF0IC9ob21lL29zemkvV2ViS2l0L1dlYktp dC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOjI2MDI= 79847 2011-01-22 08:57:30 -0800 2011-02-08 12:42:09 -0800 Patch bug-51331-20110122165728.patch text/plain 2894 robert ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9X ZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRleCBlODBhYWM1MmZmNTkxYjFkNWYwNDE1OTI2 ZmViOTM4MTMyNTQ3ZjE2Li5iNDk3ZGY3NjcwMWJlNjdhYzk5OTBlMTI2YTFkNWY2ZTA1YzU4MDhl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCkBAIC00MzEsNyArNDMxLDcgQEAgc3RhdGlj IFFXZWJQYWdlOjpXZWJBY3Rpb24gd2ViQWN0aW9uRm9yQ29udGV4dE1lbnVBY3Rpb24oV2ViQ29y ZTo6Q29udGV4dE1lbnVBY3QKIFFNZW51ICpRV2ViUGFnZVByaXZhdGU6OmNyZWF0ZUNvbnRleHRN ZW51KGNvbnN0IFdlYkNvcmU6OkNvbnRleHRNZW51ICp3ZWJjb3JlTWVudSwKICAgICAgICAgY29u c3QgUUxpc3Q8V2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtPiAqaXRlbXMsIFFCaXRBcnJheSAqdmlz aXRlZFdlYkFjdGlvbnMpCiB7Ci0gICAgaWYgKCFjbGllbnQpCisgICAgaWYgKCFjbGllbnQgfHwg IXdlYmNvcmVNZW51KQogICAgICAgICByZXR1cm4gMDsKIAogICAgIFFNZW51KiBtZW51ID0gbmV3 IFFNZW51KGNsaWVudC0+b3duZXJXaWRnZXQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGRmZjg5MzVh NzQzZTBjM2U0MGEzZWI4ZjdmYzQ1NzQyYzM1NjJhMjYuLjA5ZDY0YWU2NmM1N2RkZDQxZDNjOTFj YTIzNGQxYjNjNGI1ODEzNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjkgQEAKIDIwMTEt MDEtMjIgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUkVHUkVTU0lPTiAocjczNTM1 KTogdHN0X1FXZWJQYWdlIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MTMzMQorCisgICAgICAgIFNpbmNlIHI3MzUzNSBhIENvbnRleHRNZW51 IGlzIG9ubHkgY3JlYXRlZCB3aGVuIGEgY29udGV4dCBtZW51CisgICAgICAgIGV2ZW50IGlzIHJl Y2VpdmVkLCBzbyBRV2ViUGFnZTo6dXBkYXRlUG9zaXRpb25EZXBlbmRlbnRBY3Rpb25zKCkKKyAg ICAgICAgY2FuJ3QgZGVwZW5kIG9uIG9uZSBiZWluZyB0aGVyZSBpZiBpdCBpcyBjYWxsZWQgZGly ZWN0bHkgYnkKKyAgICAgICAgdGhlIGNsaWVudC4gUXRXZWJLaXQgaXRzZWxmIG9ubHkgZXZlciBj YWxscyB1cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFjdGlvbnMoKQorICAgICAgICB3aGVuIGEgY29u dGV4dCBtZW51IGV2ZW50IGhhcyBiZWVuIHJlY2VpdmVkLgorCisgICAgICAgIFVwZGF0ZSB0c3Rf UVdlYlBhZ2U6Y29udGV4dE1lbnVDcmFzaCB0byBleHBlY3QgYSBudWxsIGNvbnRleHQgbWVudS4K KworICAgICAgICBUaGVyZSBkb2Vzbid0IHNlZW0gdG8gYmUgYSBnb29kIHJlYXNvbiBmb3IgY3Jl YXRpbmcgYSBjb250ZXh0IG1lbnUgaWYKKyAgICAgICAgY2xpZW50cyBjYWxsIFFXZWJQYWdlOjp1 cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFjdGlvbnMoKSB3aGVuIG5vCisgICAgICAgIGNvbnRleHQg bWVudSBldmVudCBoYXMgZXZlciBiZWVuIHJlY2VpdmVkLgorCisgICAgICAgICogQXBpL3F3ZWJw YWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6Y3JlYXRlQ29udGV4dE1lbnUpOgor ICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3Rf UVdlYlBhZ2U6OmNvbnRleHRNZW51Q3Jhc2gpOgorCisyMDExLTAxLTIyICBSb2JlcnQgSG9nYW4g IDxyb2JlcnRAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5n LgogCiAgICAgICAgIFtRdF0gU3VwcG9ydCBsYXlvdXRUZXN0Q29udHJvbGxlci5hZGRVUkxUb1Jl ZGlyZWN0KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJw YWdlLmNwcAppbmRleCBlYzFmMzM2NTUzZDBhMTMwMjBjOGVkNGE2MTAwNDZhMzIzZGViZmNjLi4y M2M1NjNjNWVlY2M0NDU0NjI1NmE3N2RiMzUxMjVhMjgzNWI2ZGM3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC00OTUsNiArNDk1 LDggQEAgdm9pZCB0c3RfUVdlYlBhZ2U6Om1vZGlmaWVkKCkKICAgICBRVkVSSUZZKDo6d2FpdEZv clNpZ25hbChtX3BhZ2UsIFNJR05BTChzYXZlRnJhbWVTdGF0ZVJlcXVlc3RlZChRV2ViRnJhbWUq LFFXZWJIaXN0b3J5SXRlbSopKSkpOwogfQogCisvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAzNTcKKy8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01MTMzMQogdm9pZCB0c3RfUVdlYlBhZ2U6OmNvbnRleHRNZW51Q3Jhc2goKQogewog ICAgIFFXZWJWaWV3IHZpZXc7CkBAIC01MDYsNyArNTA4LDcgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6 OmNvbnRleHRNZW51Q3Jhc2goKQogICAgICAgICBpZiAoY29udGV4dE1lbnUpCiAgICAgICAgICAg ICBicmVhazsKICAgICB9Ci0gICAgUVZFUklGWShjb250ZXh0TWVudSk7CisgICAgUVZFUklGWSgh Y29udGV4dE1lbnUpOwogICAgIGRlbGV0ZSBjb250ZXh0TWVudTsKIH0KIAo= 81676 2011-02-08 12:42:15 -0800 2011-02-09 14:16:58 -0800 Patch bug-51331-20110208204213.patch text/plain 3842 robert U3VidmVyc2lvbiBSZXZpc2lvbjogNzc5NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv QXBpL3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRl eCA0NDc0MGEwMWUwYmRlYzMxYmJmNGMyNWEwYjM2NWM3YjU0YzA0NTk5Li45OWVhZjkxNjc3NWM2 NzRkY2MyODlmNzZhMDUwZDM4ZjY3MWI2YTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3Bw CkBAIC00MzMsNyArNDMzLDcgQEAgc3RhdGljIFFXZWJQYWdlOjpXZWJBY3Rpb24gd2ViQWN0aW9u Rm9yQ29udGV4dE1lbnVBY3Rpb24oV2ViQ29yZTo6Q29udGV4dE1lbnVBY3QKIFFNZW51ICpRV2Vi UGFnZVByaXZhdGU6OmNyZWF0ZUNvbnRleHRNZW51KGNvbnN0IFdlYkNvcmU6OkNvbnRleHRNZW51 ICp3ZWJjb3JlTWVudSwKICAgICAgICAgY29uc3QgUUxpc3Q8V2ViQ29yZTo6Q29udGV4dE1lbnVJ dGVtPiAqaXRlbXMsIFFCaXRBcnJheSAqdmlzaXRlZFdlYkFjdGlvbnMpCiB7Ci0gICAgaWYgKCFj bGllbnQpCisgICAgaWYgKCFjbGllbnQgfHwgIXdlYmNvcmVNZW51KQogICAgICAgICByZXR1cm4g MDsKIAogICAgIFFNZW51KiBtZW51ID0gbmV3IFFNZW51KGNsaWVudC0+b3duZXJXaWRnZXQoKSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv cXQvQ2hhbmdlTG9nCmluZGV4IGVmNzczYjZjZTNhNjNjMDBjMGU2YjNmZGQ4OWMzMTgyMmE0N2Y0 NmQuLmJjOWQzMDZmODExYjliYTU1ODRhNjMxNjQ2YTVmODg0ZTVhMzhmYzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDItMDggIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtRdF0gUkVHUkVTU0lPTiAocjczNTM1KTogdHN0X1FXZWJQYWdlIGZhaWxzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTMzMQorCisgICAgICAg IFNpbmNlIHI3MzUzNSBhIENvbnRleHRNZW51IGlzIG9ubHkgY3JlYXRlZCB3aGVuIGEgY29udGV4 dCBtZW51CisgICAgICAgIGV2ZW50IGlzIHJlY2VpdmVkLCBzbyBRV2ViUGFnZTo6dXBkYXRlUG9z aXRpb25EZXBlbmRlbnRBY3Rpb25zKCkKKyAgICAgICAgY2FuJ3QgZGVwZW5kIG9uIG9uZSBiZWlu ZyB0aGVyZSBpZiBpdCBpcyBjYWxsZWQgZGlyZWN0bHkgYnkKKyAgICAgICAgdGhlIGNsaWVudC4g UXRXZWJLaXQgaXRzZWxmIG9ubHkgZXZlciBjYWxscyB1cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFj dGlvbnMoKQorICAgICAgICB3aGVuIGEgY29udGV4dCBtZW51IGV2ZW50IGhhcyBiZWVuIHJlY2Vp dmVkLgorCisgICAgICAgIFVwZGF0ZSB0c3RfUVdlYlBhZ2U6Y29udGV4dE1lbnVDcmFzaCB0byBj cmVhdGUgYSBjb250ZXh0IG1lbnUuCisgICAgICAgIEFkZCB0c3RfUVdlYlBhZ2U6dXBkYXRlUG9z aXRpb25EZXBlbmRlbnRBY3Rpb25zQ3Jhc2ggdG8gdGVzdCBmb3IgdGhpcyBjcmFzaC4KKworICAg ICAgICBUaGVyZSBkb2Vzbid0IHNlZW0gdG8gYmUgYSBnb29kIHJlYXNvbiBmb3IgY3JlYXRpbmcg YSBjb250ZXh0IG1lbnUgaWYKKyAgICAgICAgY2xpZW50cyBjYWxsIFFXZWJQYWdlOjp1cGRhdGVQ b3NpdGlvbkRlcGVuZGVudEFjdGlvbnMoKSB3aGVuIG5vCisgICAgICAgIGNvbnRleHQgbWVudSBl dmVudCBoYXMgZXZlciBiZWVuIHJlY2VpdmVkLgorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNw cDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6Y3JlYXRlQ29udGV4dE1lbnUpOgorICAgICAg ICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBh Z2U6OmNvbnRleHRNZW51Q3Jhc2gpOgorCiAyMDExLTAyLTA3ICBBcGFybmEgTmFuZHlhbCAgPGFw YXJuYS5uYW5kQHdpcHJvLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5n LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBh Z2UuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3Bw CmluZGV4IDAzMDgwZTkyYWE0YzUxZDVjMzAzZTEzZWUwY2M1ZjQ4ZjQ3N2Q2ODcuLmM5YzQwOWQ3 ZDA1YWVmZjE0ZDY5ZGE4YWFkYzgzZTFmYjMxMjhjNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKQEAgLTg2LDYgKzg2LDcgQEAgcHJp dmF0ZSBzbG90czoKICAgICB2b2lkIHVzZXJTdHlsZVNoZWV0KCk7CiAgICAgdm9pZCBtb2RpZmll ZCgpOwogICAgIHZvaWQgY29udGV4dE1lbnVDcmFzaCgpOworICAgIHZvaWQgdXBkYXRlUG9zaXRp b25EZXBlbmRlbnRBY3Rpb25zQ3Jhc2goKTsKICAgICB2b2lkIGRhdGFiYXNlKCk7CiAgICAgdm9p ZCBjcmVhdGVQbHVnaW5XaXRoUGx1Z2luc0VuYWJsZWQoKTsKICAgICB2b2lkIGNyZWF0ZVBsdWdp bldpdGhQbHVnaW5zRGlzYWJsZWQoKTsKQEAgLTQ5NywxMSArNDk4LDMxIEBAIHZvaWQgdHN0X1FX ZWJQYWdlOjptb2RpZmllZCgpCiAgICAgUVZFUklGWSg6OndhaXRGb3JTaWduYWwobV9wYWdlLCBT SUdOQUwoc2F2ZUZyYW1lU3RhdGVSZXF1ZXN0ZWQoUVdlYkZyYW1lKixRV2ViSGlzdG9yeUl0ZW0q KSkpKTsKIH0KIAorLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUx MzMxCit2b2lkIHRzdF9RV2ViUGFnZTo6dXBkYXRlUG9zaXRpb25EZXBlbmRlbnRBY3Rpb25zQ3Jh c2goKQoreworICAgIFFXZWJWaWV3IHZpZXc7CisgICAgdmlldy5zZXRIdG1sKCI8cD50ZXN0Iik7 CisgICAgUVBvaW50IHBvcygwLCAwKTsKKyAgICB2aWV3LnBhZ2UoKS0+dXBkYXRlUG9zaXRpb25E ZXBlbmRlbnRBY3Rpb25zKHBvcyk7CisgICAgUU1lbnUqIGNvbnRleHRNZW51ID0gMDsKKyAgICBm b3JlYWNoIChRT2JqZWN0KiBjaGlsZCwgdmlldy5jaGlsZHJlbigpKSB7CisgICAgICAgIGNvbnRl eHRNZW51ID0gcW9iamVjdF9jYXN0PFFNZW51Kj4oY2hpbGQpOworICAgICAgICBpZiAoY29udGV4 dE1lbnUpCisgICAgICAgICAgICBicmVhazsKKyAgICB9CisgICAgUVZFUklGWSghY29udGV4dE1l bnUpOworfQorCisvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAz NTcKIHZvaWQgdHN0X1FXZWJQYWdlOjpjb250ZXh0TWVudUNyYXNoKCkKIHsKICAgICBRV2ViVmll dyB2aWV3OwogICAgIHZpZXcuc2V0SHRtbCgiPHA+dGVzdCIpOwotICAgIHZpZXcucGFnZSgpLT51 cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFjdGlvbnMoUVBvaW50KDAsIDApKTsKKyAgICBRUG9pbnQg cG9zKDAsIDApOworICAgIFFDb250ZXh0TWVudUV2ZW50IGV2ZW50KFFDb250ZXh0TWVudUV2ZW50 OjpNb3VzZSwgcG9zKTsKKyAgICB2aWV3LnBhZ2UoKS0+c3dhbGxvd0NvbnRleHRNZW51RXZlbnQo JmV2ZW50KTsKKyAgICB2aWV3LnBhZ2UoKS0+dXBkYXRlUG9zaXRpb25EZXBlbmRlbnRBY3Rpb25z KHBvcyk7CiAgICAgUU1lbnUqIGNvbnRleHRNZW51ID0gMDsKICAgICBmb3JlYWNoIChRT2JqZWN0 KiBjaGlsZCwgdmlldy5jaGlsZHJlbigpKSB7CiAgICAgICAgIGNvbnRleHRNZW51ID0gcW9iamVj dF9jYXN0PFFNZW51Kj4oY2hpbGQpOwo=