<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51319</bug_id>
          
          <creation_ts>2010-12-19 21:56:56 -0800</creation_ts>
          <short_desc>[CMAKE] Change WEBKITTOOLS_DIR to TOOLS_DIR</short_desc>
          <delta_ts>2010-12-25 15:33:47 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Ryuan Choi">ryuan.choi</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>antognolli+webkit</cc>
    
    <cc>commit-queue</cc>
    
    <cc>kenneth</cc>
    
    <cc>leandro</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>paroga</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>324289</commentid>
    <comment_count>0</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2010-12-19 21:56:56 -0800</bug_when>
    <thetext>WebKitTools/ was changed to Tools/, so CMake system should be changed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324290</commentid>
    <comment_count>1</comment_count>
      <attachid>76975</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2010-12-19 22:03:22 -0800</bug_when>
    <thetext>Created attachment 76975
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324291</commentid>
    <comment_count>2</comment_count>
      <attachid>76976</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2010-12-19 22:16:50 -0800</bug_when>
    <thetext>Created attachment 76976
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324311</commentid>
    <comment_count>3</comment_count>
      <attachid>76976</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-20 01:08:38 -0800</bug_when>
    <thetext>Comment on attachment 76976
Patch

Clearing flags on attachment: 76976

Committed r74334: &lt;http://trac.webkit.org/changeset/74334&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>324312</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-20 01:08:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>326838</commentid>
    <comment_count>5</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2010-12-25 15:33:47 -0800</bug_when>
    <thetext>r74660 &lt;http://trac.webkit.org/changeset/74660&gt; fixed WinCE build.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76975</attachid>
            <date>2010-12-19 22:03:22 -0800</date>
            <delta_ts>2010-12-19 22:16:44 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-51319-20101220150320.patch</filename>
            <type>text/plain</type>
            <size>1596</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc0MzMx
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTIt
MTkgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gQ2hhbmdlIFdFQktJVFRP
T0xTX0RJUiB0byBUT09MU19ESVIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTUxMzE5CisKKyAgICAgICAgQ2hhbmdlIFdFQktJVFRPT0xTX0RJUiB2YXJp
YWJsZSdzIG5hbWUgYW5kIHZhbHVlIHRvIFRPT0xTX0RJUiBhbmQgdG9vbHMvCisKKyAgICAgICAg
KiBDTWFrZUxpc3RzLnR4dDogCisKIDIwMTAtMTItMTcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFw
cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBDTWFr
ZUxpc3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDTWFrZUxpc3RzLnR4dAkocmV2aXNpb24gNzQzMzEp
CisrKyBDTWFrZUxpc3RzLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMTIsNyArMTIsNyBAQCBTRVQo
Q01BS0VfTU9EVUxFX1BBVEggIiR7Q01BS0VfU09VUkNFX0RJCiBTRVQoSkFWQVNDUklQVENPUkVf
RElSICIke0NNQUtFX1NPVVJDRV9ESVJ9L0phdmFTY3JpcHRDb3JlIikKIFNFVChXRUJDT1JFX0RJ
UiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9XZWJDb3JlIikKIFNFVChXRUJLSVRfRElSICIke0NNQUtF
X1NPVVJDRV9ESVJ9L1dlYktpdCIpCi1TRVQoV0VCS0lUVE9PTFNfRElSICIke0NNQUtFX1NPVVJD
RV9ESVJ9L1dlYktpdFRvb2xzIikKK1NFVChUT09MU19ESVIgIiR7Q01BS0VfU09VUkNFX0RJUn0v
VG9vbHMiKQogU0VUKERFUklWRURfU09VUkNFU19ESVIgIiR7Q01BS0VfQklOQVJZX0RJUn0vRGVy
aXZlZFNvdXJjZXMiKQogCiBJTkNMVURFKFdlYktpdE1hY3JvcykKQEAgLTExMSw3ICsxMTEsNyBA
QCBBRERfU1VCRElSRUNUT1JZKFdlYktpdCkKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgQWRk
IHRlc3QgYnJvd3NlciBpZiBleGlzdHMKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLUlOQ0xVREVf
SUZfRVhJU1RTKCR7V0VCS0lUVE9PTFNfRElSfS9DTWFrZUxpc3RzJHtQT1JUfS50eHQpCitJTkNM
VURFX0lGX0VYSVNUUygke1RPT0xTX0RJUn0vQ01ha2VMaXN0cyR7UE9SVH0udHh0KQogCiAjIC0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tCiAjIFNldCBjb21waWxlciBmbGFncyBmb3IgYWxsIHRhcmdldHMK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76976</attachid>
            <date>2010-12-19 22:16:50 -0800</date>
            <delta_ts>2010-12-20 01:08:38 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-51319-20101220151648.patch</filename>
            <type>text/plain</type>
            <size>2452</size>
            <attacher name="Ryuan Choi">ryuan.choi</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc0MzMx
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTIt
MTkgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gUmVuYW1lIFdFQktJVFRP
T0xTX0RJUiB0byBUT09MU19ESVIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTUxMzE5CisKKyAgICAgICAgQ2hhbmdlIFdFQktJVFRPT0xTX0RJUiB2YXJp
YWJsZSdzIG5hbWUgYW5kIHZhbHVlIHRvIFRPT0xTX0RJUiBhbmQgdG9vbHMvLgorCisgICAgICAg
ICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTAtMTItMTcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFw
cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBDTWFr
ZUxpc3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDTWFrZUxpc3RzLnR4dAkocmV2aXNpb24gNzQzMzEp
CisrKyBDTWFrZUxpc3RzLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMTIsNyArMTIsNyBAQCBTRVQo
Q01BS0VfTU9EVUxFX1BBVEggIiR7Q01BS0VfU09VUkNFX0RJCiBTRVQoSkFWQVNDUklQVENPUkVf
RElSICIke0NNQUtFX1NPVVJDRV9ESVJ9L0phdmFTY3JpcHRDb3JlIikKIFNFVChXRUJDT1JFX0RJ
UiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9XZWJDb3JlIikKIFNFVChXRUJLSVRfRElSICIke0NNQUtF
X1NPVVJDRV9ESVJ9L1dlYktpdCIpCi1TRVQoV0VCS0lUVE9PTFNfRElSICIke0NNQUtFX1NPVVJD
RV9ESVJ9L1dlYktpdFRvb2xzIikKK1NFVChUT09MU19ESVIgIiR7Q01BS0VfU09VUkNFX0RJUn0v
VG9vbHMiKQogU0VUKERFUklWRURfU09VUkNFU19ESVIgIiR7Q01BS0VfQklOQVJZX0RJUn0vRGVy
aXZlZFNvdXJjZXMiKQogCiBJTkNMVURFKFdlYktpdE1hY3JvcykKQEAgLTExMSw3ICsxMTEsNyBA
QCBBRERfU1VCRElSRUNUT1JZKFdlYktpdCkKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgQWRk
IHRlc3QgYnJvd3NlciBpZiBleGlzdHMKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLUlOQ0xVREVf
SUZfRVhJU1RTKCR7V0VCS0lUVE9PTFNfRElSfS9DTWFrZUxpc3RzJHtQT1JUfS50eHQpCitJTkNM
VURFX0lGX0VYSVNUUygke1RPT0xTX0RJUn0vQ01ha2VMaXN0cyR7UE9SVH0udHh0KQogCiAjIC0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tCiAjIFNldCBjb21waWxlciBmbGFncyBmb3IgYWxsIHRhcmdldHMK
SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc0MzMxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTIgQEAKKzIwMTAtMTItMTkgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFL
RV0gUmVuYW1lIFdFQktJVFRPT0xTX0RJUiB0byBUT09MU19ESVIKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMzE5CisKKyAgICAgICAgKiBDTWFrZUxp
c3RzRWZsLnR4dDoKKwogMjAxMC0xMi0xNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJr
aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgUXQgYnVpbGRmaXggYWZ0ZXIgcjc0MzAxLgpJ
bmRleDogVG9vbHMvQ01ha2VMaXN0c0VmbC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ01ha2VM
aXN0c0VmbC50eHQJKHJldmlzaW9uIDc0MzMxKQorKysgVG9vbHMvQ01ha2VMaXN0c0VmbC50eHQJ
KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiBTRVQoRVdlYkxhdW5jaGVyX1NPVVJDRVMK
LSAgICAke1dFQktJVFRPT0xTX0RJUn0vRVdlYkxhdW5jaGVyL21haW4uYworICAgICR7VE9PTFNf
RElSfS9FV2ViTGF1bmNoZXIvbWFpbi5jCiApCiAKIFNFVChFV2ViTGF1bmNoZXJfTElCUkFSSUVT
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>