51316 2010-12-19 19:44:30 -0800 [Qt] Make sure touch and orientation events are disabled in the minimal configuration 2011-02-16 16:58:54 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P4 Normal --- 1 laszlo.gombos laszlo.gombos eric ossy yael oldest_to_newest 324275 0 laszlo.gombos 2010-12-19 19:44:30 -0800 Touch and orientation (not device orientation) features are not configurable from build-webkit script so they are not disabled in the minimal config. This means that builds with these features turned off are not tested by any bot. 324276 1 76971 laszlo.gombos 2010-12-19 19:50:11 -0800 Created attachment 76971 proposed patch 324278 2 76972 laszlo.gombos 2010-12-19 20:21:46 -0800 Created attachment 76972 previous patch + bearer mgmt 324351 3 yael 2010-12-20 06:21:51 -0800 I don't think this is the right way to add ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to Qt's minimal config. Instead of adding the flags to Qt's minimal config, they should be added to build-webkit script. From there, they are automatically added to the minimal config. Please see https://bugs.webkit.org/show_bug.cgi?id=48224 and https://bugs.webkit.org/show_bug.cgi?id=48185. Qt specific flags like ENABLE_QT_BEARER should be added this way. 324371 4 ossy 2010-12-20 06:38:47 -0800 I agree with Yael, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS should be disabled on all minimal build. They aren't Qt specific features. 324502 5 76972 laszlo.gombos 2010-12-20 12:29:15 -0800 Comment on attachment 76972 previous patch + bearer mgmt Setting to cq- until bug 51346 is evaluated. Part of this patch will be needed to make sure that ENABLE_TOUCH_EVENTS can be turned off for QtWebKit. 324904 6 eric 2010-12-21 00:55:59 -0800 Attachment 76972 was posted by a committer and has review+, assigning to Laszlo Gombos for commit. 331005 7 76972 laszlo.gombos 2011-01-07 14:14:13 -0800 Comment on attachment 76972 previous patch + bearer mgmt Relevant part of the patch committed as http://trac.webkit.org/changeset/75206. Clearing flags. 352464 8 laszlo.gombos 2011-02-16 16:58:54 -0800 Closing bug. 76971 2010-12-19 19:50:11 -0800 2010-12-19 20:21:46 -0800 proposed patch 51316.patch text/plain 1298 laszlo.gombos ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2JlYWY5Ni4uOThhOWNhMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0xOSAgTGFzemxvIEdvbWJv cyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBNYWtlIHN1cmUgdG91Y2ggYW5kIG9yaWVudGF0 aW9uIGV2ZW50cyBhcmUgZGlzYWJsZWQgaW4gdGhlIG1pbmltYWwgY29uZmlndXJhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEzMTYKKworICAg ICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAg ICAgICAgKiBmZWF0dXJlcy5wcmk6IERpc2FibGUgT1JJRU5UQVRJT05fRVZFTlRTIGFuZCBUT1VD SF9FVkVOVFMgaW4KKyAgICAgICAgbWluaW1hbCBjb25maWcuCisKIDIwMTAtMTItMTkgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBDYW1lcm9u IFp3YXJpY2guCmRpZmYgLS1naXQgYS9XZWJDb3JlL2ZlYXR1cmVzLnByaSBiL1dlYkNvcmUvZmVh dHVyZXMucHJpCmluZGV4IDk2YmIwNGQuLjQxZjg5M2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZmVh dHVyZXMucHJpCisrKyBiL1dlYkNvcmUvZmVhdHVyZXMucHJpCkBAIC0xLDcgKzEsOSBAQAogIyBT ZXR0aW5nIHVwIGZlYXR1cmVzIChlbmFibGVkL2Rpc2FibGVkKQogCiBDT05GSUcobWluaW1hbCkg ewotICAgIERFRklORVMgKz0gRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEk9MAorICAgIERFRklO RVMgKj0gRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEk9MAorICAgIERFRklORVMgKj0gRU5BQkxF X09SSUVOVEFUSU9OX0VWRU5UUz0wCisgICAgREVGSU5FUyAqPSBFTkFCTEVfVE9VQ0hfRVZFTlRT PTAKIH0KIAogQ09ORklHKHByb2R1Y3Rpb24pIHsKQEAgLTE0MSw3ICsxNDMsNyBAQCBjb250YWlu cyhNT0JJTElUWV9DT05GSUcsIHNlbnNvcnMpIHsKICAgICB9CiB9CiAKLURFRklORVMgKz0gRU5B QkxFX1RPVUNIX0VWRU5UUz0xCishY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1RPVUNIX0VWRU5U Uz0uKTogREVGSU5FUyArPSBFTkFCTEVfVE9VQ0hfRVZFTlRTPTEKIAogIyBIVE1MNSBNZWRpYSBT dXBwb3J0CiAjIFdlIHJlcXVpcmUgUXRNdWx0aW1lZGlhIG9yIFBob25vbgo= 76972 2010-12-19 20:21:46 -0800 2011-01-07 14:14:13 -0800 previous patch + bearer mgmt 51316.patch text/plain 1370 laszlo.gombos ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2JlYWY5Ni4uNTcyMDcyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0xOSAgTGFzemxvIEdvbWJv cyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBNYWtlIHN1cmUgdG91Y2gsIG9yaWVudGF0aW9u IGFuZCBuZXR3b3JrIGNoYW5nZSBldmVudHMKKyAgICAgICAgYXJlIGRpc2FibGVkIGluIHRoZSBt aW5pbWFsIGNvbmZpZ3VyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTUxMzE2CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5v IG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogZmVhdHVyZXMucHJpOiBEaXNhYmxlIE9S SUVOVEFUSU9OX0VWRU5UUywgVE9VQ0hfRVZFTlRTIGFuZAorICAgICAgICBRVF9CRUFSRVIgaW4g bWluaW1hbCBjb25maWcuCisKIDIwMTAtMTItMTkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBDYW1lcm9uIFp3YXJpY2guCmRpZmYgLS1naXQg YS9XZWJDb3JlL2ZlYXR1cmVzLnByaSBiL1dlYkNvcmUvZmVhdHVyZXMucHJpCmluZGV4IDk2YmIw NGQuLjc4YWE1MmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZmVhdHVyZXMucHJpCisrKyBiL1dlYkNv cmUvZmVhdHVyZXMucHJpCkBAIC0xLDcgKzEsMTAgQEAKICMgU2V0dGluZyB1cCBmZWF0dXJlcyAo ZW5hYmxlZC9kaXNhYmxlZCkKIAogQ09ORklHKG1pbmltYWwpIHsKLSAgICBERUZJTkVTICs9IEVO QUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJPTAKKyAgICBERUZJTkVTICo9IEVOQUJMRV9ORVRTQ0FQ RV9QTFVHSU5fQVBJPTAKKyAgICBERUZJTkVTICo9IEVOQUJMRV9PUklFTlRBVElPTl9FVkVOVFM9 MAorICAgIERFRklORVMgKj0gRU5BQkxFX1FUX0JFQVJFUj0wCisgICAgREVGSU5FUyAqPSBFTkFC TEVfVE9VQ0hfRVZFTlRTPTAKIH0KIAogQ09ORklHKHByb2R1Y3Rpb24pIHsKQEAgLTE0MSw3ICsx NDQsNyBAQCBjb250YWlucyhNT0JJTElUWV9DT05GSUcsIHNlbnNvcnMpIHsKICAgICB9CiB9CiAK LURFRklORVMgKz0gRU5BQkxFX1RPVUNIX0VWRU5UUz0xCishY29udGFpbnMoREVGSU5FUywgRU5B QkxFX1RPVUNIX0VWRU5UUz0uKTogREVGSU5FUyArPSBFTkFCTEVfVE9VQ0hfRVZFTlRTPTEKIAog IyBIVE1MNSBNZWRpYSBTdXBwb3J0CiAjIFdlIHJlcXVpcmUgUXRNdWx0aW1lZGlhIG9yIFBob25v bgo=