51308 2010-12-19 14:10:33 -0800 no-caret-repaint-in-non-content-editable-element.html does not need to disable CaretBrowsing 2010-12-20 20:46:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 51372 1 tonikitoo tonikitoo oldest_to_newest 324228 0 tonikitoo 2010-12-19 14:10:33 -0800 no-caret-repaint-in-non-content-editable-element.html is the only test that explicitly disables caret browsing. ... if (window.layoutTestController) layoutTestController.overridePreference("WebKitEnableCaretBrowsing", false); ... However, this is a useless statement, since all DRT that support testing caret browsing (gtk, qt anc chromium) have it reset by default to FALSE before each test execution. On Mac and Windows, DRT that do not support testing caret browsing, it is obviously also FALSE by default. I propose removing it. Patch coming ... 324229 1 76961 tonikitoo 2010-12-19 14:15:31 -0800 Created attachment 76961 patch v1 (r74349, r=xan) 324389 2 76961 xan.lopez 2010-12-20 07:45:57 -0800 Comment on attachment 76961 patch v1 (r74349, r=xan) Makes sense to me. 324402 3 76961 tonikitoo 2010-12-20 08:15:16 -0800 Comment on attachment 76961 patch v1 (r74349, r=xan) Clearing flags on attachment: 76961 Committed r74349: <http://trac.webkit.org/changeset/74349> 324757 4 tonikitoo 2010-12-20 20:46:25 -0800 After talking to Daniel Bates, the original author of this test, we both agreed that the statement has no affect as DRTs are today (since caret browsing it reset before each test execution). However, explicitly setting caret browsing to DISABLED ensures that the test will run under the circumstance it needs to catch the bug: caret browsing is DISABLED. We decided to put this code back in, and he will add a more descriptive comment saying why it should be there. See bug 51372 76961 2010-12-19 14:15:31 -0800 2010-12-20 08:15:16 -0800 patch v1 (r74349, r=xan) 0001-2010-12-19-Antonio-Gomes-agomes-rim.com.patch text/plain 2718 tonikitoo RnJvbSA2MDYwZWNhOWQxODY1OTQ1ZGE5YjI5NGQxYTIyMTdiMzgzMzdkNGIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog U3VuLCAxOSBEZWMgMjAxMCAxNzoxNDo0NCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTAtMTIt MTkgIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgogICAgICAgIG5vLWNhcmV0LXJlcGFpbnQtaW4tbm9uLWNvbnRlbnQt ZWRpdGFibGUtZWxlbWVudC5odG1sIGRvZXMgbm90IG5lZWQgdG8gZGlzYWJsZSBDYXJldEJyb3dz aW5nCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMzA4 CgogICAgICAgIFBhdGNoIHJlbW92ZXMgdGhlIHVzZWxlc3Mgc3RhdGVtZW50IHRvIGRpc2FibGUg Y2FyZXQgYnJvd3NpbmcgZnJvbQogICAgICAgIG5vLWNhcmV0LXJlcGFpbnQtaW4tbm9uLWNvbnRl bnQtZWRpdGFibGUtZWxlbWVudC5odG1sLgoKICAgICAgICBDYXJldCBicm93c2luZyBnZXRzIHRv Z2dsZWQgT0ZGIGJlZm9yZSB0aGUgZXhlY3V0aW9uIG9mIGVhY2ggdGVzdAogICAgICAgIG9uIHRo ZSBEUlRzIHRoYXQgc3VwcG9ydCB0ZXN0aW5nIGl0IChHVEsrLCBRdCBhbmQgQ2hyb21pdW0pLiBP biBNYWMgb3IKICAgICAgICBXaW5kb3dzJ3MgRFJUIGl0IHRoZSB0ZXN0aW5nIHRoaXMgZmVhdHVy ZSBpcyB1bnN1cHBvcnQsIHNvIGNhcmV0CiAgICAgICAgYnJvd3NpbmcgaXMgYWxzbyBkaXNhYmxl ZCBieSBkZWZhdWx0LgoKICAgICAgICAqIGZhc3QvcmVwYWludC9uby1jYXJldC1yZXBhaW50LWlu LW5vbi1jb250ZW50LWVkaXRhYmxlLWVsZW1lbnQuaHRtbDoKLS0tCiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysr KysKIC4uLmV0LXJlcGFpbnQtaW4tbm9uLWNvbnRlbnQtZWRpdGFibGUtZWxlbWVudC5odG1sIHwg ICAgMiAtLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA2NTBlOTgyLi4yZTQxNjYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAt MTItMTkgIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuby1jYXJldC1yZXBhaW50LWluLW5vbi1j b250ZW50LWVkaXRhYmxlLWVsZW1lbnQuaHRtbCBkb2VzIG5vdCBuZWVkIHRvIGRpc2FibGUgQ2Fy ZXRCcm93c2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTEzMDgKKworICAgICAgICBQYXRjaCByZW1vdmVzIHRoZSB1c2VsZXNzIHN0YXRlbWVudCB0 byBkaXNhYmxlIGNhcmV0IGJyb3dzaW5nIGZyb20KKyAgICAgICAgbm8tY2FyZXQtcmVwYWludC1p bi1ub24tY29udGVudC1lZGl0YWJsZS1lbGVtZW50Lmh0bWwuCisKKyAgICAgICAgQ2FyZXQgYnJv d3NpbmcgZ2V0cyB0b2dnbGVkIE9GRiBiZWZvcmUgdGhlIGV4ZWN1dGlvbiBvZiBlYWNoIHRlc3QK KyAgICAgICAgb24gdGhlIERSVHMgdGhhdCBzdXBwb3J0IHRlc3RpbmcgaXQgKEdUSyssIFF0IGFu ZCBDaHJvbWl1bSkuIE9uIE1hYyBvcgorICAgICAgICBXaW5kb3dzJ3MgRFJUIGl0IHRoZSB0ZXN0 aW5nIHRoaXMgZmVhdHVyZSBpcyB1bnN1cHBvcnQsIHNvIGNhcmV0CisgICAgICAgIGJyb3dzaW5n IGlzIGFsc28gZGlzYWJsZWQgYnkgZGVmYXVsdC4KKworICAgICAgICAqIGZhc3QvcmVwYWludC9u by1jYXJldC1yZXBhaW50LWluLW5vbi1jb250ZW50LWVkaXRhYmxlLWVsZW1lbnQuaHRtbDoKKwog MjAxMC0xMi0xNyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9yZXBhaW50L25vLWNhcmV0LXJlcGFpbnQtaW4tbm9uLWNvbnRlbnQtZWRpdGFibGUtZWxlbWVu dC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L25vLWNhcmV0LXJlcGFpbnQtaW4tbm9u LWNvbnRlbnQtZWRpdGFibGUtZWxlbWVudC5odG1sCmluZGV4IDYyOWMwZjIuLmRlZTI0MjAgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9uby1jYXJldC1yZXBhaW50LWluLW5v bi1jb250ZW50LWVkaXRhYmxlLWVsZW1lbnQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3Jl cGFpbnQvbm8tY2FyZXQtcmVwYWludC1pbi1ub24tY29udGVudC1lZGl0YWJsZS1lbGVtZW50Lmh0 bWwKQEAgLTIsOCArMiw2IEBACiA8aGVhZD4KIDxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcmVwYWlu dC5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0PgotaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoIldlYktpdEVu YWJsZUNhcmV0QnJvd3NpbmciLCBmYWxzZSk7CiBmdW5jdGlvbiByZXBhaW50VGVzdCgpCiB7CiAg ICAgaWYgKCF3aW5kb3cuZXZlbnRTZW5kZXIpCi0tIAoxLjcuMQoK