51305 2010-12-19 09:33:34 -0800 Remove m_drawsContents from RenderSVGContainer.h 2010-12-21 00:59:16 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis eric zimmermann oldest_to_newest 324207 0 rwlbuis 2010-12-19 09:33:34 -0800 IIRC this was introduced to keep markers from being drawn directly, but we have other mechanisms for that now. 324208 1 76957 rwlbuis 2010-12-19 10:21:44 -0800 Created attachment 76957 Patch 324209 2 76957 kling 2010-12-19 10:37:41 -0800 Comment on attachment 76957 Patch LGTM! 324903 3 eric 2010-12-21 00:55:50 -0800 Attachment 76957 was posted by a committer and has review+, assigning to Rob Buis for commit. 324905 4 rwlbuis 2010-12-21 00:57:48 -0800 Hi Eric, (In reply to comment #3) > Attachment 76957 [details] was posted by a committer and has review+, assigning to Rob Buis for commit. You need new glasses :) See r74325. Cheers, Rob. 324907 5 eric 2010-12-21 00:59:16 -0800 Please close your bugs after you commit them. Tools like webkit-patch land will dot hat for you. :) Closing. 76957 2010-12-19 10:21:44 -0800 2010-12-19 10:37:41 -0800 Patch bug-51305-20101219192725.patch text/plain 5928 rwlbuis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2IwOGZjNWNmOWU3OTA2YTM2OWRjNGQ2MWQ2YjYzNjkyMTkyYzE1ZS4uYmM1NjhhYzM0M2U0MjZm ODM2ZThiMmU3OWJhZTE3MDZjZjg5ZTIwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMi0xOSAgUm9i IEJ1aXMgIDxyd2xidWlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgbV9kcmF3c0NvbnRlbnRzIGZyb20gUmVuZGVyU1ZH Q29udGFpbmVyLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUxMzA1CisKKyAgICAgICAgUmVtb3ZlIG1fZHJhd3NDb250ZW50cywgaXRzIGdldHRlciBh bmQgc2V0dGVyIGFuZCB0aGUgY2FsbAorICAgICAgICBzaXRlcywgc2luY2UgaXQgaGFzIG5vIGVm ZmVjdCBhbnltb3JlLgorCisgICAgICAgICogV2ViQ29yZS5vcmRlcjoKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNW R0NvbnRhaW5lcjo6UmVuZGVyU1ZHQ29udGFpbmVyKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl clNWR0NvbnRhaW5lcjo6cGFpbnQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJTVkdDb250 YWluZXIuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHUmVzb3VyY2VDb250YWluZXIu aDoKKyAgICAgICAgKiByZW5kZXJpbmcvU1ZHSW1hZ2VCdWZmZXJUb29scy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTVkdJbWFnZUJ1ZmZlclRvb2xzOjpyZW5kZXJTdWJ0cmVlVG9JbWFnZUJ1ZmZl cik6CisKIDIwMTAtMTItMTggIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+IGFu ZCBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBcml5YSBIaWRheWF0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLm9yZGVy IGIvV2ViQ29yZS9XZWJDb3JlLm9yZGVyCmluZGV4IDBmZGFiYjEzYjM4MzgyODFkNzgwMWFmODM0 MjRmZmZhNzk3ODRjNzMuLjI3MWRmYzliOWNjYjM2NjgyYjBlMTg3ZTdjMjc1MDY3Y2I1ZTEyMTYg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5vcmRlcgorKysgYi9XZWJDb3JlL1dlYkNvcmUu b3JkZXIKQEAgLTE4MTc2LDcgKzE4MTc2LDYgQEAgX19aTks3V2ViQ29yZTIyU1ZHUHJlc2VydmVB c3BlY3RSYXRpbzExbWVldE9yU2xpY2VFdgogX19aTks3V2ViQ29yZTE4UmVuZGVyU1ZHQ29udGFp bmVyMjlyZXBhaW50UmVjdEluTG9jYWxDb29yZGluYXRlc0V2CiBfX1pOSzdXZWJDb3JlMzFSZW5k ZXJTVkdUcmFuc2Zvcm1hYmxlQ29udGFpbmVyMjJsb2NhbFRvUGFyZW50VHJhbnNmb3JtRXYKIF9f Wk43V2ViQ29yZTE4UmVuZGVyU1ZHQ29udGFpbmVyNXBhaW50RVJOU18xMlJlbmRlck9iamVjdDlQ YWludEluZm9FaWkKLV9fWk5LN1dlYkNvcmUxOFJlbmRlclNWR0NvbnRhaW5lcjEzZHJhd3NDb250 ZW50c0V2CiBfX1pON1dlYkNvcmUxOFJlbmRlclNWR0NvbnRhaW5lcjE3YXBwbHlWaWV3cG9ydENs aXBFUk5TXzEyUmVuZGVyT2JqZWN0OVBhaW50SW5mb0UKIF9fWk43V2ViQ29yZTMxUmVuZGVyU1ZH VHJhbnNmb3JtYWJsZUNvbnRhaW5lckQwRXYKIC1bRE9NSFRNTElGcmFtZUVsZW1lbnQgY29udGVu dERvY3VtZW50XQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFp bmVyLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5jcHAKaW5kZXgg MDc2MTU2MjY3MGRlYjhkYjMzMTJhNzBhYzk1OWQ4Nzk3Yjc5ZTkwYi4uMzJlMDU5ODU3NmExYTg2 ZTkzNGIyNGQxZmM0NmJlNzdiYTY1MTEzNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyU1ZHQ29udGFpbmVyLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdD b250YWluZXIuY3BwCkBAIC0zOCw3ICszOCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogUmVu ZGVyU1ZHQ29udGFpbmVyOjpSZW5kZXJTVkdDb250YWluZXIoU1ZHU3R5bGVkRWxlbWVudCogbm9k ZSkKICAgICA6IFJlbmRlclNWR01vZGVsT2JqZWN0KG5vZGUpCi0gICAgLCBtX2RyYXdzQ29udGVu dHModHJ1ZSkKICAgICAsIG1fbmVlZHNCb3VuZGFyaWVzVXBkYXRlKHRydWUpCiB7CiB9CkBAIC05 NCw3ICs5Myw3IEBAIGJvb2wgUmVuZGVyU1ZHQ29udGFpbmVyOjpzZWxmV2lsbFBhaW50KCkKIAog dm9pZCBSZW5kZXJTVkdDb250YWluZXI6OnBhaW50KFBhaW50SW5mbyYgcGFpbnRJbmZvLCBpbnQs IGludCkKIHsKLSAgICBpZiAocGFpbnRJbmZvLmNvbnRleHQtPnBhaW50aW5nRGlzYWJsZWQoKSB8 fCAhZHJhd3NDb250ZW50cygpKQorICAgIGlmIChwYWludEluZm8uY29udGV4dC0+cGFpbnRpbmdE aXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBTcGVjOiBncm91cHMgdy9vIGNo aWxkcmVuIHN0aWxsIG1heSByZW5kZXIgZmlsdGVyIGNvbnRlbnQuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJTVkdDb250YWluZXIuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclNWR0NvbnRhaW5lci5oCmluZGV4IDViZGJmMzJiMjBjNTk1YWI0Zjg0MTVhZTNiM2ZkNmNj NWYxOTczZTkuLjNiZDUzNDYzMDI0MTMzM2UyNTFmZTFlZTQ1ZmZlOTA2NzM4MjA4NDkgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5oCisrKyBiL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5oCkBAIC0zOSwxMCArMzksNiBAQCBwdWJs aWM6CiAgICAgY29uc3QgUmVuZGVyT2JqZWN0Q2hpbGRMaXN0KiBjaGlsZHJlbigpIGNvbnN0IHsg cmV0dXJuICZtX2NoaWxkcmVuOyB9CiAgICAgUmVuZGVyT2JqZWN0Q2hpbGRMaXN0KiBjaGlsZHJl bigpIHsgcmV0dXJuICZtX2NoaWxkcmVuOyB9CiAKLSAgICAvLyA8bWFya2VyPiB1c2VzIHRoZXNl IG1ldGhvZHMgdG8gb25seSBhbGxvdyBkcmF3aW5nIGNoaWxkcmVuIGR1cmluZyBhIHNwZWNpYWwg bWFya2VyIGRyYXcgdGltZQotICAgIHZvaWQgc2V0RHJhd3NDb250ZW50cyhib29sIGRyYXdzQ29u dGVudHMpIHsgbV9kcmF3c0NvbnRlbnRzID0gZHJhd3NDb250ZW50czsgfQotICAgIGJvb2wgZHJh d3NDb250ZW50cygpIGNvbnN0IHsgcmV0dXJuIG1fZHJhd3NDb250ZW50czsgfQotCiAgICAgdmly dHVhbCB2b2lkIHBhaW50KFBhaW50SW5mbyYsIGludCBwYXJlbnRYLCBpbnQgcGFyZW50WSk7CiAg ICAgdmlydHVhbCB2b2lkIHNldE5lZWRzQm91bmRhcmllc1VwZGF0ZSgpIHsgbV9uZWVkc0JvdW5k YXJpZXNVcGRhdGUgPSB0cnVlOyB9CiAKQEAgLTc5LDcgKzc1LDYgQEAgcHJpdmF0ZToKICAgICBG bG9hdFJlY3QgbV9vYmplY3RCb3VuZGluZ0JveDsKICAgICBGbG9hdFJlY3QgbV9zdHJva2VCb3Vu ZGluZ0JveDsKICAgICBGbG9hdFJlY3QgbV9yZXBhaW50Qm91bmRpbmdCb3g7Ci0gICAgYm9vbCBt X2RyYXdzQ29udGVudHMgOiAxOwogICAgIGJvb2wgbV9uZWVkc0JvdW5kYXJpZXNVcGRhdGUgOiAx OwogfTsKICAgCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdSZXNvdXJj ZUNvbnRhaW5lci5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHUmVzb3VyY2VDb250YWlu ZXIuaAppbmRleCAwOGUxOGQ0OWNkOWFjMWFmM2QzYzA2NDUxNjcyYjA1ODczOTBkNDIzLi40ZTVl NDc1YzQyMzRiZmE5NGM2YTdhMmUwN2VmMjJmNDkzNGU4ZGNjIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJTVkdSZXNvdXJjZUNvbnRhaW5lci5oCisrKyBiL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclNWR1Jlc291cmNlQ29udGFpbmVyLmgKQEAgLTM4LDcgKzM4LDYgQEAgcHVi bGljOgogICAgIHZpcnR1YWwgdm9pZCBzdHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UsIGNv bnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSk7CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNTVkdSZXNv dXJjZUNvbnRhaW5lcigpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KLSAgICB2aXJ0dWFsIGJvb2wg ZHJhd3NDb250ZW50cygpIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBSZW5kZXJTVkdS ZXNvdXJjZUNvbnRhaW5lciogdG9SZW5kZXJTVkdSZXNvdXJjZUNvbnRhaW5lcigpIHsgcmV0dXJu IHRoaXM7IH0KIAogICAgIHN0YXRpYyBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtT25Ob25TY2Fs aW5nU3Ryb2tlKFJlbmRlck9iamVjdCosIGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgcmVzb3VyY2VU cmFuc2Zvcm0pOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvU1ZHSW1hZ2VCdWZmZXJU b29scy5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9TVkdJbWFnZUJ1ZmZlclRvb2xzLmNwcAppbmRl eCAyMGY0NWIxMWM1NjI2NGJlZjQyMmI5N2JlNDVhYzY4ZWExZDE3MmY1Li4yZGMwYTZmYWYxNTUw Y2VmNmI4YzJlMTRiMzZkMGQxOGU4M2ExMTI1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9TVkdJbWFnZUJ1ZmZlclRvb2xzLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9TVkdJbWFn ZUJ1ZmZlclRvb2xzLmNwcApAQCAtODEsMTQgKzgxLDYgQEAgdm9pZCBTVkdJbWFnZUJ1ZmZlclRv b2xzOjpyZW5kZXJTdWJ0cmVlVG9JbWFnZUJ1ZmZlcihJbWFnZUJ1ZmZlciogaW1hZ2UsIFJlbmRl ck8KIAogICAgIFBhaW50SW5mbyBpbmZvKGltYWdlLT5jb250ZXh0KCksIFBhaW50SW5mbzo6aW5m aW5pdGVSZWN0KCksIFBhaW50UGhhc2VGb3JlZ3JvdW5kLCAwLCAwLCAwKTsKIAotICAgIFJlbmRl clNWR0NvbnRhaW5lciogc3ZnQ29udGFpbmVyID0gMDsKLSAgICBpZiAoaXRlbSAmJiBpdGVtLT5p c1NWR0NvbnRhaW5lcigpICYmICFpdGVtLT5pc1NWR1ZpZXdwb3J0Q29udGFpbmVyKCkpCi0gICAg ICAgIHN2Z0NvbnRhaW5lciA9IHRvUmVuZGVyU1ZHQ29udGFpbmVyKGl0ZW0pOwotCi0gICAgYm9v bCBkcmF3c0NvbnRlbnRzID0gc3ZnQ29udGFpbmVyID8gc3ZnQ29udGFpbmVyLT5kcmF3c0NvbnRl bnRzKCkgOiBmYWxzZTsKLSAgICBpZiAoc3ZnQ29udGFpbmVyICYmICFkcmF3c0NvbnRlbnRzKQot ICAgICAgICBzdmdDb250YWluZXItPnNldERyYXdzQ29udGVudHModHJ1ZSk7Ci0KICAgICBBZmZp bmVUcmFuc2Zvcm0mIGNvbnRlbnRUcmFuc2Zvcm1hdGlvbiA9IGN1cnJlbnRDb250ZW50VHJhbnNm b3JtYXRpb24oKTsKICAgICBBZmZpbmVUcmFuc2Zvcm0gc2F2ZWRDb250ZW50VHJhbnNmb3JtYXRp b24gPSBjb250ZW50VHJhbnNmb3JtYXRpb247CiAgICAgY29udGVudFRyYW5zZm9ybWF0aW9uLm11 bHRpcGx5KHN1YnRyZWVDb250ZW50VHJhbnNmb3JtYXRpb24pOwpAQCAtOTcsOSArODksNiBAQCB2 b2lkIFNWR0ltYWdlQnVmZmVyVG9vbHM6OnJlbmRlclN1YnRyZWVUb0ltYWdlQnVmZmVyKEltYWdl QnVmZmVyKiBpbWFnZSwgUmVuZGVyTwogICAgIGl0ZW0tPnBhaW50KGluZm8sIDAsIDApOwogCiAg ICAgY29udGVudFRyYW5zZm9ybWF0aW9uID0gc2F2ZWRDb250ZW50VHJhbnNmb3JtYXRpb247Ci0K LSAgICBpZiAoc3ZnQ29udGFpbmVyICYmICFkcmF3c0NvbnRlbnRzKQotICAgICAgICBzdmdDb250 YWluZXItPnNldERyYXdzQ29udGVudHMoZmFsc2UpOwogfQogCiB2b2lkIFNWR0ltYWdlQnVmZmVy VG9vbHM6OmNsaXBUb0ltYWdlQnVmZmVyKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3Qg QWZmaW5lVHJhbnNmb3JtJiBhYnNvbHV0ZVRyYW5zZm9ybSwgY29uc3QgRmxvYXRSZWN0JiBjbGFt cGVkQWJzb2x1dGVUYXJnZXRSZWN0LCBPd25QdHI8SW1hZ2VCdWZmZXI+JiBpbWFnZUJ1ZmZlcikK