51302 2010-12-18 21:21:47 -0800 [GTK+] Simplify spatial navigation handling in EditorClientGtk.cpp 2010-12-20 08:16:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 tonikitoo tonikitoo mrobinson oldest_to_newest 324183 0 tonikitoo 2010-12-18 21:21:47 -0800 In moveCursorCallback function (EditorClientGtk.cpp) we are special handling the case where we have 'step' equals to 1 and 'direction' equals to 0 or 1. To put it simple, this is the case of either a RIGHT or LEFT arrow key press, without any modifier. 235 if (isSpatialNavigationEnabled(core(client->webView())->focusController()->focusedOrMainFrame()) && step == 1) { 236 if (direction == 1) 237 rawCommand = "MoveRight"; 238 else if (!direction) 239 rawCommand = "MoveLeft"; 240 } When spatial navigation is enabled, we change the editor command from "MoveBackwark" to "MoveLeft" or "MoveForward" to "MoveRight", respectively. This is unneeded if we change the movement mapping table directly. Patch coming ... 324184 1 76953 tonikitoo 2010-12-18 22:12:07 -0800 Created attachment 76953 patch v1 (committed r74348, r=xan) 324388 2 76953 xan.lopez 2010-12-20 07:43:07 -0800 Comment on attachment 76953 patch v1 (committed r74348, r=xan) Perhaps you can say in the ChangeLog more explicitly that this only seems to be safe for left/right (granularity = character), since the other fallbacks in those methods have a FIXME implying that they are not desired. Thanks! 324404 3 76953 tonikitoo 2010-12-20 08:16:14 -0800 Comment on attachment 76953 patch v1 (committed r74348, r=xan) Clearing flags on attachment: 76953 Committed r74348: <http://trac.webkit.org/changeset/74349> 324405 4 tonikitoo 2010-12-20 08:16:39 -0800 (In reply to comment #2) > (From update of attachment 76953 [details]) > Perhaps you can say in the ChangeLog more explicitly that this only seems to be safe for left/right (granularity = character), since the other fallbacks in those methods have a FIXME implying that they are not desired. Thanks! Fixed before landing. 76953 2010-12-18 22:12:07 -0800 2010-12-20 08:16:14 -0800 patch v1 (committed r74348, r=xan) 0001-2010-12-18-Antonio-Gomes-agomes-rim.com.patch text/plain 4613 tonikitoo RnJvbSA2OWI1MDkzM2ZmNTE4NGI0ZTRhMGE5MTQyNTI4YjliNDM1NjFkOWYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog U3VuLCAxOSBEZWMgMjAxMCAwMToxMToxNCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTAtMTIt MTggIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgogICAgICAgIFtHVEsrXSBTaW1wbGlmeSBzcGF0aWFsIG5hdmlnYXRp b24gaGFuZGxpbmcgaW4gRWRpdG9yQ2xpZW50R3RrLmNwcAogICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTMwMgoKICAgICAgICBQYXRjaCBjaGFuZ2VzOgog ICAgICAgIDEpIFRoZSBlZGl0b3IgY29tbWFuZCBmb3IgTEVGVCBhcnJvdyBrZXkgcHJlc3Mgd2l0 aG91dCBtb2RpZmllcgogICAgICAgICAgIGZyb20gTW92ZUJhY2t3YXJkIHRvIE1vdmVMZWZ0Owog ICAgICAgIDIpIEFuZCBzaW1pbGFybHkgY2hhbmdlcyB0aGUgZWRpdG9yIGNvbW1hbmQgZm9yIFJJ R0hUIGFycm93IGtleQogICAgICAgICAgcHJlc3Mgd2l0aG91dCBtb2RpZmllciBmcm9tIE1vdmVG b3J3YXJkIHRvIE1vdmVSaWdodC4KCiAgICAgICAgSXQgaGFzIG5vIGltcGxpY2F0aW9ucyBzaW5j ZSBTZWxlY3Rpb25Db250cm9sbGVyOjptb2RpZnlNb3ZpbmdSaWdodCgpCiAgICAgICAgaGFuZGxl cyAiTW92ZVJpZ2h0IiBlcXVhbHkgdG8gaG93IFNlbGVjdGlvbkNvbnRyb2xsZXI6Om1vZGlmeU1v dmluZ0ZvcndhcmQoKQogICAgICAgIGhhbmRsZXMgIk1vdmVGb3J3YXJkIi4gVGhlIGZvcm1lciBm YWxscyBiYWNrIHRvIHRoZSBsYXRlciBpbiB0aGUKICAgICAgICBjYXNlIG9mIG90aGVyIGVkaXRv ciBjb21tYW5kcy4KCiAgICAgICAgQW5hbG9nb3VzbHksIHRoZSBzYW1lIGFwcGxpZXMgdG8gaG93 IFNlbGVjdGlvbkNvbnRyb2xsZXI6Om1vZGlmeU1vdmluZ0xlZnQoKSBhbmQKICAgICAgICBTZWxl Y3Rpb25Db250cm9sbGVyOjptb2RpZnlNb3ZpbmdGb3J3YXJkKCkgaGFuZGxlICJNb3ZlTGVmdCIg YW5kICJNb3ZlQmFja3dhcmQiCiAgICAgICAgZWRpdG9yIGNvbW1hbmRzLCByZXNwZWN0aXZlbHku CgogICAgICAgIFdpdGggdGhpcyBjaGFuZ2Ugd2UgY2FuIHJlbW92ZSB0aGUgc3BhdGlhbCBuYXZp Z2F0aW9uIGhhY2sgZnJvbSBtb3ZlQ3Vyc29yQ2FsbGJhY2soKSwKICAgICAgICBpbiBFZGl0b3JD bGllbnRHdGsuY3BwLgoKICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5j cHA6CiAgICAgICAgKFdlYktpdDo6bW92ZUN1cnNvckNhbGxiYWNrKToKLS0tCiBXZWJLaXQvZ3Rr L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDI4ICsrKysrKysrKysrKysr KysrKysrKysrKysKIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNw cCB8ICAgIDkgKy0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgOCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9n dGsvQ2hhbmdlTG9nCmluZGV4IDJmZWVmNTQuLjAyZWZjNDEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9n dGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEgQEAK KzIwMTAtMTItMTggIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLK10gU2ltcGxpZnkgc3Bh dGlhbCBuYXZpZ2F0aW9uIGhhbmRsaW5nIGluIEVkaXRvckNsaWVudEd0ay5jcHAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMzAyCisKKyAgICAgICAg UGF0Y2ggY2hhbmdlczoKKyAgICAgICAgMSkgVGhlIGVkaXRvciBjb21tYW5kIGZvciBMRUZUIGFy cm93IGtleSBwcmVzcyB3aXRob3V0IG1vZGlmaWVyCisgICAgICAgICAgIGZyb20gTW92ZUJhY2t3 YXJkIHRvIE1vdmVMZWZ0OworICAgICAgICAyKSBBbmQgc2ltaWxhcmx5IGNoYW5nZXMgdGhlIGVk aXRvciBjb21tYW5kIGZvciBSSUdIVCBhcnJvdyBrZXkKKyAgICAgICAgICBwcmVzcyB3aXRob3V0 IG1vZGlmaWVyIGZyb20gTW92ZUZvcndhcmQgdG8gTW92ZVJpZ2h0LgorCisgICAgICAgIEl0IGhh cyBubyBpbXBsaWNhdGlvbnMgc2luY2UgU2VsZWN0aW9uQ29udHJvbGxlcjo6bW9kaWZ5TW92aW5n UmlnaHQoKQorICAgICAgICBoYW5kbGVzICJNb3ZlUmlnaHQiIGVxdWFseSB0byBob3cgU2VsZWN0 aW9uQ29udHJvbGxlcjo6bW9kaWZ5TW92aW5nRm9yd2FyZCgpCisgICAgICAgIGhhbmRsZXMgIk1v dmVGb3J3YXJkIi4gVGhlIGZvcm1lciBmYWxscyBiYWNrIHRvIHRoZSBsYXRlciBpbiB0aGUKKyAg ICAgICAgY2FzZSBvZiBvdGhlciBlZGl0b3IgY29tbWFuZHMuCisKKyAgICAgICAgQW5hbG9nb3Vz bHksIHRoZSBzYW1lIGFwcGxpZXMgdG8gaG93IFNlbGVjdGlvbkNvbnRyb2xsZXI6Om1vZGlmeU1v dmluZ0xlZnQoKSBhbmQKKyAgICAgICAgU2VsZWN0aW9uQ29udHJvbGxlcjo6bW9kaWZ5TW92aW5n Rm9yd2FyZCgpIGhhbmRsZSAiTW92ZUxlZnQiIGFuZCAiTW92ZUJhY2t3YXJkIgorICAgICAgICBl ZGl0b3IgY29tbWFuZHMsIHJlc3BlY3RpdmVseS4KKworICAgICAgICBXaXRoIHRoaXMgY2hhbmdl IHdlIGNhbiByZW1vdmUgdGhlIHNwYXRpYWwgbmF2aWdhdGlvbiBoYWNrIGZyb20gbW92ZUN1cnNv ckNhbGxiYWNrKCksCisgICAgICAgIGluIEVkaXRvckNsaWVudEd0ay5jcHAuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0Ojpt b3ZlQ3Vyc29yQ2FsbGJhY2spOgorCiAyMDEwLTEyLTE2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5z b24uCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0 ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAKaW5k ZXggMmE2Y2M4Ny4uMDUyMmY4NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRp dG9yQ2xpZW50R3RrLmNwcApAQCAtMTk4LDcgKzE5OCw3IEBAIHN0YXRpYyB2b2lkIGRlbGV0ZUZy b21DdXJzb3JDYWxsYmFjayhHdGtXaWRnZXQqIHdpZGdldCwgR3RrRGVsZXRlVHlwZSBkZWxldGVU eXBlCiBzdGF0aWMgY29uc3QgY2hhciogY29uc3QgZ3RrTW92ZUNvbW1hbmRzW11bNF0gPSB7CiAg ICAgeyAiTW92ZUJhY2t3YXJkIiwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJN b3ZlRm9yd2FyZCIsCiAgICAgICAiTW92ZUJhY2t3YXJkQW5kTW9kaWZ5U2VsZWN0aW9uIiwgICAg ICAgICAgICAgICAgICJNb3ZlRm9yd2FyZEFuZE1vZGlmeVNlbGVjdGlvbiIgICAgICAgICAgICAg fSwgLy8gRm9yd2FyZC9iYWNrd2FyZCBncmFwaGVtZQotICAgIHsgIk1vdmVCYWNrd2FyZCIsICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiTW92ZUZvcndhcmQiLAorICAgIHsgIk1v dmVMZWZ0IiwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiTW92ZVJpZ2h0 IiwKICAgICAgICJNb3ZlQmFja3dhcmRBbmRNb2RpZnlTZWxlY3Rpb24iLCAgICAgICAgICAgICAg ICAgIk1vdmVGb3J3YXJkQW5kTW9kaWZ5U2VsZWN0aW9uIiAgICAgICAgICAgICB9LCAvLyBMZWZ0 L3JpZ2h0IGdyYXBoZW1lCiAgICAgeyAiTW92ZVdvcmRCYWNrd2FyZCIsICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJNb3ZlV29yZEZvcndhcmQiLAogICAgICAgIk1vdmVXb3JkQmFja3dh cmRBbmRNb2RpZnlTZWxlY3Rpb24iLCAgICAgICAgICAgICAiTW92ZVdvcmRGb3J3YXJkQW5kTW9k aWZ5U2VsZWN0aW9uIiAgICAgICAgIH0sIC8vIEZvcndhcmQvYmFja3dhcmQgd29yZApAQCAtMjMy LDEzICsyMzIsNiBAQCBzdGF0aWMgdm9pZCBtb3ZlQ3Vyc29yQ2FsbGJhY2soR3RrV2lkZ2V0KiB3 aWRnZXQsIEd0a01vdmVtZW50U3RlcCBzdGVwLCBnaW50IGNvdQogICAgIGlmICghcmF3Q29tbWFu ZCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKGlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVk KGNvcmUoY2xpZW50LT53ZWJWaWV3KCkpLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFp bkZyYW1lKCkpICYmIHN0ZXAgPT0gMSkgewotICAgICAgICBpZiAoZGlyZWN0aW9uID09IDEpCi0g ICAgICAgICAgICByYXdDb21tYW5kID0gIk1vdmVSaWdodCI7Ci0gICAgICAgIGVsc2UgaWYgKCFk aXJlY3Rpb24pCi0gICAgICAgICAgICByYXdDb21tYW5kID0gIk1vdmVMZWZ0IjsKLSAgICB9Ci0K ICAgICBmb3IgKGludCBpID0gMDsgaSA8IGFicyhjb3VudCk7IGkrKykKICAgICAgICAgY2xpZW50 LT5hZGRQZW5kaW5nRWRpdG9yQ29tbWFuZChyYXdDb21tYW5kKTsKIH0KLS0gCjEuNy4xCgo=