51300 2010-12-18 15:28:44 -0800 [Qt] [WK2] QWKPagePrivate::paint() does not need to save the graphics context 2010-12-19 13:35:13 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P4 Trivial --- 1 benjamin benjamin commit-queue oldest_to_newest 324160 0 benjamin 2010-12-18 15:28:44 -0800 QWKPagePrivate::paint() currently saves and restore the context at each call. This is uncessary, the DrawingAreaProxy already does that: -TiledDrawingAreaProxy uses gc.save() before rendering anything. -ChunkedUpdateDrawingAreaProxy calls platformPaint. For Qt, ChunkedUpdateDrawingAreaProxy::platformPaint() is just calling drawimage, which has no side effect. In any case, there is no requirement for a graphics item to return the painter in the same state as it was given. 324161 1 76948 benjamin 2010-12-18 15:30:48 -0800 Created attachment 76948 Patch 324167 2 76948 benjamin 2010-12-18 16:38:08 -0800 Comment on attachment 76948 Patch Thanks Kenneth for the review. 324168 3 76948 commit-queue 2010-12-18 16:40:58 -0800 Comment on attachment 76948 Patch Rejecting attachment 76948 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76948]" exit_code: 2 Last 500 characters of output: ts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit2/UIProcess/API/qt/qwkpage.cpp Hunk #1 FAILED at 160. 1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/API/qt/qwkpage.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7231043 324211 4 76948 benjamin 2010-12-19 11:48:27 -0800 Comment on attachment 76948 Patch cq+, that should merge now. 324223 5 76948 commit-queue 2010-12-19 13:35:06 -0800 Comment on attachment 76948 Patch Clearing flags on attachment: 76948 Committed r74327: <http://trac.webkit.org/changeset/74327> 324224 6 commit-queue 2010-12-19 13:35:13 -0800 All reviewed patches have been landed. Closing bug. 76948 2010-12-18 15:30:48 -0800 2010-12-19 13:35:06 -0800 Patch 51300.diff text/plain 1285 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NWE4NDBiYS4uNmQxN2NlOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0xOCAgQmVuamFtaW4gUG91 bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1dLMl0gUVdLUGFnZVByaXZhdGU6OnBh aW50KCkgZG9lcyBub3QgbmVlZCB0byBzYXZlIHRoZSBncmFwaGljcyBjb250ZXh0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTMwMAorCisgICAgICAg IFJlbW92ZSB0aGUgdW5uZWNlc3Nhcnkgc2F2ZSgpIGFuZCByZXN0b3JlKCkgb24gdGhlIFFQYWlu dGVyLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcDoKKyAgICAgICAg KFFXS1BhZ2VQcml2YXRlOjpwYWludCk6CisKIDIwMTAtMTItMTggIEtlbm5ldGggUm9oZGUgQ2hy aXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3Bh Z2UuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCmluZGV4IDlhMWNl ZTEuLjYyMWQ5NjYgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdl LmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKQEAgLTE2MCwx NCArMTYwLDEwIEBAIHZvaWQgUVdLUGFnZVByaXZhdGU6OmRpZEZpbmlzaExvYWRpbmdEYXRhRm9y Q3VzdG9tUmVwcmVzZW50YXRpb24oY29uc3QgQ29yZUlQQzo6CiAKIHZvaWQgUVdLUGFnZVByaXZh dGU6OnBhaW50KFFQYWludGVyKiBwYWludGVyLCBRUmVjdCBhcmVhKQogewotICAgIHBhaW50ZXIt PnNhdmUoKTsKLQogICAgIGlmIChwYWdlLT5pc1ZhbGlkKCkgJiYgcGFnZS0+ZHJhd2luZ0FyZWEo KSkKICAgICAgICAgcGFnZS0+ZHJhd2luZ0FyZWEoKS0+cGFpbnQoSW50UmVjdChhcmVhKSwgcGFp bnRlcik7CiAgICAgZWxzZQogICAgICAgICBwYWludGVyLT5maWxsUmVjdChhcmVhLCBRdDo6d2hp dGUpOwotCi0gICAgcGFpbnRlci0+cmVzdG9yZSgpOwogfQogCiB2b2lkIFFXS1BhZ2VQcml2YXRl OjprZXlQcmVzc0V2ZW50KFFLZXlFdmVudCogZXYpCg==