51296 2010-12-18 13:57:52 -0800 [Qt] [WK2] Client are expected to render their own background for WebPages 2010-12-19 09:24:28 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Minor --- 1 benjamin webkit-unassigned commit-queue kenneth kling oldest_to_newest 324136 0 benjamin 2010-12-18 13:57:52 -0800 Client are expected to render their own background for WebPages. This way, clients can choose to render something else than white background when the content is not available yet, for example, the checkerboard pattern as generally used. 324139 1 76942 benjamin 2010-12-18 14:02:44 -0800 Created attachment 76942 Patch Kenneth, this is similar to the patch you made. There are the following differences: -remove the call to painter->drawRect(area). This was only drawing 1px border, which is wrong in my opinion -use QPainter::filerRect() instead of ::drawRect(). ::drawrect has to take into account the pen, ::fillRect is just a memfill in this case. 324141 2 76942 kenneth 2010-12-18 14:09:01 -0800 Comment on attachment 76942 Patch Looks good to me. 324152 3 76945 benjamin 2010-12-18 15:17:51 -0800 Created attachment 76945 Patch Second part, this is directly taken from the patch of Kenneth. 324153 4 76945 benjamin 2010-12-18 15:18:24 -0800 Comment on attachment 76945 Patch Removing cq?, I'll cq+ both patches together when this one is reviewed. 324154 5 benjamin 2010-12-18 15:20:46 -0800 Note for the reviewer: TiledDrawingAreaProxy is only used by Qt at the moment. 324165 6 commit-queue 2010-12-18 16:00:15 -0800 The commit-queue encountered the following flaky tests while processing attachment 76942: inspector/debugger-suspend-active-dom-objects.html bug 51301 (author: yurys@chromium.org) The commit-queue is continuing to process your patch. 324195 7 76945 kling 2010-12-19 01:19:12 -0800 Comment on attachment 76945 Patch r=me, nice to get rid of this. 324199 8 76945 commit-queue 2010-12-19 07:28:36 -0800 Comment on attachment 76945 Patch Rejecting attachment 76945 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 76945]" exit_code: 2 Last 500 characters of output: bexec/git-core/git-svn line 573 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit2/ChangeLog M WebKit2/UIProcess/TiledDrawingAreaProxy.cpp M WebKit2/UIProcess/TiledDrawingAreaTile.h M WebKit2/UIProcess/qt/TiledDrawingAreaTileQt.cpp Merge conflict during commit: Conflict at '/trunk/WebKit2/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 573 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/7276060 324200 9 76942 commit-queue 2010-12-19 07:28:48 -0800 Comment on attachment 76942 Patch Clearing flags on attachment: 76942 Committed r74322: <http://trac.webkit.org/changeset/74322> 324201 10 76945 benjamin 2010-12-19 07:39:35 -0800 Comment on attachment 76945 Patch Retrying. I don't see why the changelog conflicts. I'll commit manually if that fails. 324205 11 76945 commit-queue 2010-12-19 09:24:21 -0800 Comment on attachment 76945 Patch Clearing flags on attachment: 76945 Committed r74324: <http://trac.webkit.org/changeset/74324> 324206 12 commit-queue 2010-12-19 09:24:28 -0800 All reviewed patches have been landed. Closing bug. 76942 2010-12-18 14:02:44 -0800 2010-12-19 07:28:48 -0800 Patch 51296.patch text/plain 1214 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Zjc2YjIyZS4uOTc5YmYzMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0xOCAgQmVuamFtaW4gUG91 bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1dLMl0gQ2xpZW50IGFyZSBleHBlY3Rl ZCB0byByZW5kZXIgdGhlaXIgb3duIGJhY2tncm91bmQgZm9yIFdlYlBhZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTI5NgorCisgICAgICAgIERv IG5vdCByZW5kZXIgYSB3aGl0ZSBiYWNrZ3JvdW5kIGJlZm9yZSByZW5kZXJpbmcgdGhlIHBhZ2Ug d2l0aCBEcmF3aW5nQXJlYVByb3h5LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2tw YWdlLmNwcDoKKyAgICAgICAgKFFXS1BhZ2VQcml2YXRlOjpwYWludCk6CisKIDIwMTAtMTItMTcg IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh biBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFn ZS5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggZjA4OWI0 Zi4uOWExY2VlMSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2Uu Y3BwCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcApAQCAtMTYyLDEx ICsxNjIsMTAgQEAgdm9pZCBRV0tQYWdlUHJpdmF0ZTo6cGFpbnQoUVBhaW50ZXIqIHBhaW50ZXIs IFFSZWN0IGFyZWEpCiB7CiAgICAgcGFpbnRlci0+c2F2ZSgpOwogCi0gICAgcGFpbnRlci0+c2V0 QnJ1c2goUXQ6OndoaXRlKTsKLSAgICBwYWludGVyLT5kcmF3UmVjdChhcmVhKTsKLQogICAgIGlm IChwYWdlLT5pc1ZhbGlkKCkgJiYgcGFnZS0+ZHJhd2luZ0FyZWEoKSkKICAgICAgICAgcGFnZS0+ ZHJhd2luZ0FyZWEoKS0+cGFpbnQoSW50UmVjdChhcmVhKSwgcGFpbnRlcik7CisgICAgZWxzZQor ICAgICAgICBwYWludGVyLT5maWxsUmVjdChhcmVhLCBRdDo6d2hpdGUpOwogCiAgICAgcGFpbnRl ci0+cmVzdG9yZSgpOwogfQo= 76945 2010-12-18 15:17:51 -0800 2010-12-19 09:24:21 -0800 Patch 51296_2.patch text/plain 4888 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg OTc5YmYzMC4uNWE4NDBiYSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0xOCAgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBbV0syXSBDbGllbnQgYXJlIGV4cGVj dGVkIHRvIHJlbmRlciB0aGVpciBvd24gYmFja2dyb3VuZCBmb3IgV2ViUGFnZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMjk2CisKKyAgICAgICAg UmVtb3ZlIHRoZSByZW5kZXJpbmcgb2YgdGhlIGNoZWNrZXJib2FyZCBmcm9tIHRoZSB0aWxlZCBE cmF3aW5nQXJlYVByb3h5CisKKyAgICAgICAgKiBVSVByb2Nlc3MvVGlsZWREcmF3aW5nQXJlYVBy b3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6VGlsZWREcmF3aW5nQXJlYVByb3h5OjpwYWludCk6 CisgICAgICAgICogVUlQcm9jZXNzL1RpbGVkRHJhd2luZ0FyZWFUaWxlLmg6CisgICAgICAgICog VUlQcm9jZXNzL3F0L1RpbGVkRHJhd2luZ0FyZWFUaWxlUXQuY3BwOgorCiAyMDEwLTEyLTE4ICBC ZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vz cy9UaWxlZERyYXdpbmdBcmVhUHJveHkuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvVGlsZWREcmF3 aW5nQXJlYVByb3h5LmNwcAppbmRleCAzYjI5NjQ3Li4xOTU4ZjhkIDEwMDY0NAotLS0gYS9XZWJL aXQyL1VJUHJvY2Vzcy9UaWxlZERyYXdpbmdBcmVhUHJveHkuY3BwCisrKyBiL1dlYktpdDIvVUlQ cm9jZXNzL1RpbGVkRHJhd2luZ0FyZWFQcm94eS5jcHAKQEAgLTM0NiwxMyArMzQ2LDYgQEAgdm9p ZCBUaWxlZERyYXdpbmdBcmVhUHJveHk6OnBhaW50KGNvbnN0IEludFJlY3QmIHJlY3QsIFBsYXRm b3JtRHJhd2luZ0NvbnRleHQgY28KICAgICAgICAgICAgIFJlZlB0cjxUaWxlZERyYXdpbmdBcmVh VGlsZT4gY3VycmVudFRpbGUgPSB0aWxlQXQoY3VycmVudENvb3JkaW5hdGUpOwogICAgICAgICAg ICAgaWYgKGN1cnJlbnRUaWxlICYmIGN1cnJlbnRUaWxlLT5pc1JlYWR5VG9QYWludCgpKQogICAg ICAgICAgICAgICAgIGN1cnJlbnRUaWxlLT5wYWludCgmZ2MsIGRpcnR5UmVjdCk7Ci0gICAgICAg ICAgICBlbHNlIHsKLSAgICAgICAgICAgICAgICBJbnRSZWN0IHRpbGVSZWN0ID0gdGlsZVJlY3RG b3JDb29yZGluYXRlKGN1cnJlbnRDb29yZGluYXRlKTsKLSAgICAgICAgICAgICAgICBJbnRSZWN0 IHRhcmdldCA9IGludGVyc2VjdGlvbih0aWxlUmVjdCwgZGlydHlSZWN0KTsKLSAgICAgICAgICAg ICAgICBpZiAodGFyZ2V0LmlzRW1wdHkoKSkKLSAgICAgICAgICAgICAgICAgICAgY29udGludWU7 Ci0gICAgICAgICAgICAgICAgVGlsZWREcmF3aW5nQXJlYVRpbGU6OnBhaW50Q2hlY2tlclBhdHRl cm4oJmdjLCBGbG9hdFJlY3QodGFyZ2V0KSk7Ci0gICAgICAgICAgICB9CiAgICAgICAgIH0KICAg ICB9CiAgICAgZ2MucmVzdG9yZSgpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvVGls ZWREcmF3aW5nQXJlYVRpbGUuaCBiL1dlYktpdDIvVUlQcm9jZXNzL1RpbGVkRHJhd2luZ0FyZWFU aWxlLmgKaW5kZXggMDIwMTQ2MS4uYzgxOGEzZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nl c3MvVGlsZWREcmF3aW5nQXJlYVRpbGUuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9UaWxlZERy YXdpbmdBcmVhVGlsZS5oCkBAIC02NSw4ICs2NSw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgdXBk YXRlRnJvbUNodW5rKFVwZGF0ZUNodW5rKiB1cGRhdGVDaHVuaywgZmxvYXQpOwogCi0gICAgc3Rh dGljIHZvaWQgcGFpbnRDaGVja2VyUGF0dGVybihXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQqLCBj b25zdCBXZWJDb3JlOjpGbG9hdFJlY3QmKTsKLQogICAgIGludCBJRCgpIGNvbnN0IHsgcmV0dXJu IG1fSUQ7IH0KIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL3F0L1Rp bGVkRHJhd2luZ0FyZWFUaWxlUXQuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvVGlsZWREcmF3 aW5nQXJlYVRpbGVRdC5jcHAKaW5kZXggZjhkYjhjMy4uMmI2MzFjYSAxMDA2NDQKLS0tIGEvV2Vi S2l0Mi9VSVByb2Nlc3MvcXQvVGlsZWREcmF3aW5nQXJlYVRpbGVRdC5jcHAKKysrIGIvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvVGlsZWREcmF3aW5nQXJlYVRpbGVRdC5jcHAKQEAgLTQwLDI5ICs0MCw2 IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAotc3Rh dGljIGNvbnN0IHVuc2lnbmVkIGNoZWNrZXJTaXplID0gMTY7Ci1zdGF0aWMgY29uc3QgdW5zaWdu ZWQgY2hlY2tlckNvbG9yMSA9IDB4ZmY1NTU1NTU7Ci1zdGF0aWMgY29uc3QgdW5zaWduZWQgY2hl Y2tlckNvbG9yMiA9IDB4ZmZhYWFhYWE7Ci0KLXN0YXRpYyBRUGl4bWFwJiBjaGVja2VyZWRQaXht YXAoKQotewotICAgIHN0YXRpYyBRUGl4bWFwKiBwaXhtYXA7Ci0gICAgaWYgKCFwaXhtYXApIHsK LSAgICAgICAgcGl4bWFwID0gbmV3IFFQaXhtYXAoY2hlY2tlclNpemUsIGNoZWNrZXJTaXplKTsK LSAgICAgICAgUVBhaW50ZXIgcGFpbnRlcihwaXhtYXApOwotICAgICAgICBRQ29sb3IgY29sb3Ix KGNoZWNrZXJDb2xvcjEpOwotICAgICAgICBRQ29sb3IgY29sb3IyKGNoZWNrZXJDb2xvcjIpOwot ICAgICAgICBmb3IgKHVuc2lnbmVkIHkgPSAwOyB5IDwgY2hlY2tlclNpemU7IHkgKz0gY2hlY2tl clNpemUgLyAyKSB7Ci0gICAgICAgICAgICBib29sIGFsdGVybmF0ZSA9IHkgJSBjaGVja2VyU2l6 ZTsKLSAgICAgICAgICAgIGZvciAodW5zaWduZWQgeCA9IDA7IHggPCBjaGVja2VyU2l6ZTsgeCAr PSBjaGVja2VyU2l6ZSAvIDIpIHsKLSAgICAgICAgICAgICAgICBwYWludGVyLmZpbGxSZWN0KHgs IHksIGNoZWNrZXJTaXplIC8gMiwgY2hlY2tlclNpemUgLyAyLCBhbHRlcm5hdGUgPyBjb2xvcjEg OiBjb2xvcjIpOwotICAgICAgICAgICAgICAgIGFsdGVybmF0ZSA9ICFhbHRlcm5hdGU7Ci0gICAg ICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9Ci0gICAgcmV0dXJuICpwaXhtYXA7Ci19Ci0KIFRp bGVkRHJhd2luZ0FyZWFUaWxlOjpUaWxlZERyYXdpbmdBcmVhVGlsZShUaWxlZERyYXdpbmdBcmVh UHJveHkqIHByb3h5LCBjb25zdCBDb29yZGluYXRlJiB0aWxlQ29vcmRpbmF0ZSkKICAgICA6IG1f cHJveHkocHJveHkpCiAgICAgLCBtX2Nvb3JkaW5hdGUodGlsZUNvb3JkaW5hdGUpCkBAIC0xMzks MzEgKzExNiw2IEBAIHZvaWQgVGlsZWREcmF3aW5nQXJlYVRpbGU6OnBhaW50KEdyYXBoaWNzQ29u dGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBjb250ZXh0LT5wbGF0Zm9y bUNvbnRleHQoKS0+ZHJhd1BpeG1hcCh0YXJnZXQsIG1fYnVmZmVyLCBzb3VyY2UpOwogfQogCi12 b2lkIFRpbGVkRHJhd2luZ0FyZWFUaWxlOjpwYWludENoZWNrZXJQYXR0ZXJuKEdyYXBoaWNzQ29u dGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiB0YXJnZXQpCi17Ci0gICAgUVBhaW50ZXIq IHBhaW50ZXIgPSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKTsKLSAgICBRVHJhbnNmb3JtIHdv cmxkVHJhbnNmb3JtID0gcGFpbnRlci0+d29ybGRUcmFuc2Zvcm0oKTsKLSAgICBxcmVhbCBzY2Fs ZVggPSB3b3JsZFRyYW5zZm9ybS5tMTEoKTsKLSAgICBxcmVhbCBzY2FsZVkgPSB3b3JsZFRyYW5z Zm9ybS5tMjIoKTsKLQotICAgIFFSZWN0IHRhcmdldFZpZXdSZWN0ID0gUVJlY3RGKHRhcmdldC54 KCkgKiBzY2FsZVgsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGFyZ2V0Lnko KSAqIHNjYWxlWSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0YXJnZXQud2lk dGgoKSAqIHNjYWxlWCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0YXJnZXQu aGVpZ2h0KCkgKiBzY2FsZVkpLnRvQWxpZ25lZFJlY3QoKTsKLQotICAgIFFUcmFuc2Zvcm0gYWRq dXN0ZWRUcmFuc2Zvcm0oMS4sIHdvcmxkVHJhbnNmb3JtLm0xMigpLCB3b3JsZFRyYW5zZm9ybS5t MTMoKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdvcmxkVHJhbnNmb3JtLm0y MSgpLCAxLiwgd29ybGRUcmFuc2Zvcm0ubTIzKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB3b3JsZFRyYW5zZm9ybS5tMzEoKSwgd29ybGRUcmFuc2Zvcm0ubTMyKCksIHdvcmxk VHJhbnNmb3JtLm0zMygpKTsKLSAgICBwYWludGVyLT5zZXRXb3JsZFRyYW5zZm9ybShhZGp1c3Rl ZFRyYW5zZm9ybSk7Ci0KLSAgICBwYWludGVyLT5kcmF3VGlsZWRQaXhtYXAodGFyZ2V0Vmlld1Jl Y3QsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoZWNrZXJlZFBpeG1hcCgpLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBRUG9pbnQodGFyZ2V0Vmlld1JlY3QubGVmdCgpICUg Y2hlY2tlclNpemUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0YXJnZXRW aWV3UmVjdC50b3AoKSAlIGNoZWNrZXJTaXplKSk7Ci0KLSAgICBwYWludGVyLT5zZXRXb3JsZFRy YW5zZm9ybSh3b3JsZFRyYW5zZm9ybSk7Ci19Ci0KIHZvaWQgVGlsZWREcmF3aW5nQXJlYVRpbGU6 OnVwZGF0ZUZyb21DaHVuayhVcGRhdGVDaHVuayogdXBkYXRlQ2h1bmssIGZsb2F0KQogewogICAg IFFJbWFnZSBpbWFnZSh1cGRhdGVDaHVuay0+Y3JlYXRlSW1hZ2UoKSk7Cg==