51293 2010-12-18 12:51:57 -0800 WebKit does not build with worker but without the javascript debugger 2010-12-20 23:05:25 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 51025 1 benjamin webkit-unassigned commit-queue eric oldest_to_newest 324127 0 benjamin 2010-12-18 12:51:57 -0800 The patch https://bugs.webkit.org/show_bug.cgi?id=51025 refactor Inspector.idl in a way that functions related to workers are not generated if ENABLE_JAVASCRIPT_DEBUGGER is not defined. This does not compile because InspectorController guards the build with ENABLE(WORKERS). 324130 1 76941 benjamin 2010-12-18 13:21:36 -0800 Created attachment 76941 Patch To fix the build, I could have modified the idl to move the two functions outside of ENABLE_JAVASCRIPT_DEBUGGER, like they were before #51025. Instead I added guards in InspectorController. Those two functions are in the context of the Debugger, so the change of #51025 make sense in my opinion, and we can remove the calls to those methods. 324143 2 76941 commit-queue 2010-12-18 14:21:50 -0800 Comment on attachment 76941 Patch Rejecting attachment 76941 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--non-interactive', 76941]" exit_code: 2 Last 500 characters of output: -apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/inspector/InspectorController.h Hunk #1 FAILED at 398. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/inspector/InspectorController.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7209044 324150 3 76944 benjamin 2010-12-18 15:04:01 -0800 Created attachment 76944 Patch Ooops, uploaded the wrong patch. The one you reviewed is already in trunk. Attached is the right one :) 324169 4 76944 commit-queue 2010-12-18 17:01:27 -0800 Comment on attachment 76944 Patch Rejecting attachment 76944 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 76944]" exit_code: 2 Last 500 characters of output: pdating working directory Processing patch 76944 from bug 51293. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Full output: http://queues.webkit.org/results/7268037 324197 5 76956 benjamin 2010-12-19 07:20:57 -0800 Created attachment 76956 Patch, with changelog :) I was so eager to get rid of the bug that I forgot the changelog :) 324198 6 76956 kenneth 2010-12-19 07:26:40 -0800 Comment on attachment 76956 Patch, with changelog :) and I was looking at the code only as you always do good ChangeLogs :-) 324203 7 commit-queue 2010-12-19 07:56:16 -0800 The commit-queue encountered the following flaky tests while processing attachment 76956: http/tests/media/video-load-twice.html bug 51304 (authors: eric.carlson@apple.com and hclam@google.com) The commit-queue is continuing to process your patch. 324204 8 76956 commit-queue 2010-12-19 07:57:27 -0800 Comment on attachment 76956 Patch, with changelog :) Clearing flags on attachment: 76956 Committed r74323: <http://trac.webkit.org/changeset/74323> 324850 9 eric 2010-12-20 23:05:25 -0800 Please obsolete old patches when uploading new ones. webkit-patch upload will do this (and much more!) automatically for you. 76941 2010-12-18 13:21:36 -0800 2010-12-18 14:21:50 -0800 Patch 51246.patch text/plain 1128 benjamin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjY5Nzk3Ny4uZTlmOWI2ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0xNyAgQmVuamFtaW4gUG91 bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpbnNwZWN0b3IgZG9lcyBub3QgY29tcGls ZSB3aXRob3V0IEpBVkFTQ1JJUFRfREVCVUdHRVIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMjQ2CisKKyAgICAgICAgRml4IHRoZSBidWlsZCwgbV9l eHRyYUhlYWRlcnMgZG9lcyBub3QgZGVwZW5kIG9uIEpBVkFTQ1JJUFRfREVCVUdHRVIuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oOgorCiAyMDEwLTEyLTE2ICBT ZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNvbnRyb2xsZXIuaCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuaAppbmRleCBhYWFmNTNjLi5mNTUwOTBjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JDb250cm9sbGVyLmgKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y Q29udHJvbGxlci5oCkBAIC0zOTgsOCArMzk4LDggQEAgcHJpdmF0ZToKICAgICBib29sIG1fc3Rp Y2t5QnJlYWtwb2ludHNSZXN0b3JlZDsKIAogICAgIE93blB0cjxJbnNwZWN0b3JQcm9maWxlckFn ZW50PiBtX3Byb2ZpbGVyQWdlbnQ7Ci0gICAgT3duUHRyPEhUVFBIZWFkZXJNYXA+IG1fZXh0cmFI ZWFkZXJzOwogI2VuZGlmCisgICAgT3duUHRyPEhUVFBIZWFkZXJNYXA+IG1fZXh0cmFIZWFkZXJz OwogI2lmIEVOQUJMRShXT1JLRVJTKQogICAgIHR5cGVkZWYgSGFzaE1hcDxpbnRwdHJfdCwgUmVm UHRyPEluc3BlY3RvcldvcmtlclJlc291cmNlPiA+IFdvcmtlcnNNYXA7CiAK 76944 2010-12-18 15:04:01 -0800 2010-12-18 17:01:27 -0800 Patch 51293.patch text/plain 1347 benjamin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwIGIv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXggNDZkMTAyMC4u MjMzMmQ4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxl ci5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAg LTY0MCw3ICs2NDAsNyBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnBvcHVsYXRlU2NyaXB0 T2JqZWN0cygpCiAgICAgZm9yIChET01TdG9yYWdlUmVzb3VyY2VzTWFwOjppdGVyYXRvciBpdCA9 IG1fZG9tU3RvcmFnZVJlc291cmNlcy5iZWdpbigpOyBpdCAhPSBkb21TdG9yYWdlRW5kOyArK2l0 KQogICAgICAgICBpdC0+c2Vjb25kLT5iaW5kKG1fZnJvbnRlbmQuZ2V0KCkpOwogI2VuZGlmCi0j aWYgRU5BQkxFKFdPUktFUlMpCisjaWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpICYmIEVO QUJMRShXT1JLRVJTKQogICAgIFdvcmtlcnNNYXA6Oml0ZXJhdG9yIHdvcmtlcnNFbmQgPSBtX3dv cmtlcnMuZW5kKCk7CiAgICAgZm9yIChXb3JrZXJzTWFwOjppdGVyYXRvciBpdCA9IG1fd29ya2Vy cy5iZWdpbigpOyBpdCAhPSB3b3JrZXJzRW5kOyArK2l0KSB7CiAgICAgICAgIEluc3BlY3Rvcldv cmtlclJlc291cmNlKiB3b3JrZXIgPSBpdC0+c2Vjb25kLmdldCgpOwpAQCAtOTk4LDYgKzk5OCw3 IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6cG9zdFdvcmtlck5vdGlmaWNhdGlvblRvRnJv bnRlbmQoY29uc3QgSW5zcGVjdG9yV29ya2VyCiB7CiAgICAgaWYgKCFtX2Zyb250ZW5kKQogICAg ICAgICByZXR1cm47CisjaWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpCiAgICAgc3dpdGNo IChhY3Rpb24pIHsKICAgICBjYXNlIEluc3BlY3RvckNvbnRyb2xsZXI6OldvcmtlckNyZWF0ZWQ6 CiAgICAgICAgIG1fZnJvbnRlbmQtPmRpZENyZWF0ZVdvcmtlcih3b3JrZXIuaWQoKSwgd29ya2Vy LnVybCgpLCB3b3JrZXIuaXNTaGFyZWRXb3JrZXIoKSk7CkBAIC0xMDA2LDYgKzEwMDcsNyBAQCB2 b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnBvc3RXb3JrZXJOb3RpZmljYXRpb25Ub0Zyb250ZW5k KGNvbnN0IEluc3BlY3RvcldvcmtlcgogICAgICAgICBtX2Zyb250ZW5kLT5kaWREZXN0cm95V29y a2VyKHdvcmtlci5pZCgpKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQorI2VuZGlmCiB9CiAKIHZv aWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlkQ3JlYXRlV29ya2VyKGludHB0cl90IGlkLCBjb25z dCBTdHJpbmcmIHVybCwgYm9vbCBpc1NoYXJlZFdvcmtlcikK 76956 2010-12-19 07:20:57 -0800 2010-12-19 07:57:27 -0800 Patch, with changelog :) 51293.patch text/plain 2068 benjamin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDhhZGNmNi4uNmE3NDUyZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0xOCAgQmVuamFtaW4gUG91 bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdCBkb2VzIG5vdCBidWlsZCB3aXRoIHdv cmtlciBidXQgd2l0aG91dCB0aGUgamF2YXNjcmlwdCBkZWJ1Z2dlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEyOTMKKworICAgICAgICBBZGQgbWlz c2luZyBndWFyZCBmb3IgY2FsbHMgZGVwZW5kaW5nIG9uIHRoZSBkZWJ1Z2dlci4KKworICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvckNvbnRyb2xsZXI6OnBvcHVsYXRlU2NyaXB0T2JqZWN0cyk6CisgICAgICAgIChX ZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpwb3N0V29ya2VyTm90aWZpY2F0aW9uVG9Gcm9u dGVuZCk6CisKIDIwMTAtMTItMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBDYW1lcm9uIFp3YXJpY2guCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNvbnRyb2xsZXIuY3BwCmluZGV4IDQ2ZDEwMjAuLjIzMzJkODcgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC02NDAsNyArNjQwLDcgQEAgdm9p ZCBJbnNwZWN0b3JDb250cm9sbGVyOjpwb3B1bGF0ZVNjcmlwdE9iamVjdHMoKQogICAgIGZvciAo RE9NU3RvcmFnZVJlc291cmNlc01hcDo6aXRlcmF0b3IgaXQgPSBtX2RvbVN0b3JhZ2VSZXNvdXJj ZXMuYmVnaW4oKTsgaXQgIT0gZG9tU3RvcmFnZUVuZDsgKytpdCkKICAgICAgICAgaXQtPnNlY29u ZC0+YmluZChtX2Zyb250ZW5kLmdldCgpKTsKICNlbmRpZgotI2lmIEVOQUJMRShXT1JLRVJTKQor I2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKSAmJiBFTkFCTEUoV09SS0VSUykKICAgICBX b3JrZXJzTWFwOjppdGVyYXRvciB3b3JrZXJzRW5kID0gbV93b3JrZXJzLmVuZCgpOwogICAgIGZv ciAoV29ya2Vyc01hcDo6aXRlcmF0b3IgaXQgPSBtX3dvcmtlcnMuYmVnaW4oKTsgaXQgIT0gd29y a2Vyc0VuZDsgKytpdCkgewogICAgICAgICBJbnNwZWN0b3JXb3JrZXJSZXNvdXJjZSogd29ya2Vy ID0gaXQtPnNlY29uZC5nZXQoKTsKQEAgLTk5OCw2ICs5OTgsNyBAQCB2b2lkIEluc3BlY3RvckNv bnRyb2xsZXI6OnBvc3RXb3JrZXJOb3RpZmljYXRpb25Ub0Zyb250ZW5kKGNvbnN0IEluc3BlY3Rv cldvcmtlcgogewogICAgIGlmICghbV9mcm9udGVuZCkKICAgICAgICAgcmV0dXJuOworI2lmIEVO QUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQogICAgIHN3aXRjaCAoYWN0aW9uKSB7CiAgICAgY2Fz ZSBJbnNwZWN0b3JDb250cm9sbGVyOjpXb3JrZXJDcmVhdGVkOgogICAgICAgICBtX2Zyb250ZW5k LT5kaWRDcmVhdGVXb3JrZXIod29ya2VyLmlkKCksIHdvcmtlci51cmwoKSwgd29ya2VyLmlzU2hh cmVkV29ya2VyKCkpOwpAQCAtMTAwNiw2ICsxMDA3LDcgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9s bGVyOjpwb3N0V29ya2VyTm90aWZpY2F0aW9uVG9Gcm9udGVuZChjb25zdCBJbnNwZWN0b3JXb3Jr ZXIKICAgICAgICAgbV9mcm9udGVuZC0+ZGlkRGVzdHJveVdvcmtlcih3b3JrZXIuaWQoKSk7CiAg ICAgICAgIGJyZWFrOwogICAgIH0KKyNlbmRpZgogfQogCiB2b2lkIEluc3BlY3RvckNvbnRyb2xs ZXI6OmRpZENyZWF0ZVdvcmtlcihpbnRwdHJfdCBpZCwgY29uc3QgU3RyaW5nJiB1cmwsIGJvb2wg aXNTaGFyZWRXb3JrZXIpCg==